Merge ~paelzer/ubuntu/+source/qemu:bug-1842774-z15name-disco into ubuntu/+source/qemu:ubuntu/disco-devel

Proposed by Christian Ehrhardt  on 2019-10-15
Status: Approved
Approved by: Christian Ehrhardt  on 2019-10-16
Approved revision: 7f6974f89c8d44478c95d26f18af5a5d418121b7
Proposed branch: ~paelzer/ubuntu/+source/qemu:bug-1842774-z15name-disco
Merge into: ubuntu/+source/qemu:ubuntu/disco-devel
Diff against target: 64 lines (+42/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch (+34/-0)
Reviewer Review Type Date Requested Status
Rafael David Tinoco (community) 2019-10-15 Approve on 2019-10-16
Canonical Server packageset reviewers 2019-10-15 Pending
Ubuntu Server Dev import team 2019-10-15 Pending
Review via email: mp+374129@code.launchpad.net
To post a comment you must log in.
Christian Ehrhardt  (paelzer) wrote :

As states [1] for the SRU Team, I'm aware that this change alone does not fulfil the needs for a SRU but it is ok to be done and we'd want to avoid that it changes in between B->D->E so I'm uploading this along the Bionic fix (which will reach much more people and has a reasonable change along it).

[1]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1842774/comments/22

Rafael David Tinoco (rafaeldtinoco) wrote :

QEMU patch is 1:1 with upstream, and very minor, but needed for migration compatibility, according to IBM's comment: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1842774/comments/12
 after Christian's investigation. Waiting for a bigger SRU for the merge seems appropriate.

+1 on my side.

review: Approve
Christian Ehrhardt  (paelzer) wrote :

$ git push pkg upload/1%3.1+dfsg-2ubuntu3.6
...
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/qemu
 * [new tag] upload/1%3.1+dfsg-2ubuntu3.6 -> upload/1%3.1+dfsg-2ubuntu3.6

$ dput ubuntu ../qemu_3.1+dfsg-2ubuntu3.6_source.changes
Checking signature on .changes
gpg: ../qemu_3.1+dfsg-2ubuntu3.6_source.changes: Error checking signature from BA3E29338280B242: SignatureVerifyError: 0
Checking signature on .dsc
gpg: ../qemu_3.1+dfsg-2ubuntu3.6.dsc: Error checking signature from BA3E29338280B242: SignatureVerifyError: 0
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading qemu_3.1+dfsg-2ubuntu3.6.dsc: done.
  Uploading qemu_3.1+dfsg-2ubuntu3.6.debian.tar.xz: done.
  Uploading qemu_3.1+dfsg-2ubuntu3.6_source.buildinfo: done.
  Uploading qemu_3.1+dfsg-2ubuntu3.6_source.changes: done.
Successfully uploaded packages.

Unmerged commits

7f6974f... by Christian Ehrhardt  on 2019-10-15

changelog: update the z15 model name (LP: #1842774)

Signed-off-by: Christian Ehrhardt <email address hidden>

8a0c9a6... by Christian Ehrhardt  on 2019-09-24

d/p/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch: update the z15 model name (LP: #1842774)

Signed-off-by: Christian Ehrhardt <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index b39b112..c7dd071 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+qemu (1:3.1+dfsg-2ubuntu3.6) disco; urgency=medium
7+
8+ * d/p/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch:
9+ update the z15 model name (LP: #1842774)
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 15 Oct 2019 11:37:44 +0200
12+
13 qemu (1:3.1+dfsg-2ubuntu3.5) disco; urgency=medium
14
15 * d/binfmt-update-in: fix binfmt usage in some containers (LP: #1840956)
16diff --git a/debian/patches/series b/debian/patches/series
17index 7dfee6f..e06314c 100644
18--- a/debian/patches/series
19+++ b/debian/patches/series
20@@ -49,3 +49,4 @@ ubuntu/lp-1836154-s390x-cpumodel-wire-up-8561-and-8562-as-gen15-machin.patch
21 ubuntu/lp-1836154-s390-cpumodel-fix-description-for-the-new-vector-fac.patch
22 ubuntu/lp-1836154-s390x-cpumodel-remove-esort-from-the-default-model.patch
23 ubuntu/lp-1836154-s390x-cpumodel-also-change-name-of-vxbeh.patch
24+ubuntu/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch
25diff --git a/debian/patches/ubuntu/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch b/debian/patches/ubuntu/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch
26new file mode 100644
27index 0000000..f54a573
28--- /dev/null
29+++ b/debian/patches/ubuntu/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch
30@@ -0,0 +1,34 @@
31+From 7505deca0bfa859136ec6419dbafc504f22fcac2 Mon Sep 17 00:00:00 2001
32+From: Christian Borntraeger <borntraeger@de.ibm.com>
33+Date: Wed, 18 Sep 2019 16:42:14 +0200
34+Subject: [PATCH] s390x/cpumodel: Add the z15 name to the description of gen15a
35+
36+We now know that gen15a is called z15.
37+
38+Reviewed-by: David Hildenbrand <david@redhat.com>
39+Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
40+
41+Origin: upstream, https://git.qemu.org/?p=qemu.git;a=commit;h=7505deca
42+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1842774
43+Last-Update: 2019-09-24
44+
45+---
46+ target/s390x/cpu_models.c | 2 +-
47+ 1 file changed, 1 insertion(+), 1 deletion(-)
48+
49+diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
50+index 1d16d7d5e7..009afc38b9 100644
51+--- a/target/s390x/cpu_models.c
52++++ b/target/s390x/cpu_models.c
53+@@ -84,7 +84,7 @@ static S390CPUDef s390_cpu_defs[] = {
54+ CPUDEF_INIT(0x3906, 14, 1, 47, 0x08000000U, "z14", "IBM z14 GA1"),
55+ CPUDEF_INIT(0x3906, 14, 2, 47, 0x08000000U, "z14.2", "IBM z14 GA2"),
56+ CPUDEF_INIT(0x3907, 14, 1, 47, 0x08000000U, "z14ZR1", "IBM z14 Model ZR1 GA1"),
57+- CPUDEF_INIT(0x8561, 15, 1, 47, 0x08000000U, "gen15a", "IBM 8561 GA1"),
58++ CPUDEF_INIT(0x8561, 15, 1, 47, 0x08000000U, "gen15a", "IBM z15 GA1"),
59+ CPUDEF_INIT(0x8562, 15, 1, 47, 0x08000000U, "gen15b", "IBM 8562 GA1"),
60+ };
61+
62+--
63+2.23.0
64+

Subscribers

People subscribed via source and target branches