I did a full bionic review into eoan merge request, sorry, they are all linked so I guess it is no biggie. This was my comment there:
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/368748/comments/964720
I think you missed one clarification I asked about:
""" Your comment:
"remove context dependencies on post-2.11 capabilities and migration state"
was made due to positional changes, right ?
Cause I can see only the enum index as diff from upstream. """
I'm referring to a note to your cherry-pick/backport in:
commit 8ff43ee404d3e295839d1fd4e9e6571ca7a62a66 (v3.1.0-2772-g8ff43ee404) Author: Suraj Jitindar Singh <email address hidden> Date: Fri Mar 1 00:19:12 2019
target/ppc/spapr: Add SPAPR_CAP_CCF_ASSIST
Cause all difference I could find from upstream was the enum + 1.
I'm more curious then pointing out something here. ----
+1 from me.
« Back to merge proposal
I did a full bionic review into eoan merge request, sorry, they are all linked so I guess it is no biggie. This was my comment there:
https:/ /code.launchpad .net/~paelzer/ ubuntu/ +source/ qemu/+git/ qemu/+merge/ 368748/ comments/ 964720
I think you missed one clarification I asked about:
"""
Your comment:
"remove context dependencies on post-2.11 capabilities and migration state"
was made due to positional changes, right ?
Cause I can see only the enum index as diff from upstream.
"""
I'm referring to a note to your cherry- pick/backport in:
commit 8ff43ee404d3e29 5839d1fd4e9e657 1ca7a62a66 (v3.1.0- 2772-g8ff43ee40 4)
Author: Suraj Jitindar Singh <email address hidden>
Date: Fri Mar 1 00:19:12 2019
target/ ppc/spapr: Add SPAPR_CAP_ CCF_ASSIST
Cause all difference I could find from upstream was the enum + 1.
I'm more curious then pointing out something here.
----
+1 from me.