Merge ~paelzer/ubuntu/+source/qemu:fix-1832622-ppc-spectre-bionic into ubuntu/+source/qemu:ubuntu/bionic-devel
Status: | Merged |
---|---|
Approved by: | Christian Ehrhardt on 2019-06-26 |
Approved revision: | 32e74e3f62c3f5c94e3f90b8fad0a2f4472e2f92 |
Merge reported by: | Christian Ehrhardt |
Merged at revision: | 32e74e3f62c3f5c94e3f90b8fad0a2f4472e2f92 |
Proposed branch: | ~paelzer/ubuntu/+source/qemu:fix-1832622-ppc-spectre-bionic |
Merge into: | ubuntu/+source/qemu:ubuntu/bionic-devel |
Diff against target: |
629 lines (+589/-0) 6 files modified
debian/changelog (+7/-0) debian/patches/series (+4/-0) debian/patches/ubuntu/lp-1832622-0001-target-ppc-Factor-out-the-parsing-in-kvmppc_get_cpu_.patch (+101/-0) debian/patches/ubuntu/lp-1832622-0002-target-ppc-spapr-Add-workaround-option-to-SPAPR_CAP_.patch (+159/-0) debian/patches/ubuntu/lp-1832622-0003-ppc-spapr-caps-Change-migration-macro-to-take-full-s.patch (+79/-0) debian/patches/ubuntu/lp-1832622-0004-target-ppc-spapr-Add-SPAPR_CAP_CCF_ASSIST.patch (+239/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Rafael David Tinoco | 2019-06-13 | Approve on 2019-06-26 | |
Canonical Server packageset reviewers | 2019-06-13 | Pending | |
Ubuntu Server Dev import team | 2019-06-13 | Pending | |
Review via email:
|
Christian Ehrhardt (paelzer) wrote : | # |
Paride Legovini (paride) wrote : | # |
Looks good from a formal point view; the packages in the PPA seem to be working as expected, however I don't think I can test the specific fix.
Rafael David Tinoco (rafaeldtinoco) wrote : | # |
I did a full bionic review into eoan merge request, sorry, they are all linked so I guess it is no biggie. This was my comment there:
https:/
I think you missed one clarification I asked about:
"""
Your comment:
"remove context dependencies on post-2.11 capabilities and migration state"
was made due to positional changes, right ?
Cause I can see only the enum index as diff from upstream.
"""
I'm referring to a note to your cherry-
commit 8ff43ee404d3e29
Author: Suraj Jitindar Singh <email address hidden>
Date: Fri Mar 1 00:19:12 2019
target/
Cause all difference I could find from upstream was the enum + 1.
I'm more curious then pointing out something here.
----
+1 from me.
Christian Ehrhardt (paelzer) wrote : | # |
Yes it was just context changes for other options being missing in 2.11
Christian Ehrhardt (paelzer) wrote : | # |
This migrated, closing forgotten MP
Related test PPA at [1].
This is based on the provided backports for 2.11
[1]: https:/ /launchpad. net/~paelzer/ +archive/ ubuntu/ bug-1832622- qemu-spectre- ppc