Merge ~paelzer/ubuntu/+source/qemu:fix-1820291-freeze-hook-and-CVE into ~ubuntu-virt/ubuntu/+source/qemu:ubuntu-disco-3.1
Proposed by
Christian Ehrhardt
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Christian Ehrhardt | ||||
Merged at revision: | 6bda69c720794f432abc84bde494e4612cf925e5 | ||||
Proposed branch: | ~paelzer/ubuntu/+source/qemu:fix-1820291-freeze-hook-and-CVE | ||||
Merge into: | ~ubuntu-virt/ubuntu/+source/qemu:ubuntu-disco-3.1 | ||||
Diff against target: |
279 lines (+227/-1) 7 files modified
debian/changelog (+14/-0) debian/patches/i2c-ddc-fix-oob-read-CVE-2019-3812.patch (+34/-0) debian/patches/series (+1/-0) debian/qemu-guest-agent.install (+1/-1) debian/qemu-guest-agent.postinst (+59/-0) debian/qemu-guest-agent.postrm (+56/-0) debian/qemu-guest-agent.preinst (+62/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robie Basak (community) | Approve | ||
Andreas Hasenack (community) | Abstain | ||
Ubuntu Virtualisation team | Pending | ||
Review via email: mp+364760@code.launchpad.net |
To post a comment you must log in.
AFAICT the implementation of your conffile rename is necessary and correct.
I am somewhat confused by the approach you took though, which seems to have three different "what to minimise" choices in three different cases. I've left comments inline in an effort to explain what I mean. However, I don't think it's worth worrying about, since this upgrade path code will go away soon anyway, you have tested the different cases with your implementation here carefully, and I don't see any functional problems with your approach as dpkg-maintscrip t-helper and dpkg are written today.
Separately I suggested one minor changelog fixup (inline), which I leave to your discretion in case I'm missing something.