Merge ~paelzer/ubuntu/+source/qemu:fix-lp-1807743-timerfd-syscall-xenial into ubuntu/+source/qemu:ubuntu/xenial-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: a5c1b48536d39667ee193e9ddc526ee69723e514
Merge reported by: Christian Ehrhardt 
Merged at revision: a5c1b48536d39667ee193e9ddc526ee69723e514
Proposed branch: ~paelzer/ubuntu/+source/qemu:fix-lp-1807743-timerfd-syscall-xenial
Merge into: ubuntu/+source/qemu:ubuntu/xenial-devel
Diff against target: 139 lines (+117/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu/lp1807743-linux-user-timerfd.patch (+109/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+360798@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Test PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3562/+packages
Test ticket: https://bileto.ubuntu.com/#/ticket/3562

Bug test instruction on the bug in the SRU template.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

tests are fine in https://bileto.ubuntu.com/excuses/3562/xenial.html
(open-iscsi is already a force-badtest)

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks, tagged and uploaded for SRU

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index fe7e42e..cc37d80 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+qemu (1:2.5+dfsg-5ubuntu10.34) xenial; urgency=medium
7+
8+ * d/p/ubuntu/lp1807743-linux-user-timerfd.patch: fix define for
9+ timerfd_create system call (LP: #1807743)
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 12 Dec 2018 13:18:01 +0100
12+
13 qemu (1:2.5+dfsg-5ubuntu10.33) xenial-security; urgency=medium
14
15 * SECURITY UPDATE: integer overflow in NE2000 NIC emulation
16diff --git a/debian/patches/series b/debian/patches/series
17index 41454ff..aaf2a21 100644
18--- a/debian/patches/series
19+++ b/debian/patches/series
20@@ -249,3 +249,4 @@ CVE-2018-17963.patch
21 CVE-2018-18849.patch
22 CVE-2018-19364-1.patch
23 CVE-2018-19364-2.patch
24+ubuntu/lp1807743-linux-user-timerfd.patch
25diff --git a/debian/patches/ubuntu/lp1807743-linux-user-timerfd.patch b/debian/patches/ubuntu/lp1807743-linux-user-timerfd.patch
26new file mode 100644
27index 0000000..b0b1d96
28--- /dev/null
29+++ b/debian/patches/ubuntu/lp1807743-linux-user-timerfd.patch
30@@ -0,0 +1,109 @@
31+From 93a92d3bd649cd315db47b9fb5dcb6af657cc22c Mon Sep 17 00:00:00 2001
32+From: Riku Voipio <riku.voipio@linaro.org>
33+Date: Mon, 15 Feb 2016 15:38:40 +0200
34+Subject: [PATCH] linux-user: correct timerfd_create syscall numbers
35+
36+x86, m68k, ppc, sh4 and sparc failed to enable timerfd, because they
37+didn't have timerfd_create system call defined. Instead QEMU
38+defined timerfd syscall. Checking with kernel sources, it appears
39+kernel developers reused timerfd syscall number with timerfd_create,
40+presumably since no userspace called the old syscall number.
41+
42+Reported-by: Laurent Vivier <laurent@vivier.eu>
43+Reviewed-by: Laurent Vivier <laurent@vivier.eu>
44+Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
45+
46+Origin: upstream, https://git.qemu.org/?p=qemu.git;a=commit;h=93a92d3bd649cd315db47b9fb5dcb6af657cc22c
47+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1807743
48+Last-Update: 2018-12-12
49+
50+---
51+ linux-user/i386/syscall_nr.h | 2 +-
52+ linux-user/m68k/syscall_nr.h | 2 +-
53+ linux-user/ppc/syscall_nr.h | 2 +-
54+ linux-user/sh4/syscall_nr.h | 2 +-
55+ linux-user/sparc/syscall_nr.h | 2 +-
56+ linux-user/x86_64/syscall_nr.h | 2 +-
57+ 6 files changed, 6 insertions(+), 6 deletions(-)
58+
59+diff --git a/linux-user/i386/syscall_nr.h b/linux-user/i386/syscall_nr.h
60+index fa3f0b4a08..bc1bc233ed 100644
61+--- a/linux-user/i386/syscall_nr.h
62++++ b/linux-user/i386/syscall_nr.h
63+@@ -324,7 +324,7 @@
64+ #define TARGET_NR_epoll_pwait 319
65+ #define TARGET_NR_utimensat 320
66+ #define TARGET_NR_signalfd 321
67+-#define TARGET_NR_timerfd 322
68++#define TARGET_NR_timerfd_create 322
69+ #define TARGET_NR_eventfd 323
70+ #define TARGET_NR_fallocate 324
71+ #define TARGET_NR_timerfd_settime 325
72+diff --git a/linux-user/m68k/syscall_nr.h b/linux-user/m68k/syscall_nr.h
73+index a2daba034a..4b50fb29b6 100644
74+--- a/linux-user/m68k/syscall_nr.h
75++++ b/linux-user/m68k/syscall_nr.h
76+@@ -317,7 +317,7 @@
77+ #define TARGET_NR_epoll_pwait 315
78+ #define TARGET_NR_utimensat 316
79+ #define TARGET_NR_signalfd 317
80+-#define TARGET_NR_timerfd 318
81++#define TARGET_NR_timerfd_create 318
82+ #define TARGET_NR_eventfd 319
83+ #define TARGET_NR_fallocate 320
84+ #define TARGET_NR_timerfd_settime 321
85+diff --git a/linux-user/ppc/syscall_nr.h b/linux-user/ppc/syscall_nr.h
86+index 0a5fd543e7..46ed8a68ce 100644
87+--- a/linux-user/ppc/syscall_nr.h
88++++ b/linux-user/ppc/syscall_nr.h
89+@@ -319,7 +319,7 @@
90+ #define TARGET_NR_epoll_pwait 303
91+ #define TARGET_NR_utimensat 304
92+ #define TARGET_NR_signalfd 305
93+-#define TARGET_NR_timerfd 306
94++#define TARGET_NR_timerfd_create 306
95+ #define TARGET_NR_eventfd 307
96+ #define TARGET_NR_sync_file_range2 308
97+ #define TARGET_NR_fallocate 309
98+diff --git a/linux-user/sh4/syscall_nr.h b/linux-user/sh4/syscall_nr.h
99+index bdf8742c69..50099846d2 100644
100+--- a/linux-user/sh4/syscall_nr.h
101++++ b/linux-user/sh4/syscall_nr.h
102+@@ -323,7 +323,7 @@
103+ #define TARGET_NR_epoll_pwait 319
104+ #define TARGET_NR_utimensat 320
105+ #define TARGET_NR_signalfd 321
106+-#define TARGET_NR_timerfd 322
107++#define TARGET_NR_timerfd_create 322
108+ #define TARGET_NR_eventfd 323
109+ #define TARGET_NR_fallocate 324
110+ #define TARGET_NR_timerfd_settime 325
111+diff --git a/linux-user/sparc/syscall_nr.h b/linux-user/sparc/syscall_nr.h
112+index 5b582a5a90..732b1052a4 100644
113+--- a/linux-user/sparc/syscall_nr.h
114++++ b/linux-user/sparc/syscall_nr.h
115+@@ -278,7 +278,7 @@
116+ #define TARGET_NR_epoll_pwait 309
117+ #define TARGET_NR_utimensat 310
118+ #define TARGET_NR_signalfd 311
119+-#define TARGET_NR_timerfd 312
120++#define TARGET_NR_timerfd_create 312
121+ #define TARGET_NR_eventfd 313
122+ #define TARGET_NR_fallocate 314
123+ #define TARGET_NR_timerfd_settime 315
124+diff --git a/linux-user/x86_64/syscall_nr.h b/linux-user/x86_64/syscall_nr.h
125+index f00fa2b783..16397b3e8f 100644
126+--- a/linux-user/x86_64/syscall_nr.h
127++++ b/linux-user/x86_64/syscall_nr.h
128+@@ -281,7 +281,7 @@
129+ #define TARGET_NR_utimensat 280
130+ #define TARGET_NR_epoll_pwait 281
131+ #define TARGET_NR_signalfd 282
132+-#define TARGET_NR_timerfd 283
133++#define TARGET_NR_timerfd_create 283
134+ #define TARGET_NR_eventfd 284
135+ #define TARGET_NR_fallocate 285
136+ #define TARGET_NR_timerfd_settime 286
137+--
138+2.17.1
139+

Subscribers

People subscribed via source and target branches