Code review comment for ~paelzer/ubuntu/+source/psmisc:lp1806060-fix-killall-option-parsing-bionic

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok:

- compared cosmic fix with bionic fix, same
- ran the test (nice script), ok
- even though sometimes the test script doesn't find a process to kill, by then it parsed the command line already, and if an unknown option were to be used it would have shown the help output
- killall is definitely used by many scripts out there, let's keep an eye on possible regressions

+1

review: Approve

« Back to merge proposal