Merge ~paelzer/ubuntu/+source/postgresql-pgmp:fix-tests-python3-transition into ~paelzer/ubuntu/+source/postgresql-pgmp:importer/ubuntu/focal-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: a3b19f4c78c9c4902c5f2eff07f75c8f833896c1
Merge reported by: Christian Ehrhardt 
Merged at revision: a3b19f4c78c9c4902c5f2eff07f75c8f833896c1
Proposed branch: ~paelzer/ubuntu/+source/postgresql-pgmp:fix-tests-python3-transition
Merge into: ~paelzer/ubuntu/+source/postgresql-pgmp:importer/ubuntu/focal-devel
Diff against target: 122 lines (+64/-5)
6 files modified
debian/changelog (+9/-0)
debian/control (+3/-2)
debian/control.in (+3/-2)
debian/patches/series (+1/-0)
debian/patches/use-python2.patch (+47/-0)
debian/tests/control (+1/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack (community) Approve
Christian Ehrhardt  Abstain
Canonical Server Pending
Review via email: mp+378239@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) :
review: Abstain
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

With the fix all tests are good again:
https://bileto.ubuntu.com/excuses/3904/focal.html

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1, minor issues inline which you can choose to change or not.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Done - thanks

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading postgresql-pgmp_1.0.2-8ubuntu1.dsc: done.
  Uploading postgresql-pgmp_1.0.2-8ubuntu1.debian.tar.xz: done.
  Uploading postgresql-pgmp_1.0.2-8ubuntu1_source.buildinfo: done.
  Uploading postgresql-pgmp_1.0.2-8ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This migrated into focal.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 7dd9591..95cf5d6 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+postgresql-pgmp (1.0.2-8ubuntu1) focal; urgency=medium
7+
8+ * explicitly use python2 until python3 is supported (LP: #1861273)
9+ - d/control[.in]: bump build dependencies to explcit 2
10+ - d/p/use-python2.patch: update script headers to call python2
11+ - d/t/control: bump test dependencies to explcit 2
12+
13+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 29 Jan 2020 12:27:31 +0100
14+
15 postgresql-pgmp (1.0.2-8) unstable; urgency=medium
16
17 * Upload for PostgreSQL 12.
18diff --git a/debian/control b/debian/control
19index edeaabf..86551aa 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -1,9 +1,10 @@
23 Source: postgresql-pgmp
24 Section: database
25 Priority: optional
26-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
27+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
28+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
29 Uploaders: Christoph Berg <myon@debian.org>
30-Build-Depends: debhelper (>= 9), libgmp-dev, postgresql-server-dev-all (>= 158~), python-minimal
31+Build-Depends: debhelper (>= 9), libgmp-dev, postgresql-server-dev-all (>= 158~), python2-minimal
32 Standards-Version: 4.1.1
33 Homepage: https://github.com/dvarrazzo/pgmp
34 Vcs-Git: https://salsa.debian.org/postgresql/postgresql-pgmp.git
35diff --git a/debian/control.in b/debian/control.in
36index 70e992f..b0b6ccf 100644
37--- a/debian/control.in
38+++ b/debian/control.in
39@@ -1,9 +1,10 @@
40 Source: postgresql-pgmp
41 Section: database
42 Priority: optional
43-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
44+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
45+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <team+postgresql@tracker.debian.org>
46 Uploaders: Christoph Berg <myon@debian.org>
47-Build-Depends: debhelper (>= 9), libgmp-dev, postgresql-server-dev-all (>= 158~), python-minimal
48+Build-Depends: debhelper (>= 9), libgmp-dev, postgresql-server-dev-all (>= 158~), python2-minimal
49 Standards-Version: 4.1.1
50 Homepage: https://github.com/dvarrazzo/pgmp
51 Vcs-Git: https://salsa.debian.org/postgresql/postgresql-pgmp.git
52diff --git a/debian/patches/series b/debian/patches/series
53index 9df8b37..7f9c027 100644
54--- a/debian/patches/series
55+++ b/debian/patches/series
56@@ -3,3 +3,4 @@ makefile-reproducible
57 9.5
58 10
59 12
60+use-python2.patch
61diff --git a/debian/patches/use-python2.patch b/debian/patches/use-python2.patch
62new file mode 100644
63index 0000000..9aa4d1e
64--- /dev/null
65+++ b/debian/patches/use-python2.patch
66@@ -0,0 +1,47 @@
67+Description: Use python2 explicitly until python3 support is ready
68+ Upstream needs to implement python3, until then lets make the python usage
69+ explicitly based on python2 to avoid failures and resolve dependency
70+ issues as just "python" no more exists (as package) and is pytohn3 (as binary).
71+Forwarded: https://github.com/dvarrazzo/pgmp/issues/16
72+Author: Christian Ehrhardt <christian.ehrhardt@canonical.com>
73+Last-Update: 2019-01-29
74+--- a/sandbox/bench/benchmark.py
75++++ b/sandbox/bench/benchmark.py
76+@@ -1,4 +1,4 @@
77+-#!/usr/bin/env python
78++#!/usr/bin/env python2
79+ """Script to perform comparisons between pmpz and other data types.
80+
81+ Copyright (C) 2011 - Daniele Varrazzo
82+--- a/sandbox/bench/plot_result.py
83++++ b/sandbox/bench/plot_result.py
84+@@ -1,4 +1,4 @@
85+-#!/usr/bin/env python
86++#!/usr/bin/env python2
87+ """Plot a result from benchmark.py
88+
89+ Copyright (C) 2011 - Daniele Varrazzo
90+--- a/sandbox/pi/calc_pi.py
91++++ b/sandbox/pi/calc_pi.py
92+@@ -1,4 +1,4 @@
93+-#!/usr/bin/env python
94++#!/usr/bin/env python2
95+ """
96+ A script to calculate pi using parallel PostgreSQL processes.
97+
98+--- a/tools/sql2extension.py
99++++ b/tools/sql2extension.py
100+@@ -1,4 +1,4 @@
101+-#!/usr/bin/env python
102++#!/usr/bin/env python2
103+ """Generate "ALTER EXTENSION" statements to package a list of SQL definitions.
104+
105+ The script doesn't try to be a robust parser: it relies on the input file
106+--- a/tools/unmix.py
107++++ b/tools/unmix.py
108+@@ -1,4 +1,4 @@
109+-#!/usr/bin/env python
110++#!/usr/bin/env python2
111+ """Convert a file containing a mix of python code and content into content.
112+
113+ Write the input file to stdout. Python code included between blocks
114diff --git a/debian/tests/control b/debian/tests/control
115index b3a7b37..9d9b525 100644
116--- a/debian/tests/control
117+++ b/debian/tests/control
118@@ -1,3 +1,3 @@
119 Tests: installcheck
120-Depends: @, postgresql-server-dev-all, python
121+Depends: @, postgresql-server-dev-all, python2
122 Restrictions: allow-stderr

Subscribers

People subscribed via source and target branches

to all changes: