Merge ~paelzer/ubuntu/+source/postgis:lp-1952604-ppc-test-skip into ~paelzer/ubuntu/+source/postgis:master

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: b499c1a054a1e1940c6db39039d3afb03d39506d
Proposed branch: ~paelzer/ubuntu/+source/postgis:lp-1952604-ppc-test-skip
Merge into: ~paelzer/ubuntu/+source/postgis:master
Diff against target: 61 lines (+13/-4)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/control.in (+2/-1)
debian/rules (+2/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Pending
Christian Ehrhardt  Pending
Review via email: mp+412640@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This isn't imported in git-ubuntu (yet), but since it is a sync salsa-master == jammy-devel.
And salsa-master is what this is proposed against.

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4728/+packages
Bug: https://bugs.launchpad.net/ubuntu/+source/postgis/+bug/1952604

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Christian.

I agree with your analysis here; this specific test is already being ignored in almost every architecture anyway, so it makes sense to include ppc64el in the list. This is a classic scenario of a broken test that needs to be fixed upstream.

LGTM, +1.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading postgis_3.1.4+dfsg-3ubuntu1.dsc: done.
  Uploading postgis_3.1.4+dfsg-3ubuntu1.debian.tar.xz: done.
  Uploading postgis_3.1.4+dfsg-3ubuntu1_source.buildinfo: done.
  Uploading postgis_3.1.4+dfsg-3ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index e0ed5b6..e7539c3 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+postgis (3.1.4+dfsg-3ubuntu1) jammy; urgency=medium
7+
8+ * d/rules: ignore ppc64el test results that became unstable
9+ in the autopkgtest.u.c environment in Jammy (LP: #1952604)
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 01 Dec 2021 13:51:24 +0100
12+
13 postgis (3.1.4+dfsg-3) unstable; urgency=medium
14
15 * Add upstream patch to fix test failures with GEOS 3.10.0.
16diff --git a/debian/control b/debian/control
17index e50093d..753a3c1 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,5 +1,6 @@
21 Source: postgis
22-Maintainer: Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org>
25 Uploaders: Stephen Frost <sfrost@debian.org>,
26 Francesco Paolo Lovergine <frankie@debian.org>,
27 Markus Wanner <markus@bluegap.ch>,
28diff --git a/debian/control.in b/debian/control.in
29index 00e8a14..28533a1 100644
30--- a/debian/control.in
31+++ b/debian/control.in
32@@ -1,5 +1,6 @@
33 Source: postgis
34-Maintainer: Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org>
35+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
36+XSBC-Original-Maintainer: Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org>
37 Uploaders: Stephen Frost <sfrost@debian.org>,
38 Francesco Paolo Lovergine <frankie@debian.org>,
39 Markus Wanner <markus@bluegap.ch>,
40diff --git a/debian/rules b/debian/rules
41index ccb6001..8c836e4 100755
42--- a/debian/rules
43+++ b/debian/rules
44@@ -152,7 +152,7 @@ ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
45 # Run unit tests (against the newest Postgres version, first)
46 echo " ### testing $(NEWEST_POSTGRES_VERSION) ###"
47 # Ignore test failure on problematic architectures
48-ifneq (,$(filter $(DEB_BUILD_ARCH),mips mips64el mipsel s390x alpha hppa hurd-i386 kfreebsd-i386 powerpc ppc64 sparc64))
49+ifneq (,$(filter $(DEB_BUILD_ARCH),mips mips64el mipsel s390x alpha hppa hurd-i386 kfreebsd-i386 powerpc ppc64 ppc64el sparc64))
50 pg_virtualenv -v $(NEWEST_POSTGRES_VERSION) \
51 make check RUNTESTFLAGS="-v" || echo "Ignoring test failures"
52 else
53@@ -161,7 +161,7 @@ else
54 endif
55
56 # Test against all other Postgres versions
57-ifneq (,$(filter $(DEB_BUILD_ARCH),mips mips64el mipsel s390x alpha hppa hurd-i386 kfreebsd-i386 powerpc ppc64 sparc64))
58+ifneq (,$(filter $(DEB_BUILD_ARCH),mips mips64el mipsel s390x alpha hppa hurd-i386 kfreebsd-i386 powerpc ppc64 ppc64el sparc64))
59 set -e; \
60 for PGVER in $(OTHER_POSTGRES_VERSIONS); do \
61 echo " ### testing $$PGVER ###"; \

Subscribers

People subscribed via source and target branches

to all changes: