Since d3d47039 "Start vgauth before vmtoolsd" there is a potential race
of starting vgauth so early that it might have issues. This was
discussed back in the day in [1] to [2], but confirmed to be ok by
VMWare.
We were all somewhat convinced by this, but a bad feeling remained not
only with me but also with Bernd [4].
A recent SRU review denial made me rethink all of it and I think we can
make it safer without thwarting the purpose of the original change.
Note: Disambiguation of service names used below:
vgauth - open-vm-tools.vgauth.service
vmtoolsd - open-vm-tools.service
fs - systemd-remount-fs.service
tmp - systemd-tmpfiles-setup.service
cloud-init - cloud-init-local.service
Currently we have these dependency requirements:
- vgauth should be before vmtoolsd
- cloud init should be before vmtoolsd
- cloud init has to be really early in general
- therefore this is using DefaultDependencies=No
That lead to this graph:
fs / tmp -> vmtoolsd -> cloud-init
And d3d47039 added it to be like:
fs / tmp -> vmtoolsd -> cloud-init
^
vgauth --|
But there is no need to have vgauth without any pre-dependencies at all.
It is only needed to be "before" vmtoolsd, therefore we can make it:
fs / tmp -> vgauth -> vmtoolsd -> cloud-init
That will make execution of vgauth much less error-prone (even though I
have no hard issue to report) while at the same time holding up all
known required ordering constraints.
Note: this is accepted in Debian via [5] and can be dropped on the
next merge, but due to Debian Freeze we add it as Ubuntu delta for now.
New changelog entries:
[ Christian Ehrhardt ]
* [d3d4703] Start vgauth before vmtoolsd.
VGAuthService needs to be ready when vmtoolsd runs. Certain cases - e.g.
Site Recovery Manager failover - will need vgauth to be up.
Therefore add an After=vgauth.service dependency to open-vm-tools.service
To have vgauth be able start early - and not pull cloud-init back late - it
is also required to drop default dependencies which according to VMware is
fine to do so.
(LP: #1804287)
New changelog entries:
[ Raphaël Hertzog ]
* [db2a364] Ensure vmwgfx module is loaded before start of vmtoolsd.
This avoids a failure to start the resolutionKMS plugin and it's
achieved through a drop-in snippet extending open-vm-tools.service
adding an ExecStartPre directive loading the module prior to
the start of the service. (Closes: #915031)
[ Christian Ehrhardt ]
* [e6e0ab8] d/rules: fix dangling symlink of vmware-user.
Back in 2:9.4.0-1280544-6 vmware-user* was moved to the
open-vm-tools-desktop package and some follow on fixes moved bits that
were forgotten like the man page.
(LP: #1807441)
There still is a symlink in /usr/bin/vmware-user that is forgotten in
the base package and broken unless open-vm-tools-desktop is installed.
Change d/rules to move the symlink as well.
Signed-off-by: Christian Ehrhardt <email address hidden>
* [13d22e5] Breaks and Replaces for moving vmware-user.
Signed-off-by: Christian Ehrhardt <email address hidden>
* [d56826a] Bump breaks and replaces to next version to be released.
Signed-off-by: Christian Ehrhardt <email address hidden>
[ Bernd Zeimetz ]
* [e4697c7] Fix race condition between open-vm-tools and systemd-tmpfiles-setup.
Thanks to Jean-Louis Dupond (Closes: #914910)
New changelog entries:
* [7061cb7] Update upstream source from tag 'upstream/10.3.5'
Update to upstream version '10.3.5'
with Debian dir 9315f58cab8ba1356c1e4aa77d714257dc0651f2
New changelog entries:
* [16acbc3] Remove PrivateTmp=yes.
Thanks to Christian Ehrhardt (Closes: #905170)
* [72aabb2] Add RequiresMountsFor=/tmp.
Thanks to Christopher Odenbach (Closes: #900566)
* [96bf0c5] Update upstream source from tag 'upstream/10.3.0'
Update to upstream version '10.3.0'
with Debian dir ace0137b2d17e039ddac188fdcd15f882119925a
* [e5a9b82] Re-add .travis.yml
* [83e043f] Refreshing patches
New changelog entries:
* [ea03a58] Update upstream source from tag 'upstream/10.2.5'
Update to upstream version '10.2.5'
with Debian dir 74e96286320224bb6d5b717034930169514dbd51
* [c1c18d3] Refreshing patches.
