Merge ~paelzer/ubuntu/+source/open-vm-tools:lp-1944946-multiarch-fallout-IMPISH into ubuntu/+source/open-vm-tools:ubuntu/impish-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: dc40dd92cf71482965b63bccc5d9c873e81620ca
Merged at revision: dc40dd92cf71482965b63bccc5d9c873e81620ca
Proposed branch: ~paelzer/ubuntu/+source/open-vm-tools:lp-1944946-multiarch-fallout-IMPISH
Merge into: ubuntu/+source/open-vm-tools:ubuntu/impish-devel
Diff against target: 43 lines (+12/-1)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/rules (+3/-0)
Reviewer Review Type Date Requested Status
Paride Legovini (community) Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+409807@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

PPA (same content just other changelog): https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4673

Debian discussion (accepted but reverted by me as we do not want it later in 22.04 or experimental/unstable):
https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools/-/merge_requests/11

Revision history for this message
Paride Legovini (paride) wrote :

Simple packaging-only change with a clear comment; I verified that the link is in place in the installed package and point to the right location. This LGTM, approving.

---

I normally prefer using dh_link d/package.links files to add symlinks, but in this case it would have required dh-exec to expand $(DEB_HOST_MULTIARCH) as an extra build-dep, easy to forget there even after we remove this workaround. Debhelper level 13 now expands dpkg-architecture variables natively, without resorting to dh-exec, but the package is at compat 12. In the end I would have implemented the workaround in the same way as proposed.

review: Approve
Revision history for this message
Paride Legovini (paride) wrote :

Reapproving with the update-maintainer changes (discussed on MM).

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks, fixed up the update-maintainer that you asked for.
Uploading ...

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading open-vm-tools_11.3.0-2ubuntu1.dsc: done.
  Uploading open-vm-tools_11.3.0-2ubuntu1.debian.tar.xz: done.
  Uploading open-vm-tools_11.3.0-2ubuntu1_source.buildinfo: done.
  Uploading open-vm-tools_11.3.0-2ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index cd1f2ff..35e13cf 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+open-vm-tools (2:11.3.0-2ubuntu1) impish; urgency=medium
7+
8+ * d/rules: provide a compat link for the old open-vm-tools
9+ library/plugin paths (LP: #1944946)
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 07 Oct 2021 09:31:05 +0200
12+
13 open-vm-tools (2:11.3.0-2) experimental; urgency=medium
14
15 * d/copyright: further fix licenses after consulting SPDX
16diff --git a/debian/control b/debian/control
17index 52f79c5..0264bc6 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: open-vm-tools
22 Section: admin
23 Priority: optional
24-Maintainer: Bernd Zeimetz <bzed@debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org>
27 Uploaders: Christian Ehrhardt <christian.ehrhardt@canonical.com>
28 Build-Depends:
29 debhelper-compat (= 12), doxygen, libcunit1-dev,
30diff --git a/debian/rules b/debian/rules
31index f19b2ba..481ec14 100755
32--- a/debian/rules
33+++ b/debian/rules
34@@ -85,6 +85,9 @@ override_dh_auto_install:
35 mv debian/open-vm-tools/usr/lib/$(DEB_HOST_MULTIARCH)/open-vm-tools/serviceDiscovery/scripts/* debian/open-vm-tools-sdmp/usr/lib/$(DEB_HOST_MULTIARCH)/open-vm-tools/serviceDiscovery/scripts/
36 rm -rf debian/open-vm-tools/usr/lib/$(DEB_HOST_MULTIARCH)/open-vm-tools/serviceDiscovery/
37
38+ # Compat link for LP: #1944946 due to software checking the old non multiarch .so paths
39+ ln --relative --symbolic debian/open-vm-tools/usr/lib/$(DEB_HOST_MULTIARCH)/open-vm-tools debian/open-vm-tools/usr/lib/open-vm-tools
40+
41 override_dh_gencontrol:
42 if [ "${VENDOR}" = "UBUNTU" ]; \
43 then \

Subscribers

People subscribed via source and target branches