Merge ~paelzer/ubuntu/+source/open-vm-tools:lp-1855686-crash-broken-lsb-output-FOCAL into ubuntu/+source/open-vm-tools:ubuntu/focal-devel

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3857

[Christian Ehrhardt  (paelzer)]

Pre Fix:

● open-vm-tools.service - Service for virtual machines hosted on VMware
   Loaded: loaded (/lib/systemd/system/open-vm-tools.service; enabled; vendor preset: enabled)
   Active: failed (Result: core-dump) since Mon 2019-12-09 10:38:23 UTC; 11s ago
     Docs: http://open-vm-tools.sourceforge.net/about.php
  Process: 10317 ExecStart=/usr/bin/vmtoolsd (code=dumped, signal=SEGV)
 Main PID: 10317 (code=dumped, signal=SEGV)

Dec 09 10:38:22 node-4 systemd[1]: Started Service for virtual machines hosted on VMware.
Dec 09 10:38:23 node-4 systemd[1]: open-vm-tools.service: Main process exited, code=dumped, status=11/SEGV
Dec 09 10:38:23 node-4 systemd[1]: open-vm-tools.service: Failed with result 'core-dump'.

Post-Fix:
● open-vm-tools.service - Service for virtual machines hosted on VMware
   Loaded: loaded (/lib/systemd/system/open-vm-tools.service; enabled; vendor preset: enabled)
   Active: active (running) since Mon 2019-12-09 11:41:03 UTC; 3min 24s ago
     Docs: http://open-vm-tools.sourceforge.net/about.php
 Main PID: 13318 (vmtoolsd)
    Tasks: 2 (limit: 4915)
   CGroup: /system.slice/open-vm-tools.service
           └─13318 /usr/bin/vmtoolsd

Dec 09 11:41:03 node-4 systemd[1]: Started Service for virtual machines hosted on VMware.

Working as expected

[Rafael David Tinoco (rafaeldtinoco)]

Review checklist:

- [√] changelog entry correct, targeted to correct codename "focal"
- [-] no major upstream changes to consider
- [-] debian changes look safe
- [√] update-maintainer has been run
- [x] changes forwarded upstream/debian (if appropriate)
      - https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools (needs the patch)
- [-] nothing else to drop
- [x] patches match what was proposed upstream
      - lots of weird whitespaces (upstream) have been removed.
      - code changes are the same.
- [√] patches correctly included in debian/patches/series?
- [√] patches have correct DEP3 metadata
- [√] verified PPA package installs/uninstalls
- [-] autopkgtest against the PPA package passes

+1 for this change:

open-vm-tools (2:11.0.1-3ubuntu1) focal; urgency=medium

  * d/p/lp-1855686-Avoid-vmtoolsd-crash-in-HostInfo.patch: fix crash with
    uncommon lsb_output behavior (LP: #1855686)

 -- Christian Ehrhardt <email address hidden> Mon, 09 Dec 2019 11:03:56 +0100

Will do a +1 on the other merges as well (as its straight forward).

PS: Debian needs the same change. Should it be forwarded ? Do you plan to ?

Best,

Rafael

review: Approve

[Christian Ehrhardt  (paelzer)]

tag pushed and uploaded to focal

[Christian Ehrhardt  (paelzer)]

And FYI Debian is at https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools/merge_requests/1

diff --git a/debian/changelog b/debian/changelog
index f1e5390..6a78290 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+open-vm-tools (2:11.0.1-3ubuntu1) focal; urgency=medium
+
+  * d/p/lp-1855686-Avoid-vmtoolsd-crash-in-HostInfo.patch: fix crash with
+    uncommon lsb_output behavior (LP: #1855686)
+
+ -- Christian Ehrhardt <[e-mail]>  Mon, 09 Dec 2019 11:03:56 +0100
+
 open-vm-tools (2:11.0.1-3) unstable; urgency=medium
 
   * [c30953f] gitlab-ci: disable reprotest
diff --git a/debian/control b/debian/control
index 64ddd6f..6477170 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: open-vm-tools
 Section: admin
 Priority: optional
-Maintainer: Bernd Zeimetz <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Bernd Zeimetz <[e-mail]>
 Build-Depends:
  debhelper (>= 11~), doxygen, libcunit1-dev,
  libfuse-dev, libgtkmm-3.0-dev, libgtk-3-dev,
diff --git a/debian/patches/lp-1855686-Avoid-vmtoolsd-crash-in-HostInfo.patch b/debian/patches/lp-1855686-Avoid-vmtoolsd-crash-in-HostInfo.patch
new file mode 100644
index 0000000..6ed1acf
--- /dev/null
+++ b/debian/patches/lp-1855686-Avoid-vmtoolsd-crash-in-HostInfo.patch
@@ -0,0 +1,62 @@
+From 61b43df047e0a6666590016966b9574af21951a8 Mon Sep 17 00:00:00 2001
+From: Oliver Kurth <[e-mail]>
+Date: Thu, 5 Dec 2019 11:34:43 -0800
+Subject: [PATCH] Avoid vmtoolsd crash in HostInfo.
+
+The guest identification code causes vmtoolsd to crash in certain
+versions of some distros.  The crash is caused by recent changes to
+the lsb_release command.  Previously, if the command existed, all
+of its options worked.  Now, some of the options no longer exist.
+
+Change the code to check for an lsb_release failure whenever it is
+invoked.
+
+Fix for: https://github.com/vmware/open-vm-tools/issues/390
+
+Origin: upstream, https://github.com/vmware/open-vm-tools/commit/61b43df047e0a6666590016966b9574af21951a8
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1855686
+Last-Update: 2019-12-09
+Note: removed non important whitespace damage from the upstream patch
+
+---
+ open-vm-tools/lib/misc/hostinfoPosix.c | 32 +++++++++++++++-----------
+ 1 file changed, 19 insertions(+), 13 deletions(-)
+
+diff --git a/open-vm-tools/lib/misc/hostinfoPosix.c b/open-vm-tools/lib/misc/hostinfoPosix.c
+index 91a44ca89..26c3efd89 100644
+--- a/open-vm-tools/lib/misc/hostinfoPosix.c
++++ b/open-vm-tools/lib/misc/hostinfoPosix.c
+@@ -1334,6 +1334,8 @@ HostinfoLsbRemoveQuotes(char *lsbOutput)  // IN/OUT:
+ {
+    char *lsbStart = lsbOutput;
+ 
++   ASSERT(lsbStart != NULL);
++
+    if (lsbStart[0] == '"') {
+       char *quoteEnd = strchr(++lsbStart, '"');
+ 
+@@ -1407,13 +1409,17 @@ HostinfoLsb(char ***args)  // OUT:
+ 
+       /* LSB Distributor */
+       lsbOutput = HostinfoGetCmdOutput("/usr/bin/lsb_release -si 2>/dev/null");
+-      (*args)[0] = Util_SafeStrdup(HostinfoLsbRemoveQuotes(lsbOutput));
+-      free(lsbOutput);
++      if (lsbOutput != NULL) {
++         (*args)[0] = Util_SafeStrdup(HostinfoLsbRemoveQuotes(lsbOutput));
++         free(lsbOutput);
++      }
+ 
+       /* LSB Release */
+       lsbOutput = HostinfoGetCmdOutput("/usr/bin/lsb_release -sr 2>/dev/null");
+-      (*args)[1] = Util_SafeStrdup(HostinfoLsbRemoveQuotes(lsbOutput));
+-      free(lsbOutput);
++      if (lsbOutput != NULL) {
++         (*args)[1] = Util_SafeStrdup(HostinfoLsbRemoveQuotes(lsbOutput));
++         free(lsbOutput);
++      }
+ 
+       /* LSB Description */
+       (*args)[3] = Util_SafeStrdup((*args)[fields]);
+-- 
+2.24.0
+
diff --git a/debian/patches/series b/debian/patches/series
index c9b4b0c..55a1e83 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -3,3 +3,4 @@ debian/max_nic_count
 debian/scsi-udev-rule
 89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC
 d7d04cf9d_Avoid-securing-disk-device-info-for-ZFS-pools-at-this-time
+lp-1855686-Avoid-vmtoolsd-crash-in-HostInfo.patch