Merge ~paelzer/ubuntu/+source/open-vm-tools:bug-1844834-v11-bionic into ubuntu/+source/open-vm-tools:ubuntu/bionic-devel
- Git
- lp:~paelzer/ubuntu/+source/open-vm-tools
- bug-1844834-v11-bionic
- Merge into ubuntu/bionic-devel
Proposed by
Christian Ehrhardt
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Christian Ehrhardt | ||||
Approved revision: | 2432b3f65bd26796acadcf2f112fa68930531dfd | ||||
Merged at revision: | 2432b3f65bd26796acadcf2f112fa68930531dfd | ||||
Proposed branch: | ~paelzer/ubuntu/+source/open-vm-tools:bug-1844834-v11-bionic | ||||
Merge into: | ubuntu/+source/open-vm-tools:ubuntu/bionic-devel | ||||
Diff against target: |
236126 lines (+33500/-40114) (has conflicts) 306 files modified
ReleaseNotes.md (+46/-25) debian/.gitlab-ci.yml (+14/-0) debian/changelog (+112/-0) debian/control (+11/-6) debian/copyright (+1/-1) debian/open-vm-tools.lintian-overrides (+2/-0) debian/open-vm-tools.vgauth.service (+1/-0) debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC (+90/-0) debian/patches/fix_zfs_fs_detection (+13/-0) debian/patches/series (+5/-0) debian/rules (+2/-3) dev/null (+0/-62) open-vm-tools/AUTHORS (+9/-0) open-vm-tools/ChangeLog (+13979/-34669) open-vm-tools/Makefile.am (+8/-13) open-vm-tools/checkvm/checkvm.c (+6/-1) open-vm-tools/configure.ac (+30/-118) open-vm-tools/hgfsclient/hgfsclient.c (+7/-1) open-vm-tools/hgfsmounter/hgfsmounter.c (+9/-5) open-vm-tools/lib/appUtil/appUtilX11.c (+19/-9) open-vm-tools/lib/asyncsocket/asyncsocket.c (+171/-11) open-vm-tools/lib/auth/authPosix.c (+74/-16) open-vm-tools/lib/file/file.c (+2/-1) open-vm-tools/lib/file/fileIO.c (+5/-6) open-vm-tools/lib/file/fileInt.h (+4/-3) open-vm-tools/lib/file/fileLockPosix.c (+7/-12) open-vm-tools/lib/file/filePosix.c (+146/-131) open-vm-tools/lib/glibUtils/fileLogger.c (+9/-12) open-vm-tools/lib/glibUtils/stdLogger.c (+6/-6) open-vm-tools/lib/glibUtils/sysLogger.c (+6/-6) open-vm-tools/lib/hgfsServer/hgfsServer.c (+17/-12) open-vm-tools/lib/hgfsServer/hgfsServerLinux.c (+1/-1) open-vm-tools/lib/hgfsServer/hgfsServerPacketUtil.c (+2/-8) open-vm-tools/lib/hgfsServerManagerGuest/hgfsServerManagerGuest.c (+86/-18) open-vm-tools/lib/hgfsServerPolicyGuest/hgfsServerPolicyGuest.c (+6/-1) open-vm-tools/lib/include/appUtil.h (+3/-1) open-vm-tools/lib/include/asyncsocket.h (+27/-2) open-vm-tools/lib/include/auth.h (+3/-1) open-vm-tools/lib/include/backdoor_def.h (+182/-15) open-vm-tools/lib/include/backdoor_types.h (+3/-2) open-vm-tools/lib/include/buildNumber.h (+6/-6) open-vm-tools/lib/include/capsProvider.h (+2/-1) open-vm-tools/lib/include/circList.h (+29/-1) open-vm-tools/lib/include/conf.h (+106/-1) open-vm-tools/lib/include/deployPkg/linuxDeployment.h (+28/-1) open-vm-tools/lib/include/dynarray.h (+17/-1) open-vm-tools/lib/include/dynbuf.h (+42/-1) open-vm-tools/lib/include/err.h (+1/-1) open-vm-tools/lib/include/file.h (+8/-4) open-vm-tools/lib/include/ghIntegrationCommon.h (+130/-18) open-vm-tools/lib/include/guestInfo.h (+17/-1) open-vm-tools/lib/include/guest_os.h (+44/-12) open-vm-tools/lib/include/guest_os_tables.h (+19/-201) open-vm-tools/lib/include/hashTable.h (+2/-2) open-vm-tools/lib/include/hgfsServer.h (+10/-5) open-vm-tools/lib/include/hostinfo.h (+24/-10) open-vm-tools/lib/include/includeCheck.h (+11/-28) open-vm-tools/lib/include/ioplGet.h (+1/-1) open-vm-tools/lib/include/log.h (+43/-2) open-vm-tools/lib/include/logToHost.h (+32/-0) open-vm-tools/lib/include/loglevel_user.h (+11/-4) open-vm-tools/lib/include/mutexRankLib.h (+2/-1) open-vm-tools/lib/include/posix.h (+1/-1) open-vm-tools/lib/include/procMgr.h (+9/-1) open-vm-tools/lib/include/product.h (+3/-4) open-vm-tools/lib/include/productState.h (+5/-4) open-vm-tools/lib/include/random.h (+3/-1) open-vm-tools/lib/include/rpcin.h (+1/-1) open-vm-tools/lib/include/rpcout.h (+1/-7) open-vm-tools/lib/include/rpcvmx.h (+2/-13) open-vm-tools/lib/include/rpcvmxext.h (+49/-0) open-vm-tools/lib/include/sha1.h (+26/-1) open-vm-tools/lib/include/unicodeBase.h (+1/-1) open-vm-tools/lib/include/unicodeTypes.h (+3/-1) open-vm-tools/lib/include/util.h (+6/-1) open-vm-tools/lib/include/vixCommands.h (+1/-2) open-vm-tools/lib/include/vmGuestAppMonitorLib.h (+187/-0) open-vm-tools/lib/include/vmGuestLib.h (+10/-1) open-vm-tools/lib/include/vm_assert.h (+2/-2) open-vm-tools/lib/include/vm_atomic.h (+10/-7) open-vm-tools/lib/include/vm_basic_asm.h (+132/-102) open-vm-tools/lib/include/vm_basic_asm_x86.h (+20/-35) open-vm-tools/lib/include/vm_basic_asm_x86_64.h (+44/-66) open-vm-tools/lib/include/vm_basic_asm_x86_common.h (+403/-57) open-vm-tools/lib/include/vm_basic_defs.h (+67/-61) open-vm-tools/lib/include/vm_basic_types.h (+107/-206) open-vm-tools/lib/include/vm_device_version.h (+21/-16) open-vm-tools/lib/include/vm_product.h (+19/-20) open-vm-tools/lib/include/vm_product_versions.h (+58/-61) open-vm-tools/lib/include/vm_tools_version.h (+54/-4) open-vm-tools/lib/include/vm_version.h (+3/-1) open-vm-tools/lib/include/vmci_defs.h (+24/-2) open-vm-tools/lib/include/vmci_sockets.h (+8/-1) open-vm-tools/lib/include/vmstdio.h (+5/-1) open-vm-tools/lib/include/vmware/guestrpc/deploypkg.h (+2/-1) open-vm-tools/lib/include/vmware/guestrpc/guestcust-events.h (+42/-0) open-vm-tools/lib/include/vmware/guestrpc/tclodefs.h (+16/-1) open-vm-tools/lib/include/vmware/guestrpc/timesync.h (+3/-1) open-vm-tools/lib/include/vmware/tools/desktopevents.h (+8/-1) open-vm-tools/lib/include/vmware/tools/guestrpc.h (+25/-4) open-vm-tools/lib/include/vmware/tools/log.h (+44/-2) open-vm-tools/lib/include/vmware/tools/plugin.h (+10/-1) open-vm-tools/lib/include/vmware/tools/threadPool.h (+5/-2) open-vm-tools/lib/include/vmware/tools/utils.h (+1/-7) open-vm-tools/lib/include/wiper.h (+9/-3) open-vm-tools/lib/include/x86_basic_defs.h (+11/-2) open-vm-tools/lib/include/x86cpuid.h (+923/-867) open-vm-tools/lib/include/x86cpuid_asm.h (+35/-24) open-vm-tools/lib/lock/ul.c (+6/-6) open-vm-tools/lib/lock/ulBarrier.c (+3/-3) open-vm-tools/lib/lock/ulExcl.c (+3/-3) open-vm-tools/lib/lock/ulInt.h (+6/-8) open-vm-tools/lib/lock/ulIntShared.h (+2/-2) open-vm-tools/lib/lock/ulRW.c (+3/-3) open-vm-tools/lib/lock/ulRec.c (+4/-4) open-vm-tools/lib/lock/ulSema.c (+3/-3) open-vm-tools/lib/lock/ulStats.c (+28/-92) open-vm-tools/lib/misc/dynbuf.c (+61/-1) open-vm-tools/lib/misc/hostinfo.c (+61/-54) open-vm-tools/lib/misc/hostinfoHV.c (+2/-2) open-vm-tools/lib/misc/hostinfoInt.h (+30/-8) open-vm-tools/lib/misc/hostinfoPosix.c (+531/-220) open-vm-tools/lib/misc/idLinux.c (+40/-12) open-vm-tools/lib/misc/prng.c (+15/-1) open-vm-tools/lib/misc/sha1.c (+1/-429) open-vm-tools/lib/misc/timeutil.c (+2/-2) open-vm-tools/lib/misc/utilMem.c (+34/-1) open-vm-tools/lib/misc/util_misc.c (+3/-3) open-vm-tools/lib/misc/vmstdio.c (+35/-1) open-vm-tools/lib/misc/vthreadBase.c (+1/-1) open-vm-tools/lib/nicInfo/nicInfoPosix.c (+41/-6) open-vm-tools/lib/panic/panic.c (+11/-11) open-vm-tools/lib/poll/poll.c (+299/-95) open-vm-tools/lib/procMgr/procMgrPosix.c (+82/-16) open-vm-tools/lib/rpcChannel/bdoorChannel.c (+3/-2) open-vm-tools/lib/rpcChannel/glib_stubs.c (+43/-0) open-vm-tools/lib/rpcChannel/rpcChannel.c (+253/-135) open-vm-tools/lib/rpcChannel/rpcChannelInt.h (+2/-4) open-vm-tools/lib/rpcChannel/vsockChannel.c (+4/-3) open-vm-tools/lib/rpcIn/rpcin.c (+1/-1) open-vm-tools/lib/rpcOut/rpcout.c (+4/-2) open-vm-tools/lib/sslDirect/Makefile.am (+2/-9) open-vm-tools/lib/sslDirect/sslDirect.c (+1/-1) open-vm-tools/lib/stubs/stub-log.c (+57/-2) open-vm-tools/lib/stubs/stub-panic.c (+2/-1) open-vm-tools/lib/stubs/stub-warning.c (+3/-2) open-vm-tools/lib/syncDriver/syncDriverPosix.c (+27/-5) open-vm-tools/lib/system/systemLinux.c (+12/-2) open-vm-tools/lib/unicode/unicodeICU.c (+17/-13) open-vm-tools/lib/unicode/unicodeSimpleTypes.c (+36/-2) open-vm-tools/lib/user/util.c (+46/-10) open-vm-tools/lib/user/utilBacktrace.c (+3/-2) open-vm-tools/lib/wiper/wiperCommon.c (+5/-1) open-vm-tools/lib/wiper/wiperPosix.c (+50/-6) open-vm-tools/libDeployPkg/Makefile.am (+2/-2) open-vm-tools/libDeployPkg/deployPkgFormat.h (+22/-19) open-vm-tools/libDeployPkg/linuxDeployment.c (+225/-111) open-vm-tools/libDeployPkg/mspackWrapper.c (+3/-2) open-vm-tools/libappmonitor/COPYING (+502/-0) open-vm-tools/libappmonitor/Makefile.am (+74/-0) open-vm-tools/libappmonitor/appmonitor.pc.in (+13/-0) open-vm-tools/libappmonitor/stub-debug.c (+67/-0) open-vm-tools/libappmonitor/vmGuestAppMonitorLib.c (+462/-0) open-vm-tools/libappmonitor/vmGuestAppMonitorLibInt.h (+56/-0) open-vm-tools/libappmonitor/vmguestappmonitorlib_version.h (+35/-0) open-vm-tools/libguestlib/guestlibV3.x (+7/-2) open-vm-tools/libguestlib/vmGuestLib.c (+43/-1) open-vm-tools/libvmtools/Makefile.am (+1/-6) open-vm-tools/libvmtools/i18n.c (+13/-11) open-vm-tools/libvmtools/vmtoolsConfig.c (+7/-289) open-vm-tools/libvmtools/vmtoolsLog.c (+1103/-94) open-vm-tools/libvmtools/vmxLogger.c (+1/-12) open-vm-tools/m4/vmtools.m4 (+14/-16) open-vm-tools/modules/freebsd/vmmemctl/os.c (+37/-23) open-vm-tools/modules/shared/vmmemctl/backdoor_balloon.c (+63/-26) open-vm-tools/modules/shared/vmmemctl/backdoor_balloon.h (+6/-6) open-vm-tools/modules/shared/vmmemctl/balloon_def.h (+3/-2) open-vm-tools/modules/shared/vmmemctl/vmballoon.c (+17/-17) open-vm-tools/modules/shared/vmmemctl/vmballoon.h (+7/-7) open-vm-tools/modules/shared/vmxnet/eth_public.h (+10/-4) open-vm-tools/modules/shared/vmxnet/net.h (+3/-1) open-vm-tools/modules/shared/vmxnet/upt1_defs.h (+2/-2) open-vm-tools/modules/shared/vmxnet/vmnet_def.h (+4/-3) open-vm-tools/modules/shared/vmxnet/vmxnet3_defs.h (+107/-1) open-vm-tools/modules/solaris/vmxnet3/vmxnet3_main.c (+4/-2) open-vm-tools/modules/solaris/vmxnet3/vmxnet3_tx.c (+8/-5) open-vm-tools/namespacetool/namespacetool.c (+8/-1) open-vm-tools/rpctool/rpctool.c (+8/-1) open-vm-tools/scripts/Makefile.am (+0/-3) open-vm-tools/scripts/common/vm-support (+4/-2) open-vm-tools/services/plugins/Makefile.am (+1/-4) open-vm-tools/services/plugins/deployPkg/deployPkg.c (+38/-3) open-vm-tools/services/plugins/deployPkg/deployPkgLog.c (+3/-0) open-vm-tools/services/plugins/dndcp/Makefile.am (+19/-9) open-vm-tools/services/plugins/dndcp/copyPasteCompatX11.c (+19/-26) open-vm-tools/services/plugins/dndcp/copyPasteDnDX11.cpp (+2/-1) open-vm-tools/services/plugins/dndcp/copyPasteUIX11.cpp (+24/-4) open-vm-tools/services/plugins/dndcp/dnd/dnd.h (+32/-4) open-vm-tools/services/plugins/dndcp/dnd/dndCPMsgV4.c (+24/-8) open-vm-tools/services/plugins/dndcp/dnd/dndCPMsgV4.h (+14/-2) open-vm-tools/services/plugins/dndcp/dnd/dndClipboard.c (+18/-7) open-vm-tools/services/plugins/dndcp/dnd/dndClipboard.h (+9/-1) open-vm-tools/services/plugins/dndcp/dnd/dndCommon.c (+152/-0) open-vm-tools/services/plugins/dndcp/dnd/dndRpcV4.hh (+3/-1) open-vm-tools/services/plugins/dndcp/dndGuest/dndRpcV4.cc (+14/-1) open-vm-tools/services/plugins/dndcp/dndGuest/rpcV4Util.cpp (+35/-5) open-vm-tools/services/plugins/dndcp/dndGuest/rpcV4Util.hpp (+4/-1) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDCPMgr.cc (+131/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDCPMgr.hh (+56/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDMgr.cc (+166/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDMgr.hh (+53/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDSrc.cc (+103/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDSrc.hh (+41/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestFileTransfer.cc (+97/-0) open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestFileTransfer.hh (+51/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDImpl.h (+55/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDWrapper.cpp (+509/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDWrapper.h (+88/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDX11.h (+64/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dndFileList.cc (+715/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dndFileList.hh (+84/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dndPluginInt.h (+44/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dndRpcV3.cc (+693/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dndRpcV3.hh (+110/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dndUIX11.h (+240/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/dragDetWndX11.h (+97/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestCopyPaste.hh (+136/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnD.hh (+205/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDCPMgr.cc (+141/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDCPMgr.hh (+66/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDDest.cc (+254/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDMgr.cc (+631/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDSrc.cc (+277/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestFileTransfer.cc (+52/-0) open-vm-tools/services/plugins/dndcp/dndGuestBase/guestFileTransfer.hh (+43/-0) open-vm-tools/services/plugins/dndcp/dndUIX11.cpp (+126/-54) open-vm-tools/services/plugins/dndcp/dndcp.cpp (+25/-1) open-vm-tools/services/plugins/dndcp/dragDetWndX11.cpp (+50/-13) open-vm-tools/services/plugins/dndcp/fakeMouseWayland/fakeMouseWayland.cpp (+3/-2) open-vm-tools/services/plugins/dndcp/pointer.cpp (+1/-1) open-vm-tools/services/plugins/dndcp/stringxx/string.cc (+2/-1) open-vm-tools/services/plugins/dndcp/stringxx/string.hh (+3/-3) open-vm-tools/services/plugins/dndcp/stringxx/ubstr_t.hh (+3/-3) open-vm-tools/services/plugins/dndcp/vmCopyPasteDnDWrapper.cpp (+388/-0) open-vm-tools/services/plugins/dndcp/vmCopyPasteDnDWrapper.h (+59/-0) open-vm-tools/services/plugins/dndcp/xutils/xutils.cc (+89/-5) open-vm-tools/services/plugins/dndcp/xutils/xutils.hh (+4/-2) open-vm-tools/services/plugins/guestInfo/diskInfo.c (+823/-21) open-vm-tools/services/plugins/guestInfo/diskInfoPosix.c (+17/-5) open-vm-tools/services/plugins/guestInfo/guestInfoInt.h (+44/-6) open-vm-tools/services/plugins/guestInfo/guestInfoServer.c (+588/-187) open-vm-tools/services/plugins/guestInfo/perfMonLinux.c (+1/-1) open-vm-tools/services/plugins/hgfsServer/hgfsPlugin.c (+1/-1) open-vm-tools/services/plugins/powerOps/powerOps.c (+8/-3) open-vm-tools/services/plugins/vix/foundryToolsDaemon.c (+1/-220) open-vm-tools/services/plugins/vix/vixPlugin.c (+1/-3) open-vm-tools/services/plugins/vix/vixPluginInt.h (+1/-4) open-vm-tools/services/plugins/vix/vixTools.c (+289/-104) open-vm-tools/services/plugins/vix/vixToolsInt.h (+4/-2) open-vm-tools/services/plugins/vmbackup/scriptOps.c (+5/-2) open-vm-tools/services/plugins/vmbackup/stateMachine.c (+10/-8) open-vm-tools/services/plugins/vmbackup/vmBackupInt.h (+4/-4) open-vm-tools/services/vmtoolsd/Makefile.am (+2/-1) open-vm-tools/services/vmtoolsd/cmdLine.c (+1/-3) open-vm-tools/services/vmtoolsd/mainLoop.c (+107/-5) open-vm-tools/services/vmtoolsd/mainPosix.c (+11/-4) open-vm-tools/services/vmtoolsd/serviceObj.c (+19/-9) open-vm-tools/services/vmtoolsd/serviceObj.h (+2/-2) open-vm-tools/services/vmtoolsd/threadPool.c (+26/-26) open-vm-tools/services/vmtoolsd/toolsCoreInt.h (+3/-1) open-vm-tools/services/vmtoolsd/toolsHangDetector.c (+534/-0) open-vm-tools/services/vmtoolsd/toolsHangDetector.h (+31/-0) open-vm-tools/services/vmtoolsd/toolsRpc.c (+1/-1) open-vm-tools/tests/testVmblock/vmblocktest.c (+3/-2) open-vm-tools/toolbox/toolbox-cmd.c (+51/-14) open-vm-tools/toolbox/toolboxCmdInt.h (+17/-6) open-vm-tools/toolbox/toolboxcmd-info.c (+2/-2) open-vm-tools/toolbox/toolboxcmd-shrink.c (+10/-5) open-vm-tools/toolbox/toolboxcmd-stat.c (+11/-8) open-vm-tools/toolbox/toolboxcmd-time.c (+3/-4) open-vm-tools/tools.conf (+256/-0) open-vm-tools/vgauth/cli/main.c (+4/-1) open-vm-tools/vgauth/common/certverify.c (+7/-3) open-vm-tools/vgauth/common/i18n.c (+36/-24) open-vm-tools/vgauth/common/prefs.h (+9/-1) open-vm-tools/vgauth/common/vmxlog.c (+640/-0) open-vm-tools/vgauth/common/vmxlog.h (+45/-0) open-vm-tools/vgauth/lib/authPosix.c (+2/-2) open-vm-tools/vgauth/service/Makefile.am (+2/-1) open-vm-tools/vgauth/service/fileLogger.c (+1/-5) open-vm-tools/vgauth/service/gio.c (+4/-1) open-vm-tools/vgauth/service/main.c (+12/-1) open-vm-tools/vgauth/service/service.h (+2/-1) open-vm-tools/vgauth/serviceImpl/alias.c (+21/-1) open-vm-tools/vgauth/serviceImpl/proto.c (+3/-1) open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c (+44/-4) open-vm-tools/vgauth/serviceImpl/service.c (+2/-1) open-vm-tools/vgauth/serviceImpl/verify.c (+20/-9) open-vm-tools/vmhgfs-fuse/cache.c (+50/-1) open-vm-tools/vmhgfs-fuse/dir.c (+92/-83) open-vm-tools/vmhgfs-fuse/file.c (+125/-92) open-vm-tools/vmhgfs-fuse/filesystem.c (+31/-21) open-vm-tools/vmhgfs-fuse/fsutil.c (+35/-21) open-vm-tools/vmhgfs-fuse/link.c (+62/-63) open-vm-tools/vmhgfs-fuse/vmhgfs_version.h (+4/-4) open-vm-tools/xferlogs/xferlogs.c (+47/-9) Conflict in debian/changelog Conflict in debian/control Conflict in debian/patches/series |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Rafael David Tinoco (community) | Approve | ||
Canonical Server packageset reviewers | Pending | ||
git-ubuntu developers | Pending | ||
Review via email: mp+374899@code.launchpad.net |
Commit message
Description of the change
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt (paelzer) wrote : | # |
Revision history for this message
Christian Ehrhardt (paelzer) wrote : | # |
Builds and checks now good, reopening for review.
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote : | # |
Just like the Eoan merge:
https:/
I'm +1 on this change, including removing the Wno-errors that were introduced to allow GCC upgrade.
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) : | # |
review:
Approve
Revision history for this message
Christian Ehrhardt (paelzer) wrote : | # |
Thanks for the review, Tags pushed and uploaded
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | diff --git a/ReleaseNotes.md b/ReleaseNotes.md |
2 | index 3f754e0..3912c83 100644 |
3 | --- a/ReleaseNotes.md |
4 | +++ b/ReleaseNotes.md |
5 | @@ -1,9 +1,6 @@ |
6 | -open-vm-tools 10.3.10 Release Notes |
7 | -================================= |
8 | +**Updated on: 17 OCT 2019** |
9 | |
10 | -**Updated on: 14 MAR 2019** |
11 | - |
12 | -open-vm-tools | 14 MAR 2019 | Build 12406962 |
13 | +VMware Tools | 17 OCT 2019 | Build 14773994 |
14 | |
15 | Check for additions and updates to these release notes. |
16 | |
17 | @@ -15,32 +12,33 @@ The release notes cover the following topics: |
18 | * [What's New](#whatsnew) |
19 | * [Before You Begin](#beforeyoubegin) |
20 | * [Internationalization](#i18n) |
21 | +* [Product Support Notice](#productsupport) |
22 | * [End of Feature Support Notice](#endoffeaturesupport) |
23 | +* [Compatibility Notes](#compatibility) |
24 | * [Guest Operating System Customization Support](#guestop) |
25 | * [Interoperability Matrix](#interop) |
26 | -* [Resolved Issues](#resolvedissues) |
27 | * [Known Issues](#knownissues) |
28 | |
29 | What's New |
30 | ---------- |
31 | |
32 | -* **Resolved Issues: **There are some issues that are resolved in this release of open-vm-tools which are documented in the [Resolved Issues](#resolvedissues) section of this release notes. |
33 | +* It is highly recommended to upgrade to this version of VMware Tools, if you are using the native service discovery feature in vRealize Operations Manager 8.0, or using the vRealize Operations Service Discovery Management Pack with previous releases of vRealize Operations Manager (7.x or before). For more details, refer [KB 75122](https://kb.vmware.com/s/article/75122). |
34 | |
35 | Before You Begin |
36 | ---------------- |
37 | |
38 | -**Important note about upgrading to ESXi 5.5 Update 3b or later** |
39 | +**Important note about upgrading to ESXi 6.0 or later** |
40 | |
41 | -Resolution on incompatibility and general guidelines: While upgrading ESXi hosts to ESXi 5.5 Update 3b or ESXi 6.0 Update 1 or later, and using older versions of Horizon View Agent, refer to the knowledge base articles: |
42 | +Resolution on incompatibility and general guidelines: While upgrading ESXi hosts to ESXi 6.0 or later, and using older versions of Horizon View Agent, refer to the knowledge base articles: |
43 | |
44 | -* [Connecting to View desktops with Horizon View Agent 5.3.5 or earlier hosted on ESXi 5.5 Update 3b or later fails with a black screen.](http://kb.vmware.com/kb/2144438) |
45 | -* [Connecting to View desktops with Horizon View Agent 6.0.x or 6.1.x hosted on ESXi 5.5 Update 3b or later fails with a black screen.](http://kb.vmware.com/kb/2144518) |
46 | -* [Connecting to View desktops with Horizon View Agent 6.1.x hosted on ESXi 6.0 Update 1 or later fails with a black screen.](http://kb.vmware.com/kb/2144453) |
47 | +* [Connecting to View desktops with Horizon View Agent 5.3.5 or earlier hosted on ESXi 6.0 or later fails with a black screen.](http://kb.vmware.com/kb/2144438) |
48 | +* [Connecting to View desktops with Horizon View Agent 6.0.x or 6.1.x hosted on ESXi 6.0 or later fails with a black screen.](http://kb.vmware.com/kb/2144518) |
49 | +* [Connecting to View desktops with Horizon View Agent 6.1.x hosted on ESXi 6.0 or later fails with a black screen.](http://kb.vmware.com/kb/2144453) |
50 | |
51 | Internationalization |
52 | -------------------- |
53 | |
54 | -open-vm-tools 10.3.10 is available in the following languages: |
55 | +open-vm-tools 11.0.1 is available in the following languages: |
56 | |
57 | * English |
58 | * French |
59 | @@ -55,9 +53,12 @@ open-vm-tools 10.3.10 is available in the following languages: |
60 | End of Feature Support Notice |
61 | ----------------------------- |
62 | |
63 | -* Support for Common Agent Framework (CAF) will be removed in the next major release of open-vm-tools. |
64 | -* VMware Tools 10.3.5 freezes feature support for tar tools and OSPs |
65 | - The tar tools (linux.iso) and OSPs shipped with open-vm-tools 10.3.5 release will continue to be supported. However, releases after VMware Tools 10.3.5 will only include critical and security fixes and no new feature support in these types of open-vm-tools (tar tools and OSP's). It is recommended that customers use open-vm-tools for those operating systems that support open-vm-tools. For more information on different types of open-vm-tools, see [https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html](https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html) |
66 | +* The tar tools (linux.iso) and OSPs shipped with VMware Tools 10.3.5 release will continue to be supported. However, releases after VMware Tools 10.3.5 will only include critical and security fixes and no new feature support in these types of VMware Tools (tar tools and OSP's). It is recommended that customers use open-vm-tools for those operating systems that support open-vm-tools. For more information on different types of VMware Tools, see [https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html](https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html) |
67 | + |
68 | +Compatibility Notes |
69 | +------------------- |
70 | + |
71 | +* Starting with VMware Tools version 10.2.0, Perl script-based VMware Tools installation for FreeBSD has been discontinued. FreeBSD systems are supported only through the open-vm-tools packages directly available from FreeBSD package repositories. FreeBSD packages for open-vm-tools 10.1.0 and later are available from FreeBSD package repositories. |
72 | |
73 | Guest Operating System Customization Support |
74 | -------------------------------------------- |
75 | @@ -72,35 +73,55 @@ The [VMware Product Interoperability Matrix](http://partnerweb.vmware.com/comp_ |
76 | Resolved Issues |
77 | --------------- |
78 | |
79 | -* **In certain cases, quiesced snapshots on Linux guests do not include backup manifests.** |
80 | +* **Memory leak in vmtoolsd.** |
81 | |
82 | - On a Linux guest, if VMware Tools 10.3.5 gets an error when notifying the ESXi host of a quiesced snapshot's backup manifest file, VMware Tools logs an error and does not notify the ESXi host of the backup manifest file on subsequent quiesced snapshots. As a result, some quiesced snapshots do not include the backup manifest file, that would otherwise be available on the ESXi host. Such snapshots are not identified as quiesced by vSphere clients. |
83 | + vmtoolsd leaks memory when the vSphere APIs ListGuestAliases and ListGuestMappedAliasers are used. |
84 | |
85 | This issue is fixed in this release. |
86 | |
87 | Known Issues |
88 | ------------ |
89 | |
90 | +* **Suspend Guest of Linux VM using any version of open-vm-tools may fail with some versions of SELinux.** |
91 | + |
92 | + A "Suspend Guest" operation on a Linux guest running any version of open-vm-tools and with SELinux enabled may stall and ultimately fail. |
93 | + |
94 | + The failure may appear as: |
95 | + - a "Failed to suspend the virtual machine" message display. |
96 | + - nothing happened and the "Suspend Guest" button is reactivated. IPv4 connections may be closed. |
97 | + - a delayed suspend happens but the IPv4 addresses are lost when the VM is resumed. |
98 | + |
99 | + Even an apparent "stall" which exceeds 30 seconds is an indication of the problem. |
100 | + |
101 | + For more details, see [KB 74722](https://kb.vmware.com/s/article/74722). |
102 | + |
103 | + Workaround: |
104 | + |
105 | + Update the selinux-policy and selinux-policy-targeted packages to the latest version available from the Linux vendor. If package updates are not available or if the issue persists, then consider the following workaround: |
106 | + |
107 | + Create an exemption for the vmtools/NetworkManager denied access by using the audit2allow command to generate a local loadable SELinux policy module as outlined in [KB 74722](https://kb.vmware.com/s/article/74722). |
108 | + |
109 | * **Drag functionality fails to work in Ubuntu.** |
110 | |
111 | Drag functionality fails to work in Ubuntu 16.04.4 32-bit virtual machine installed using easy install. Also, failure of copy and paste functionality is observed in the same system. |
112 | |
113 | + Note: This issue is applicable for open-vm-tools running on Workstation and Fusion. |
114 | + |
115 | Workaround: |
116 | |
117 | * Add the modprobe.blacklist=vmwgfx linux kernel boot option. |
118 | * To gain access to larger resolutions, remove svga.guestBackedPrimaryAware = "TRUE" option from the VMX file. |
119 | - |
120 | * **Shared Folders mount is unavailable on Linux VM.** |
121 | |
122 | If the **Shared Folders** feature is enabled on a Linux VM while it is powered off, shared folders mount is not available on restart. |
123 | |
124 | - Workaround: |
125 | + Note: This issue is applicable for open-vm-tools running on Workstation and Fusion. |
126 | |
127 | - If the VM is powered on, disable and enable the **Shared Folders** feature from the interface. |
128 | - |
129 | - For resolving the issue permanently, edit **/etc/fstab** and add an entry to mount the Shared Folders automatically on boot. |
130 | - |
131 | - For example, add the line: |
132 | + Workaround: |
133 | |
134 | + If the VM is powered on, disable and enable the **Shared Folders** feature from the interface. |
135 | + For resolving the issue permanently, edit **/etc/fstab** and add an entry to mount the Shared Folders automatically on boot. |
136 | + For example, add the line: |
137 | vmhgfs-fuse /mnt/hgfs fuse defaults,allow\_other 0 0 |
138 | |
139 | + |
140 | diff --git a/debian/.gitlab-ci.yml b/debian/.gitlab-ci.yml |
141 | new file mode 100644 |
142 | index 0000000..62767c1 |
143 | --- /dev/null |
144 | +++ b/debian/.gitlab-ci.yml |
145 | @@ -0,0 +1,14 @@ |
146 | +include: |
147 | + - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml |
148 | + - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml |
149 | + |
150 | +variables: |
151 | + RELEASE: 'unstable' |
152 | + SALSA_CI_DISABLE_APTLY: 0 |
153 | + SALSA_CI_DISABLE_AUTOPKGTEST: 0 |
154 | + SALSA_CI_DISABLE_BLHC: 0 |
155 | + SALSA_CI_DISABLE_LINTIAN: 0 |
156 | + SALSA_CI_DISABLE_PIUPARTS: 0 |
157 | + SALSA_CI_DISABLE_REPROTEST: 0 |
158 | + SALSA_CI_DISABLE_BUILD_PACKAGE_ALL: 0 |
159 | + SALSA_CI_DISABLE_BUILD_PACKAGE_ANY: 0 |
160 | diff --git a/debian/changelog b/debian/changelog |
161 | index f7e8a4f..1049416 100644 |
162 | --- a/debian/changelog |
163 | +++ b/debian/changelog |
164 | @@ -1,3 +1,4 @@ |
165 | +<<<<<<< debian/changelog |
166 | open-vm-tools (2:10.3.10-1~ubuntu0.18.04.2) bionic; urgency=medium |
167 | |
168 | * Fix memory leaks in vix plugin (LP: #1847157) |
169 | @@ -12,6 +13,117 @@ open-vm-tools (2:10.3.10-1~ubuntu0.18.04.1) bionic; urgency=medium |
170 | * Backport recent open-vm-tools (LP: #1822204) |
171 | |
172 | -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 14 May 2019 09:07:32 +0200 |
173 | +======= |
174 | +open-vm-tools (2:11.0.1-2ubuntu0.18.11.1) bionic; urgency=medium |
175 | + |
176 | + * Update to latest release v11 (LP: #1844834) |
177 | + - d/rules: Revert "Enable all compiler errors again" for the older |
178 | + compiler |
179 | + |
180 | + -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 30 Oct 2019 09:58:25 +0100 |
181 | + |
182 | +open-vm-tools (2:11.0.1-2) unstable; urgency=medium |
183 | + |
184 | + * [76c600f] Fix segfault for fs devices without / |
185 | + See https://github.com/vmware/open-vm-tools/issues/378 for details. |
186 | + Thanks to Mo Zhou (Closes: #942692) |
187 | + |
188 | + -- Bernd Zeimetz <bzed@debian.org> Tue, 22 Oct 2019 15:48:48 +0200 |
189 | + |
190 | +open-vm-tools (2:11.0.1-1) unstable; urgency=medium |
191 | + |
192 | + * [bb36e10] Update upstream source from tag 'upstream/11.0.1' |
193 | + Update to upstream version '11.0.1' |
194 | + with Debian dir 60c0d512096774b9a2a7cc9e4e94556b2893ae8a |
195 | + |
196 | + -- Bernd Zeimetz <bzed@debian.org> Tue, 22 Oct 2019 09:40:50 +0200 |
197 | + |
198 | +open-vm-tools (2:11.0.0-2) unstable; urgency=medium |
199 | + |
200 | + * [4cfe383] Update Vcs-Git/Browser to point to salsa. |
201 | + * [bc253ad] Remove .travis.yml, add debian/.gitlab-ci.yml |
202 | + * [c92ca3a] Add add_patch.sh script to add patches from upstream. |
203 | + * [1d9b491] Add patch to remove deprecated inline functions |
204 | + * [3e2e307] Rename lintian-override file properly |
205 | + |
206 | + -- Bernd Zeimetz <bzed@debian.org> Tue, 15 Oct 2019 23:25:24 +0200 |
207 | + |
208 | +open-vm-tools (2:11.0.0-1) unstable; urgency=medium |
209 | + |
210 | + [ goldstar611 ] |
211 | + * [c138871] Ensure VGAuthService starts after AppArmor |
212 | + https://gitlab.com/apparmor/apparmor/issues/13 |
213 | + |
214 | + [ Bernd Zeimetz ] |
215 | + * [28ef841] New upstream version 11.0.0~0 |
216 | + * [f78ed2d] New upstream version 11.0.0 |
217 | + Closes: #940853 |
218 | + * [19efc80] Revert "Revert "Removing libdumbnet-dev."" |
219 | + This reverts commit 31177fab964d92687501ab81774440a9b8d09e39. |
220 | + * [bc14a8b] snapshot changelog |
221 | + * [1c5e9ea] Dropping patches that were picked from upstream |
222 | + |
223 | + -- Bernd Zeimetz <bzed@debian.org> Mon, 30 Sep 2019 14:37:27 +0200 |
224 | + |
225 | +open-vm-tools (2:10.3.10-3) unstable; urgency=medium |
226 | + |
227 | + [ Bernd Zeimetz ] |
228 | + * [19c646a] gcc9 compatibility. |
229 | + Upstream commit c68172ef7f2d4f116078e2aba82986a8cab0b16e (Closes: #925794) |
230 | + |
231 | + [ Christian Ehrhardt ] |
232 | + * [865763e] Fix other ftbfs with GCC-9 |
233 | + * d/rules: disable address-of-packed-member gcc-9 warnings for pre 11.0 code |
234 | + (LP: #1842301) |
235 | + * d/rules: use modern syntax for disabling deprecated-declarations |
236 | + * d/p/gcc9-Remove-GLib-2.32-deprecated-APIs-from-tools.patch: stop using outdated GLib features |
237 | + Upstream commit a7c141fc |
238 | + * d/p/gcc9-drop-obsolete-G_INLINE_FUNC.patch: stop using deprecated GLib Macro |
239 | + * d/p/gcc9-GStaticRecMutex.patch: stop using deprecated GStaticRecMutex |
240 | + Upstream commit 19ca3e36 |
241 | + * d/p/gcc9-build-error-in-vmblocktest.c.patch: avoid error due to stringop-truncation |
242 | + Upstream commit 553d1283 |
243 | + |
244 | + [ Bernd Zeimetz ] |
245 | + * [0ce2ba2] Policy 4.0.1: The extra priority has been deprecated |
246 | + * [c8760c6] Bumping Standards-Version to 4.4.0 |
247 | + * [a6ed8ce] Don't override dh_builddeb. |
248 | + debian-rules-should-not-use-custom-compression-settings |
249 | + * [bdfd8b5] Remove add_patch script |
250 | + * [be4d889] Update copyright years. |
251 | + * [9ac710e] Remove autotools-dev dependency. |
252 | + * [4296cf4] Fix permissions of udev rules file |
253 | + * [ed11c19] A new lintian override |
254 | + |
255 | + -- Bernd Zeimetz <bzed@debian.org> Tue, 03 Sep 2019 18:06:54 +0200 |
256 | + |
257 | +open-vm-tools (2:10.3.10-2) unstable; urgency=medium |
258 | + |
259 | + [ Christian Ehrhardt ] |
260 | + * [d79cc9d] d/control: fix postinst missing lsmod/modprobe. |
261 | + Upgrades on open-vm-desktop can trigger errors like the following: |
262 | + /var/lib/dpkg/info/open-vm-tools-desktop.postinst: 5: |
263 | + /var/lib/dpkg/info/open-vm-tools-desktop.postinst: lsmod: not found |
264 | + /var/lib/dpkg/info/open-vm-tools-desktop.postinst: 6: |
265 | + /var/lib/dpkg/info/open-vm-tools-desktop.postinst: modprobe: not found |
266 | + The reason is that kmod isn't a dependency of open-vm-tools-desktop and |
267 | + could be missing e.g. if you installed it in a system container. |
268 | + Once might discuss how useful open-vm-tools-desktop is in that |
269 | + environment but a n issue to fix none the less. |
270 | + Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> |
271 | + |
272 | + [ Bernd Zeimetz ] |
273 | + * [4d3f25f] Fix guest OS reporting for Debian/Buster. |
274 | + Without this fix, open-vm-tools report other4xLinux64Guest instead of |
275 | + Debian/Buster. |
276 | + Reason is the output of lsb_release, which outputs: |
277 | + $ lsb_release -sd |
278 | + Debian GNU/Linux 10 (buster) |
279 | + But the code in open-vm-tools expects '10.'. |
280 | + Thanks to Oliver Kurth (Closes: #934005) |
281 | + |
282 | + -- Bernd Zeimetz <bzed@debian.org> Wed, 07 Aug 2019 10:28:52 +0200 |
283 | +>>>>>>> debian/changelog |
284 | |
285 | open-vm-tools (2:10.3.10-1) unstable; urgency=high |
286 | |
287 | diff --git a/debian/control b/debian/control |
288 | index 9858935..a8964b2 100644 |
289 | --- a/debian/control |
290 | +++ b/debian/control |
291 | @@ -1,11 +1,15 @@ |
292 | Source: open-vm-tools |
293 | Section: admin |
294 | +<<<<<<< debian/control |
295 | Priority: extra |
296 | +======= |
297 | +Priority: optional |
298 | +>>>>>>> debian/control |
299 | Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com> |
300 | XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org> |
301 | Build-Depends: |
302 | - debhelper (>= 11~), autotools-dev, doxygen, libcunit1-dev, |
303 | - libdumbnet-dev, libfuse-dev, libgtkmm-3.0-dev, libgtk-3-dev, |
304 | + debhelper (>= 11~), doxygen, libcunit1-dev, |
305 | + libfuse-dev, libgtkmm-3.0-dev, libgtk-3-dev, |
306 | libicu-dev, libnotify-dev, libpam0g-dev, libprocps-dev, libx11-dev, |
307 | libxinerama-dev, libxss-dev, libxtst-dev, |
308 | libmspack-dev, |
309 | @@ -13,10 +17,10 @@ Build-Depends: |
310 | libxmlsec1-dev, |
311 | libudev-dev, |
312 | libdrm-dev, |
313 | -Standards-Version: 3.9.6 |
314 | +Standards-Version: 4.4.0 |
315 | Homepage: https://github.com/vmware/open-vm-tools |
316 | -Vcs-Git: https://github.com/bzed/pkg-open-vm-tools.git |
317 | -Vcs-Browser: https://github.com/bzed/pkg-open-vm-tools |
318 | +Vcs-Git: https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools.git |
319 | +Vcs-Browser: https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools |
320 | |
321 | Package: open-vm-tools |
322 | Architecture: amd64 i386 |
323 | @@ -37,7 +41,8 @@ Package: open-vm-tools-desktop |
324 | Architecture: amd64 i386 |
325 | Depends: ${misc:Depends}, ${shlibs:Depends}, |
326 | open-vm-tools (= ${binary:Version}), |
327 | - fuse |
328 | + fuse, |
329 | + kmod, |
330 | Breaks: open-vm-tools (<< 2:10.3.5-2~) |
331 | Replaces: open-vm-tools (<< 2:10.3.5-2~) |
332 | Recommends: |
333 | diff --git a/debian/copyright b/debian/copyright |
334 | index efa4e0d..47ec060 100644 |
335 | --- a/debian/copyright |
336 | +++ b/debian/copyright |
337 | @@ -29,7 +29,7 @@ License: MIT(**) |
338 | |
339 | Files: debian/* |
340 | Copyright: 2007-2013 Daniel Baumann <mail@daniel-baumann.ch> |
341 | - 2014 Bernd Zeimetz <bzed@debian.org> |
342 | + 2014-2019 Bernd Zeimetz <bzed@debian.org> |
343 | License: GPL-2+ |
344 | |
345 | License: BSD-3 |
346 | diff --git a/debian/open-vm-tools.lintian-overrides b/debian/open-vm-tools.lintian-overrides |
347 | new file mode 100644 |
348 | index 0000000..af41546 |
349 | --- /dev/null |
350 | +++ b/debian/open-vm-tools.lintian-overrides |
351 | @@ -0,0 +1,2 @@ |
352 | +# only kernel module source are under GPL. |
353 | +open-vm-tools: possible-gpl-code-linked-with-openssl |
354 | diff --git a/debian/open-vm-tools.vgauth.service b/debian/open-vm-tools.vgauth.service |
355 | index 86f03f2..1b00ca1 100644 |
356 | --- a/debian/open-vm-tools.vgauth.service |
357 | +++ b/debian/open-vm-tools.vgauth.service |
358 | @@ -4,6 +4,7 @@ Documentation=http://github.com/vmware/open-vm-tools |
359 | ConditionVirtualization=vmware |
360 | DefaultDependencies=no |
361 | After=systemd-remount-fs.service systemd-tmpfiles-setup.service |
362 | +After=apparmor.service |
363 | PartOf=open-vm-tools.service |
364 | |
365 | [Service] |
366 | diff --git a/debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC b/debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC |
367 | new file mode 100644 |
368 | index 0000000..a28cf83 |
369 | --- /dev/null |
370 | +++ b/debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC |
371 | @@ -0,0 +1,90 @@ |
372 | +From 89c0d444567eb525e8d083fb564c46d68e96660c Mon Sep 17 00:00:00 2001 |
373 | +From: Oliver Kurth <okurth@vmware.com> |
374 | +Date: Mon, 30 Sep 2019 16:24:27 -0700 |
375 | +Subject: [PATCH] GitHub Issue #367. Remove references to deprecated |
376 | + G_INLINE_FUNC. |
377 | + |
378 | +G_INLINE_FUNC was a work-around for compilers that didn't support |
379 | +static inline. Change uses of it to static inline. |
380 | +--- |
381 | + open-vm-tools/lib/include/vmware/tools/plugin.h | 2 +- |
382 | + open-vm-tools/lib/include/vmware/tools/threadPool.h | 8 ++++---- |
383 | + open-vm-tools/lib/include/vmware/tools/utils.h | 9 --------- |
384 | + 3 files changed, 5 insertions(+), 14 deletions(-) |
385 | + |
386 | +diff --git a/open-vm-tools/lib/include/vmware/tools/plugin.h b/open-vm-tools/lib/include/vmware/tools/plugin.h |
387 | +index f9acc6a29..deefd1f3d 100644 |
388 | +--- a/open-vm-tools/lib/include/vmware/tools/plugin.h |
389 | ++++ b/open-vm-tools/lib/include/vmware/tools/plugin.h |
390 | +@@ -290,7 +290,7 @@ typedef struct ToolsAppCtx { |
391 | + * |
392 | + * @return TRUE if COM is initialized when the function returns. |
393 | + */ |
394 | +-G_INLINE_FUNC gboolean |
395 | ++static inline gboolean |
396 | + ToolsCore_InitializeCOM(ToolsAppCtx *ctx) |
397 | + { |
398 | + if (!ctx->comInitialized) { |
399 | +diff --git a/open-vm-tools/lib/include/vmware/tools/threadPool.h b/open-vm-tools/lib/include/vmware/tools/threadPool.h |
400 | +index 3f2082b3e..5880fbcff 100644 |
401 | +--- a/open-vm-tools/lib/include/vmware/tools/threadPool.h |
402 | ++++ b/open-vm-tools/lib/include/vmware/tools/threadPool.h |
403 | +@@ -91,7 +91,7 @@ typedef struct ToolsCorePool { |
404 | + ******************************************************************************* |
405 | + */ |
406 | + |
407 | +-G_INLINE_FUNC ToolsCorePool * |
408 | ++static inline ToolsCorePool * |
409 | + ToolsCorePool_GetPool(ToolsAppCtx *ctx) |
410 | + { |
411 | + ToolsCorePool *pool = NULL; |
412 | +@@ -123,7 +123,7 @@ ToolsCorePool_GetPool(ToolsAppCtx *ctx) |
413 | + ******************************************************************************* |
414 | + */ |
415 | + |
416 | +-G_INLINE_FUNC guint |
417 | ++static inline guint |
418 | + ToolsCorePool_SubmitTask(ToolsAppCtx *ctx, |
419 | + ToolsCorePoolCb cb, |
420 | + gpointer data, |
421 | +@@ -153,7 +153,7 @@ ToolsCorePool_SubmitTask(ToolsAppCtx *ctx, |
422 | + ******************************************************************************* |
423 | + */ |
424 | + |
425 | +-G_INLINE_FUNC void |
426 | ++static inline void |
427 | + ToolsCorePool_CancelTask(ToolsAppCtx *ctx, |
428 | + guint taskId) |
429 | + { |
430 | +@@ -197,7 +197,7 @@ ToolsCorePool_CancelTask(ToolsAppCtx *ctx, |
431 | + ******************************************************************************* |
432 | + */ |
433 | + |
434 | +-G_INLINE_FUNC gboolean |
435 | ++static inline gboolean |
436 | + ToolsCorePool_StartThread(ToolsAppCtx *ctx, |
437 | + const gchar *threadName, |
438 | + ToolsCorePoolCb cb, |
439 | +diff --git a/open-vm-tools/lib/include/vmware/tools/utils.h b/open-vm-tools/lib/include/vmware/tools/utils.h |
440 | +index f65745906..a3292d5c0 100644 |
441 | +--- a/open-vm-tools/lib/include/vmware/tools/utils.h |
442 | ++++ b/open-vm-tools/lib/include/vmware/tools/utils.h |
443 | +@@ -51,15 +51,6 @@ |
444 | + # include <sys/time.h> |
445 | + #endif |
446 | + |
447 | +- |
448 | +-/* Work around a glib limitation: it doesn't set G_INLINE_FUNC on Win32. */ |
449 | +-#if defined(G_PLATFORM_WIN32) |
450 | +-# if defined(G_INLINE_FUNC) |
451 | +-# undef G_INLINE_FUNC |
452 | +-# endif |
453 | +-# define G_INLINE_FUNC static __inline |
454 | +-#endif |
455 | +- |
456 | + #ifndef ABS |
457 | + # define ABS(x) (((x) >= 0) ? (x) : -(x)) |
458 | + #endif |
459 | +-- |
460 | +2.23.0 |
461 | + |
462 | diff --git a/debian/patches/fix_zfs_fs_detection b/debian/patches/fix_zfs_fs_detection |
463 | new file mode 100644 |
464 | index 0000000..4fed620 |
465 | --- /dev/null |
466 | +++ b/debian/patches/fix_zfs_fs_detection |
467 | @@ -0,0 +1,13 @@ |
468 | +--- a/open-vm-tools/services/plugins/guestInfo/diskInfo.c |
469 | ++++ b/open-vm-tools/services/plugins/guestInfo/diskInfo.c |
470 | +@@ -826,8 +826,9 @@ GuestInfoGetDiskDevice(const char *fsNam |
471 | + /* Not an LVM; check if a basic block device. */ |
472 | + char blockDevPath[PATH_MAX]; |
473 | + |
474 | ++ char* x = strrchr(fsName, '/'); |
475 | + Str_Snprintf(blockDevPath, PATH_MAX, "%s/%s", LINUX_SYS_BLOCK_DIR, |
476 | +- strrchr(fsName, '/') + 1); |
477 | ++ x != NULL ? x+1 : ""); |
478 | + GuestInfoLinuxBlockDevice(blockDevPath, partEntry, 1 /* first and only*/); |
479 | + } |
480 | + |
481 | diff --git a/debian/patches/series b/debian/patches/series |
482 | index 0950b30..5b3c1fc 100644 |
483 | --- a/debian/patches/series |
484 | +++ b/debian/patches/series |
485 | @@ -1,6 +1,11 @@ |
486 | debian/pam-use-common-auth-account |
487 | debian/max_nic_count |
488 | debian/scsi-udev-rule |
489 | +<<<<<<< debian/patches/series |
490 | lp-1847157-Fix-memory-leaks-in-vix-tools-plugin.patch |
491 | lp-1847157-End-VGAuth-impersonation-in-the-case-of-error.patch |
492 | lp-1847157-Fix-leaks-in-ListAliases-and-ListMappedAliases-9bc72.patch |
493 | +======= |
494 | +89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC |
495 | +fix_zfs_fs_detection |
496 | +>>>>>>> debian/patches/series |
497 | diff --git a/debian/rules b/debian/rules |
498 | index 62a68ce..ab0cb9e 100755 |
499 | --- a/debian/rules |
500 | +++ b/debian/rules |
501 | @@ -20,7 +20,7 @@ override_dh_auto_configure: |
502 | --with-pic \ |
503 | --enable-xmlsec1 \ |
504 | --with-gtk3 \ |
505 | - CFLAGS="-fPIC -Wno-deprecated-declarations $(CFLAGS)" \ |
506 | + CFLAGS="-fPIC $(CFLAGS)" \ |
507 | CUSTOM_PROCPS_NAME=procps |
508 | |
509 | override_dh_auto_install: |
510 | @@ -35,6 +35,7 @@ override_dh_auto_install: |
511 | # permissions |
512 | chmod 0644 debian/*/etc/pam.d/* |
513 | chmod 4755 debian/*/usr/bin/vmware-user-suid-wrapper |
514 | + chmod 0644 debian/*/lib/udev/rules.d/99-vmware-scsi-udev.rules |
515 | |
516 | install -D -m 0644 debian/local/xautostart.conf debian/open-vm-tools-desktop/etc/vmware-tools/xautostart.conf |
517 | install -D -m 0644 debian/local/tools.conf debian/open-vm-tools/etc/vmware-tools/tools.conf |
518 | @@ -84,8 +85,6 @@ override_dh_gencontrol: |
519 | else \ |
520 | dh_gencontrol; \ |
521 | fi |
522 | -override_dh_builddeb: |
523 | - dh_builddeb -- -Zxz |
524 | |
525 | override_dh_fixperms: |
526 | dh_testroot |
527 | diff --git a/open-vm-tools/AUTHORS b/open-vm-tools/AUTHORS |
528 | index ff87a57..08cc28e 100644 |
529 | --- a/open-vm-tools/AUTHORS |
530 | +++ b/open-vm-tools/AUTHORS |
531 | @@ -37,6 +37,15 @@ Ed Schouten Use standard SYSCTL_ADD_OID() macro to access the |
532 | Steve Wills Fix vmmemctl.ko driver build for supported FreeBSD releases. |
533 | - https://github.com/vmware/open-vm-tools/pull/140 |
534 | |
535 | +John Eismeier Propose fix some spelling. |
536 | + - https://github.com/vmware/open-vm-tools/pull/264 |
537 | + |
538 | +Josh Paetzel Additional changes to vmmemctl.ko for FreeBSD 12.0 API changes. |
539 | + - https://github.com/vmware/open-vm-tools/pull/286 |
540 | + |
541 | [Code]Ai Highlighted a potential NULL pointer dereference and four |
542 | pieces of dead code. |
543 | - https://github.com/vmware/open-vm-tools/pull/247 |
544 | + |
545 | +Haruki Tsurumoto Fix Asianux identification |
546 | + - https://github.com/vmware/open-vm-tools/pull/325 |
547 | diff --git a/open-vm-tools/ChangeLog b/open-vm-tools/ChangeLog |
548 | index 2e5317f..bcbdaeb 100644 |
549 | --- a/open-vm-tools/ChangeLog |
550 | +++ b/open-vm-tools/ChangeLog |
551 | @@ -1,40768 +1,20078 @@ |
552 | -commit 4826a76513b6f8254132f664e07fa70ed18f22c4 |
553 | +commit 94abb05ae948eae31091a5bdcdd5d78e5e0192d1 |
554 | Author: Oliver Kurth <okurth@vmware.com> |
555 | -Date: Sat Mar 16 10:40:23 2019 -0700 |
556 | +Date: Wed Oct 2 17:48:35 2019 -0700 |
557 | |
558 | - update version and build number |
559 | + Fix leaks in ListAliases and ListMappedAliases. |
560 | |
561 | -commit 990cc40de10f257d1d3c01b69fe476c233afb950 |
562 | + The 'record' for each alias was being leaked. |
563 | + |
564 | +commit 87589da5255d84efad0c50446246b2788eeab582 |
565 | Author: Oliver Kurth <okurth@vmware.com> |
566 | -Date: Sat Mar 16 10:39:48 2019 -0700 |
567 | +Date: Fri Sep 20 13:11:24 2019 -0700 |
568 | |
569 | - correct verson numbers |
570 | + release notes for 11.0.0 |
571 | |
572 | -commit f6a274cf64eebfd574e8cf587b4ebaf1c579267f |
573 | +commit 3c03fd5446ddd23979380fd2518f1f5c7c116dbd |
574 | Author: Oliver Kurth <okurth@vmware.com> |
575 | -Date: Sat Mar 16 10:27:03 2019 -0700 |
576 | +Date: Fri Sep 20 11:08:35 2019 -0700 |
577 | |
578 | - Update release notes for 10.3.10 |
579 | + update copyright header for lib/include/vmware/guestrpc/tclodefs.h |
580 | |
581 | -commit 640bd4f9c012b201ad1d45a131dad2e804f53766 |
582 | +commit 99145edb39cc1e08b0848ea464fd17dca2ef2541 |
583 | Author: Oliver Kurth <okurth@vmware.com> |
584 | -Date: Wed Feb 6 16:47:22 2019 -0800 |
585 | +Date: Fri Sep 20 11:07:16 2019 -0700 |
586 | |
587 | - sync deploypkg files |
588 | + update build number for release |
589 | |
590 | -commit 182eda3bc5f371339114241f0581f446e72def6d |
591 | +commit 570ec94ccfc5bcf2a55d891ae8af2a24bb4e9caf |
592 | Author: Oliver Kurth <okurth@vmware.com> |
593 | -Date: Tue Feb 5 17:36:53 2019 -0800 |
594 | +Date: Thu Aug 29 17:14:39 2019 -0700 |
595 | |
596 | - Update copyright year to 2019 for OVT 10.3.10 files. |
597 | - |
598 | - * Few dnd related files have been modified since 10.3.5 OVT and |
599 | - we just missed updating the copyright year to 2019. |
600 | - |
601 | - * Updated the copyright year accordingly. |
602 | + Due to a quirk the way patches were generated, the 'coomon-agent' directory was not removed as intended, but just contained empty files |
603 | |
604 | -commit ba83c29fcd703ecb6a13a7767bad180033234aea |
605 | +commit ae791f849d0e49d968a3ba068d6f421de936754d |
606 | Author: Oliver Kurth <okurth@vmware.com> |
607 | -Date: Tue Jan 29 17:24:44 2019 -0800 |
608 | +Date: Fri Aug 23 13:33:55 2019 -0700 |
609 | |
610 | - Fix CentOS 7.6 detection |
611 | - |
612 | - The version information in /etc/centos-release has 3 parts, |
613 | - in particular for CentOS 7.6: |
614 | - |
615 | - CentOS Linux release 7.6.1810 (Core) |
616 | - |
617 | - This was misidentified as CentOS 6 because the substring "6." |
618 | - was matched before matching "7.". This change fixes this by |
619 | - requiring a space before the major version. |
620 | + tools.conf example: add vss.disableAppQuiescing |
621 | |
622 | -commit f4708f4b5a9d24b122237875ce6a542f267caab3 |
623 | +commit 867f9cf4fd9903e1e10e4d7f70fef3b7fdb2a5d3 |
624 | Author: Oliver Kurth <okurth@vmware.com> |
625 | -Date: Tue Jan 29 17:24:44 2019 -0800 |
626 | +Date: Mon Aug 5 11:22:01 2019 -0700 |
627 | |
628 | - Include vmware/tools/log.h to define g_info. |
629 | - |
630 | - A recent change added a call to g_info from syncManifest.c. This |
631 | - in turn is causing open-vm-tools builds to fail because g_info is |
632 | - not available on SLES 12sp1. |
633 | + Enable the guest OS disk mapping feature as default. |
634 | |
635 | - To fix the problem, include vmware/tools/log.h in syncManifest.c. |
636 | - log.h defines g_info as a macro. |
637 | + Enabling the OS disk mapping feature in VMware Tools 11.0.0 for |
638 | + Windows and Linux guests. |
639 | |
640 | -commit 139a21cab79d971e9fe3ea5b8e993646b2e6cb48 |
641 | +commit 782b42a5248cd01d37f0002aa7e30df4cc787129 |
642 | Author: Oliver Kurth <okurth@vmware.com> |
643 | -Date: Tue Jan 29 17:24:44 2019 -0800 |
644 | +Date: Mon Aug 5 11:22:01 2019 -0700 |
645 | |
646 | - Always send VMBACKUP_EVENT_GENERIC_MANIFEST during quiesced snapshots. |
647 | - |
648 | - vSphere 6.7 added a host-side interface that allows VMTools to send |
649 | - a "generic" backup manifest during a quiesced snapshot on Linux guests. |
650 | - VMTools 10.2.0 or later tries to notify the host of the backup manifest |
651 | - file through a vmbackup event message VMBACKUP_EVENT_GENERIC_MANIFEST. |
652 | - If the host is unable to field the message, then VMTools logs the |
653 | - failure and then continues with the quiesced snapshot in the older |
654 | - fashion, without the backup manifest. |
655 | - |
656 | - An earlier change attempted to reduce the amount of logging done when |
657 | - running on older hosts that don't support VMBACKUP_EVENT_GENERIC_MANIFEST |
658 | - by detecting when sending VMBACKUP_EVENT_GENERIC_MANIFEST fails and |
659 | - not sending the message again for subsequent quiesced snapshots. |
660 | - However, subsequent stress testing has uncovered problems with this |
661 | - approach when running on newer hosts; specifically, errors may sometimes |
662 | - be encountered on newer hosts when sending VMBACKUP_EVENT_GENERIC_MANIFEST. |
663 | - Therefore this change backs out that earlier change. |
664 | - |
665 | - Note that the need to solve the problem that that earlier change was |
666 | - intended to solve has been reduced because support for |
667 | - VMBACKUP_EVENT_GENERIC_MANIFEST has been backported to vSphere 6.5 |
668 | - P03, which is available, and vSphere 6.0 P08, which is scheduled for |
669 | - release later this year. ESXi 5.5 is out of general support. |
670 | - |
671 | - This change also addresses an issue that surfaced when testing on a |
672 | - host without support for VMBACKUP_EVENT_GENERIC_MANIFEST. |
673 | - If VMTools fails to send VMBACKUP_EVENT_GENERIC_MANIFEST, the quiesced |
674 | - snapshot operation will be aborted rather than continuing as it should. |
675 | - To address this, create a new function, VmBackup_SendEventNoAbort, |
676 | - which does not abort the quiesced snapshot on failure, and call that |
677 | - function rather than VmBackup_SendEvent when sending |
678 | - VMBACKUP_EVENT_GENERIC_MANIFEST. |
679 | + Fix broken command: vmtoolsd --cmd info-get | info-set |
680 | |
681 | -commit f9a93010ac532ab8eaaeba7f1de5c0c3e732554a |
682 | +commit d4922cad5f627b1dd3315f59ed8a5ce2f4767e83 |
683 | Author: Oliver Kurth <okurth@vmware.com> |
684 | -Date: Tue Jan 29 17:24:43 2019 -0800 |
685 | +Date: Mon Aug 5 11:22:01 2019 -0700 |
686 | |
687 | - Update copyright year to 2019. |
688 | + [OVT] Update copyright year to 2019. |
689 | + |
690 | + A new version of VMware Tools 11.0.0 will be released in 2019. All |
691 | + applicable files need to stamped with 2019 copyright year. |
692 | |
693 | -commit 74d165bab17132b50d909b7f2e5cb19f3f140a01 |
694 | +commit 5cb75e0a93b9531875e9e29515a0ea912ca3aca7 |
695 | Author: Oliver Kurth <okurth@vmware.com> |
696 | -Date: Tue Jan 29 14:03:19 2019 -0800 |
697 | +Date: Mon Aug 5 11:22:00 2019 -0700 |
698 | |
699 | - Fix some bad derefs in primary NIC gather code |
700 | + Avoid freezing mount points for same device. |
701 | |
702 | - Found by user in https://github.com/vmware/open-vm-tools/issues/272 |
703 | + Loopback device setup could cause a cyclic dependency |
704 | + between 2 mount points. In order to break the cycle, |
705 | + avoid freezing the mount points to the same device. |
706 | |
707 | - Debug code tries to access a struct field that may not be init'd. |
708 | - Pointer deref'd without a sanity check. |
709 | + This change also skips some system mount points for 'tmpfs' |
710 | + and 'cgroup' etc as those share the same device/FS name. |
711 | + This is fine because we can't quiese those mount points |
712 | + anyway (system mount points don't support quiescing). |
713 | |
714 | -commit e88f91b00a715b79255de6576506d80ecfdb064c |
715 | +commit 385dc97f645ccaa4a0550b53949715394a009fb6 |
716 | Author: Oliver Kurth <okurth@vmware.com> |
717 | -Date: Tue Jan 29 14:03:19 2019 -0800 |
718 | +Date: Mon Aug 5 11:21:59 2019 -0700 |
719 | |
720 | - Fix possible security issue with the permissions of the intermediate |
721 | - staging directory and path |
722 | - |
723 | - /tmp/VMwareDnD is a staging directory used for DnD and CnP. It should be |
724 | - a regular directory, but malicious code or user may create the /tmp/VMwareDnD |
725 | - as a symbolic link which points elsewhere on the system. This may provide |
726 | - user access to user B's files. |
727 | + Add RpcChannel_SendOneRawPriv() |
728 | |
729 | - Do not set the permission of the root directory if the root directory |
730 | - already exists and has the wrong permission. The permission of the directory |
731 | - must be 1777 if it is created by the VMToolsi. If not, then the directory |
732 | - has been created or modified by malicious code or user, so just cancel the |
733 | - host to guest DnD or CnP operation. |
734 | + Send privileged guest RPC "guestStore.connect" with it after the |
735 | + vmsvc RPC channel falls back to backdoor. |
736 | |
737 | -commit bfa5e5d27a8a96a9c71fbe581f3fe32dcd2e55fd |
738 | +commit e385c90808d527bce41259796badba094ad62a77 |
739 | Author: Oliver Kurth <okurth@vmware.com> |
740 | -Date: Tue Jan 29 14:03:19 2019 -0800 |
741 | +Date: Mon Aug 5 11:21:59 2019 -0700 |
742 | |
743 | - CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate(). |
744 | + Add an example configuration tools.conf file for tools |
745 | |
746 | - Red Hat ran coverity scan on open-vm-tools and found an occurrence |
747 | - of CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate(). |
748 | + This adds an example tools.conf file. Settings are shown in the |
749 | + file with default values, but commented out with documentation. |
750 | |
751 | -commit 4bba1dcd28806eff0cb3795cbfeea32f91fb1c40 |
752 | +commit decb8769e31e88f23b16b7a6ff3a1545a6259abe |
753 | Author: Oliver Kurth <okurth@vmware.com> |
754 | -Date: Tue Jan 29 14:03:19 2019 -0800 |
755 | +Date: Mon Aug 5 11:21:59 2019 -0700 |
756 | |
757 | - Bail out vmtoolsd early when there are RPC errors. |
758 | + [TOOLS] Fix dnd text from Linux guest |
759 | |
760 | - VMX state machine could give up quiescing operation for various |
761 | - reasons when vmtoolsd is busy performing necessary state transitions. |
762 | - Once VMX gives up quiescing operation, there is no point in |
763 | - vmtoolsd continuing with it. vmtoolsd should also give up the |
764 | - operation asap. vmtoolsd can detect VMX state machine change |
765 | - when it gets errors sending VMBACKUP_PROTOCOL_EVENT_SET RPC. |
766 | + Gtk::Widget::drag_dest_find_target() returns different values from GDK_NONE |
767 | + on Gtk2 and Gtk3. |
768 | |
769 | - RPC errors are only used as a trigger to abort the operation. |
770 | - We ignore the RPC errors that might occur after aborting the |
771 | - operation. |
772 | + On Gtk2, it returns an empty string. It matches the existing code. |
773 | + On Gtk3, it returns "NONE". The current logic breaks. |
774 | + |
775 | + To overcome this issue, use Gdk::AtomString::to_cpp_type(GDK_NONE) to |
776 | + replace the current empty string. This works on both Gtk2 and Gtk3. |
777 | |
778 | -commit 0cb7f7a903015e5e711fa6eb5b41748f797ce794 |
779 | +commit 8d299b17ba81d47f7f561479a688ab1843f904c8 |
780 | Author: Oliver Kurth <okurth@vmware.com> |
781 | -Date: Tue Jan 29 14:03:19 2019 -0800 |
782 | +Date: Mon Aug 5 11:21:59 2019 -0700 |
783 | |
784 | - [10.3.10] Update copyright year to 2019. |
785 | + Fix gcc 9.1 build error in vmblocktest.c |
786 | |
787 | - Update the copyright year to 2019 for ALL open-vm-tools destined files |
788 | - modified since the release of 10.3.5. |
789 | + GCC 9.1 in Ubuntu eoan (19.10) failed to build open-vm-tools: |
790 | + error: '__builtin_strncpy' specified bound 4096 equals destination |
791 | + size [-Werror=stringop-truncation] |
792 | |
793 | -commit e569c47f85fa8520f0834148d6774c1cb66df68c |
794 | +commit e8d08518353295527e635f666c0d3146dcc698cb |
795 | Author: Oliver Kurth <okurth@vmware.com> |
796 | -Date: Tue Jan 29 14:03:19 2019 -0800 |
797 | +Date: Sat Jul 20 17:10:07 2019 -0700 |
798 | |
799 | - Don't send a backup manifest when aborting a Linux quiesced snapshot. |
800 | - |
801 | - When taking a Linux quiesced snapshot, communication failures between |
802 | - VMX and VMTools may result in VMTools sending a genericManifest event |
803 | - message after the quiesced snapshot operation has been aborted. If |
804 | - this happens, VMX will send an error back to VMTools, which in turn |
805 | - causes VMTools not to send genericManifest messages on subsequent |
806 | - quiesced snapshots even if the host supports such messages. |
807 | + version 11.0.0 |
808 | + |
809 | +commit 82ef6f896c99212c9366e3e52d7767e86d9677c3 |
810 | +Author: Oliver Kurth <okurth@vmware.com> |
811 | +Date: Sat Jul 20 17:03:42 2019 -0700 |
812 | + |
813 | + Fix the memory leak in procMgr library. |
814 | |
815 | - One aspect of the implementation that gives rise to this behavior is |
816 | - the use of the sync provider's snapshotDone function to undo a |
817 | - quiescing operation. Specifically, if VMTools aborts a quiesced |
818 | - snapshot when the file system is quiesced, the quiescing must be |
819 | - undone. Currently, this is handled by calling the sync provider's |
820 | - snapshotDone function. This is the same function that is called to |
821 | - complete the quiescing snapshot protocol when it is successful. In |
822 | - some respects this makes sense, since in either case snapshotDone |
823 | - unquiesces the file system. However, architecturally and conceptually, |
824 | - it seems useful to distinguish between the action to be taken in the |
825 | - successful case versus the aborting case. It's also useful to do so |
826 | - in practice, because the successful case sends the genericManifest |
827 | - event to notify the host there is a backup manifest file, while the |
828 | - aborting case should not do that. |
829 | + In a specific code path, procCmdAbsPath attribute is ovewritten |
830 | + with the new memory. This leads to a memory leak for the previously |
831 | + allocated memory. |
832 | + |
833 | +commit 003ed9e082dd10c67aa022514ad0c662c7e1a6a4 |
834 | +Author: Oliver Kurth <okurth@vmware.com> |
835 | +Date: Sat Jul 20 17:03:42 2019 -0700 |
836 | + |
837 | + GuestInfo: fix memory leak in GuestInfoGetPrimaryIP() |
838 | |
839 | - To address the issue, add an "undo" function for the Linux sync |
840 | - provider. The undo function is called instead of snapshotDone as |
841 | - part of aborting a quiesced snapshot in which the file system is |
842 | - quiesced at the time of the abort. |
843 | + "ipstr" was not free'ed when it was not being used. |
844 | |
845 | -commit 81835cd72369b5b75fc5b0bed761f3b75cb7146b |
846 | +commit 3d60252dc25705841c4afb49e766be2bd7815acd |
847 | Author: Oliver Kurth <okurth@vmware.com> |
848 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
849 | +Date: Sat Jul 20 17:03:42 2019 -0700 |
850 | |
851 | - Special-case profile loading for StartProgram |
852 | + Avoid emitting a trailing comma in the GuestInfoSendDiskInfoV1 JSON RPC |
853 | |
854 | - Keep the user's profile loaded for the life of the |
855 | - program, to avoid races where its unloaded too quickly. |
856 | + Although currently accepted by the JSON library that we are using |
857 | + in VMX, that superfluous comma is strictly invalid according to the |
858 | + JSON standard - ECMA-404. |
859 | |
860 | -commit d3515adb2a1617dcde4b65a6a9ab72ee8624454b |
861 | +commit f65edaec32d2e1c7c14d69f4f2af669805cfd4b4 |
862 | Author: Oliver Kurth <okurth@vmware.com> |
863 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
864 | +Date: Sat Jul 20 17:03:42 2019 -0700 |
865 | |
866 | - Changes to common source files not applicable to open-vm-tools. |
867 | + [Tools/dndcp] Fix two coverity issues reported by a customer. |
868 | |
869 | -commit 4d3e3183bc04517cf75ab590a12e14224207eb6d |
870 | +commit 74fe39c2abac9da4d45188eec8b389be421f7c8f |
871 | Author: Oliver Kurth <okurth@vmware.com> |
872 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
873 | +Date: Sat Jul 20 17:03:42 2019 -0700 |
874 | |
875 | - Bump up the SYSIMAGE_VERSION for VMware tools 10.3.10 |
876 | - |
877 | - The last released deploypkg version for 'VMware Tools' 10.3.5 is 8.4.1. |
878 | - Bumping up the CBS version to 8.4.10. |
879 | + Add the SLEDGEHAMMER code name to the 11.0.0 release version defines. |
880 | |
881 | -commit 8f3630e77bcf647c22c40093bb37500f3032e578 |
882 | +commit 0c6ad5edceca60dc05eb9f3b1ee6ac42dc0455ef |
883 | Author: Oliver Kurth <okurth@vmware.com> |
884 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
885 | +Date: Wed Jul 3 14:28:56 2019 -0700 |
886 | |
887 | - Deploypkg log files of linux should not be world readable. |
888 | + Fix a Coverity issue reported in vgauth/serviceImpl/verify.c |
889 | |
890 | -commit 4470d99e5eaf19cea741e6fa6f46c72acd57b3e1 |
891 | +commit 47c8f75e4516552615c070c6920633f7e8e572a0 |
892 | Author: Oliver Kurth <okurth@vmware.com> |
893 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
894 | +Date: Wed Jul 3 14:28:56 2019 -0700 |
895 | |
896 | - General code clean-up. |
897 | + Fix process command name for special linux processes. |
898 | |
899 | - bora/lib/misc/posixPosix.c: |
900 | - Treat local variables "len" consistently as "size_t" type in |
901 | - Posix_Getmntent_r() |
902 | + While listing down the processes in a linux guest, the existing |
903 | + procMgr library reads /proc/<PID>/cmdline file and parses the |
904 | + content. While reading this, an assumption is made that there is |
905 | + a null terminating character at the end of the file content. |
906 | + This holds true for most of the processes. But for few special processes, |
907 | + the cmdline file doesn't have the terminating null character. |
908 | |
909 | - bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c: |
910 | - Improve readability of error handling logic in ShrinkDoWipeAndShrink() |
911 | - and remove another line of dead code. |
912 | + Proper content from cmdline file: |
913 | |
914 | - bora-vmsoft/lib/procMgr/procMgrPosix.c: |
915 | - Recent discussions about setting "errno" to ENOENT when either |
916 | - getpwuid_r() or getpwnam_r() return 0 (success) if there is no passwd |
917 | - entry for the user have vacillated. |
918 | + /usr/lib/systemd/systemd\0--switched-root\0--system\0--deserialize\021\0 |
919 | + /usr/sbin/vmtoolsd\0 |
920 | + sshd: root@pts/2\0\0\0 |
921 | + |
922 | + Example cmdline file where NUL terminator is missing: |
923 | |
924 | - Since none of the current callers of the routines in procMgrPosix.c |
925 | - query the contents of "errno", the current consensus is to simply log |
926 | - a warning message along with reason for the failure. |
927 | + avahi-daemon: running [linux.local] |
928 | + avahi-daemon: chroot helper |
929 | |
930 | -commit 5f3f6ccd3ad143d64f2927bd19791a6148e1e2ba |
931 | +commit 2660d40ca4f5beca0ba3a4c68a66f8c7dcf77a67 |
932 | Author: Oliver Kurth <okurth@vmware.com> |
933 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
934 | +Date: Wed Jul 3 14:28:56 2019 -0700 |
935 | |
936 | - Fix NULL pointer dereference and remove three lines of dead code. |
937 | + Fix the command name for few linux processes. |
938 | |
939 | - QbitLogic has run [Code]Ai on the open-vm-tools source code and |
940 | - and notified VMware of a potential NULL pointer reference and four |
941 | - pieces of dead code. |
942 | + ProcMgr library publishes the 'command name' attribute for |
943 | + each process while listing down all the processes. For doing this, |
944 | + the commandline is first parsed from /proc/<PID>/cmdline file |
945 | + and the part starting from the right-most '/' is considered as the |
946 | + command name. This is OK only if we have an absolute path for the |
947 | + command binary. Other wise, this may result in incorrect results. |
948 | |
949 | - See https://github.com/vmware/open-vm-tools/pull/247 |
950 | + For example: |
951 | + sshd: root@pts/1 |
952 | + gdm-session-worker [pam/gdm-autologin] |
953 | |
954 | - bora-vmsoft/services/vmtoolsd/pluginMgr.c |
955 | - The proposed fix conditionally emitted a log message. That fix has |
956 | - been reworked to consistently emit a log message with conditional |
957 | - content. |
958 | + Fixed the code to ignore the parsing if we do not have an absolute |
959 | + path. |
960 | |
961 | - bora/lib/misc/posixPosix.c |
962 | - bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c |
963 | - Remove one line of dead code from each source file. |
964 | + Note: There are two ways how the command name is retrieved for each |
965 | + process. |
966 | |
967 | - bora-vmsoft/lib/procMgr/procMgrPosix.c: |
968 | - Suggested dead code fix actually pointed to a bug where errno |
969 | - was not getting updated as intended. |
970 | + 1. /proc/<PID>/cmdline is parsed. |
971 | |
972 | - bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c: |
973 | - Suggested dead code is no longer dead; change not applicable. |
974 | + If (1) fails for some reason, then |
975 | + |
976 | + 2. /proc/<PID>/status is parsed. |
977 | + |
978 | + There is no issue with (2). This changeset fixes the parsing issue only |
979 | + with (1) approach mentioned above. |
980 | |
981 | -commit f10780bc3d7119d90bf72c0cf2f07066955d7d98 |
982 | +commit 7aaf580b14f44a994100ede098e0ced5d60ba484 |
983 | Author: Oliver Kurth <okurth@vmware.com> |
984 | -Date: Tue Jan 29 14:03:18 2019 -0800 |
985 | +Date: Wed Jul 3 14:28:56 2019 -0700 |
986 | |
987 | - Bump VMware Tools version to 10.3.10 for the next scheduled update release |
988 | + Add support for NVMe disks; IDE and SATA disk devices in 3.x Linux kernels |
989 | |
990 | - Set the VMware Tools version as TOOLS_VERSION_JACKHAMMER_UPDATE2 = 10.3.10 |
991 | + Support has been added for virtual disks attached to an NVMe |
992 | + controller. The device "label" will provide the "nvme<n>" for the |
993 | + controller. The disk unit is provided in the device "nsid" file. |
994 | + An earlier implementation (Linux 2.6 kernels) provided the unit |
995 | + number as the final digit group in the device node name. |
996 | + |
997 | + The Linux 3.x kernel has some differences in the layout of IDE and |
998 | + SATA disk devices in the sysfs filesystem. The differences from the |
999 | + sysfs in a 2.6 Linux kernel are: |
1000 | + - The IDE "class" file and SATA "class" and "label" files are in a |
1001 | + different directory. |
1002 | + - IDE controller and SATA device nodes begin with "ata" where "host" |
1003 | + was used in earlier kernel sysfs filesystems. |
1004 | + |
1005 | + GuestInfoGetDevClass() has been modfied to check in two possible |
1006 | + locations for the "class" file. The directory located will also |
1007 | + contain the "label" file for SCSI, SAS, and SATA disk devices. |
1008 | + |
1009 | + GuestInfoGetIdeSataDev() has been modified to search for either |
1010 | + ata<n> or host<n> directories in the sysfs tree for the disk device. |
1011 | |
1012 | -commit f2ff192717375b95a6b7e278fb47dbb3d3bc56d1 |
1013 | +commit 193a5f93d6678b2ebfec1cf365a84bfd8533650d |
1014 | Author: Oliver Kurth <okurth@vmware.com> |
1015 | -Date: Wed Nov 7 15:00:09 2018 -0800 |
1016 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1017 | |
1018 | - release notes for 10.3.5 |
1019 | + Common header file change not applicable to open-vm-tools. |
1020 | |
1021 | -commit 8f98dbc87304546cbb75756bbad8ba0dbc0221a4 |
1022 | +commit 2657373a9321ad4090af75d84beac00836170e27 |
1023 | Author: Oliver Kurth <okurth@vmware.com> |
1024 | -Date: Wed Nov 7 14:13:03 2018 -0800 |
1025 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1026 | |
1027 | - add 10.3.5 changes to ChangeLog |
1028 | -commit 583fc02dbee4ba88a20c67a0f5e5a9b023b551ea |
1029 | + Truncate oversize partition names |
1030 | + |
1031 | + Truncate disk partition names if they are too large, rather than just |
1032 | + skipping all the disk information for the guest. Closes |
1033 | + https://github.com/vmware/open-vm-tools/issues/346 . |
1034 | + |
1035 | +commit 6b8ffb7199159ab3a306646bc572f6a83a8ce7f6 |
1036 | Author: Oliver Kurth <okurth@vmware.com> |
1037 | -Date: Tue Nov 6 17:14:40 2018 -0800 |
1038 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1039 | |
1040 | - bump version and build number |
1041 | + Common header file change not applicable to open-vm-tools. |
1042 | |
1043 | -commit d51ec15038c43472e9bc48de7081b0954a122f97 |
1044 | +commit fe04b4263ae90af524fe51e124e206df737e974b |
1045 | Author: Oliver Kurth <okurth@vmware.com> |
1046 | -Date: Tue Nov 6 17:13:04 2018 -0800 |
1047 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1048 | |
1049 | - sync deploypkg files |
1050 | + Suppress possible NULL pointer deref in a debug message. |
1051 | |
1052 | -commit b4b07f53c71a83beed8fdc11f2dfeeb43aa20fda |
1053 | +commit 130334ca6f1cf6d696b0fe36d54b83f1f7d7bc2e |
1054 | Author: Oliver Kurth <okurth@vmware.com> |
1055 | -Date: Fri Oct 5 13:55:27 2018 -0700 |
1056 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1057 | |
1058 | - Use bitwise AND operation while fetching current IOPL. |
1059 | - |
1060 | - Iopl_Get() was using logical AND operation which could result |
1061 | - in wrong IOPL value. We should be using bitwise AND instead. |
1062 | + Common header file change not applicable to open-vm-tools. |
1063 | |
1064 | -commit 87593b29e5c337141be65e4430fb95a4f1741afb |
1065 | +commit ace8b9e3c13a0b320835d36f569d2c7e5c6513a7 |
1066 | Author: Oliver Kurth <okurth@vmware.com> |
1067 | -Date: Fri Oct 5 13:55:27 2018 -0700 |
1068 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1069 | |
1070 | - Optional override for short and long OS names sent from Tools |
1071 | - |
1072 | - Added support for customers to override the returned long and short OS |
1073 | - names through the tools config file. If the setting is present, then names |
1074 | - gathered by hostinfo will be ignored. The user is responsible for setting |
1075 | - the appropriate names. |
1076 | - |
1077 | - The override will be ignored if the short-name setting is not present in |
1078 | - tools.conf. |
1079 | - |
1080 | - An empty string will be sent for the long OS name if only the short-name |
1081 | - setting is present. |
1082 | - |
1083 | - Appropriate warning msg will be generated in both cases. |
1084 | - |
1085 | - Example of the conf setting: |
1086 | - |
1087 | - [guestosinfo] |
1088 | - short-name = centos6-64 |
1089 | - long-name = some long name |
1090 | + Changes to common header files not applicable to open-vm-tools. |
1091 | |
1092 | -commit b08cd0da457263f80e84ca95348c2a97cb7e22a5 |
1093 | +commit eda7db540bb048ac406e6624786c300cb17968c2 |
1094 | Author: Oliver Kurth <okurth@vmware.com> |
1095 | -Date: Mon Sep 17 16:41:19 2018 -0700 |
1096 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1097 | |
1098 | - Hgfs Server Linux: fix the share permissions on a file rename or delete |
1099 | - |
1100 | - Coverity found that the argumeents to obtain the share permissions |
1101 | - on a file rename were swapped. Even though they are tested together |
1102 | - in an if statement which is not an issue, it could be in the future. |
1103 | - |
1104 | - Reverse arguments so the share read and write permissions are correct. |
1105 | + Common header file change not applicable to open-vm-tools. |
1106 | |
1107 | -commit bdde701699212ca7fb118f3a49a9bbc7fb06df68 |
1108 | +commit 7b17b7265ad31f2ed3dc6d6d28c5a4caf4c12e5c |
1109 | Author: Oliver Kurth <okurth@vmware.com> |
1110 | -Date: Mon Sep 17 16:41:18 2018 -0700 |
1111 | +Date: Wed Jul 3 14:26:55 2019 -0700 |
1112 | |
1113 | - Hgfs FUSE Client: fix missing pthread_mutex_unlock call |
1114 | - |
1115 | - Fix missing pthread_mutex_unlock call in HgfsSetAttrCache when |
1116 | - updating the cached attributes on a file and a memory allocation |
1117 | - fails. |
1118 | + Common header file change not applicable to open-vm-tools. |
1119 | |
1120 | -commit 01376aca4d4bee5efed9b4b2597d141722a7feb5 |
1121 | +commit 59d4eda2fc89e43ac092d82866c42c9692ebca68 |
1122 | Author: Oliver Kurth <okurth@vmware.com> |
1123 | -Date: Mon Sep 17 16:41:18 2018 -0700 |
1124 | +Date: Wed Jul 3 14:26:54 2019 -0700 |
1125 | |
1126 | - Bump up the SYSIMAGE_VERSION for VMware Tools 10.3.5 |
1127 | + Common header file change not applicable to open-vm-tools. |
1128 | |
1129 | -commit 7fc13e2b58dc91627d4ff78fd532b77898adf2d2 |
1130 | +commit 8fe237da4894488e9cb0fccdec1f0d8180998a24 |
1131 | Author: Oliver Kurth <okurth@vmware.com> |
1132 | -Date: Mon Sep 17 16:41:18 2018 -0700 |
1133 | +Date: Wed Jul 3 14:26:54 2019 -0700 |
1134 | |
1135 | - Update the copyright year for OVT bundled files modified since 10.3.2 |
1136 | + Common header file change not directly applicable to open-vm-tools. |
1137 | |
1138 | -commit c7a186e204cdff46b5e02bcb5208ef8979eaf261 |
1139 | +commit e266c0bb1879792f24b29d38af9f9f833475f228 |
1140 | Author: Oliver Kurth <okurth@vmware.com> |
1141 | -Date: Mon Sep 17 16:41:18 2018 -0700 |
1142 | +Date: Wed Jul 3 14:26:54 2019 -0700 |
1143 | |
1144 | - Handle Linux kernel /proc FS uint32 type stat overflow when calculating |
1145 | - tools rate stats. |
1146 | + Changes to common source files not directly applicable to open-vm-tools. |
1147 | |
1148 | - On both 32-bit and 64-bit Linux, tools always parses Linux kernel /proc |
1149 | - FS stats as uint64 values. For rate stats, current - previous can handle |
1150 | - uint64 type stat overflow, but not uint32 type. |
1151 | + Reduce malloc/free overheads in the VMX for HGFS over VMCI |
1152 | |
1153 | -commit 064d0a3458991f0c34a397664b6b5cd8cc00e5b3 |
1154 | +commit 9c30be3448c743e51718480543142bf833ea553a |
1155 | Author: Oliver Kurth <okurth@vmware.com> |
1156 | -Date: Mon Sep 17 16:41:18 2018 -0700 |
1157 | +Date: Mon Jun 17 11:41:38 2019 -0700 |
1158 | |
1159 | - nicinfo: skip loopback devices |
1160 | + copyPasteCompatX11.c code generating unnecessary Coverity warning |
1161 | |
1162 | - When libdnet isn't used, loopback devices were reported. This change |
1163 | - skips these interfaces. Also skip interfaces that are down. |
1164 | + This patch aims to fix an issue found by Coverity Scan. |
1165 | |
1166 | - The interface was visible with vim-cmd, but not in the VC or |
1167 | - ESX UI. It did not contain any IP addresses. |
1168 | + This issue is a False Positive, the outBuf is only freed in specific |
1169 | + scenario, so there is no 'BAD FREE'. But it's better to reconstruct the |
1170 | + related code to clear the SCA error. |
1171 | |
1172 | -commit 8979f11f78ef7fdbb51afa298896e06b4d874e5b |
1173 | +commit a72b4c2513b8faf4e5b08b085583a43b1b6149a1 |
1174 | Author: Oliver Kurth <okurth@vmware.com> |
1175 | -Date: Mon Sep 17 16:41:18 2018 -0700 |
1176 | +Date: Mon Jun 17 11:41:38 2019 -0700 |
1177 | |
1178 | - Allow only a single instance of vmusr when multiple users are logged into a VM |
1179 | - |
1180 | - When a vmusr process gets the "channel conflict" error while attempting |
1181 | - to open the toolbox-dnd channel, a channel reset is triggered. That |
1182 | - reset results in the channel being restarted and a subsequent conflict |
1183 | - and reset occurs - every second until the channel becomes available. |
1184 | - |
1185 | - For *nix guests: |
1186 | - The fix is making use of the repetitive channel resets where the only |
1187 | - RpcIn message received is a "reset" to catch this channel "permanently" |
1188 | - unavailable state. If other RpcIn messages are received, a channel |
1189 | - is considered to be working and the cumulative error count is cleared.. |
1190 | - |
1191 | - lib/rpcin/rpcin.c: |
1192 | - - struct RpcIn: Added error status boolean and callback function to |
1193 | - notify the dependent layer that a channel error has been |
1194 | - resolved. |
1195 | - - RpcInLoop(): If a non "reset" message is received, clear any channel |
1196 | - error status. This will also notify the dependent layer |
1197 | - that the channel is functioning. |
1198 | - - RpcIn_start(): Added additional argument for new callback; NULL if |
1199 | - not needed. |
1200 | - |
1201 | - lib/rpcChannel/rpcChannel.c: |
1202 | - - struct rpcChannelInt: |
1203 | - - Renamed "rpcErrorCount" to "rpcResetErrorCount" since it is actually |
1204 | - a count of the consecutive channel reset failures and not a count |
1205 | - of RpcChannel errors. |
1206 | - - Added counter "rpcFailureCount" for the cumulative channel errors. |
1207 | - - Added "rpcFailureCb" for optional callback to notify the app of a |
1208 | - "permanent" channel failure. |
1209 | - - New function RpcChannelClearError() for RpcIn to notify when the |
1210 | - channel is working; to clear the rpcFailureCount . |
1211 | - - RpcChannel_Setup() - added two arguments for (1) an optional function |
1212 | - to be called when there is a channel failure |
1213 | - and (2) a failure count threshold. |
1214 | - These optional values are stored in the |
1215 | - RpcChannel structure being created. |
1216 | - - RpcChannelError(): Added logic to notify the calling app if the error |
1217 | - threshold has been reached and notify the app if a |
1218 | - callback was provided. A zero threshold signifies |
1219 | - the single vmusr limit should not be enforced. |
1220 | - (fix disable switch). |
1221 | - |
1222 | - services/vmtoolsd/mainLoop.c: |
1223 | - - New function ToolsCore_GetVmusrLimit() to retrieve the channel error |
1224 | - threshold default or over-ride from tools.conf. |
1225 | + Common header file change not applicable to open-vm-tools. |
1226 | + |
1227 | +commit 680c9d4a412a099efde6382a0a4e5f300bc4fc4e |
1228 | +Author: Oliver Kurth <okurth@vmware.com> |
1229 | +Date: Mon Jun 17 11:41:38 2019 -0700 |
1230 | + |
1231 | + linuxDeployment.c: Suppress the telinit error if the first telinit commands |
1232 | + has made VM reboot. |
1233 | |
1234 | - services/vmtoolsd/toolsRpc.c: |
1235 | - - Added ToolsCoreAppChannelFail(): Callback for "permanent" channel |
1236 | - connection failure. A warning is logged based on whether another |
1237 | - "vmtoolsd -n vmusr" is running or not and the process is terminated. |
1238 | - On Mac OS, the process is terminated with exit(1) as an indication |
1239 | - to launchd that the vmusr process should not automatically be |
1240 | - restarted. |
1241 | + The code executes '/sbin/telinit 6' repeatedly to reboot VM. VM will be |
1242 | + rebooting if the telinit command executed successfully(exitcode==0). |
1243 | + Observed the repeated telinit command might get error(exitcode==1) on some |
1244 | + GOSes, ex: Ubuntu18.04, RHEL7.4/7.5 and Fedora 29. |
1245 | + Observed no such error on older GOSes, ex: Ubuntu14.04, RHEL6.6 |
1246 | |
1247 | - The current implementation uses the error callback only for the vmusr |
1248 | - server on Linux (*nix). |
1249 | - The default channel error limit is 5 (approx. 5 second), but is user |
1250 | - configurable in tools.conf. |
1251 | + The error telinit log is confusing, actually it does NOT mean customization |
1252 | + failed. |
1253 | |
1254 | - [vmusr] |
1255 | - maxChannelAttempts = n # where allowed n = 0, 3-15 |
1256 | + This change does NOT log telinit error, and returns deployPkg status to |
1257 | + make sure the log is consistent with customization result when the first |
1258 | + 'telinit 6' succeeded but one of the following 'telinit 6' command failed. |
1259 | |
1260 | - When "maxChannelAttempts = 0" is used, the restriction to a single |
1261 | - running vmusr process is not enforced. The existing behavior is |
1262 | - restored with all the accompanying VMX log spew. This is essentially |
1263 | - a user configurable feature disablement switch. |
1264 | + The following actions are unchanged with or without this change: |
1265 | + 1. log telinit error, stop loop and exit 127 if the first 'telinit 6' fails. |
1266 | + 2. repeatedly execute 'telinit 6' if previous one executed successfully |
1267 | + (exitcode==0). |
1268 | |
1269 | -commit 0c34a86b232a9904941f825ce8b16320cadaace1 |
1270 | +commit 37d8b16e2cc1a21919cb6974c2a87071a345e232 |
1271 | Author: Oliver Kurth <okurth@vmware.com> |
1272 | -Date: Mon Sep 17 16:41:17 2018 -0700 |
1273 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1274 | |
1275 | - Changes to common header files not directly applicable to open-vm-tools |
1276 | - |
1277 | - VGAuth Windows: fix file properties product version and file version |
1278 | - |
1279 | - Product name of the VGAuth binaries are set to VMware Workstation and |
1280 | - the Product version set to experimental (e.x.p). |
1281 | - |
1282 | - Experimental version has the e.x.p build number in the Product Version |
1283 | - field of each of the shipped binaries. Now that we are WHQL signing a DLL too |
1284 | - for security it does make sense for the feature to use an official version. |
1285 | + Common header file change not applicable to open-vm-tools. |
1286 | + |
1287 | +commit 8c87c985179a7a152c9a36aa83edd2b02fc7894d |
1288 | +Author: Oliver Kurth <okurth@vmware.com> |
1289 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1290 | + |
1291 | + Common header file change not applicable to open-vm-tools. |
1292 | + |
1293 | +commit 9e1d3be7c075e8ca4c7ff07b8dadeab8a14953b3 |
1294 | +Author: Oliver Kurth <okurth@vmware.com> |
1295 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1296 | + |
1297 | + HgfsServer: Fix coverity issue - uninitialized variable "requestId" |
1298 | |
1299 | - This changes the Product name and version fields from |
1300 | - Product name -> VMware Workstation |
1301 | - Product version -> e.x.p build-4013326 |
1302 | + Fix coverity uninitialized variable "requestId" by zeroing it |
1303 | + in HgfsServerGetRequest before passing to the request packet |
1304 | + HgfsUnpackPacketParams extraction function which will use it |
1305 | + in a log message. |
1306 | |
1307 | - to |
1308 | - Product name -> VMware Guest Authentication |
1309 | - Product version -> 1.0.0 build-4013326 |
1310 | + Also moved an assert useful for testing protocol changes which was |
1311 | + incorrect in its placement. |
1312 | |
1313 | -commit 5f5a7f4a0984ee35ce79d736426a5335c91da332 |
1314 | +commit d2213fb32a1357305e72cbd6856f5e5ea9e151da |
1315 | Author: Oliver Kurth <okurth@vmware.com> |
1316 | -Date: Fri Sep 7 15:53:28 2018 -0700 |
1317 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1318 | |
1319 | - Remove vmxnet and vmxnet3 drivers from FreeBSD builds and open-vm-tools |
1320 | - |
1321 | - The vmxnet (version 1) network driver is not supported by any currently |
1322 | - supported VMware virtualization platform. Removing the FreeBSD |
1323 | - specific vmxnet source and deleting the vmxnet.ko driver build from |
1324 | - the tools and the open-vm-tools builds. |
1325 | + Changes to common header files not applicable to open-vm-tools. |
1326 | |
1327 | - FreeBSD has their own vmxnet3 network driver based on community source |
1328 | - and has never made use of the vmxnet3 source code or drivers from |
1329 | - VMware. Removing the unneeded FreeBSD vmxnet3 source and builds |
1330 | + Remove checks for GCC 4.1 in xsave, xrstor, etc. instructions |
1331 | |
1332 | -commit 1a413064fee53ac3e334e96c546886e60724d07a |
1333 | +commit 83dbe8ed5bf6f9e770e22c670c5617bc93e48e55 |
1334 | Author: Oliver Kurth <okurth@vmware.com> |
1335 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1336 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1337 | |
1338 | - Update SSL configuration with more secure settings. |
1339 | + Determine Linux OS disk devices associated with mounted filesystems. |
1340 | |
1341 | - Due to SSL issues in the past, The preference is to have default |
1342 | - settings to be more secure than compatible. This change mainly |
1343 | - inherits the default settings from ssl.c. |
1344 | + For each filesystem for which disk guestInfo is currently collected, |
1345 | + determine the virtual hardware device being used. This is currently |
1346 | + represented as <cntrl class><cntrl #>:<device #>, eg. scsi0:0, |
1347 | + scsi1:0, ide0:0 or sata1:4 and matches the virtual device label seen |
1348 | + in VMX. |
1349 | + |
1350 | + A Linux logical volume based filesystem can reside on multiple disks. |
1351 | + In order to handle LVMs, the disk devices for each filesystem are |
1352 | + maintained as a variable array of disk device names. |
1353 | + For Linux guests, disk device names are passed as a json array. |
1354 | |
1355 | -commit 450aca9f244b5e56bcef130df1a06137fd1f07e0 |
1356 | +commit 9bfd01b26e7d22aa847d6282e9b814b05a41e80e |
1357 | Author: Oliver Kurth <okurth@vmware.com> |
1358 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1359 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1360 | |
1361 | - Add virbr* interfaces on RHEL to the default exclude-nics. |
1362 | + Common header file change not applicable to open-vm-tools. |
1363 | |
1364 | -commit 5a6e8bc0ef8af2eedbbc4dc1973cb7fe18afa939 |
1365 | +commit f456a5938662175b914ffcb53c6284835476268f |
1366 | Author: Oliver Kurth <okurth@vmware.com> |
1367 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1368 | +Date: Mon Jun 17 11:41:37 2019 -0700 |
1369 | |
1370 | - Fix a gcc-8 compiler warning in lib/misc/vthreadBase.c |
1371 | + Fix 'Using uninitialized value' issue reported by Coverity. |
1372 | |
1373 | - gcc-8 generates a stringop-truncation warning when it's possible |
1374 | - for strncpy to exclude the trailing nul. The code was fine, we never |
1375 | - touch the last byte in the buffer and it's a static, but explicitly |
1376 | - set a nul at the end of the buffer so gcc sees it. |
1377 | + * In a error code path, 'exitCode' variable is used without |
1378 | + any initialization. This issue was reported by the Coverity. |
1379 | + Fixed it by initializing the 'exitCode' to -1. |
1380 | |
1381 | - This is needed for open-vm-tools to build on Suse Tumbleweed. |
1382 | + * While fixing this, moved the variables to the if block where |
1383 | + they are acutally used. |
1384 | |
1385 | -commit 5200ba3a770463e5c6a9e9d7e7a6a949857332ec |
1386 | +commit 2b3de798522314545b00297f1ece86b223dbeb6f |
1387 | Author: Oliver Kurth <okurth@vmware.com> |
1388 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1389 | +Date: Mon Jun 17 11:41:36 2019 -0700 |
1390 | |
1391 | - Return proper vix error code when guest op VIX_COMMAND_DELETE_GUEST_DIRECTORY_EX fails. |
1392 | + Common header file change not applicable to open-vm-tools. |
1393 | |
1394 | -commit 8ffda7dbae4b916b28e3f903554bc37db1d5f974 |
1395 | +commit 7cf4c83d4a0b580209184bb4d5ac6c26cd5734f4 |
1396 | Author: Oliver Kurth <okurth@vmware.com> |
1397 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1398 | +Date: Mon Jun 17 11:41:36 2019 -0700 |
1399 | |
1400 | - Make Tools logfiles readable only by owner and root |
1401 | + Fix leak in error path reported by Coverity. |
1402 | |
1403 | -commit b0e2fab2787fbc511d240c4ce0f52a74b55152fe |
1404 | +commit 1b32002d84c1dbb6dbe34586c04b84d26224c5ee |
1405 | Author: Oliver Kurth <okurth@vmware.com> |
1406 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1407 | +Date: Mon Jun 17 11:41:36 2019 -0700 |
1408 | |
1409 | - Reduce quiesced snapshot warning messages when running on older hosts. |
1410 | - |
1411 | - vSphere 6.7 added a new interface on the host side that allows tools |
1412 | - to send a "generic" backup manifest during a quiesced snapshot on |
1413 | - Linux guests. VMTools 10.2.0 or later will try to send the manifest |
1414 | - file and if the host is unable to field it, then VMTools logs this |
1415 | - information and continues with the quiesced snapshot in the older |
1416 | - fashion. This change reduces the logging that is done in this case. |
1417 | + Common source file change not directly applicable to open-vm-tools. |
1418 | |
1419 | -commit a4b4c338f1202d161e8cad2eb7cf78d44f2fd302 |
1420 | +commit 5260daab25ee9afdd5267531516b45f5006d57d1 |
1421 | Author: Oliver Kurth <okurth@vmware.com> |
1422 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1423 | +Date: Mon Jun 17 11:41:36 2019 -0700 |
1424 | |
1425 | - Common source file change not directly applicable to open-vm-tools |
1426 | + Improvements for ProcMgr library. |
1427 | |
1428 | - Verify existence of the returned path, retry the guest OP |
1429 | - CreateTemporaryFileInGuest/CreateTemporaryDirectoryInGuest using system |
1430 | - temp folder if the path disappears. |
1431 | + * This changeset fixes various issues related to ProcMgr library. |
1432 | + |
1433 | + == Retrieve the absolute path of the image for each process == |
1434 | + * When listing down the processes, it is useful to retrieve the |
1435 | + absolute path of the process binary. |
1436 | + |
1437 | + === For Linux ===: |
1438 | + * In /proc filesystem, /proc/{PID}/exe is a symlink to the binary |
1439 | + and we can make use of it to figure out the absolute path. |
1440 | + |
1441 | + * If /proc/{PID}/exe is not a valid symlink, then the 'cmdline' |
1442 | + is parsed and aboslute path is calculated accordingly. |
1443 | + |
1444 | + * Note: This changeset tries its best to figure out the absolute path. |
1445 | + If it can't, then the attribute is set to NULL. |
1446 | + |
1447 | + == Misc issues fixed. == |
1448 | + === Linux === |
1449 | + * Fixed a memory leak with 'procCmdName' while looping through the |
1450 | + /proc/ directory entries. |
1451 | + |
1452 | + * Fixed another memory leak with cmdLineTemp and cmdStatTemp variables |
1453 | + while listing down the processes in linux guests. |
1454 | + |
1455 | + * In few cases, /proc/{PID}/cmdline file contains multiple NUL |
1456 | + characters at the end. In that case, the existing code converts them |
1457 | + into 'whitespaces'. Fixed the code to chop of all the trailing |
1458 | + whitespaces in the command line. |
1459 | |
1460 | -commit b6c450d123141a752bd4805263b7d476f5b1f26b |
1461 | +commit ffdf5a69fa3654dc3a16bf9951171290f48561b8 |
1462 | Author: Oliver Kurth <okurth@vmware.com> |
1463 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1464 | +Date: Mon Jun 17 11:41:35 2019 -0700 |
1465 | |
1466 | - Fix coverity complaint; not a real bug |
1467 | + Skip loading/unloading user profile for VMXI_HGFS_SEND_PACKET_COMMAND. |
1468 | + |
1469 | + This command is used repeatedly to transfer file to/from the guest. |
1470 | |
1471 | -commit 23bd37544bb9ae4069002d73cb1c1b40e221d36a |
1472 | +commit e858e40d2beb08880e62ccac3f9dcf3661f3e093 |
1473 | Author: Oliver Kurth <okurth@vmware.com> |
1474 | -Date: Fri Sep 7 15:53:27 2018 -0700 |
1475 | +Date: Mon Jun 17 11:41:35 2019 -0700 |
1476 | |
1477 | - Common source file change not directly applicable to open-vm-tools. |
1478 | + Common header file change not applicable to open-vm-tools. |
1479 | |
1480 | -commit c2dd430ea5c8c9309700d25548513469dae68c9b |
1481 | +commit 653248aaff38309a1660f84a347b7eff70e64701 |
1482 | Author: Oliver Kurth <okurth@vmware.com> |
1483 | -Date: Fri Sep 7 15:53:26 2018 -0700 |
1484 | +Date: Mon Jun 17 11:41:35 2019 -0700 |
1485 | |
1486 | - Disable hgfsServer plugin when not running in a VMware VM. |
1487 | - |
1488 | - VmCheck_GetVersion() accesses Backdoor in an unsafe manner |
1489 | - which is not expected to work on non-VMware environments |
1490 | - including physical machines. So, we need to make sure that |
1491 | - VmCheck_GetVersion() is called only when we are running in |
1492 | - a VMware VM. |
1493 | + Common header file change not applicable to open-vm-tools. |
1494 | |
1495 | -commit 31a60ab3529a8dad8d602a524d194013d90abeec |
1496 | +commit 2ca144aceda2bae479f3b67eb0d60e4ef7e439dc |
1497 | Author: Oliver Kurth <okurth@vmware.com> |
1498 | -Date: Fri Sep 7 15:53:26 2018 -0700 |
1499 | +Date: Mon Jun 17 11:41:35 2019 -0700 |
1500 | |
1501 | - Expose more guest stats for vROPS to report the exact physical memory |
1502 | - stats as the guest OS UI does. |
1503 | - |
1504 | - Windows: |
1505 | - guest.mem.modifiedPages (Win32_PerfRawData_PerfOS_Memory#ModifiedPageListBytes) |
1506 | - guest.mem.standby.core (Win32_PerfRawData_PerfOS_Memory#StandbyCacheCoreBytes) |
1507 | - guest.mem.standby.normal (Win32_PerfRawData_PerfOS_Memory#StandbyCacheNormalPriorityBytes) |
1508 | - guest.mem.standby.reserve (Win32_PerfRawData_PerfOS_Memory#StandbyCacheReserveBytes) |
1509 | - |
1510 | - Linux: |
1511 | - guest.mem.total (/proc/meminfo#MemTotal) |
1512 | - guest.mem.buffers (/proc/meminfo#Buffers) |
1513 | - guest.mem.cached (/proc/meminfo#Cached) |
1514 | - guest.mem.slabReclaim (/proc/meminfo#SReclaimable) |
1515 | - guest.mem.available (/proc/meminfo#MemAvailable since Linux 3.14, emulated by VMTools for kernels 2.6.27+) |
1516 | + Common header file change not applicable to open-vm-tools. |
1517 | |
1518 | -commit 0b01aefe3ee960c6035863bcf4fd7e2ff654b99b |
1519 | +commit 3583ad84072c618064dfea742faa763b5f8207f0 |
1520 | Author: Oliver Kurth <okurth@vmware.com> |
1521 | -Date: Fri Sep 7 15:53:26 2018 -0700 |
1522 | +Date: Mon Jun 17 11:41:35 2019 -0700 |
1523 | |
1524 | - Update the tools version to 10.3.5 |
1525 | - |
1526 | - Set the tools version in vm_tools_version.h to be |
1527 | - TOOLS_VERSION_JACKHAMMER_UPDATE1 = 10.3.5. |
1528 | + Common header file change not applicable to open-vm-tools. |
1529 | + |
1530 | +commit 4e06bc447106be090fefdb6ea057482152390d73 |
1531 | +Author: Oliver Kurth <okurth@vmware.com> |
1532 | +Date: Mon Jun 17 11:41:33 2019 -0700 |
1533 | + |
1534 | + Common header file change not applicable to open-vm-tools. |
1535 | |
1536 | -commit 2147df6aabe639fc5ff423ed791a8e7f02bf8d0a |
1537 | +commit be8b98cda2d3149966b73d91cc76e77bf19d8228 |
1538 | Author: Oliver Kurth <okurth@vmware.com> |
1539 | -Date: Fri Jul 13 11:54:23 2018 -0700 |
1540 | +Date: Mon Jun 3 13:39:45 2019 -0700 |
1541 | + |
1542 | + Common source file change not applicable to open-vm-tools. |
1543 | |
1544 | - prepare for 10.3.0 release |
1545 | -commit a30d7aaa4d10fbce4b7d262487fffaf1dc32d949 |
1546 | +commit 61c51b4e4ac091f066e5e0efa22cc39d00b05d6d |
1547 | Author: Oliver Kurth <okurth@vmware.com> |
1548 | -Date: Fri Jul 6 14:31:55 2018 -0700 |
1549 | +Date: Mon Jun 3 13:39:45 2019 -0700 |
1550 | |
1551 | - Common source file change, not directly applicable to open-vm-tools. |
1552 | + Fix memory leak in SNEBuildHash function. |
1553 | |
1554 | - Enforce monotonic behavior for the value returned by times() on Mac. |
1555 | + In a specific code path, if a key already exists in the hashtable, |
1556 | + the memory allocated for 'value' variable is not being freed. This |
1557 | + leads to a memory leak. Fixed. |
1558 | |
1559 | -commit 12e5559e4dcf3968dd45131077b68364578f3bef |
1560 | +commit 0d5e8c618131e3899f3c30c91722e1df4e1162e9 |
1561 | Author: Oliver Kurth <okurth@vmware.com> |
1562 | -Date: Fri Jul 6 14:31:55 2018 -0700 |
1563 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1564 | |
1565 | - Update the Tools-10.3.0 OSL. |
1566 | + Common header file change not applicable to open-vm-tools. |
1567 | + |
1568 | +commit f37292f0a8524783888d55f57fa30bb828e2408b |
1569 | +Author: Oliver Kurth <okurth@vmware.com> |
1570 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1571 | + |
1572 | + Crash during File_WalkDirectoryNext |
1573 | |
1574 | - Update the Tools-10.3.0 open source license files. |
1575 | + In the rewrite of File_WalkDirectoryNext, a bug was introduced in the |
1576 | + invalid Unicode path. Invalid Unicode occurs very rarely... and the |
1577 | + bug finally turned up. Fix this... the bug is rather obvious. |
1578 | |
1579 | -commit c80bb3fc7960bc78a6d39c89b6952218a401b0cf |
1580 | +commit 1749604dc3481d0cc670e97945b915821c1039d3 |
1581 | Author: Oliver Kurth <okurth@vmware.com> |
1582 | -Date: Fri Jul 6 14:31:55 2018 -0700 |
1583 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1584 | |
1585 | - [tools-plugin] Potential solution for reported desktopEvent crash |
1586 | + Fix asianux identification. |
1587 | |
1588 | - On several distros like RHEL, CentOS and Fedora, plugin desktopEvents.so |
1589 | - crashes have been reported. However, neither development or QE can |
1590 | - reproduce this issue in local environments. |
1591 | + Add asianux to distroArray and change how asianux releases 7 and 8 |
1592 | + are identified. |
1593 | |
1594 | - The XFetchName document states that it may generate BadWindow error. That |
1595 | - means that the value for a Window argument does not name a defined Window. |
1596 | - X FAQ also suggests handling badwindow error after finding it. Since |
1597 | - the window does not exist when XFetchName is run on it, the name is not |
1598 | - needed. Suppress this error to avoid a crash. |
1599 | + This came in as a pull request on github for open-vm-tools: |
1600 | + https://github.com/vmware/open-vm-tools/pull/325 . Apparently |
1601 | + the OS identification in /etc/asianux-release changed with Asianux |
1602 | + 7, and as a result tools does not identify it correctly. |
1603 | + |
1604 | +commit 19969734d2a64e52cccf8f04669b55ad13f9c61c |
1605 | +Author: Oliver Kurth <okurth@vmware.com> |
1606 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1607 | + |
1608 | + Fallback to /proc/mounts. |
1609 | |
1610 | - After grabbing the X server, use XSetErrorHandler to temporarily define |
1611 | - a local error handler to intercept and cleanly handle any BadWindow |
1612 | - errors. XSetErrorHandler returns the current error handler, so it is |
1613 | - straightforward to reinstate GDK's original handler. |
1614 | + Use /proc/mounts on systems where /etc/mtab may not be there. |
1615 | + This change is targeted for guestInfo reporting at the moment. |
1616 | |
1617 | -commit 6172812c021469704c51817693c6c8f6bf226509 |
1618 | +commit f78a6801a8ec0f549fc3aa3817215f91cf6607af |
1619 | Author: Oliver Kurth <okurth@vmware.com> |
1620 | -Date: Fri Jul 6 14:31:55 2018 -0700 |
1621 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1622 | |
1623 | - Remove the new guest metrics feature switch, permanently enabling the |
1624 | - collection of new guest metrics for vROps.. |
1625 | + Common source file change not applicable to open-vm-tools. |
1626 | |
1627 | -commit 6e6285ec690a13ff8ba894ee463a5aa0fd034269 |
1628 | +commit e3f8ffec4a1de47cb62e4d8b2ba175a03da13246 |
1629 | Author: Oliver Kurth <okurth@vmware.com> |
1630 | -Date: Tue Jun 19 11:07:46 2018 -0700 |
1631 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1632 | |
1633 | - Previous change to configure.ac and vmtools.m4 caused a regression |
1634 | - |
1635 | - Backing out of 10.3.0. |
1636 | + Common source file change not directly applicable to open-vm-tools. |
1637 | |
1638 | -commit 699cda01fab8b1ad8a1e912d650aa92f7ffdf0e6 |
1639 | +commit 70596395cf892d07321ddd9ee8f947c06973e565 |
1640 | Author: Oliver Kurth <okurth@vmware.com> |
1641 | -Date: Tue Jun 19 11:07:46 2018 -0700 |
1642 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1643 | |
1644 | - [OVT] Update copyright year to 2018 for few files. |
1645 | - |
1646 | - Updated the copyright year to 2018 for few files changed in the last |
1647 | - few days. |
1648 | + Common header file change not applicable to open-vm-tools. |
1649 | |
1650 | -commit cecbaf6b16f5fd1ecbfe4419310352353b047ba2 |
1651 | +commit a652f6e7c2c14310e2f6f030660b73e48aeeba80 |
1652 | Author: Oliver Kurth <okurth@vmware.com> |
1653 | -Date: Tue Jun 19 11:07:46 2018 -0700 |
1654 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1655 | |
1656 | - open-vm-tools: use AC_CHECK_TOOL for pkg-config |
1657 | + Common source file change not directly applicable to open-vm-tools. |
1658 | + |
1659 | +commit c209a5619fa74f6b76171420c57fd65303331a0f |
1660 | +Author: Oliver Kurth <okurth@vmware.com> |
1661 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1662 | + |
1663 | + Update to common source code; does not affect open-vm-tools. |
1664 | |
1665 | - AC_CHECK_TOOL honors the --host setting to configure, and searches |
1666 | - for tools with the cross compile prefix thus allowing for cross |
1667 | - compile specific tools. |
1668 | + Allow an asyncWebSocket to connect through an existing socket descriptor |
1669 | |
1670 | - Fixes issue #26 in github. |
1671 | + Because Windows does not allow unprivileged processes to specify |
1672 | + DSCP (formerly ToS) values on TCP traffic, in order to support |
1673 | + DSCP for Blast WebSockets we must obtain a preconfigured socket |
1674 | + descriptor from a privileged process and then build the WebSocket |
1675 | + connection over that socket. |
1676 | + |
1677 | + This changeset extends the asyncWebSocket API by adding a Connect |
1678 | + function that can accept and use an existing socket descriptor in |
1679 | + addition to the usual collection of WebSocket Connect parameters. |
1680 | + |
1681 | + Because the asyncWebSocket is built over an asyncTCPSocket, this |
1682 | + change ripples down into the asyncTCPSocket API which also gets a |
1683 | + new Connect variant with a socket descriptor parameter. |
1684 | + |
1685 | + To avoid duplicating existing logic, the old Connect variants |
1686 | + are modified to do their work by invoking the new API with |
1687 | + a distinguished socket descriptor value of -1. This value |
1688 | + indicates that no existing socket descriptor is provided and |
1689 | + that a new socket should be created and used for the connection. |
1690 | + |
1691 | + In this changeset, passing in an existing socket is supported |
1692 | + only on the Windows platform. The feature is not required on |
1693 | + other platforms, where unprivileged processes are permitted to |
1694 | + define DSCP values for their connections. Attempting to create |
1695 | + a connection over an existing socket on other platforms will |
1696 | + result in a Connect failure. |
1697 | |
1698 | -commit f2c8d02161569c96ac452f9d1063756d133562ba |
1699 | +commit 20e8a3d4213019202241d766ba3c7c660c4b74c2 |
1700 | Author: Oliver Kurth <okurth@vmware.com> |
1701 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1702 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1703 | |
1704 | - open-vm-tools: build dndcp with thread libs |
1705 | + Round out Log functions to all levels |
1706 | |
1707 | - Recent changes in the dndcp plugin made it necessary to make sure that |
1708 | - it links against pthread libs. |
1709 | + Logs would be measurably more useful for debugging if the available |
1710 | + levels were used correctly and consistently. As a step towards |
1711 | + encouraging such use, define Log_Warning() and Log_Info() as synonyms |
1712 | + for Warning() and Log() (which, for historical reasons, are not |
1713 | + declared in log.h). Also remove all the conflicting private definitions. |
1714 | |
1715 | -commit 99df5712ba7b8910c3db138c64aab6957f31c914 |
1716 | +commit e45c4e3da624187d83f25681cf25b67ae059b6ed |
1717 | Author: Oliver Kurth <okurth@vmware.com> |
1718 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1719 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1720 | |
1721 | - Clipboard content on the host gets loaded to tmp on Linux guest with a right click on Guest |
1722 | - |
1723 | - Root Cause: |
1724 | - Dndcp plugin creates a sub thread to monitor if there is other application |
1725 | - access the specific file. The root cause for this bug is the main thread |
1726 | - doesn't update its field before wakeup the sub thread, this cause the sub |
1727 | - thread get a wrong value. |
1728 | - |
1729 | - Solution: |
1730 | - Main thread should update the field before wakeup the sub thread. |
1731 | + Common header file change not applicable to open-vm-tools. |
1732 | |
1733 | -commit 99af79200f91c246580197b5698995fba4dc47af |
1734 | +commit 94ffa684475ea998347b4c6e25626d099eb8315c |
1735 | Author: Oliver Kurth <okurth@vmware.com> |
1736 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1737 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1738 | |
1739 | - open-vm-tools: build for FreeBSD fails in fakeMouseWayland |
1740 | - |
1741 | - Root Cause: |
1742 | - In the file fakeMouseWayland.cpp, several Linux related header files |
1743 | - are included: |
1744 | - <linux/input.h> |
1745 | - <linux/ioctl.h> |
1746 | - <linux/uinput.h> |
1747 | - |
1748 | - These header files do not exist for FreeBSD and Solaris. |
1749 | + Linux DeployPkg configurable timeout. |
1750 | |
1751 | - Solution: |
1752 | - Lib fakeMouse is not needed by FreeBSD and Solaris, so update the makefile |
1753 | - to build the fakemouse related code only on Linux. |
1754 | + Update to descriptive comments for function DeployPkg_SetProcessTimeout(). |
1755 | |
1756 | -commit 104cab14e08b93a2525992e09f0d13ff26d52d9d |
1757 | +commit 4bd043870ec94332aa8b3794449a2144847cad33 |
1758 | Author: Oliver Kurth <okurth@vmware.com> |
1759 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1760 | +Date: Mon Jun 3 13:39:44 2019 -0700 |
1761 | |
1762 | - Use "/var/run" or "/run" instead of "/tmp" in Linux guest for imc package copy |
1763 | - |
1764 | - 1. check if /var/run is a directory in VM |
1765 | - 2. if Yes, use /var/run/XXXXXX |
1766 | - 3. check if /run is a directory in VM |
1767 | - 4. if Yes, use /run/XXXXXX |
1768 | - 5. if both No, use /tmp/XXXXXX as before |
1769 | + Common header file change not applicable to open-vm-tools. |
1770 | |
1771 | -commit 8f93d803066032a738b9d9a6990e32ed17b589e1 |
1772 | +commit 46cb6aa361cc8b1d287e3b9b77bf86819b4b1fc5 |
1773 | Author: Oliver Kurth <okurth@vmware.com> |
1774 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1775 | +Date: Wed May 22 13:09:37 2019 -0700 |
1776 | |
1777 | - Build open-vm-tools with xmlsec1 by default. |
1778 | - |
1779 | - Build open-vm-tools with xmlsec1 by default, rather than with |
1780 | - xml-security-c as is done currently. This requires modifications |
1781 | - to configure.ac to change the default for use_xmlsec1, plus |
1782 | - modifications to bora-vmsoft/install/Source/tools-pkg.make to |
1783 | - initialize flags for xmlsec1 and xml2 now needed by the OVT build |
1784 | - that is done during tools builds. |
1785 | - |
1786 | - Another change that surfaced during this was that the symbol that |
1787 | - configure checks for the xmlsec library was wrong. It should be |
1788 | - xmlSecCheckVersionExt rather than xmlSecCheckVersion. The latter |
1789 | - is a header-defined macro but not a library symbol. |
1790 | + Fix [RH Covscan] Coverity reported memory leaks in toolboxcmd-stat.c. |
1791 | |
1792 | -commit 7313fdc5b2b14ac83340b2e59752b934494c2ae9 |
1793 | +commit d0f0af3e62d065492b29791556c39c27eb97c751 |
1794 | Author: Oliver Kurth <okurth@vmware.com> |
1795 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1796 | +Date: Wed May 22 13:09:37 2019 -0700 |
1797 | |
1798 | - [Wayland Copy & Paste] Part2: Uses VMBlock notification mechanism for Copy & Paste |
1799 | - |
1800 | - This patch is part of the new feature for Workstation 15: \[P0\] Wayland |
1801 | - support in Linux guest - Copy & Paste. |
1802 | - |
1803 | - In the first patch, the notification mechanism is added to the VMBlock module. |
1804 | - In this patch, the notification mechanism is used, |
1805 | + Common header file change not applicable to open-vm-tools. |
1806 | |
1807 | -commit c04b9987786901f544c4df04f7701b48ac8f6475 |
1808 | +commit 873db0841a17a530cabe6b6e6e473647da685c17 |
1809 | Author: Oliver Kurth <okurth@vmware.com> |
1810 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1811 | +Date: Wed May 22 13:09:37 2019 -0700 |
1812 | |
1813 | - [Wayland Copy & Paste] Part1: Add notification mechanism to the VMBlock module |
1814 | - |
1815 | - This patch is part of the new feature for Workstation 15: [P0] Wayland support |
1816 | - in Linux guest - Copy & Paste. |
1817 | - |
1818 | - In the implementation of current VMTools, there is a restriction, in the first |
1819 | - second after grab into the guest, the CopyPasteUIX11::LocalGetFileRequestCB, |
1820 | - which is a callback from a file paste request from another guest application |
1821 | - and begins copying the files from host to guest and return the file list, |
1822 | - will return none directly. |
1823 | - |
1824 | - The Wayland file explorer will request the content in the clipboard after the |
1825 | - user clicks on the file explorer, and the request will get nothing since the |
1826 | - restriction in the VMTools, so the following ‘Paste’ operation will fail. |
1827 | - |
1828 | - Solution: |
1829 | - This solution is only used for the Linux guest with Wayland. The behavior |
1830 | - for Linux guest with X11 will not change. |
1831 | - |
1832 | - The restriction, the CopyPasteUIX11::LocalGetFileRequestCB returns directly |
1833 | - in the first second after grab into the guest, will be removed. |
1834 | - |
1835 | - And, the notification mechanism will be added into the VM block file system. |
1836 | - This mechanism is similar with the inotify module. |
1837 | - |
1838 | - Take the VMBlock Fuse File System as an example, currently, the mount point contains below contents: |
1839 | - |
1840 | - * /blockdir/ |
1841 | - |
1842 | - * /dev |
1843 | - |
1844 | - /blockdir/ contains the symlinks to the contents of the target directory. |
1845 | - |
1846 | - /dev is the control file for VMBlock Fuse File System. |
1847 | - |
1848 | - In this new solution, a new folder /notifydir/ will be added, each file in this folder is a special file, read from this file will be blocked until any other process read from the corresponding file in target directory or the block on the target directory is removed. |
1849 | - |
1850 | - This patch only focus on the notification mechanism. |
1851 | + Common source file change not applicable to open-vm-tools. |
1852 | |
1853 | -commit 6c0b2130e7ee103ece06eb674c5f5dfea66c26f1 |
1854 | +commit 403dc83d2040d386b2c6c04756b289f277657e41 |
1855 | Author: Oliver Kurth <okurth@vmware.com> |
1856 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1857 | +Date: Wed May 22 13:09:37 2019 -0700 |
1858 | |
1859 | - FreeBSD: clang compiler related changes to configure.ac |
1860 | - |
1861 | - On FreeBSD, the unwind.h header is available in the libunwind |
1862 | - package (/usr/ports/devel/libunwind) which may or may not be installed |
1863 | - on a system. The libunwind functions to determine the call-chain in a |
1864 | - program are defined only if " __GNU_SOURCE" is defined to enable "all" |
1865 | - GCC extensions. Avoid the unwind.h header if seen on FreeBSD. |
1866 | - |
1867 | - The "clang" compiler will issue warnings if the address of a member |
1868 | - of a packed structure is taken. Since warnings are errors with -Wall, |
1869 | - add --Wno-address-of-packed-member to CFLAGS when compiling with |
1870 | - "clang". |
1871 | + Common header file change not applicable to open-vm-tools. |
1872 | |
1873 | -commit bba52bfa5b29c8860f18200022db5b8b250d326b |
1874 | +commit af0a4979c7bcaba6a913e686609f99c1245db384 |
1875 | Author: Oliver Kurth <okurth@vmware.com> |
1876 | -Date: Tue Jun 19 11:07:45 2018 -0700 |
1877 | +Date: Wed May 22 13:09:37 2019 -0700 |
1878 | |
1879 | - open-vm-tools: build with tirpc |
1880 | - |
1881 | - Newer distros (Fedora, OpenSuSE Tumblweed) no longer ship rpcgen with glibc, |
1882 | - so we need to build with libtirpc (see |
1883 | - https://bugzilla.redhat.com/show_bug.cgi?id=1531540 and |
1884 | - https://bugzilla.suse.com/show_bug.cgi?id=1089181). |
1885 | - With this change, configure will check for the presence of libtirpc and |
1886 | - if found, sets flags to build with it. configure will also exit with an |
1887 | - error if rpcgen is not found. |
1888 | + Change to common header file not applicable to open-vm-tools. |
1889 | |
1890 | -commit 5c0b9496db96af9ea5e4b3b1321f0612a3f62d99 |
1891 | +commit 7c1e69708bc3bbdbf9dc66b039ab40f9767b29c1 |
1892 | Author: Oliver Kurth <okurth@vmware.com> |
1893 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
1894 | +Date: Wed May 22 13:09:37 2019 -0700 |
1895 | |
1896 | - Changes to build CAF with VS 2015; not applicable to open-vm-tools. |
1897 | + Change to common header file not directly applicable to open-vm-tools. |
1898 | |
1899 | -commit 3961588fcce58090c249f4a65ad8cc109efecc5c |
1900 | +commit da3efa69411c5fe8897e6295927dc4b8eacaff04 |
1901 | Author: Oliver Kurth <okurth@vmware.com> |
1902 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
1903 | +Date: Wed May 22 13:09:36 2019 -0700 |
1904 | |
1905 | - Log full version of Tools in vmware.log. |
1906 | - |
1907 | - Currently, only the Tools build number is logged in vmware.log. |
1908 | - It will be very handy to have the full version logged in |
1909 | - there and avoid the need to manually lookup the build. |
1910 | + Changes to common source files not directly applicable to open-vm-tools. |
1911 | |
1912 | -commit bf494fd02a77a4f34ff420c03c0c5a19e43218d3 |
1913 | +commit 8017efa7e941561274088d27e32883f6c1965abf |
1914 | Author: Oliver Kurth <okurth@vmware.com> |
1915 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
1916 | +Date: Wed May 22 13:09:36 2019 -0700 |
1917 | |
1918 | - Tools 10.3.0 L10n drop2 |
1919 | + Pick up filesystem (fsType) name for Linux disks. |
1920 | |
1921 | - This is to integrate the final L10n drop for VMware Tools 10.3. |
1922 | + Building upon the OS Volume Disk Mapping changes added for Windows |
1923 | + guests, pick up and propogate the filesystem type for Linux disks. |
1924 | + Move fsType related code and declaration out of the _WIN32 specific |
1925 | + source code. |
1926 | + |
1927 | + Diskwiper code (for Linux) modified to pass along filesystem type |
1928 | + obtained from the MNTINFO structure from the non-Windows guest. |
1929 | + Also passing along the mount point for device-based mapping to be done |
1930 | + in the guestInfo plugin. |
1931 | |
1932 | -commit 065f09b94e09f1127901db29e73cc9b9f36df4fc |
1933 | +commit 82d42ead6fc14eed2bc1670352f5fb8f62413230 |
1934 | Author: Oliver Kurth <okurth@vmware.com> |
1935 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
1936 | +Date: Wed May 22 13:09:35 2019 -0700 |
1937 | |
1938 | - Add two switches for max IPv4/6 routes to gather |
1939 | + Change to common header file not applicable to open-vm-tools. |
1940 | + |
1941 | +commit 744fe0bec43f7e242f1353c767c613180512000d |
1942 | +Author: Oliver Kurth <okurth@vmware.com> |
1943 | +Date: Wed May 8 15:27:20 2019 -0700 |
1944 | + |
1945 | + Common header file change not applicable to open-vm-tools. |
1946 | + |
1947 | +commit 5b0e339cde98dce03ec5046c04ded329f61dc5ef |
1948 | +Author: Oliver Kurth <okurth@vmware.com> |
1949 | +Date: Wed May 8 15:27:20 2019 -0700 |
1950 | + |
1951 | + Fix the 'procCmdName' attribute of process information. |
1952 | |
1953 | - Gathering nic info in a Linux guest OS which is configured with large |
1954 | - number(60000+) of ipv6 routes could result in vmtoolsd process taking a |
1955 | - long time and rock solid 100% CPU of a core. Though tools only exports |
1956 | - at most NICINFO_MAX_ROUTES(100) routes, it tries to read all the contents |
1957 | - of /proc/net/ipv6_route which costs too much time because: |
1958 | - 1. IPv6 route table is not efficient natively compared to ipv4 due to |
1959 | - its implementation. |
1960 | - 2. The g_io library can aggravate the performance. |
1961 | + * When listing down the processes, /proc/{PID}/cmdline file is read |
1962 | + and parsed to figure out the command name. While doing this parsing, |
1963 | + the terminating NUL character is not parsed. Due to this, if any |
1964 | + process doesn't have any command line arguments, the 'command name' is |
1965 | + retrieved as NULL. |
1966 | |
1967 | - On the other hand, when gathering routes, IPv4 comes first, and IPv6 second. |
1968 | - And the routes reported to VMX has an overall limitation of serializing |
1969 | - (NICINFO_MAX_ROUTES). If there's more than NICINFO_MAX_ROUTES IPv4 routes |
1970 | - in system, no IPv6 will get reported. |
1971 | + Note: This issue doesn't happen if the cmdLine has any arguments. |
1972 | |
1973 | - Added two switches "max-ipv4-routes" and "max-ipv6-routes" |
1974 | - (NICINFO_MAX_ROUTES by default) in tools.conf and let SlashProcNet_GetRoute*() |
1975 | - only read the first max ipv4/6 routes lines of /proc/net/[ipv6_]route to avoid |
1976 | - performance problem. Users can disable ipv4/ipv6 routes gathering |
1977 | - separately if they want ipv6 or ipv4 only. |
1978 | + Ex: |
1979 | + /usr/bin/vmtoolsd -> 'cmdName' is retrieved as NULL |
1980 | + /usr/bin/vmtoolsd -n vmusr -> 'cmdName' is retrieved properly as 'vmtoolsd' |
1981 | + |
1982 | + * Fixed the code to include the trailing NUL character also while parsing. |
1983 | |
1984 | -commit bf86c612a8ffe1d20b98c20b76f0c34840a7a2a3 |
1985 | +commit 7b096ae277428efd8f550c1bbb35e98bb0cdf565 |
1986 | Author: Oliver Kurth <okurth@vmware.com> |
1987 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
1988 | +Date: Wed May 8 15:27:20 2019 -0700 |
1989 | |
1990 | - Not checking symbols when building open-vm-tools |
1991 | + Hgfs fuse Client: fix max name length setting for statvfs |
1992 | |
1993 | - Using a hard-coded mangled name is not a good idea because C++ does not |
1994 | - have any standard for name mangling. Remove these mangled names introduced |
1995 | - in an earlier fix. |
1996 | + Detected internally with Fedora 29 and reported in |
1997 | + https://github.com/vmware/open-vm-tools/issues/337, |
1998 | + the statvfs structure must provide a valid max name length field. Setting |
1999 | + to NAME_MAX. This allows the GUI Files application to create new folders |
2000 | + and rename existing ones correctly. |
2001 | |
2002 | -commit d36ed6e5b4784a36cb93f50e05d6a49b5d76b86e |
2003 | +commit 9876844113a4f6b538f131d61b61c994264f7caf |
2004 | Author: Oliver Kurth <okurth@vmware.com> |
2005 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
2006 | +Date: Wed May 8 15:27:19 2019 -0700 |
2007 | |
2008 | - [OVT] Update copyright year to 2018 for files modified since 10.2.5 GA |
2009 | + Plumb through filesystemType |
2010 | + |
2011 | + Implement the filesystemType property in the vim.vm.guestInfo.DiskInfo. |
2012 | |
2013 | -commit 8086ead225faf3a051952773c0b98b2c751b1e84 |
2014 | +commit 79c7f28781fc38eb2e2ec691c907822dd1259bc4 |
2015 | Author: Oliver Kurth <okurth@vmware.com> |
2016 | -Date: Tue Jun 19 11:07:44 2018 -0700 |
2017 | +Date: Wed May 8 15:27:19 2019 -0700 |
2018 | |
2019 | - Hgfs Win Client: fix bad illegal character escaping; not applicable to open-vm-tools. |
2020 | + Common header file change not applicable to open-vm-tools. |
2021 | |
2022 | -commit 7efc7b70a57cf734012a069fabab19e96f8cf16d |
2023 | +commit 000856aea0bd78c581888c3e3771cf79c6fdb7e9 |
2024 | Author: Oliver Kurth <okurth@vmware.com> |
2025 | -Date: Tue Jun 19 11:07:43 2018 -0700 |
2026 | +Date: Wed May 8 15:27:19 2019 -0700 |
2027 | |
2028 | - Add the JACKHAMMER code name to the 10.3.0 release version defines. |
2029 | + Fix copy/paste on Ubuntu 19.04 guest |
2030 | |
2031 | - Adding the code name JACKHAMMER to the 10.3.x series version notation |
2032 | - for the public source release and use by future 10.3.x patches or |
2033 | - updates. |
2034 | + Ubuntu 19.04 chooses Nautilus 3.32 as the default file browser. From |
2035 | + 3.30, Nautilus checks mime type when pasting files from the clipboard, |
2036 | + and the target type is also changed to UTF8_STRING instead of |
2037 | + x-special/gnome-copied-files. To support Ubuntu 19.04, apply this |
2038 | + change into our guest code. |
2039 | |
2040 | -commit d71381445f6c3b986e263435006428a44be0451a |
2041 | +commit 7bbb1521360bd140a56d1fbf6a9663d297277901 |
2042 | Author: Oliver Kurth <okurth@vmware.com> |
2043 | -Date: Tue Jun 19 11:07:43 2018 -0700 |
2044 | +Date: Wed May 8 15:27:19 2019 -0700 |
2045 | |
2046 | - Hgfs Server Plugin: only handle the shared folders client in hosted products |
2047 | + Add a comment in vmci_sockets.h about why a file handle is "leaked" |
2048 | |
2049 | - Only initialize the Shared Folders client redirector in hosted product |
2050 | - environments. |
2051 | + Let's add a comment in vmci_sockets.h explaining why we intentionally "leak" |
2052 | + a file handle in VMCISock_GetAFValueFd. |
2053 | |
2054 | - Details: Check if the tools system service started in a non-hosted product |
2055 | - and if so do not start the shared folders client redirector. |
2056 | - Check if the tools user service started in a non-hosted product product and if |
2057 | - so then skip reconnecting any Shared Folders mapped drives. |
2058 | + fd is intentionally left open when outFd is NULL. Closing it |
2059 | + will break applications running on Linux without a fixed AF for |
2060 | + vSockets. In such cases, the fd will be closed during cleanup when |
2061 | + the application exits. |
2062 | |
2063 | -commit ad7c68780a773d6d456687aff0d27f9cff808370 |
2064 | +commit a5823224051da0318facf10e0732baa9f55334fc |
2065 | Author: Oliver Kurth <okurth@vmware.com> |
2066 | -Date: Thu May 10 16:47:16 2018 -0700 |
2067 | +Date: Wed May 8 15:27:19 2019 -0700 |
2068 | |
2069 | - update version number |
2070 | + Fix a trivial Coverity-reported memory leak. |
2071 | + |
2072 | + If AuthLoadPAM doesn't find all the needed symbols from the pam |
2073 | + library, then dlclose the library, as is already done for |
2074 | + the same-named funtion in bora/lib/auth/authPosix.c. |
2075 | |
2076 | -commit cac0f086ffcc00da73dd7dd80fef6956962f4dd6 |
2077 | +commit 47766e511be85410f5afc0bf8b0f05776fb66ece |
2078 | Author: Oliver Kurth <okurth@vmware.com> |
2079 | -Date: Thu May 10 16:38:11 2018 -0700 |
2080 | +Date: Wed May 8 15:27:19 2019 -0700 |
2081 | |
2082 | - Remove debug display of CPUID vendor string seen in VmCheck_IsVirtualWorld |
2083 | + Record Tools version 10.3.11 as Hot Patch for PR 2328829 |
2084 | + |
2085 | +commit 801df14f0e2b32aea17771bbd33d65140ff2361c |
2086 | +Author: Oliver Kurth <okurth@vmware.com> |
2087 | +Date: Wed May 8 15:27:19 2019 -0700 |
2088 | + |
2089 | + Fix Coverity-reported double memory free errors. |
2090 | |
2091 | - The "Debug" message containing vendor string returned by the CPUID |
2092 | - instruction will appear on STDERR for stand-alone programs such |
2093 | - as vmware-checkvm. This unexpected output is at best noise and may |
2094 | - adversely affect existing scripts. |
2095 | + Similar double memory free errors were reported in each of two |
2096 | + functions, VixToolsListAuthAliases and VixToolsListMappedAliases. |
2097 | + The fixes for each function are similar: be consistent in using |
2098 | + tmpBuf2 (renamed tmpBuf) as the pointer to the overall buffer being |
2099 | + computed and tmpBuf (renamed nextBuf) as the "next" version of the |
2100 | + buffer. Specifically, in the computation of recordBuf following exit |
2101 | + from the for loop, use the variable formerly known as tmpBuf2 rather |
2102 | + than the one formerly known as tmpBuf. |
2103 | + |
2104 | + The variables were renamed in an attempt to distinguish more clearly |
2105 | + between them and how they are used. Also, with these changes in |
2106 | + place, it's evident that there's no need to free nextBuf in the abort |
2107 | + case and as a result its scope can be limited. |
2108 | |
2109 | -commit 7ddbe3c9df400dfdf7d67d259ae3942d157dedb4 |
2110 | +commit 2031724154177a3f5ce28d3c608709c7ad6153dc |
2111 | Author: Oliver Kurth <okurth@vmware.com> |
2112 | -Date: Mon Apr 30 15:42:54 2018 -0700 |
2113 | +Date: Wed May 8 15:27:19 2019 -0700 |
2114 | |
2115 | - sync deploypkg files |
2116 | + Common header file change not applicable to open-vm-tools. |
2117 | |
2118 | -commit 80a23d71a281493071668fd45b77d7f8248fad68 |
2119 | +commit 8634350c330318eaf8f333c49f405e20b71ca813 |
2120 | Author: Oliver Kurth <okurth@vmware.com> |
2121 | -Date: Mon Apr 30 14:04:14 2018 -0700 |
2122 | +Date: Wed May 8 15:27:19 2019 -0700 |
2123 | |
2124 | - Changes to common header files: |
2125 | - - Add Amazon Linux 2 to the known guest OS list. |
2126 | - - Other change not application to open-vm-tools. |
2127 | + Common header file change not directly applicable to open-vm-tools. |
2128 | |
2129 | -commit 48dc7a57ff3fe5cb1441040876f74b69772c1ea5 |
2130 | +commit 2bbd56da4314856dfc1a8fed2db5b55cd9ef8860 |
2131 | Author: Oliver Kurth <okurth@vmware.com> |
2132 | -Date: Mon Apr 30 14:04:13 2018 -0700 |
2133 | +Date: Wed May 8 15:27:18 2019 -0700 |
2134 | |
2135 | - [DeployPkg] Replace Log() references with g_log() |
2136 | + Fixes for few leaks and improved error handling. |
2137 | |
2138 | - * Modified the code to replace a couple of Log() references with g_debug() |
2139 | - so that they are properly logged with 'deplogPkg' domain instead of the |
2140 | - generic 'vmsvc' domain in the tools log files. |
2141 | + Fix a memory leak detected by coverity scan. It is not critical, |
2142 | + but it is real in an error case when there is no end mark. While |
2143 | + fixing it, also enhanced code to handle different error cases |
2144 | + properly because we would want valid content to be decoded even |
2145 | + when there are invalid marks in the log file. Invalid log marks |
2146 | + are possible when vmware.log gets rotated in the middle of guest |
2147 | + logging. |
2148 | + |
2149 | + While verifying the fix using valgrind, found a couple of more |
2150 | + leaks in panic and warning stubs. Addressed those as well. |
2151 | |
2152 | -commit 9cb12223b4da529df043d95ab025f22c6ee00c39 |
2153 | +commit 544cf1363c78d1d8c75e57d560b3650b5f667c64 |
2154 | Author: Oliver Kurth <okurth@vmware.com> |
2155 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2156 | +Date: Wed May 8 15:27:18 2019 -0700 |
2157 | |
2158 | - [oss] Upgrade GTK+ and its dependent libraries for VMtools |
2159 | + Fix a trivial Coverity-reported memory leak in vgauth/cli/main.c. |
2160 | |
2161 | - GTK+ and its dependent libraries are upgraded to: |
2162 | - gtk+ 2.24.32 |
2163 | - atk 2.28.1 |
2164 | - gdk-pixbuf 2.36.11 |
2165 | - pango 1.40.13 |
2166 | - cairo 1.14.12 |
2167 | - fontconfig 2.13.0 |
2168 | - freetype 2.9 |
2169 | + Call Pref_Shutdown to close the PrefHandle. |
2170 | |
2171 | -commit a5c03957c95ec78c92246b87cdf60a90b2eca7f7 |
2172 | +commit 4a2c4645a363c705e66cdb81847f579d8ff30e04 |
2173 | Author: Oliver Kurth <okurth@vmware.com> |
2174 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2175 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2176 | |
2177 | - Common header file change not applicable to open-vm-tools. |
2178 | + Add garbage collection for vix process handles. |
2179 | + |
2180 | + This closely follows the model used for hgfs session cleanup. |
2181 | |
2182 | -commit f87d177acab33f00229234ed51722504e2f7afc7 |
2183 | +commit ea2ee4789fd0db5451752ea98af55a3c6b47f1d2 |
2184 | Author: Oliver Kurth <okurth@vmware.com> |
2185 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2186 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2187 | |
2188 | - Changes to common header files not directly applicable to open-vm-tools. |
2189 | + Common header file change not applicable to open-vm-tools. |
2190 | |
2191 | -commit ba65905dfc7e6c07d1aeea37db885284e54b02fa |
2192 | +commit 4ee0255f2f7a32a76095de8c02a869e78f7ec765 |
2193 | Author: Oliver Kurth <okurth@vmware.com> |
2194 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2195 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2196 | |
2197 | - Set perms on Tools script logs. |
2198 | - |
2199 | - Make the network script logs secure; set log file perms to 0600. |
2200 | + Common header file change not applicable to open-vm-tools. |
2201 | |
2202 | -commit aa59d16e0b5968efc298065ef50ece282d406265 |
2203 | +commit 9e6e3afa5b5c3dc11c7aa79454ca4c8184c87bdf |
2204 | Author: Oliver Kurth <okurth@vmware.com> |
2205 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2206 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2207 | |
2208 | - [Wayland DnD] Part2: Open the uinput device file with root permission. |
2209 | + Fix a memory leak in the unicode library. |
2210 | |
2211 | - The device file /dev/uinput (or /dev/input/uinput) can only be accessed |
2212 | - by root account, so the dndcp plugin may failed to open this device file |
2213 | - if the current user is not root account. |
2214 | - |
2215 | - A way to fix this issue is opening this device file with root account, |
2216 | - then pass the file descriptor to the sub task which is started with the |
2217 | - current account. An example for this solution is blockVM file system |
2218 | - device file. |
2219 | + Ensure that allocated strings are freed before returning a failure. |
2220 | |
2221 | - This patch is part of the new feature 'Wayland support in Linux guest'. |
2222 | + The ASSERTs have never been known to fire; a warning in a obj |
2223 | + build will help with debugging. The warning should "never" happen. |
2224 | |
2225 | -commit b3899c91d348d23c2e6c22944b8ac1a06e4e3988 |
2226 | +commit d1de801b4b490aeecd982f19274e46485f156f79 |
2227 | Author: Oliver Kurth <okurth@vmware.com> |
2228 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2229 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2230 | |
2231 | - [Wayland DnD] Part1: Add 'fakeMouse' module which is used to simulate the |
2232 | - mouse motion under Wayland |
2233 | - |
2234 | - For Linux guest with X11, the VMTools uses the X system APIs to simulate |
2235 | - the mouse motion, but these X11 System APIs do not work in Wayland. Need |
2236 | - to pick up another method to simulate the mouse motion. |
2237 | + Common header file change not applicable to open-vm-tools. |
2238 | + |
2239 | +commit b2a6fdafed0bef27a77d549e4ffbed9a09b9f0bd |
2240 | +Author: Oliver Kurth <okurth@vmware.com> |
2241 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2242 | + |
2243 | + Common header file change not applicable to open-vm-tools. |
2244 | + |
2245 | +commit a63fe3472895c9394ee8c3f2d0d2a496c3ccab6f |
2246 | +Author: Oliver Kurth <okurth@vmware.com> |
2247 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2248 | + |
2249 | + Common header file change not applicable to open-vm-tools. |
2250 | + |
2251 | +commit 9bec96154c23462f2c6f80dd660f41bba38d4614 |
2252 | +Author: Oliver Kurth <okurth@vmware.com> |
2253 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2254 | + |
2255 | + Provide a shutdown function for users of the unicode library to free memory |
2256 | + allocated by Unicode_Init(). |
2257 | |
2258 | - Another way to simulate the mouse motion is using uinput module. |
2259 | + Most applications using the unicode library do not free related memory |
2260 | + since they are about to terminate. A Unicode_Shutdown() function is |
2261 | + provided which will explicitly free the memory allocated by Unicode_Init(). |
2262 | + |
2263 | +commit 5614d61a2b8353cd48095210afbcc89f66228ae7 |
2264 | +Author: Oliver Kurth <okurth@vmware.com> |
2265 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2266 | + |
2267 | + Changes to common header files not applicable to open-vm-tools. |
2268 | + |
2269 | +commit 4ae954db584b7e3287a97f44d0eeb96d09ba2c68 |
2270 | +Author: Oliver Kurth <okurth@vmware.com> |
2271 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2272 | + |
2273 | + Common header file change not directly applicable to open-vm-tools. |
2274 | + |
2275 | +commit 35570e72d3833b73db653c89c84223c959856467 |
2276 | +Author: Oliver Kurth <okurth@vmware.com> |
2277 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2278 | + |
2279 | + Changes to common source files not directly applicable to open-vm-tools. |
2280 | |
2281 | - uinput is a kernel module that makes it possible to emulate input devices |
2282 | - from userspace. By writing to /dev/uinput (or /dev/input/uinput) device, |
2283 | - a process can create a virtual input device with specific capabilities. |
2284 | - Once this virtual device is created, the process can send events through |
2285 | - it, that will be delivered to userspace and in-kernel consumers. |
2286 | + Added the function Random_FastStream64() to provide a 64-bit random number |
2287 | + if needed. |
2288 | + |
2289 | +commit e89c751f0045f163c468c49b71db70478581c85c |
2290 | +Author: Oliver Kurth <okurth@vmware.com> |
2291 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2292 | + |
2293 | + vm_basic_defs.h: include stddef.h |
2294 | |
2295 | - Here is the link which contains more information about the uinput module: |
2296 | + The stddef.h header has existed since C89. It includes interesting |
2297 | + things like an offsetof definition, and a definition of NULL. |
2298 | |
2299 | - https://www.kernel.org/doc/html/v4.12/input/uinput.html |
2300 | + Let's stop re-inventing this long-standardized header. Except |
2301 | + in vmkernel, where bogus __FreeBSD__ values break gcc's <stddef.h>. |
2302 | + (Detail: vmkernel networking likes to define __FreeBSD__ to empty |
2303 | + or 1, whereas ABI requires "FreeBSD major version". |
2304 | |
2305 | - This patch adds a new module named 'fakeMouse' which is used to simulate the mouse motion under Wayland. |
2306 | + This change is deliberately minimal as touching headers included |
2307 | + everywhere is inherently fragile. Further cleanups (like removing |
2308 | + vmw_offsetof) can be done in follow-up changes. |
2309 | |
2310 | - This patch is part of the new feature 'Wayland support in Linux guest'. |
2311 | + The stddef.h header is a 'freestanding' header, which means it's |
2312 | + part of the language and not a "system" header. It is thus safe |
2313 | + to include (modulo vmkernel-networking problem above). |
2314 | |
2315 | -commit 995befcb0d6156fb47773c96db6d478173d1bc89 |
2316 | +commit 642d7a61db13969f9fb654ad1cc0d879bf680612 |
2317 | Author: Oliver Kurth <okurth@vmware.com> |
2318 | -Date: Mon Apr 23 17:08:18 2018 -0700 |
2319 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2320 | |
2321 | - Add new guest metrics to be consumed by vROps. |
2322 | + Fix Coverity reported issues in i18n.c code - VMTools & VGAuth |
2323 | |
2324 | - Windows: |
2325 | - * ProcessorQueueLength |
2326 | - * CurrentDiskQueueLength |
2327 | - * AvgDiskQueueLength |
2328 | + bora-vmsoft/apps/vmtoolsbib/i18n.c: MsgLoadCatalog() |
2329 | + - Coverity reported memory leak when an error is encountered parsing a |
2330 | + line from a message catalog. |
2331 | + - Second memory leak on error missed. |
2332 | |
2333 | - Linux: |
2334 | - * CPU run queue size |
2335 | - * Current disk queue size |
2336 | - * Average disk queue size |
2337 | + bora-vmsoft/vgauth/common/i18n.c: MsgLoadCatalog() |
2338 | + - Coverity reported some dead code. |
2339 | + - Missed reporting memory leak when error is encountered parsing a |
2340 | + line from a message catalog. |
2341 | |
2342 | -commit 9d6cfe650cd15095e65024fbb5d9cd6944e1cf14 |
2343 | +commit 0f7b4b275aaf20bebf8d4739cf283fade05c3dcb |
2344 | Author: Oliver Kurth <okurth@vmware.com> |
2345 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2346 | +Date: Tue Apr 30 13:24:25 2019 -0700 |
2347 | |
2348 | - Historical: Recording version numbers assigned for 10.2.x patches. |
2349 | + Common header file change not applicable to open-vm-tools. |
2350 | + |
2351 | +commit 9e0ccaa3bf2805674fd882362427aa2d3376a3a8 |
2352 | +Author: Oliver Kurth <okurth@vmware.com> |
2353 | +Date: Tue Apr 30 13:24:24 2019 -0700 |
2354 | + |
2355 | + Common header file change not applicable to open-vm-tools. |
2356 | + |
2357 | +commit 3cf1df758ba64cb6aebe81bf3a430ad536221c19 |
2358 | +Author: Oliver Kurth <okurth@vmware.com> |
2359 | +Date: Tue Apr 30 13:24:24 2019 -0700 |
2360 | + |
2361 | + Toolsd uses log.text RPC only when the useLogTextRpc is set to TRUE. |
2362 | |
2363 | - Define TOOLS_VERSION_CHAINSAW_PATCH1 as 10.2.1. |
2364 | - Define TOOLS_VERSION_CHAINSAW_PATCH2 as 10.2.6. |
2365 | + This allows the tools installer to start use the log.text RPC without |
2366 | + worrying about that toolsd has not completed the work of scrubbing its logs |
2367 | + for security and privacy issues. |
2368 | |
2369 | -commit ba6c319f18d294b36c0e989f851fbfdbc8a629b7 |
2370 | +commit 1b755d3e619ed40d8750532f10af5a1df6de6cda |
2371 | Author: Oliver Kurth <okurth@vmware.com> |
2372 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2373 | +Date: Tue Apr 30 13:24:24 2019 -0700 |
2374 | |
2375 | - Bump up the version requirement for glib and friends to 2.34.0 |
2376 | + Fix memory leak in SNEBuildHash function. |
2377 | |
2378 | - For open-vm-tools, we are bumping up the minimum version requirement |
2379 | - to 2.34.0 for glib and its friends. Modified the configure.ac |
2380 | - with the proper new version checks. Also, updated the |
2381 | - error message with the proper version. |
2382 | + In a specific code path of the SNEBuildHash function, when the |
2383 | + environment variable is of the format VMWARE_*=[0|1], the value |
2384 | + is not freed. Fixed the memory leak. |
2385 | |
2386 | -commit 26d03ad8075913cb869b814462b7285c02367252 |
2387 | +commit 0957e9c46476f8eab435576e7094b125e102f6ce |
2388 | Author: Oliver Kurth <okurth@vmware.com> |
2389 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2390 | +Date: Tue Apr 30 13:24:24 2019 -0700 |
2391 | |
2392 | Common header file change not applicable to open-vm-tools. |
2393 | |
2394 | -commit ce1ed002f5e05f09678e15b4021bac8155edb1eb |
2395 | +commit bbefe8051a56b3cf834bf71c8f55fdfd88802b9d |
2396 | Author: Oliver Kurth <okurth@vmware.com> |
2397 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2398 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2399 | |
2400 | - Common source file changes that are not directly related to open-vm-tools. |
2401 | - |
2402 | - Build vmtools and vgauth for Windows with xmlsec instead of |
2403 | - xml-security-c. It will still be possible to build with xml-security-c |
2404 | - either by commenting out the definition of USE_XMLSEC_FOR_WINDOWS in |
2405 | - bora-vmsoft/vgauth/make/inc/defs.mk or adding a make command line |
2406 | - argument of USE_XMLSEC_FOR_WINDOWS=0. |
2407 | + Common header file change not applicable to open-vm-tools. |
2408 | |
2409 | -commit d5c0bcea04aae65484ba3c2756b64acf6f6388d0 |
2410 | +commit a0b825b2251bf9d30fb29d5deb1d269ec361428c |
2411 | Author: Oliver Kurth <okurth@vmware.com> |
2412 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2413 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2414 | |
2415 | - Update bora-vmsoft/install/Source/README |
2416 | - |
2417 | - The content is stale. Since the file is used internally and is |
2418 | - not published, rather than maintain it in two places, point to |
2419 | - the current README file and Release Notes on github. |
2420 | + Common header file change not applicable to open-vm-tools. |
2421 | |
2422 | -commit 512d5475520ec5e0525633cd47530faaae774b5e |
2423 | +commit abd87bf17c9869900dad292a458b871de90c4c7d |
2424 | Author: Oliver Kurth <okurth@vmware.com> |
2425 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2426 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2427 | |
2428 | Common header file change not applicable to open-vm-tools. |
2429 | |
2430 | -commit 982998c9a6a3ec8664f9c4c08ff9ef30f52a9ae2 |
2431 | +commit 85bc2e71dd7a855d3c533965859c1756deecc314 |
2432 | Author: Oliver Kurth <okurth@vmware.com> |
2433 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2434 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2435 | |
2436 | - Common header file change not applicable to open-vm-tools. |
2437 | + Fix minor leak in FileRotateByRenumber - Coverity scan |
2438 | |
2439 | -commit ab36b3227275a5beded8a5115929e2d649c6aad3 |
2440 | +commit 82169f198925c9aa27bd04fd665eac67396adbe7 |
2441 | Author: Oliver Kurth <okurth@vmware.com> |
2442 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2443 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2444 | |
2445 | - Common header file changes not applicable to open-vm-tools. |
2446 | + Fix a leak if VGAuth setup fails. Coverity issue |
2447 | |
2448 | -commit 0527d5c5f14f626a5129231778ec433dfff55c2a |
2449 | +commit 555f28c7d07161a5bcd0a90fe46869bc6be4ba21 |
2450 | Author: Oliver Kurth <okurth@vmware.com> |
2451 | -Date: Mon Apr 23 17:08:17 2018 -0700 |
2452 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2453 | + |
2454 | + Common source file change not applicable to open-vm-tools. |
2455 | + |
2456 | +commit b9993b990ea7dc077c6e625137802492245fb31b |
2457 | +Author: Oliver Kurth <okurth@vmware.com> |
2458 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2459 | |
2460 | Common header file change not applicable to open-vm-tools. |
2461 | |
2462 | -commit 571dc1fbadd962d91dcb7a44652b501de3f48e0e |
2463 | +commit ca4be3d1bcb1d184eafb2c576dd7a127a95628fc |
2464 | Author: Oliver Kurth <okurth@vmware.com> |
2465 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2466 | +Date: Mon Apr 15 11:33:00 2019 -0700 |
2467 | |
2468 | Common header file change not applicable to open-vm-tools. |
2469 | |
2470 | -commit 998903d73496bf6080053f994c8410dc880db2f9 |
2471 | +commit e6d24a37cdcd88624f66ad86f161e8576e7c6ec0 |
2472 | Author: Oliver Kurth <okurth@vmware.com> |
2473 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2474 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2475 | |
2476 | Common header file change not applicable to open-vm-tools. |
2477 | |
2478 | -commit 3b814f9b4dcbf54893078a4ba187d8d0cbf23e31 |
2479 | +commit da8c476be54bcd94c6b4f15a013dd02419b4ec29 |
2480 | Author: Oliver Kurth <okurth@vmware.com> |
2481 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2482 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2483 | |
2484 | - lib/hashMap/hashMap.c: |
2485 | - Add new HashMap_Get() which uses a constant time memory comparison function. |
2486 | + Changes to common source files not directly applicable to open-vm-tools. |
2487 | |
2488 | - lib/misc/utilMem.c: |
2489 | - Constant time memory and string comparison functions. |
2490 | + Add an error code to a debug message. |
2491 | |
2492 | -commit 5daceb4448834143d884b061f391c37aeaaad683 |
2493 | +commit 8eba31ddbf50a194acdd3eb30935a1fb3895bd50 |
2494 | Author: Oliver Kurth <okurth@vmware.com> |
2495 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2496 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2497 | |
2498 | - Changes to common header files not applicable to open-vm-tools. |
2499 | + Common header file change not applicable to open-vm-tools. |
2500 | |
2501 | -commit 42d1e6b11c0b11c1b1f6f967cb5c4d7e2f3b39e0 |
2502 | +commit b4a0d4c8137cdfbee073b456c71b731fa21e6ead |
2503 | Author: Oliver Kurth <okurth@vmware.com> |
2504 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2505 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2506 | |
2507 | - Change to common header file not applicable to open-vm-tools. |
2508 | + Common header file change not applicable to open-vm-tools. |
2509 | |
2510 | -commit f4b7b227119712c90be4a3583d4430a3fcc1d093 |
2511 | +commit e53f942615313e5d209f49d9c4da4227671c38d8 |
2512 | Author: Oliver Kurth <okurth@vmware.com> |
2513 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2514 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2515 | |
2516 | - Change to common header file not applicable to open-vm-tools. |
2517 | + Common header file change not applicable to open-vm-tools. |
2518 | |
2519 | -commit 874b8b4801a5bba439401db8e624e3e3d1989ca7 |
2520 | +commit c0ec4f8294ec6428ee2a7f7284b37f79f4661bf3 |
2521 | Author: Oliver Kurth <okurth@vmware.com> |
2522 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2523 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2524 | |
2525 | - Common header file change not applicale to open-vm-tools. |
2526 | + Add a DynBuf_InitWithString() function to the dynamic buffer routines. |
2527 | |
2528 | -commit ff2616a657c32bbb5e6799f8b8cd0a470d0e5202 |
2529 | +commit 2dc55af11451712b05a0c85a9c2ba1e5619b4841 |
2530 | Author: Oliver Kurth <okurth@vmware.com> |
2531 | -Date: Mon Apr 23 17:08:16 2018 -0700 |
2532 | +Date: Mon Apr 15 11:32:59 2019 -0700 |
2533 | |
2534 | - Common header file changes not applicable to open-vm-tools. |
2535 | + Common header file change not applicable to open-vm-tools. |
2536 | |
2537 | -commit 5d9cc73f1c7979466d55f7897f98c0888d2fb15d |
2538 | +commit f35313969af9bd2815709930f054171d7ebbcbc9 |
2539 | Author: Oliver Kurth <okurth@vmware.com> |
2540 | -Date: Mon Apr 23 17:08:15 2018 -0700 |
2541 | +Date: Mon Apr 15 11:32:58 2019 -0700 |
2542 | |
2543 | - Header file change in preparation for C++11 compilation. Also updating |
2544 | - copyright dates. |
2545 | + Common header file change not applicable to open-vm-tools. |
2546 | |
2547 | -commit 29fb30f6d1956ccd4ad803b1b7f0430e4ef28ceb |
2548 | +commit c864f9e015a25864b952210796458e77c1f5726f |
2549 | Author: Oliver Kurth <okurth@vmware.com> |
2550 | -Date: Mon Apr 23 17:08:15 2018 -0700 |
2551 | +Date: Mon Apr 15 11:32:58 2019 -0700 |
2552 | |
2553 | - FreeBSD vmmemctl: Fold in open-vm-tools pull requests #125 and #140 |
2554 | - |
2555 | - This change incorporates two open-vm-tools pull requests that provide |
2556 | - code changes that allows the existing vmmemctl.ko driver to be compiled |
2557 | - on FreeBSD 10, 11 or 12. |
2558 | - |
2559 | - Pull request #125: |
2560 | - An optional argument has been added to the sysctl_add_oid() function |
2561 | - in FreeBSD 12.x. All releases have a SYSCTL_ADD_OID() macro that does |
2562 | - not require the additional argument. |
2563 | - |
2564 | - Pull request #140: |
2565 | - Functions and macros to lock and unlock memory pages and objects have |
2566 | - changed between the FBSD 10 & 11. The pull request provides a set C |
2567 | - preprocessor directives to select the appropriate code based on the |
2568 | - FreeBSD release being targeted. |
2569 | - |
2570 | - The code change as been tidied up by using the release version checks |
2571 | - to define LOCK and UNLOCK macros for memory pages and objects at the |
2572 | - beginning of the source file. The code logic is easier to follow |
2573 | - without the abundance of #if, #else and #endif statements scattered |
2574 | - about. |
2575 | - |
2576 | - Ed Schouten: https://github.com/vmware/open-vm-tools/pull/125 |
2577 | - Steve Wills: https://github.com/vmware/open-vm-tools/pull/140 |
2578 | + Common header file change not directly applicable to open-vm-tools. |
2579 | |
2580 | -commit 2a34b181de524b3f0d01cad90d3da184bde7ad99 |
2581 | +commit 6de2df2c43c412c048f666277eaa48d8bb0c0321 |
2582 | Author: Oliver Kurth <okurth@vmware.com> |
2583 | -Date: Mon Apr 23 17:08:15 2018 -0700 |
2584 | +Date: Wed Apr 10 14:14:57 2019 -0700 |
2585 | |
2586 | - Common source file changes not directly applicable to open-vm-tools. |
2587 | + Common header file change not applicable to open-vm-tools. |
2588 | |
2589 | -commit fab45e62a1468b86d2097a6a0784c4f259d6b0ef |
2590 | +commit 306f0f7b507486795c0d726288ceb7145dcf3c00 |
2591 | Author: Oliver Kurth <okurth@vmware.com> |
2592 | -Date: Mon Apr 23 17:08:15 2018 -0700 |
2593 | +Date: Wed Apr 10 14:14:57 2019 -0700 |
2594 | |
2595 | - Common header file change not applicable to open-vm-tools. |
2596 | + Common header file change no applicable to open-vm-tools. |
2597 | |
2598 | -commit 357e8418e5441c2c5fc75a19f7b6529d6bce7452 |
2599 | +commit 6219e245c5e42479f4aef36ab8ee49db3c368f83 |
2600 | Author: Oliver Kurth <okurth@vmware.com> |
2601 | -Date: Mon Apr 23 17:08:15 2018 -0700 |
2602 | +Date: Wed Apr 10 14:14:57 2019 -0700 |
2603 | |
2604 | - Common header file change not applicable to open-vm-tools. |
2605 | + Remove use of "-Wno-address-of-packed-member" option for OVT builds on FBSD |
2606 | + |
2607 | + With the HGFS source code refactor to avoid taking the address of a |
2608 | + packed structure memberuse of "-Wno-address-of-packed-member" |
2609 | + is no longer needed to build OVT on FBSD 11.x and FBSD 12.x. |
2610 | |
2611 | -commit fad97e4a7c756b3b297e0fe9e68a1a4674c4fdcc |
2612 | +commit 8b2bbbd8c2b647592a2f444a678fe93552fb0d22 |
2613 | Author: Oliver Kurth <okurth@vmware.com> |
2614 | -Date: Mon Apr 23 17:08:15 2018 -0700 |
2615 | +Date: Wed Apr 10 14:14:56 2019 -0700 |
2616 | |
2617 | - Common header file change not applicable to open-vm-tools. |
2618 | + Add a 64 bit pseudo random number generator |
2619 | + |
2620 | + This change adds a 64 bit pseudo random number generator to the public |
2621 | + library by calling the existing 32 bit Random_Fast function twice. |
2622 | + Since the period of Random_Fast is 2^64, this should be sufficient. |
2623 | |
2624 | -commit 357d9139342c19a98ed12f5961f415d099df3287 |
2625 | +commit 5f9bd0c6a39a266854fad680d2251c024c309425 |
2626 | Author: Oliver Kurth <okurth@vmware.com> |
2627 | -Date: Fri Mar 23 15:05:36 2018 -0700 |
2628 | +Date: Wed Apr 10 14:14:56 2019 -0700 |
2629 | |
2630 | - Common source file changes that are not applicable to open-vm-tools. |
2631 | + Remove some "always TRUE" comparisons reported by clang 6.0 on FBSD. |
2632 | + |
2633 | + A recent refactoring of HGFS fuse code to avoid taking the address of |
2634 | + a field in a packed structure introduced a comparision of an array |
2635 | + address != NULL which will always evaluate to "true". Removing the |
2636 | + unnecessary "if" statements. |
2637 | |
2638 | -commit 6c3261d152442fa11fc2b928490d74846f23465d |
2639 | +commit 67b66d0ff13324413deac6c522bd382ee450125e |
2640 | Author: Oliver Kurth <okurth@vmware.com> |
2641 | -Date: Fri Mar 23 15:05:36 2018 -0700 |
2642 | +Date: Wed Apr 10 14:14:56 2019 -0700 |
2643 | + |
2644 | + Common source file change not applicable to open-vm-tools. |
2645 | + |
2646 | +commit 86bf8de08dbb28e8902411b8a9bc0e64f972f74d |
2647 | +Author: Oliver Kurth <okurth@vmware.com> |
2648 | +Date: Wed Apr 10 14:14:56 2019 -0700 |
2649 | |
2650 | Common header file change not applicable to open-vm-tools. |
2651 | |
2652 | -commit 3747daca8efbfe8e709687b97c874a29f183b717 |
2653 | +commit 3bc7907533c45544fcfb24906a0e4b7de61718e7 |
2654 | Author: Oliver Kurth <okurth@vmware.com> |
2655 | -Date: Fri Mar 23 15:05:36 2018 -0700 |
2656 | +Date: Wed Apr 10 14:14:55 2019 -0700 |
2657 | |
2658 | - Backout previous change to lib/include/vm_basic_math.h. |
2659 | + Changes to common header files not applilcable to open-vm-tools. |
2660 | |
2661 | -commit f9414d19532a9664e6c260a8644ee09200e32429 |
2662 | +commit 6576ad0d7b28bd1ddab2fce8a0f34695aa57a774 |
2663 | Author: Oliver Kurth <okurth@vmware.com> |
2664 | -Date: Fri Mar 23 15:05:36 2018 -0700 |
2665 | +Date: Wed Apr 10 14:14:55 2019 -0700 |
2666 | |
2667 | - Common header file change: lib/include/vm_basic_math.h |
2668 | - |
2669 | - Define portability macros for Inf and Nan tests. |
2670 | + Common source file change not applicable to open-vm-tools. |
2671 | |
2672 | -commit de2010a1a45a9e515b932a1a83374539661a2b39 |
2673 | +commit 8c69b930a826aad87c692d516fd77d1a4cbed0fb |
2674 | Author: Oliver Kurth <okurth@vmware.com> |
2675 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2676 | +Date: Wed Apr 10 14:14:55 2019 -0700 |
2677 | |
2678 | - Add missing memory constraints for vm_atomic RMW (Read/Modify/Write) instructions |
2679 | + DnD Phase II] - Avoid potential memory overflow. |
2680 | |
2681 | - There are two inseparable concepts involved when dealing with atomics: |
2682 | - 1. Atomicity of the access itself |
2683 | - 2. Ordering of the access with respect to other reads&writes (from the view of |
2684 | - other processors). |
2685 | - |
2686 | - Our Read-Modify-Write functions are all meant to provide the highest level of |
2687 | - ordering guarantee: Sequential Consistency, which means no reordering of reads |
2688 | - or writes across the access. We properly implement that on ARM, and on |
2689 | - x86/x64 at the hardware layer. But, on x86/x64 we needed to tell the compiler |
2690 | - (it must flush out any pending reads/writes that are currently hiding in |
2691 | - registers) |
2692 | + In the case when dragging a format whose size is exactly the same as the |
2693 | + size threshold and plain text is provided, the plain text can't be added. |
2694 | + Current logic does not handle this case. Instead it will result in a |
2695 | + large unsigned number (0-1 = 0xffff_ffff) of bytes to be allocated to |
2696 | + store plain text which causes memory overflow. |
2697 | |
2698 | - Side Note: we do *not* change the pure Read and pure Write functions, only |
2699 | - the Read/Modify/Write ones. On both ARM and x86/x64, vm_atomic functions like |
2700 | - Atomic_WriteN provide no (re)ordering guarantees today (at the hardware layer |
2701 | - on ARM or at the compiler layer on x86/x64). This is because some callers |
2702 | - didn't need or want such guarantees - as such, Atomic_WriteN by itself is |
2703 | - *not* sufficient to, say, release a lock. Making these remaining atomic |
2704 | - weapons safe by default will require us to first |
2705 | - 1. add new unordered atomic equivalents of Atomic_ReadN/TestBitN and |
2706 | - Atomic_WriteN (in C11 terminology, acquire/release and relaxed) |
2707 | - 2. Scan the tree and switch appropriate callers to the new functions |
2708 | + Just return in the case that no more size left to add plain text or the |
2709 | + plain text is empty. |
2710 | + |
2711 | +commit 685aa3d0879aabde450ba0d6c79d256d6abaf3f5 |
2712 | +Author: Oliver Kurth <okurth@vmware.com> |
2713 | +Date: Wed Apr 10 14:14:55 2019 -0700 |
2714 | + |
2715 | + Common header file change not applicable to open-vm-tools. |
2716 | + |
2717 | +commit 71b41229ffe1f31711b35145ee1ab0bfbb763295 |
2718 | +Author: Oliver Kurth <okurth@vmware.com> |
2719 | +Date: Wed Apr 10 14:14:54 2019 -0700 |
2720 | + |
2721 | + Common header file change not applicable to open-vm-tools. |
2722 | + |
2723 | +commit f2eb555cf6e9f8c779daf1dc9c2f7aff383d105a |
2724 | +Author: Oliver Kurth <okurth@vmware.com> |
2725 | +Date: Wed Apr 10 14:14:54 2019 -0700 |
2726 | + |
2727 | + Common header file change not applicable to open-vm-tools. |
2728 | + |
2729 | +commit 8046af84ee4aa1d271af4c1d2379fb3d88dba3ac |
2730 | +Author: Oliver Kurth <okurth@vmware.com> |
2731 | +Date: Wed Apr 10 14:14:54 2019 -0700 |
2732 | + |
2733 | + Common header file change not applicable to open-vm-tools. |
2734 | + |
2735 | +commit cf05c47b06af90a7bb7c5d561fb425ba2ebc0b47 |
2736 | +Author: Oliver Kurth <okurth@vmware.com> |
2737 | +Date: Wed Apr 10 14:14:54 2019 -0700 |
2738 | + |
2739 | + Common source file change not directly applicable to open-vm-tools. |
2740 | + |
2741 | +commit 5a6ee8f90b90f42d24de1561ee94855c576933f3 |
2742 | +Author: Oliver Kurth <okurth@vmware.com> |
2743 | +Date: Wed Apr 10 14:14:53 2019 -0700 |
2744 | + |
2745 | + Common header file change not applicable to open-vm-tools. |
2746 | + |
2747 | +commit d759ae5ecfcc6f1069decdb2511ec32bf12a1663 |
2748 | +Author: Oliver Kurth <okurth@vmware.com> |
2749 | +Date: Wed Apr 10 14:14:53 2019 -0700 |
2750 | + |
2751 | + Asyncsocket in low latency send mode may write into freed memory |
2752 | |
2753 | - *and only then* |
2754 | - 3. Strengthen the defaults, affecting only callers who needed the stronger |
2755 | - defaults to be correct. ... but that would be a separate change in the |
2756 | - future. |
2757 | + Blast service encounters access violation exception during scale tests |
2758 | + in AsyncTCPSocketSend() at bora\lib\asyncsocket\asyncsocket.c. |
2759 | |
2760 | - Codegen differences (vmm.vmm64): |
2761 | - -------------------------------- |
2762 | - The function that uncovered this was ST_HandleCrossCall, which invoked |
2763 | - Atomic_And64. |
2764 | + Root cause is asock refcount is not incremented before the inline |
2765 | + invocation of AsyncTCPSocketSendCallback() in the low latency send |
2766 | + mode and asock is accessed right after this invocation to decrement |
2767 | + inLowLatencySendCb counter. AsyncTCPSocketSendCallback() on error |
2768 | + would invoke error handler which in turn could close the asock |
2769 | + leading to freeing of asock. |
2770 | |
2771 | - original w/o explicit compiler mem barrier in ST_HandleCrossCall: |
2772 | - ... |
2773 | - lock and QWORD PTR [rdx+0x0],rax |
2774 | - movsxd rax,DWORD PTR [rip+offset] <-- load reordered after Atomic_And64 |
2775 | - lea rax,[rax+rax*2] |
2776 | - lea rdi,[rax*8+0x0] |
2777 | + Issue wouldn't happen if AsyncWebSocket impl guarded all of its |
2778 | + transport->send(transport) calls with AsyncSocketAddRef(transport) |
2779 | + and AsyncSocketRelease(transport) but isn't the case currently. |
2780 | |
2781 | - with "memory" constraint, it's now identical to code w/an explicit |
2782 | - compiler mem barrier (which was the workaround): |
2783 | - ... |
2784 | - mov edx,DWORD PTR [rip+offset] <-- load emitted prior to Atomic_And64 |
2785 | - ... |
2786 | - lock and QWORD PTR [rsi+0x0],rax |
2787 | - movsxd rax,edx <-- ... and used after Atomic_And64 |
2788 | - lea rax,[rax+rax*2] |
2789 | - lea rdi,[rax*8+0x0] |
2790 | + Fix is to add and release asock reference around the inline |
2791 | + invocation of AsyncTCPSocketSendCallback(). |
2792 | + |
2793 | +commit 325e244951790d7a848281fdb0236b0f6ee26996 |
2794 | +Author: Oliver Kurth <okurth@vmware.com> |
2795 | +Date: Wed Apr 10 14:14:53 2019 -0700 |
2796 | + |
2797 | + Common header file change not applicable to open-vm-tools. |
2798 | + |
2799 | +commit b90344ea3696506c7d2a8022c340b6aafb6f6a91 |
2800 | +Author: Oliver Kurth <okurth@vmware.com> |
2801 | +Date: Wed Apr 10 14:14:52 2019 -0700 |
2802 | + |
2803 | + Common header file change not applicable to open-vm-tools. |
2804 | + |
2805 | +commit 13f457aa737d8bca27f09862cf2a45df8f4a425b |
2806 | +Author: Oliver Kurth <okurth@vmware.com> |
2807 | +Date: Wed Apr 10 14:14:52 2019 -0700 |
2808 | + |
2809 | + InitiateFileTransferToGuest fails when uploading file to root directory |
2810 | |
2811 | - vmm.vmm64's .text section shrank 28 bytes |
2812 | - vmware-vmx's .text section shrank 16 bytes |
2813 | + File upload to '/' on Linux fails the directory exists check. |
2814 | + This is caused by the file dirname being an empty string when parsed from |
2815 | + the guest file path name per the documented behavior of File_GetPathName. |
2816 | |
2817 | - Given that these are tiny fractions of the .text section, this suggests the |
2818 | - problem was quite rare, which is why it escaped our attention until now. |
2819 | - (Testing of vmx's lib/lock, lib/sync, lib/vprobe, and lib/misc saw no |
2820 | - differences with GCC 4.4, 6.4, 7.1 or Clang) |
2821 | + The caller of File_GetPathName needs to handle the expected empty dirname |
2822 | + string when dealing with file path in the root ('/') filesystem on Linux. |
2823 | |
2824 | - While in there: nuke some tabs |
2825 | + Proposed fix is to replace the dirname string with the root path ('/') when: |
2826 | + A. dirname obtained from File_GetPathName call is an empty string AND |
2827 | + B. the original file path name starts with the path separator ('/') on |
2828 | + Linux (or *nix like) GOSes |
2829 | |
2830 | - Slated for a future change: vmkapi_atomic.h |
2831 | + This allows for the directory checks to inspect the root folder before |
2832 | + proceeding with the file transfer. |
2833 | |
2834 | -commit 333ac41076afff4e31ccb0d0688e1581e8c9019a |
2835 | +commit 022121ce185662c05b3e1bf7166500f4f0f72bb2 |
2836 | Author: Oliver Kurth <okurth@vmware.com> |
2837 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2838 | +Date: Wed Apr 10 14:14:51 2019 -0700 |
2839 | |
2840 | Common header file change not applicable to open-vm-tools. |
2841 | |
2842 | -commit 8671bd8d4f68a490a5b20f1876f05797f3057c4b |
2843 | +commit 3de5e45099ae309b59f371e1d71c88c80815f92d |
2844 | Author: Oliver Kurth <okurth@vmware.com> |
2845 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2846 | +Date: Wed Apr 10 14:14:51 2019 -0700 |
2847 | |
2848 | - vmcheck.c VmCheck_IsVirtualWorld(): Always check for a working backdoor. |
2849 | - |
2850 | - The specific checks for Xen and VirtualPC hypervisors currently happen |
2851 | - only if the VMware hypervisor is not detected. The test for a working |
2852 | - VMware backdoor is then done to avoid all other hypervisors. |
2853 | + Backing out the previous change to vixTools.c |
2854 | |
2855 | - In the case where running on a VMware hypervisor and the backdoor |
2856 | - channel has been disabled such as with |
2857 | + As the code committed was not the one reviewed but another version of the |
2858 | + fix under exploration, reverting the previous change. |
2859 | + |
2860 | +commit e38e881a04cdf1684913c0e65596f4965e8d0c32 |
2861 | +Author: Oliver Kurth <okurth@vmware.com> |
2862 | +Date: Wed Apr 10 14:14:51 2019 -0700 |
2863 | + |
2864 | + Common header file change not applicable to open-vm-tools. |
2865 | + |
2866 | +commit f682261e7997aa440523af63369e4b99e4823af7 |
2867 | +Author: Oliver Kurth <okurth@vmware.com> |
2868 | +Date: Wed Apr 10 14:14:49 2019 -0700 |
2869 | + |
2870 | + InitiateFileTransferToGuest fails when uploading file to root directory |
2871 | |
2872 | - monitor_control.restrict_backdoor = "TRUE" |
2873 | + File upload to '/' on Linux fails the directory exists check. |
2874 | + This is caused by the file dirname being an empty string when parsed from the guest file path name per the documented behavior of File_GetPathName. |
2875 | |
2876 | - vmtoolsd, vmware-toolbox-cmd and vmware-checkvm will crash when |
2877 | - attempting to get the version number of the installed VMware Tools. |
2878 | + The caller of File_GetPathName needs to handle the expected empty dirname string when dealing with file path in the root ('/') filesystem on Linux. |
2879 | |
2880 | - Added an additional test to detect Linux KVM with the existing tests |
2881 | - for the Xen hypervisor and Microsoft Virtual PC. Avoid checking for |
2882 | - a working backdoor if a non VMware hypervisor is seen. |
2883 | + Proposed fix is to replace the dirname string with the root path ('/') when: |
2884 | + A. dirname obtained from File_GetPathName call is an empty string AND |
2885 | + B. the original file path name starts with the path separator ('/') on Linux (or *nix like) GOSes |
2886 | |
2887 | - Microsoft Hv checking to be added later and is tracked in a separate PR. |
2888 | - Oracle VirtualBox provides no unique CPUID vendor signature string. |
2889 | + This allows for the directory checks to inspect the root folder before proceedeing with the file transfer. |
2890 | |
2891 | -commit 09958952cc761075d5546b18bed0ce59260ec4db |
2892 | +commit fcb7bb71a30f740b2d4bcfb8ae82733d044e6c00 |
2893 | Author: Oliver Kurth <okurth@vmware.com> |
2894 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2895 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2896 | |
2897 | - FreeBSD open-vm-tools kernel modules compilations cannot locate <stdint.h> |
2898 | - |
2899 | - With the change for VMware headers to utilize the standard types |
2900 | - defined in C99 standard headers, the compilation of FreeBSD kernel |
2901 | - modules must specifically add /usr/include to the compilation |
2902 | - options. |
2903 | - |
2904 | - CFLAGS += -isystem /usr/include |
2905 | - |
2906 | - This change updates the Makefiles's for FreeBSD kernel modules and |
2907 | - drivers. |
2908 | + Make building without ICU the default for Linux. |
2909 | |
2910 | -commit cdf0406dc669f2284e1e810ac5820f123d46a50e |
2911 | +commit bd84c8a35c7aedb2638bba087bc1756cfb9ccf9d |
2912 | Author: Oliver Kurth <okurth@vmware.com> |
2913 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2914 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2915 | |
2916 | - FreeBSD: Improper use of sysconf() for getpwent buffer size leads to |
2917 | - vmtoolsd crash. |
2918 | - |
2919 | - On FreeBSD, sysconf(_SC_GETPW_R_SIZE_MAX) can return -1 if it has |
2920 | - no hard limit ultimately resulting in an incorrect buffer size. |
2921 | - |
2922 | - This change is adapting the sysconf() ifixes done elsewhere to |
2923 | - bora-vmsoft/services/plugins/vix/vixTools.c and updating the |
2924 | - open-vm-tools AUTHORS file to share credit for the pull request. |
2925 | + Query disks for UUID |
2926 | |
2927 | - https://github.com/vmware/open-vm-tools/pull/238 |
2928 | + As part of identifying a guest disk so it can be associated with a vmdk, |
2929 | + query its serial number, which is the same as the vmdk's ddb.uuid |
2930 | |
2931 | -commit e20e9bd49d244749ee6bcd4ea7d57a26d891afbe |
2932 | +commit 076e7e10f24b53fcbd7b21d95ee4763f5f527e45 |
2933 | Author: Oliver Kurth <okurth@vmware.com> |
2934 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2935 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2936 | |
2937 | Common header file change not applicable to open-vm-tools. |
2938 | |
2939 | -commit 7e03f0676a8d1a8667d7d6aeda968a74c8708c0e |
2940 | +commit b9939819756514c7ebe71059e0323cde8bb44c68 |
2941 | Author: Oliver Kurth <okurth@vmware.com> |
2942 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2943 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2944 | |
2945 | Common header file change not applicable to open-vm-tools. |
2946 | |
2947 | -commit 0c4420178932c1879f402ece689e5cfaf5f37d84 |
2948 | +commit 59a7e9e1c5e8e6883740ec43371cbe7076ee6bc0 |
2949 | Author: Oliver Kurth <okurth@vmware.com> |
2950 | -Date: Fri Mar 23 15:05:35 2018 -0700 |
2951 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2952 | |
2953 | - CAF changes for Windows; not applicable to open-vm-tools. |
2954 | + Bug fix for DnD performance tuning for Mac and Windows clients; not |
2955 | + directly applicable to open-vm-tools. |
2956 | |
2957 | -commit e9463abdc0d56d0612237faf01a5736c9998b499 |
2958 | +commit 176aa26ae63050e7d10c8413230c566069cb06d9 |
2959 | Author: Oliver Kurth <okurth@vmware.com> |
2960 | -Date: Fri Mar 23 14:57:12 2018 -0700 |
2961 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2962 | |
2963 | - sysconf() usage leads to crashes in BSD tools |
2964 | - |
2965 | - Not using the sysconf interface properly when determinining the |
2966 | - getpwent buffer size. Fix this. |
2967 | + Common source file changes not applicable to open-vm-tools. |
2968 | |
2969 | - Problem was identified and proposed fix was submitted in pull request |
2970 | - https://github.com/vmware/open-vm-tools/pull/238 |
2971 | + Security fix for dll load paths in Tools and vgauth. |
2972 | |
2973 | -commit 4eff69adab058331a1e93aee17ed9a4e13fa8714 |
2974 | +commit f2e134e40bd7fab478f4f1545db8f09b39e2d3dc |
2975 | Author: Oliver Kurth <okurth@vmware.com> |
2976 | -Date: Fri Mar 23 14:57:12 2018 -0700 |
2977 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2978 | |
2979 | - [lib/file]: remove useless heap allocation |
2980 | - |
2981 | - FileIO_AtomicUpdateEx allocates the argument to the "swap" ioctl |
2982 | - on the heap. This argument is a struct which contains a single int |
2983 | - fd... there is no need to heap-allocate it, the stack is just fine. |
2984 | + Common header file change not directly applicable to open-vm-tools. |
2985 | |
2986 | -commit 6de42f7d96fb5c70d70ae3b68011477f8b93aef2 |
2987 | +commit c65bb4057bbd8d4b96f8b1bedfc273669357cfd8 |
2988 | Author: Oliver Kurth <okurth@vmware.com> |
2989 | -Date: Fri Mar 23 14:57:12 2018 -0700 |
2990 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
2991 | |
2992 | - bora/lib: Use _exit when in the context of a signal handler |
2993 | - |
2994 | - There are a few cases in bora/lib where exit(3) is used in the |
2995 | - context of a signal handler. It was recently noticed that exit(3) is |
2996 | - not async-signal-safe, and _exit(2) should be used instead. |
2997 | + GOS Table: Add Linux 5.x |
2998 | |
2999 | - This patch changes a call from exit(3) to _exit(2) in bora/lib. |
3000 | + Linux 5.x is here! Add it to our supported guests list. |
3001 | |
3002 | -commit 54415a34a372388374bf322d8118ef47c7b0f9f7 |
3003 | +commit 9f05b0bca42039eb6de0f16441d3a6edc4093264 |
3004 | Author: Oliver Kurth <okurth@vmware.com> |
3005 | -Date: Fri Mar 23 14:57:12 2018 -0700 |
3006 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
3007 | |
3008 | - Hgfs FUSE Client: enable the FUSE client for RHEL 7, Ubuntu 14.04 and others |
3009 | + Common header file change not directly applicable to open-vm-tools. |
3010 | + |
3011 | +commit d28bb53aeeb425502de7a90175482c5abf16b8ee |
3012 | +Author: Oliver Kurth <okurth@vmware.com> |
3013 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
3014 | + |
3015 | + Remove the /etc/security directory from the guest vm-support bundle. |
3016 | |
3017 | - The RHEL 7.x releases are all kernel 3.10 based. Currently the Hgfs FUSE |
3018 | - client will not be enabled for these earlier kernel versions, enabled only |
3019 | - for 4.0 kernels and later. This means for default tools install on plaftorms |
3020 | - running those kernel versions the Hgfs kernel client must be installed and |
3021 | - used for Shared Folders. The consequence of this means that the tar tools |
3022 | - installer must be run to provide the Hgfs kernel client on top of the OVT |
3023 | - install. |
3024 | + This directory contains sensitive guest side data that we should not |
3025 | + expose to the host side. |
3026 | |
3027 | - To remove the need to install the tar tools we must enable support for the |
3028 | - Hgfs FUSE client, which just requires the kernel version check to be modified |
3029 | - from 4.0.0 to 3.10.0. |
3030 | + Although running the vm-support requires the root privilege in the guest, |
3031 | + the guest admin might not be aware of the ramification of running the script. |
3032 | + Therefore, better be cautious. |
3033 | + |
3034 | + No file from the /etc/security has been needed in the past. If any file is |
3035 | + needed in the future, that need will be evaluated case-by-case at that time. |
3036 | |
3037 | -commit 84977ad9a0ca964d5873516c42efec328bac23c9 |
3038 | +commit b87bf1b5a1fb93f348d311086c335c0e14e44469 |
3039 | Author: Oliver Kurth <okurth@vmware.com> |
3040 | -Date: Fri Mar 23 14:57:12 2018 -0700 |
3041 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
3042 | |
3043 | - Changes to common header files; not applicable to open-vm-tools. |
3044 | + Common header file change not applicable to open-vm-tools. |
3045 | |
3046 | -commit 587d95eeadbdab2f20020ef24686bd989af6d8b0 |
3047 | +commit c760135f46eaf246612bc8632374966ed79ce9b2 |
3048 | Author: Oliver Kurth <okurth@vmware.com> |
3049 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3050 | +Date: Thu Mar 28 12:43:00 2019 -0700 |
3051 | |
3052 | - lib/misc/hostinfoPosix.c: Fix sscanf format string case typo. |
3053 | + DnD performance tuning for Mac and Windows clients; not directly applicable |
3054 | + to open-vm-tools. |
3055 | |
3056 | -commit 8e22cb4da06036b71a06698da3377ed72cfef440 |
3057 | +commit 477bc19fac47a71369bf5872c8ff9b366d51ca1a |
3058 | Author: Oliver Kurth <okurth@vmware.com> |
3059 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3060 | +Date: Thu Mar 28 12:42:59 2019 -0700 |
3061 | |
3062 | - Changes to common header files; not applicable to open-vm-tools. |
3063 | + Fix a memory leak in vmbackup. |
3064 | + |
3065 | + Note: vm_free() is called here because GuestApp_GetConfPath() is calling |
3066 | + Util_SafeStrdup() to allocate the memory. Both GuestApp_GetConfPath and |
3067 | + vm_free are implemented inside libvmtools.so. |
3068 | |
3069 | -commit 9e3738b457eba1d9f8302fa449e9521da59f2dfd |
3070 | +commit 8f1e76f97989009fa44cbbfc1ac48e3e0083b9e7 |
3071 | Author: Oliver Kurth <okurth@vmware.com> |
3072 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3073 | +Date: Thu Mar 28 12:42:59 2019 -0700 |
3074 | |
3075 | - Changes to common header files; not applicable to open-vm-tools. |
3076 | + Common source file change not applicable to open-vm-tools. |
3077 | |
3078 | -commit 18358aecd27f7d77b71d5ab31250edc600b7bfbc |
3079 | +commit d93219282ff7e89e3f581bf757dfd807c7568452 |
3080 | Author: Oliver Kurth <okurth@vmware.com> |
3081 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3082 | +Date: Thu Mar 28 12:42:59 2019 -0700 |
3083 | |
3084 | - Changes to common header files; not applicable to open-vm-tools. |
3085 | + Fix memory leak in GetFormattedCommandLine() function (linuxDeployment.c) |
3086 | + |
3087 | + 1. There are malloc() calls happening in a loop; this function returns |
3088 | + NULL when one of malloc fails. If a malloc call fails in the loop, |
3089 | + all memory allocated in previous iterations should be freed before |
3090 | + the return NULL. |
3091 | + 2. Clear allocated resources before return NULL in this file. |
3092 | + 3. Add NULL check following malloc calls in this file. |
3093 | + 4. Encapsulate %s in () only if %s is strerror(errno), otherwise encapsulate |
3094 | + %s in single quotes. |
3095 | + 5. End with \n in sLog. |
3096 | |
3097 | -commit 670dba44e90c64173a1f67e617a7193f18fc3a2c |
3098 | +commit 85f0733565333335aac4c45851013e8e0901a9f5 |
3099 | Author: Oliver Kurth <okurth@vmware.com> |
3100 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3101 | +Date: Wed Feb 27 14:39:58 2019 -0800 |
3102 | + |
3103 | + Remove dead code in vmtoolsConfig.c |
3104 | + |
3105 | + There is a lot code in vmtoolsConfig.c that handles the 'tools upgrades' |
3106 | + from legacy tools versions. |
3107 | + |
3108 | + But as per |
3109 | + https://docs.vmware.com/en/VMware-Tools/10.1/rn/vmware-tools-1010-release-notes.html#installupgrade, |
3110 | + legacy tools versions (prior to 9.4.x) must be first upgraded to 10.1.0 before |
3111 | + upgrading to the latest tools versions. Hence, removed all the code which is |
3112 | + no longer applicable for the 'latest tools version'. |
3113 | + |
3114 | +commit 449b8d4aa6ca1fbd34ac1f5aa5324c141075ab0a |
3115 | +Author: Oliver Kurth <okurth@vmware.com> |
3116 | +Date: Wed Feb 27 14:39:58 2019 -0800 |
3117 | |
3118 | Common header file change not applicable to open-vm-tools. |
3119 | |
3120 | -commit 5fe941cd27194495811036667d312f14aece1975 |
3121 | +commit 23dec2833bc0961b7623672deb9971f4ae0ec385 |
3122 | Author: Oliver Kurth <okurth@vmware.com> |
3123 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3124 | +Date: Wed Feb 27 14:39:58 2019 -0800 |
3125 | |
3126 | Common header file change not applicable to open-vm-tools. |
3127 | |
3128 | -commit 03faa87192b23354a996b4d62282c002de002c59 |
3129 | +commit fa94fcf10c3fd0fe8a327cb27de72830ce615257 |
3130 | Author: Oliver Kurth <okurth@vmware.com> |
3131 | -Date: Fri Mar 23 14:57:11 2018 -0700 |
3132 | +Date: Wed Feb 27 14:39:58 2019 -0800 |
3133 | + |
3134 | + Log guest OP results to guest side only. |
3135 | + |
3136 | +commit aaa29bf9e9a59a25b009949bc688166615e983ae |
3137 | +Author: Oliver Kurth <okurth@vmware.com> |
3138 | +Date: Wed Feb 27 14:39:57 2019 -0800 |
3139 | |
3140 | Common header file change not applicable to open-vm-tools. |
3141 | |
3142 | -commit 2438cefba37d37de65bf2003b1880f47b529ef47 |
3143 | +commit c88df96c3c8aab080bb79ad8ece5b558cf49bbe1 |
3144 | Author: Oliver Kurth <okurth@vmware.com> |
3145 | -Date: Tue Mar 6 10:38:43 2018 -0800 |
3146 | +Date: Wed Feb 27 14:39:57 2019 -0800 |
3147 | |
3148 | - Enhancements for rpcChannel library. |
3149 | - |
3150 | - rpcChannel.c file contains the code for building rpcChannel library. A good |
3151 | - amount of the same code is duplicated in rpcChannelSimple.c file to |
3152 | - build a simplified version (no glib dependency) of the rpcChannel library. |
3153 | - It's recommended to remove the duplication and maintain only one single |
3154 | - file which can be used to build both 'glib-dependent rpcChannel' and |
3155 | - 'glib independent rpcChannel' library. |
3156 | + Common header file change not applicable to open-vm-tools. |
3157 | + |
3158 | +commit 89dcc97adf9ed58ed3f2f89ca354ee55353e8317 |
3159 | +Author: Oliver Kurth <okurth@vmware.com> |
3160 | +Date: Wed Feb 27 14:39:57 2019 -0800 |
3161 | + |
3162 | + Changes to common header files not applicable to open-vm-tools. |
3163 | + |
3164 | +commit f23e764d01136eaf3aba5c91da2db334b4c9cb1a |
3165 | +Author: Oliver Kurth <okurth@vmware.com> |
3166 | +Date: Wed Feb 27 14:39:57 2019 -0800 |
3167 | + |
3168 | + Tools Vix Plugin: minor cleanup remove unnecessary undefs |
3169 | |
3170 | - This changeset implements the following changes: |
3171 | - * Removed rpcChannelSimple.c |
3172 | + A minor cleanup remove unnecessary undefs and fixing a misspelling in |
3173 | + a function header. The function header somehow got removed from the |
3174 | + previous clean up so here it is again anyway, with the addition of the |
3175 | + spelling correction. |
3176 | + |
3177 | +commit 13e4fd7c5be25fcf2a4243c2ca32cdf0fec44496 |
3178 | +Author: Oliver Kurth <okurth@vmware.com> |
3179 | +Date: Wed Feb 27 14:39:57 2019 -0800 |
3180 | + |
3181 | + Linux DeployPkg should provide a configurable timeout for the spanning |
3182 | + customization process. |
3183 | |
3184 | - * Renamed I_USE_SIMPLE_RPC make variable to USE_RPCI_ONLY. If this |
3185 | - flag is specified, rpcChannel library will be built using only RPCI. |
3186 | - No dependencies on rpcIn will be added. This inturn will remove |
3187 | - dependencies on dynxdr, xdr and glib. |
3188 | + Change the upper limit of the timeout value in tools.conf to 3600 instead |
3189 | + of MAX_UINT16. Revise the log message displayed when an invalid value |
3190 | + is configured in tools.conf. |
3191 | + |
3192 | +commit 6b6a4c8d2262036fec01d894819b8ac8c764e05b |
3193 | +Author: Oliver Kurth <okurth@vmware.com> |
3194 | +Date: Wed Feb 27 14:39:57 2019 -0800 |
3195 | + |
3196 | + Remove some redundant code in lib/poll/poll.c detected by cppcheck. |
3197 | + |
3198 | +commit bd4bd92bab5339dc29ad042295e218b68c35f974 |
3199 | +Author: Oliver Kurth <okurth@vmware.com> |
3200 | +Date: Wed Feb 27 14:39:56 2019 -0800 |
3201 | + |
3202 | + Tools Vix Plugin: remove unused hgfs rpc channel |
3203 | |
3204 | - * Modified the RpcChannelInt structure to have only the necessary |
3205 | - attributes when USE_RPCI_ONLY is defined. |
3206 | - |
3207 | - * Modified a bunch of functions into '#if defined(NEED_RPCIN)' block |
3208 | - to make available only when necessary. |
3209 | - |
3210 | - * Modified guestrpc.h to provide the declarations for few RpcChannel_* |
3211 | - functions only when needed. |
3212 | - |
3213 | - * Modified rpcChannel library to implement necessary stub files / functions |
3214 | - when it has to be built 'with rpci only' setting. |
3215 | - |
3216 | - * Removed various copies of 'glib_stubs.c' maintained by different |
3217 | - consumers of rpcChannel (appmonitorlib, vmGuestLib, 'imgcust' components). |
3218 | - |
3219 | - * Modified the make files of various consumers (vmGuestLib, appmonitorlib, |
3220 | - imgcust components [linux-pkg-deployer, guestcustutil, UnitTest]) to |
3221 | - remove the dependencies for dynxdr library. |
3222 | - |
3223 | - * Did some code refactoring. |
3224 | - - Removed some dead code in some make files. |
3225 | + This change removes the unused VIX_BACKDOORCOMMAND_SEND_HGFS_PACKET |
3226 | + rpc handler from the Vix plugin. |
3227 | |
3228 | -commit 87be66f17bf7911a8ec59ce9917778f7f653a398 |
3229 | +commit df108dbfeb08dcf1c9ac0b6dd0026048c6c007a8 |
3230 | Author: Oliver Kurth <okurth@vmware.com> |
3231 | -Date: Tue Mar 6 10:38:43 2018 -0800 |
3232 | +Date: Wed Feb 27 14:39:56 2019 -0800 |
3233 | |
3234 | - Implement a new function VMTools_GetTimeAsString. |
3235 | - |
3236 | - * Implemented a new function VMTools_GetTimeAsString in |
3237 | - vmtools library which returns a properly formatted UTC timestamp |
3238 | - information. This function can be used by different modules / plugins |
3239 | - in 'VMware Tools' to add the timestamp information in log files. |
3240 | - |
3241 | - Example of UTC timestamp information: "2018-02-22T21:17:38.517Z" |
3242 | - |
3243 | - * Modified vmtools logging module to call the new function and |
3244 | - prepend the UTC timestamp information in every log message. |
3245 | - |
3246 | - * Modified deployPkgLog.c to use the new function. |
3247 | - |
3248 | - * Removed references / definition of System_GetTimeAsString since |
3249 | - it is no longer used anywhere in the code. |
3250 | + Changes to common header files not applicable to open-vm-tools. |
3251 | |
3252 | -commit acbf7d90add72d9d3aa70bb8677179e7b3d28e23 |
3253 | +commit 3cd64dd8b345194c277dfbfe7361db115294a40c |
3254 | Author: Oliver Kurth <okurth@vmware.com> |
3255 | -Date: Tue Mar 6 10:38:43 2018 -0800 |
3256 | +Date: Wed Feb 27 14:39:56 2019 -0800 |
3257 | |
3258 | - Common header file change; not applicable to open-vm-tools. |
3259 | + Common header file change not applicable to open-vm-tools. |
3260 | |
3261 | -commit 87ddd2684bff33836db5667718449f42642c76e2 |
3262 | +commit 1875839fe260d7093e8170ef079b6c6875a1c99d |
3263 | Author: Oliver Kurth <okurth@vmware.com> |
3264 | -Date: Tue Mar 6 10:38:43 2018 -0800 |
3265 | +Date: Wed Feb 27 14:39:56 2019 -0800 |
3266 | |
3267 | - GOS Table: The official Amazon Linux 2 string is "amazonlinux2-64" |
3268 | - |
3269 | - The hosted UI isn't creating an Amazon 2 VM with the correct guest OS |
3270 | - identifier string. Fix this. |
3271 | + Common header file change not applicable to open-vm-tools. |
3272 | |
3273 | -commit 91b42f829a0ddc13a1657610700332dad7a9e362 |
3274 | +commit 705dea9434a9e2b4db2163e6cf9bdd5451f4e4d6 |
3275 | Author: Oliver Kurth <okurth@vmware.com> |
3276 | -Date: Tue Mar 6 10:38:43 2018 -0800 |
3277 | +Date: Wed Feb 27 14:39:55 2019 -0800 |
3278 | |
3279 | - Fix vgauth log timestamps to have zone and use UTC |
3280 | + Common header file change not applicable to open-vm-tools. |
3281 | |
3282 | -commit d225ed26cca556f559c035234d11bd7d380c6d7f |
3283 | +commit 0230f00147774547cd72e62a805db511234bbf8e |
3284 | Author: Oliver Kurth <okurth@vmware.com> |
3285 | -Date: Tue Mar 6 10:38:42 2018 -0800 |
3286 | +Date: Wed Feb 27 14:39:55 2019 -0800 |
3287 | |
3288 | - Common header file change; not applicable to open-vm-tools |
3289 | + Common header file change not applicable to open-vm-tools. |
3290 | |
3291 | -commit d585ee8fcc4135d6d52fdc38ec2e0ca747663bf7 |
3292 | +commit 1703710a2706527748ec7be6767c14f2fcf63fc2 |
3293 | Author: Oliver Kurth <okurth@vmware.com> |
3294 | -Date: Tue Mar 6 10:38:42 2018 -0800 |
3295 | +Date: Wed Feb 27 14:39:55 2019 -0800 |
3296 | |
3297 | - Compilation fixes to build Tools with VS2015 |
3298 | + Common source file changes not directly applicable to open-vm-tools. |
3299 | + |
3300 | +commit c68172ef7f2d4f116078e2aba82986a8cab0b16e |
3301 | +Author: Oliver Kurth <okurth@vmware.com> |
3302 | +Date: Wed Feb 27 14:39:55 2019 -0800 |
3303 | + |
3304 | + GCC 9 caught several misaligned accesses and a format overflow. |
3305 | |
3306 | - This change consists of fixing warnings/errors as a result of building Tools with VS2015. |
3307 | + GCC 9 generated several instances of "Werror=address-of-packed-member" |
3308 | + in HGFS Fuse support code and hgfsmounter. There is also one instance of |
3309 | + "Werror=format-overflow" generated in util_misc.c. |
3310 | + |
3311 | + According to stackoverflow discussion - |
3312 | + https://stackoverflow.com/questions/8568432/is-gccs-attribute-packed-pragma-pack-unsafe, |
3313 | + x86 hardware handles misaligned access and does not exhibit any real |
3314 | + issues. However, GCC 9 generates misaligned access warning |
3315 | + ("Werror=address-of-packed-member) for all architectures. In case of |
3316 | + open-vm-tools build we treat warnings as errors and also we want code |
3317 | + to be as portable as possible in general unless there is a reason not |
3318 | + to do so. |
3319 | |
3320 | -commit 03c98a1fb30513b223e3d6eafb21b5f4d4c6c5bc |
3321 | +commit 577bc573f875ad5fe0e932cc58f2d607c422ea92 |
3322 | Author: Oliver Kurth <okurth@vmware.com> |
3323 | -Date: Tue Mar 6 10:38:42 2018 -0800 |
3324 | +Date: Wed Feb 27 14:39:54 2019 -0800 |
3325 | |
3326 | - Add timestamp information to each deploypkg log message. |
3327 | + Common source file changes not applicable to open-vm-tools. |
3328 | + |
3329 | +commit 17a318fbde8df0b7aaa222acf944d319397fa42c |
3330 | +Author: Oliver Kurth <okurth@vmware.com> |
3331 | +Date: Wed Feb 27 14:39:54 2019 -0800 |
3332 | + |
3333 | + Common header file change not applicable to open-vm-tools. |
3334 | + |
3335 | +commit 9a013addd657dda0d6671b7ea64c4a0793f57d18 |
3336 | +Author: Oliver Kurth <okurth@vmware.com> |
3337 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3338 | + |
3339 | + Bump up the SYSIMAGE_VERSION to be same as the VMTools version. |
3340 | + |
3341 | +commit 34e9b02de740562802680ab43b8dfd3e741b0658 |
3342 | +Author: Oliver Kurth <okurth@vmware.com> |
3343 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3344 | + |
3345 | + Hgfs Server Manager Tools: fix a memory leak |
3346 | |
3347 | - * Modified deployPkgLog.c file to prepend UTC timestamp information |
3348 | - to each log message coming from 'deploypkg' module in 'VMware Tools'. |
3349 | + The Hgfs server manager interface assumes that it is called only once |
3350 | + for each application that uses it. However, in the tools services there |
3351 | + are multiple clients. Hence, the initialization is done multiple times |
3352 | + and causes the previous initializations which allocate resources to be |
3353 | + overwritten and lost. Thus memory is being leaked. |
3354 | |
3355 | - * Used bunch of glib functions to get the current UTC time. As per |
3356 | - the glib manual, these glib functions are available since 2.26. 2.26 was |
3357 | - released around 8 years ago which is kind of very old. Having the glib |
3358 | - dependency on 2.26 is OK. |
3359 | + Initialize the policy shares once on the first register and cleanup |
3360 | + the policy shares on final unregister by introducing a reference count. |
3361 | |
3362 | - * Did some minor code refactoring. In DeployPkg.c file, at all |
3363 | - call sites for DeployPkgLog_Log, replaced the hard coded values with |
3364 | - the proper LogLevel enums. |
3365 | + The channel is already reference counted and initializes the channel once. |
3366 | + However it is necessary to call the channel init on each register |
3367 | + and exit on each unregister as it saves a channel reference in the data manager |
3368 | + object passed to it by the caller for subsequent retrieval. |
3369 | + |
3370 | + Add an additional log to the policy init and cleanup calls for tracking purposes. |
3371 | |
3372 | -commit 73a21a057dc23cf428b5fa1799eb0c5945732fee |
3373 | +commit 19609ecdf97dbdbfa116eb3129689850fbf3e528 |
3374 | Author: Oliver Kurth <okurth@vmware.com> |
3375 | -Date: Tue Mar 6 10:38:42 2018 -0800 |
3376 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3377 | |
3378 | - Common header file change; not applicable to open-vm-tools. |
3379 | + Common header file change not applicable to open-vm-tools. |
3380 | |
3381 | -commit 3eb8434aebde9a2eebc65d57044d8ea6367d685f |
3382 | +commit 05fb961e2c5fcb0e3be0353171f3f2b5d945d0dd |
3383 | Author: Oliver Kurth <okurth@vmware.com> |
3384 | -Date: Tue Mar 6 10:38:42 2018 -0800 |
3385 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3386 | |
3387 | - Common header file change; not applicable to open-vm-tools. |
3388 | + Common source file change not directly applicable to open-vm-tools. |
3389 | |
3390 | -commit 24e9d211752210abb94bd1e76bec8be20d8abef8 |
3391 | +commit 393476a4ccab5dbf1afe1ac5ced9f71be0d25cff |
3392 | Author: Oliver Kurth <okurth@vmware.com> |
3393 | -Date: Tue Mar 6 10:38:42 2018 -0800 |
3394 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3395 | |
3396 | - vm_basic_types.h: enable stdint.h for c99 |
3397 | - |
3398 | - C99 mode (a.k.a. __STDC_VERSION__ >= 199901L) guarantees |
3399 | - the stdint.h header will be present, which means we can use it |
3400 | - for standard types instead of rolling our own. |
3401 | + Common header file change not applicable to open-vm-tools. |
3402 | |
3403 | -commit b4016c210e7cb6c0407d40dba5edfa64d550bef3 |
3404 | +commit 4746cfffa7f4334438f4f0b219033b33d079f970 |
3405 | Author: Oliver Kurth <okurth@vmware.com> |
3406 | -Date: Tue Mar 6 10:38:41 2018 -0800 |
3407 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3408 | |
3409 | - Don't lose errno/lastError when logging |
3410 | - |
3411 | - guestOps need to see errno/lastError in order to return the proper |
3412 | - error to VIX/guestOps APIs. Logging (at any layer) can cause these |
3413 | - to be overwritten, so make sure they're preserved. |
3414 | + Common header file change not applicable to open-vm-tools. |
3415 | |
3416 | -commit 14a0ffe23be6437c9ee656ccf2d516ead6265dfd |
3417 | +commit 68b2d39547222badd73cdbc6eecdec57e8e5e45e |
3418 | Author: Oliver Kurth <okurth@vmware.com> |
3419 | -Date: Mon Feb 26 19:23:18 2018 -0800 |
3420 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3421 | |
3422 | - Enhancing CAF listener preconfigured check logic to update the preconfigured flag at runtime |
3423 | - |
3424 | - 1. Preconfigure listener and start listener upon tunnel enabled logic are |
3425 | - invoked in two different threads. |
3426 | - 2. There is a case where preconfigure logic is performed after the |
3427 | - pre-configured flag is computed in the enable-listener thread. |
3428 | - |
3429 | - The current patch invalidates the flag in the start listener thread and |
3430 | - should guarantee the preconfigured status is up-to-date. |
3431 | + Common header file change not applicable to open-vm-tools. |
3432 | |
3433 | -commit 60f7afc97264435e1c04c2e70fe39397261b52b4 |
3434 | +commit 188df13c0a30c4612c074b7c805926f9a35120d0 |
3435 | Author: Oliver Kurth <okurth@vmware.com> |
3436 | -Date: Mon Feb 26 19:22:04 2018 -0800 |
3437 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3438 | |
3439 | - CAF MA Performance Issues |
3440 | - |
3441 | - CAF MA Performance Issues |
3442 | - |
3443 | - Vmware CAF ManagementAgentHost service was polling every 5 secs to check if Guest Network "Tunnel(port 6672)" was enabled to preconfigure & bring up Vmware CAF CommAmqpListener service. |
3444 | - This resulted in more CPU Utilization as opposed to previous release in CAF & caused regression in vmtools 10.2.0. |
3445 | - We are increasing the Poll rate to 5 mins, which fixed the issue & is giving us the same CPU/memory utilizations as in vmtools 10.1.0. |
3446 | - |
3447 | - We were checking for the different stages of listener preconfiguration status from the listenerpreConfigure.txt files in the polling time interval, which caused increased IO operations. |
3448 | - To fix that we have stored the value of listener preconfiguration status from the files into a variable locally & using the same at all places instead of file access. |
3449 | + Common header file change not applicable to open-vm-tools. |
3450 | |
3451 | -commit 872baeed3fd1e79f89143baa0b9c47077b655567 |
3452 | +commit 7b88dd52f7d3f70664282f9546230f40dbabc694 |
3453 | Author: Oliver Kurth <okurth@vmware.com> |
3454 | -Date: Mon Feb 26 12:29:08 2018 -0800 |
3455 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3456 | |
3457 | - lib/file: add File_MakeSafeTempSubdir |
3458 | - |
3459 | - File_MakeSafeTempDir and File_GetSafeTmpDir are typically used to create |
3460 | - "safe" temp dirs on Windows and Linux. These are dirs in a known-secure |
3461 | - location with known-secure security attributes that only allow access to |
3462 | - the current user. These APIs work fine. However, on Windows if one creates |
3463 | - a subdir inside the safe dir, the subdir may be given an unexpected |
3464 | - (and overly restrictive) set of default DACLs on it in unusual situations. |
3465 | - The solution is to introduce a new API specifically to allow a caller to |
3466 | - create a subdir within an existing safe dir that ensures the DACLs |
3467 | - are exactly what are needed. |
3468 | + Changes to common header files not applicable to open-vm-tools. |
3469 | |
3470 | -commit bdbab22ec42544dbfff657b811d695e5b5a6d429 |
3471 | +commit 91c3366719fad3546d705ccb8000fef12ab8e284 |
3472 | Author: Oliver Kurth <okurth@vmware.com> |
3473 | -Date: Mon Feb 26 12:29:08 2018 -0800 |
3474 | +Date: Tue Feb 19 12:51:33 2019 -0800 |
3475 | |
3476 | - Remove the header file safetime.h |
3477 | - |
3478 | - This removes the file itself. |
3479 | + Common header file change not applicable to open-vm-tools. |
3480 | |
3481 | -commit 047f05f379eb73530ac943d35cda5c162e045fa2 |
3482 | +commit 41d328a9b1119f6078948fdb619d66940eae2a9b |
3483 | Author: Oliver Kurth <okurth@vmware.com> |
3484 | -Date: Mon Feb 26 12:29:08 2018 -0800 |
3485 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3486 | |
3487 | - Common source file change; not applicable to open-vm-tools. |
3488 | + Common header file change not applicable to open-vm-tools. |
3489 | |
3490 | -commit 2c927bb65029cb89ba0c4b7ba9b341890166823d |
3491 | +commit c9863b19f32c20a6ca38cdb6244ef48e5f51dcc2 |
3492 | Author: Oliver Kurth <okurth@vmware.com> |
3493 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3494 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3495 | |
3496 | - Skip specified file systems when doing a quiesced snapshot on Linux |
3497 | - |
3498 | - Add a tools.conf setting "excludedFileSystems" that specifies one or |
3499 | - more file system mount points to be skipped over when performing a |
3500 | - quiesced snapshot on Linux guests. The value of excludedFileSystems |
3501 | - is a comma-separated list of glob-style patterns as recognized by the |
3502 | - glib routines described here: |
3503 | - |
3504 | - https://developer.gnome.org/glib/stable/glib-Glob-style-pattern-matching.html |
3505 | - |
3506 | - With this change, when performing a quiesced snapshot, the sync driver |
3507 | - freeze routine removes from the list of mount points it is to process |
3508 | - any path that matches a pattern in the excludedFileSystems list. |
3509 | - |
3510 | - In the course of testing the change, a bug was found in SyncDriverFreeze |
3511 | - in which it returned SD_ERROR rather than FALSE when the path list is |
3512 | - empty. |
3513 | - |
3514 | - This change also includes some whitespace cleanup in syncDriverWin32.c. |
3515 | + Common header file change not applicable to open-vm-tools. |
3516 | |
3517 | -commit 9fb904dbdbd12952f2743d1463cda56a72c50c90 |
3518 | +commit fdcd728a0b9c21f6017f7a4aef55553a88a6f9ee |
3519 | Author: Oliver Kurth <okurth@vmware.com> |
3520 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3521 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3522 | |
3523 | - lib/file: Paranoid clear of old cached values |
3524 | - |
3525 | - Rare, but an app might toggle addPid; cover this. Also optimize the |
3526 | - cache update. |
3527 | + Changes to common header files not directly applicable to open-vm-tools. |
3528 | |
3529 | -commit d244dac08f07cbbcba3f66eab7d78c16150edfba |
3530 | +commit 46ce56518e018c98d5f2c2dfcbda6df039cb548f |
3531 | Author: Oliver Kurth <okurth@vmware.com> |
3532 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3533 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3534 | |
3535 | - lib/file: File_GetSafeTmpDir is not aware of credentials changes |
3536 | + Common header file change not applicable to open-vm-tools. |
3537 | + |
3538 | +commit 35eae094a31571d806ffdb82c479a425a865bfda |
3539 | +Author: Oliver Kurth <okurth@vmware.com> |
3540 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3541 | + |
3542 | + Common header file change not applicable to open-vm-tools. |
3543 | + |
3544 | +commit 43ba436554ee51d8d7e40a7e86618bd634292356 |
3545 | +Author: Oliver Kurth <okurth@vmware.com> |
3546 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3547 | + |
3548 | + Common source file changes not applicable to open-vm-tools. |
3549 | + |
3550 | +commit a62dd61cc798cf311fa23449534eb22470997ee7 |
3551 | +Author: Oliver Kurth <okurth@vmware.com> |
3552 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3553 | + |
3554 | + Changes to common source files not directly applicable to open-vm-tools. |
3555 | + |
3556 | +commit 9877ed7ad678fa77028c6f4c8a285c82d7fbcb9e |
3557 | +Author: Oliver Kurth <okurth@vmware.com> |
3558 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3559 | + |
3560 | + Common header file change not applicable to open-vm-tools. |
3561 | + |
3562 | +commit 364684e1ce5fba483682f91c7fc27ee0fdcc2a93 |
3563 | +Author: Oliver Kurth <okurth@vmware.com> |
3564 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3565 | + |
3566 | + Fix the missing IP aliases in the guest info. |
3567 | |
3568 | - Some applications may masquerade their use (change their EUID). |
3569 | - Futhermore, each thread in an application can have a separate EUID. |
3570 | + IP aliases were missing in the guest info when libdnet is not used. |
3571 | |
3572 | - Anytime a application or thread asked for its safe temporary directory, |
3573 | - it needs to get the same result regardless of how many times it asks. |
3574 | + Previously tried to use the MAC address as the key to identify the IP aliases |
3575 | + on Linux. However, that didn't work for vlan devices which share the same |
3576 | + MAC as the parent NIC. The previous attempt was backed out. |
3577 | |
3578 | - Change File_GetSafeTmpDir to cache the EUID associated with the cached |
3579 | - values. If there is an EUID change, invalidate the existing cache |
3580 | - entries and recompute them. The recomputation process is stable, in |
3581 | - that it will obtain the same return any time it is called. |
3582 | + Ideally, need to find a way to map the label name to the NIC name, but |
3583 | + have not been able to find a simple solution for this. There might be a |
3584 | + netlink based solution but it is way too costly to do. |
3585 | |
3586 | - This way we get the benefit of the cache (performance), ensured |
3587 | - correctness (for applications that do not masquerade), and correctness |
3588 | - for those applications that do masquerade. |
3589 | + After more investigation, found out that a valid IP alias name must start |
3590 | + with the original NIC name followed by a colon. Even though the ip addr allows |
3591 | + any string as the start of the NIC name, configuration file requires the colon. |
3592 | + In addition, ifconfig would error out when the name is not of the standard: |
3593 | + ens192wwwww: error fetching interface information: Device not found |
3594 | + |
3595 | + Therefore, a correctly configured system should use eth0:1, ens192:2 etc. |
3596 | + |
3597 | + A lookup of libdnet source revealed the same assumption in the libdnet code. |
3598 | + |
3599 | + /* Get addresses for this interface. */ |
3600 | + for (ifr = intf->ifc.ifc_req; ifr < lifr && (ap + 1) < lap; |
3601 | + ifr = NEXTIFR(ifr)) { |
3602 | + /* XXX - Linux, Solaris ifaliases */ |
3603 | + if ((p = strchr(ifr->ifr_name, ':')) != NULL) |
3604 | + *p = '\0'; |
3605 | + |
3606 | + Therefore, doing just the same. Look for the colon, then trim it, and then |
3607 | + compare it with the NIC name. |
3608 | |
3609 | -commit f9177b133f7f683fcc0f85770712d8069ec52421 |
3610 | +commit 47943dec30e3b98259c1dc0d48fb4f669fb02e99 |
3611 | Author: Oliver Kurth <okurth@vmware.com> |
3612 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3613 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3614 | |
3615 | - Common header file change; not applicable to open-vm-tools. |
3616 | + Update copyright year to 2019 for OVT 10.3.10 files. |
3617 | |
3618 | -commit 4da56779c42a55ce1b872748f9d6fd90bd10d281 |
3619 | +commit 0c18ef48a57aeb73c7ac970336c3a7c199744de1 |
3620 | Author: Oliver Kurth <okurth@vmware.com> |
3621 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3622 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3623 | |
3624 | - lib/file: Clean up POSIX File_GetSafeTempDir() in fileTempPosix.c |
3625 | - |
3626 | - Make things clearer. |
3627 | + Back out the previous change to bump up the SYSIMAGE_VERSION to be the same |
3628 | + with VMTools version. |
3629 | |
3630 | -commit f608f63948520ab2088870a800bcc62c67a416ab |
3631 | +commit 8ae36f730d8a7460e5cc139019c8b583abf9677a |
3632 | Author: Oliver Kurth <okurth@vmware.com> |
3633 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3634 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3635 | |
3636 | - Common header file change; not applicable to open-vm-tools. |
3637 | + Back out the previous change to fix the missing IP aliases in the guest info. |
3638 | |
3639 | -commit 5d98c8b5183e236dc8fb548647574f4b24e87d23 |
3640 | +commit b2976af2553c758cfd871b4d9b7593a92c867e9d |
3641 | Author: Oliver Kurth <okurth@vmware.com> |
3642 | -Date: Mon Feb 26 12:29:07 2018 -0800 |
3643 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3644 | |
3645 | - Common header file change; not applicable to open-vm-tools. |
3646 | + Bump up the SYSIMAGE_VERSION to be the same with VMTools version. |
3647 | |
3648 | -commit 65a35ec640223e4455e016c883261f514eb21492 |
3649 | +commit e9512d13665b8d7f9bed2712b0a92a4ebc03f785 |
3650 | Author: Oliver Kurth <okurth@vmware.com> |
3651 | -Date: Mon Feb 26 12:29:06 2018 -0800 |
3652 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3653 | |
3654 | - Common header file change; not applicable to open-vm-tools. |
3655 | + Common header file change not applicable to open-vm-tools. |
3656 | |
3657 | -commit aefcbec68487e14de8938fafbf0606a9ce37b2b9 |
3658 | +commit 7f5a754e197ff4f1159f3d8c793de1fc8d3a19de |
3659 | Author: Oliver Kurth <okurth@vmware.com> |
3660 | -Date: Mon Feb 26 12:29:06 2018 -0800 |
3661 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3662 | |
3663 | - Skip davfs mount points during quiescing (part 2) |
3664 | + GuestOS: Improve the guest OS identification code |
3665 | |
3666 | - Refactor the change to skip davfs mount points. Capture the length |
3667 | - of the static URL prefixes at compile time and avoid repetitive |
3668 | - strlen() calls when checking each active mount point. |
3669 | + Now that we often have an explicit, unambiguous version string for |
3670 | + a distro, use it. In the rare case we don't have one, search the |
3671 | + distro string for a digit and use that. If we can't find anything, |
3672 | + note this and let the code fall into the default appropriate to the |
3673 | + distro. |
3674 | + |
3675 | + With this change, we stop using strings and so are no longer confused |
3676 | + by things like "7.5". For a few of the distros, we now no longer care |
3677 | + about the upper bound, we can report what we find. Anything above what |
3678 | + the release supports will be fixed by the GuestMapper. |
3679 | |
3680 | -commit f459a325c4eec2e31eddc7f74901623b30ea0525 |
3681 | +commit 50a8517abc36af4963c9c29b1127b7652829e410 |
3682 | Author: Oliver Kurth <okurth@vmware.com> |
3683 | -Date: Mon Feb 26 12:29:06 2018 -0800 |
3684 | - |
3685 | - Skip davfs mount points during quiescing |
3686 | - |
3687 | - The davfs2 is a Linux filesystem that allows mounting a Web Distributed |
3688 | - Authoring and Versioning (WebDAV) network resource as a local filesystem. |
3689 | - On some Linux releases, the FREEZE ioctl() is rejected and quiescing |
3690 | - these filesystems is not attempted. On others, however, the FREEZE is |
3691 | - not rejected and there exists the potential of a quiescing deadlock |
3692 | - if the davfs2 attempts to write to its cache in /var which has already |
3693 | - been quiesced. |
3694 | - |
3695 | - This fix is to avoid a potential deadlock by excluding davfs2 mounts |
3696 | - as the networking filesystem they are. Since davfs2 may be implemented |
3697 | - on the Linux fuse (default) or coda filesystem kernel module, |
3698 | - the detection of these network mounts must be based upon detection |
3699 | - of the URL prefix of the mounted device name. |
3700 | - |
3701 | - The static function SyncDriverIsRemoteFSType() is being updated to |
3702 | - not only exclude remote filesystems based on filesystem type but also |
3703 | - to exclude davfs2 remote filesystems by the "http://" or "https://" |
3704 | - URL prefix on the device name. The function name is being changed |
3705 | - to SyncDriverIsRemoteFS(). |
3706 | - |
3707 | -commit 3af8139cfcb4578dd9d7cd9a85301ed808775eb4 |
3708 | -Author: Oliver Kurth <okurth@vmware.com> |
3709 | -Date: Mon Feb 26 12:29:06 2018 -0800 |
3710 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3711 | |
3712 | - vm_basic_types.h: scrub FMTxx specifiers |
3713 | - |
3714 | - Reduce the amount of magic in vm_basic_types.h... nowadays, any |
3715 | - system we support (including Tools) DEFINITELY supports C99-style |
3716 | - specifiers, with two exceptions: pre-vs2015 MSVC, and pre-10.13 |
3717 | - macOS kernels. |
3718 | - |
3719 | - Rip out all the pre-C99 junk. Add a few comments explaining exactly |
3720 | - what the caveats here are. |
3721 | + Common header file change not applicable to open-vm-tools. |
3722 | |
3723 | -commit 442683ac70f1f1c8665feb347be40cac5c8edd65 |
3724 | +commit b6d001fd7b45c5b9414c5642503ad91a5ab279c8 |
3725 | Author: Oliver Kurth <okurth@vmware.com> |
3726 | -Date: Mon Feb 26 12:29:06 2018 -0800 |
3727 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3728 | |
3729 | - amazonlinux2-64 should use OVT only, not tar tools linux.iso. |
3730 | + Common header file change not applicable to open-vm-tools. |
3731 | |
3732 | -commit b4e66d7ac1f29b4d81877741c0dc85b8eeb68365 |
3733 | +commit dd38338c0bfe8a4778a29a53819e3b5aac683381 |
3734 | Author: Oliver Kurth <okurth@vmware.com> |
3735 | -Date: Mon Feb 26 12:29:06 2018 -0800 |
3736 | +Date: Tue Feb 19 12:51:32 2019 -0800 |
3737 | |
3738 | - Common header file change; not applicable to open-vm-tools. |
3739 | + Fix the missing IP aliases in the guest info. |
3740 | + |
3741 | + IP aliases were missing in the guest info when the libdnet is not used. |
3742 | + ESX does not seem to support IP aliases, so the ESX code path is kept logically |
3743 | + the same as before. |
3744 | + |
3745 | + On Linux, for each IP entry, get the label name, and use ioctl to get its MAC. |
3746 | + Use the MAC to match the current device MAC. |
3747 | + |
3748 | + The getifaddrs() call ensures that the ifa_name is not NULL, so there is no |
3749 | + need to check for NULL pointers. |
3750 | |
3751 | -commit 16e63100ba9aeb419d22d8ade3af1eda2e3f02c0 |
3752 | +commit e689b1996788de4e8b9e3dd896a593dad4ca4520 |
3753 | Author: Oliver Kurth <okurth@vmware.com> |
3754 | -Date: Mon Feb 26 12:29:05 2018 -0800 |
3755 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3756 | |
3757 | - Changes to common header files; not applicable to open-vm-tools. |
3758 | + Common header file change not applicable to open-vm-tools. |
3759 | |
3760 | -commit f5b05ca724708bd54b5c5b7dc3f9d0d959134773 |
3761 | +commit bda2908d861cbfae99119340d22c09aae99df51e |
3762 | Author: Oliver Kurth <okurth@vmware.com> |
3763 | -Date: Mon Feb 26 12:29:05 2018 -0800 |
3764 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3765 | |
3766 | - Common header file change; not applicable to open-vm-tools. |
3767 | + Include vmware/tools/log.h to define g_info. |
3768 | + |
3769 | + A recent change added a call to g_info from syncManifest.c. This |
3770 | + in turn is causing open-vm-tools builds to fail because g_info is |
3771 | + not available on SLES 12sp1. |
3772 | + |
3773 | + To fix the problem, include vmware/tools/log.h in syncManifest.c. |
3774 | + log.h defines g_info as a macro. |
3775 | |
3776 | -commit 783e87e2a465d28db5233e7d1e284fa9410ffec4 |
3777 | +commit eb1b69ce8a677025cde23c5913719c5103c6a186 |
3778 | Author: Oliver Kurth <okurth@vmware.com> |
3779 | -Date: Mon Feb 26 12:29:05 2018 -0800 |
3780 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3781 | |
3782 | - Remove uses of header file safetime.h |
3783 | - |
3784 | - - (many places) replace "safetime.h" with <time.h> and/or <sys/stat.h>, |
3785 | - occasionally re-ordering this header to top of file |
3786 | - - (many places) remove "safetime.h" as no time functions are used |
3787 | + Common header file change not directly applicable to open-vm-tools. |
3788 | |
3789 | -commit bf31e9478b99b5713f2c330e48d2e40c5091d3bc |
3790 | +commit cf60bf56b021452e7a92c42a767156b2a64e1ac0 |
3791 | Author: Oliver Kurth <okurth@vmware.com> |
3792 | -Date: Mon Feb 26 12:29:04 2018 -0800 |
3793 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3794 | |
3795 | - Common header file change; not applicable to open-vm-tools. |
3796 | + Back out the previous change to remove support for building with |
3797 | + xml-security-c and xerces-c. |
3798 | |
3799 | -commit cbdbeef4b6c3454f58e9733079140edcc30fdb2a |
3800 | +commit a9db8091cbc5286086ccddf7b78560f05fe90fb6 |
3801 | Author: Oliver Kurth <okurth@vmware.com> |
3802 | -Date: Mon Feb 26 12:29:03 2018 -0800 |
3803 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3804 | |
3805 | - Remove GLIBC_VERSION_NN macros |
3806 | + Remove support for building with xml-security-c and xerces-c |
3807 | |
3808 | - No existing usages. Astute observers will note we currently |
3809 | - use glibc-2.5 minimum (so all but one of these macros are ALWAYS |
3810 | - defined). |
3811 | + Remove support for building VMTools with xml-security-c. Since |
3812 | + xml-security-c is the only requirement for xerces-c, xerces-c |
3813 | + is dropped as well. |
3814 | + |
3815 | + There is also some cleanup of the handling of some configure |
3816 | + options related to vgauth, ssl, xmlsec1, and xml2. |
3817 | |
3818 | -commit eec6e2798def2e9ff6da5e73b092cfe92e60b763 |
3819 | +commit 3a023fad437c1ee576c4e9802f94f208243a9bb8 |
3820 | Author: Oliver Kurth <okurth@vmware.com> |
3821 | -Date: Wed Feb 7 16:39:26 2018 -0800 |
3822 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3823 | |
3824 | Common header file change not applicable to open-vm-tools. |
3825 | |
3826 | -commit 5170db44c1c7b814d0d2bd4131e1895dbd999db7 |
3827 | +commit 8a60e9573885f1ef339cf1bfc19cfb7bc1912122 |
3828 | Author: Oliver Kurth <okurth@vmware.com> |
3829 | -Date: Wed Feb 7 16:39:26 2018 -0800 |
3830 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3831 | |
3832 | - Use a unique random temp directory for vmtoolsd on Linux. |
3833 | + Always send VMBACKUP_EVENT_GENERIC_MANIFEST during quiesced snapshots. |
3834 | |
3835 | - The temporay directory currently used by vmtoolsd and its plugins |
3836 | - on Linux is of the form /tmp/vmware-<user>. Since it is used to |
3837 | - upload VMware Tools upgrade and GOS customization scripts and commands, |
3838 | - that name predictability may make it susceptible to attack. This |
3839 | - change adds a new function File_GetSafeRandomTmpDir() in |
3840 | - bora/lib/file/fileTempPosix.c to both add the PID to the user name |
3841 | - and add a random number suffix to the temp directory path. |
3842 | + vSphere 6.7 added a host-side interface that allows VMTools to send |
3843 | + a "generic" backup manifest during a quiesced snapshot on Linux guests. |
3844 | + VMTools 10.2.0 or later tries to notify the host of the backup manifest |
3845 | + file through a vmbackup event message VMBACKUP_EVENT_GENERIC_MANIFEST. |
3846 | + If the host is unable to field the message, then VMTools logs the |
3847 | + failure and then continues with the quiesced snapshot in the older |
3848 | + fashion, without the backup manifest. |
3849 | |
3850 | - /tmp/vmware-<user>_<pid>-nnnnnn |
3851 | + An earlier change attempted to reduce the amount of logging done when |
3852 | + running on older hosts that don't support VMBACKUP_EVENT_GENERIC_MANIFEST |
3853 | + by detecting when sending VMBACKUP_EVENT_GENERIC_MANIFEST fails and |
3854 | + not sending the message again for subsequent quiesced snapshots. |
3855 | + However, subsequent stress testing has uncovered problems with this |
3856 | + approach when running on newer hosts; specifically, errors may sometimes |
3857 | + be encountered on newer hosts when sending VMBACKUP_EVENT_GENERIC_MANIFEST. |
3858 | + Therefore this change backs out that earlier change. |
3859 | |
3860 | - VMware Tools commands and plugins are being updated to use this random |
3861 | - temp directory. |
3862 | + Note that the need to solve the problem that that earlier change was |
3863 | + intended to solve has been reduced because support for |
3864 | + VMBACKUP_EVENT_GENERIC_MANIFEST has been backported to vSphere 6.5 |
3865 | + P03, which is available, and vSphere 6.0 P08, which is scheduled for |
3866 | + release later this year. ESXi 5.5 is out of general support. |
3867 | + |
3868 | + This change also addresses an issue that surfaced when testing on a |
3869 | + host without support for VMBACKUP_EVENT_GENERIC_MANIFEST. |
3870 | + If VMTools fails to send VMBACKUP_EVENT_GENERIC_MANIFEST, the quiesced |
3871 | + snapshot operation will be aborted rather than continuing as it should. |
3872 | + To address this, create a new function, VmBackup_SendEventNoAbort, |
3873 | + which does not abort the quiesced snapshot on failure, and call that |
3874 | + function rather than VmBackup_SendEvent when sending |
3875 | + VMBACKUP_EVENT_GENERIC_MANIFEST. |
3876 | |
3877 | -commit 9bc56af5d0cb7dcc6f079ff4ab4d3456535365b2 |
3878 | +commit 1b7769909f3269f681e530acc413201c8d6facf0 |
3879 | Author: Oliver Kurth <okurth@vmware.com> |
3880 | -Date: Wed Feb 7 16:39:26 2018 -0800 |
3881 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3882 | |
3883 | - Changes to common header files not applicable to open-vm-tools. |
3884 | + Common header file change not applicable to open-vm-tools. |
3885 | |
3886 | -commit 3e4091698461c0a5c36f9025410941f189c5af69 |
3887 | +commit 480dd20016ed0517b31b78735d50ee3630790e07 |
3888 | Author: Oliver Kurth <okurth@vmware.com> |
3889 | -Date: Wed Feb 7 16:39:26 2018 -0800 |
3890 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3891 | |
3892 | - Fix two comment typos in hostinfoPosix.c. |
3893 | + Add disk UUID to GuestDiskInfo |
3894 | + |
3895 | + Add UUID/Serial number to the GuestDiskInfo. |
3896 | |
3897 | -commit cf4f582e5b3c2df25aa775d77d458a15583a05ad |
3898 | +commit 119c9df55c2265460fc7eb6fad5d87226435e276 |
3899 | Author: Oliver Kurth <okurth@vmware.com> |
3900 | -Date: Wed Feb 7 16:39:26 2018 -0800 |
3901 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3902 | |
3903 | - open-vm-tools: ignore with/without gtk2/3 options when building without X |
3904 | + Linux DeployPkg should provide a configurable timeout for the spanning |
3905 | + customization process. Right now it is hard-coded to 100 seconds. |
3906 | |
3907 | - When building without X support, we should ignore the options to enable/disable |
3908 | - gtk2 and gtk3. This was reported in gthub issue |
3909 | - https://github.com/vmware/open-vm-tools/issues/228 . |
3910 | + Sources to provide "timeout" value: |
3911 | + 1. Clients such as vCenter and SRM can pack timeout value in cab header |
3912 | + via API func "DeployPkg_SetProcessTimeout(uint16 timeout)". this timeout |
3913 | + value will be implemented during the package deployment process. |
3914 | + 2. Package deployment engines: |
3915 | + - tools deployPkg plugin: |
3916 | + Add "process-timeout" in tools.conf. The tools deployPkg plugin will use |
3917 | + that value to control the time period of the package deployment. |
3918 | + - linuxDeployPkg: |
3919 | + Add "-t <timeout>" as optional argument in linuxDeployPkg |
3920 | + Usage: ./linuxDeployPkg -d <cabfile> -t <timeout> --skip-reboot |
3921 | + 3. Default value in deployPkg is 100s. If both the client and package |
3922 | + deployment engines don't provid this value, then the default value of |
3923 | + 100s will be used. |
3924 | + 4. The "timeout" value from clients will overwrite the value from the |
3925 | + deployment engines when both of them provid this value. |
3926 | |
3927 | -commit 0a099c6f4949a05d1400dc147ab68ad15ebf152a |
3928 | +commit fde5e1e4fade4bc3672a94cbae7b20d063057540 |
3929 | Author: Oliver Kurth <okurth@vmware.com> |
3930 | -Date: Wed Feb 7 16:39:26 2018 -0800 |
3931 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3932 | |
3933 | Common header file change not applicable to open-vm-tools. |
3934 | |
3935 | -commit 7be0019e01c7d473deffb8b8646fce1dff22e11a |
3936 | +commit ee25e6a05996b9beda0c07361d44d4e30fdbe3f2 |
3937 | Author: Oliver Kurth <okurth@vmware.com> |
3938 | -Date: Wed Feb 7 16:39:25 2018 -0800 |
3939 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3940 | |
3941 | - Common header file changes not applicable to open-vm-tools. |
3942 | + Common header file change not applicable to open-vm-tools. |
3943 | |
3944 | -commit f838807d08b9c4e72d4887642d4181dea25b6c35 |
3945 | +commit 4caacb6a4fba771d2d416505ec3c3014fac3cb82 |
3946 | Author: Oliver Kurth <okurth@vmware.com> |
3947 | -Date: Wed Feb 7 16:39:25 2018 -0800 |
3948 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3949 | |
3950 | - Common header file change not applicable to open-vm-tools. |
3951 | + Common source file changes not directly applicable to open-vm-tools. |
3952 | |
3953 | -commit 25d00050c8009dd74e3bbcf1883fdd408411a693 |
3954 | +commit c8fa72b1b3e3f0ecf725faf77cc747d804dc0ae1 |
3955 | Author: Oliver Kurth <okurth@vmware.com> |
3956 | -Date: Wed Feb 7 16:39:25 2018 -0800 |
3957 | +Date: Tue Feb 19 12:51:31 2019 -0800 |
3958 | |
3959 | - Common header file change not applicable to open-vm-tools. |
3960 | + Common header file change not directly applicable to open-vm-tools. |
3961 | |
3962 | -commit 6b6038522ed24ea134eb4e4a2752288f6f42fcd5 |
3963 | +commit 7d4ddf5c1a1160720f89f1a7f79fdb2f98b9b49b |
3964 | Author: Oliver Kurth <okurth@vmware.com> |
3965 | -Date: Wed Feb 7 16:39:25 2018 -0800 |
3966 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
3967 | |
3968 | - Header file change not applicable to open-vm-tools. |
3969 | + Common header file change not applicable to open-vm-toold. |
3970 | |
3971 | -commit ee4bd450c4449f8905dbca2e4759660fda5c58dc |
3972 | +commit 799401f69d0ee47d475b201254a2fa65bdfe7b81 |
3973 | Author: Oliver Kurth <okurth@vmware.com> |
3974 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
3975 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
3976 | |
3977 | - fix buffer overrun in AsyncTCPSocketConnect() |
3978 | - |
3979 | - Callers may pass a struct smaller than sockaddr_storage, but a |
3980 | - sockaddr_storage-sized chunk gets copied to asock->remoteAddr. |
3981 | - memcpy() should be used. |
3982 | - |
3983 | - One such caller is AsyncSocket_ConnectUnixDomain(). It passes sockaddr_un. |
3984 | - sizeof(sockaddr_un) == 110, sizeof(sockaddr_storage) == 128. |
3985 | - |
3986 | - Caught by AddressSanitizer. |
3987 | + Common header file change not directly applicable to open-vm-tools. |
3988 | |
3989 | -commit 13df0e2fc2f68aeab0380761eb0c5ab129730710 |
3990 | +commit 69dc92cfb5397399385e7fa67bab3ef685d51c3e |
3991 | Author: Oliver Kurth <okurth@vmware.com> |
3992 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
3993 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
3994 | |
3995 | - open-vm-tools: use pkg-config for building with icu |
3996 | + Use the LSB and os-release data to find the best guest identification |
3997 | |
3998 | - icu uses pkg-config in recent versions, and no longer ships with |
3999 | - icu-config in most recent versions. Make the configure script |
4000 | - use pkg-config for icu if available, and icu-config if not. For |
4001 | - pkg-config we need to specify 'icui18n' which returns the same result |
4002 | - as icu-config did to link with icui18n. |
4003 | + Historically, we have the LSB to describe a Linux distro. More |
4004 | + recently, the os-release standard was added. Change our guest |
4005 | + identification code to attempt to use both data - when available - and |
4006 | + make a value judgement as to which is better. |
4007 | |
4008 | -commit 3a8221c7e4b149efacf87658ac239d815c56adba |
4009 | +commit 7c4d548c5f6dfc3a0d24e11bf53c834487df9067 |
4010 | Author: Oliver Kurth <okurth@vmware.com> |
4011 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
4012 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4013 | |
4014 | - Ignore ENXIO errors with SyncDriver |
4015 | + Send diskInfo as a json document. Modernize diskInfo RPC. |
4016 | + |
4017 | +commit 6143662e1b1e89671c4b4812bdbed76d12cff14e |
4018 | +Author: Oliver Kurth <okurth@vmware.com> |
4019 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4020 | + |
4021 | + [Part 2] GuestLib support for 64bit memory shares. |
4022 | |
4023 | - A quiesced snapshot fails when the target VM has a bind mount. The |
4024 | - problem is that the syncDriver gets an ENXIO error when it tries to |
4025 | - open the mount point. To fix the problem, let the quiesce operation |
4026 | - skip a mount point when opening it results in an ENXIO error. |
4027 | + MEMSCHED_SHARES_MAX is currently set to MAX_PPN and will not fit in |
4028 | + 32-bit soon. 'memshares' property which is currently available in GuestSDK |
4029 | + is an unsigned 32bit value. Starting from ESX 7.0, this value is available |
4030 | + only if it can be fit in an unsigned 32-bit data type. |
4031 | |
4032 | - This change is based on pull request |
4033 | - https://github.com/vmware/open-vm-tools/pull/218 . |
4034 | + 'memShares64' is the new unsigned 64-bit property added in GuestSDK for the |
4035 | + memory shares. |
4036 | + |
4037 | + Added necessary APIs to retrieve the memshares64 value. The new API |
4038 | + VMGuestLib_GetMemShares64 will first try to retrieve the memShares64 property. |
4039 | + If the underlying host is an older one, then the API will return the memShares |
4040 | + property. |
4041 | + |
4042 | + Updated the vmGuestLibTest code to retrieve and print the new memShares64 value. |
4043 | |
4044 | -commit ff754c8a99bffe92b07c933898c7d9d20c02873f |
4045 | +commit b1f9a9656e20d4e6f1cb74bc07b75d936346d96a |
4046 | Author: Oliver Kurth <okurth@vmware.com> |
4047 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
4048 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4049 | |
4050 | - Refinement for memory corruption bug fix in StdIO_ReadNextLine |
4051 | + Common header file change not applicable to open-vm-tools. |
4052 | |
4053 | -commit 7b45a62730624c711fb4eb63a0bfd125a2befa57 |
4054 | +commit e639a33061a85ec70aded35429b9d634de17ac74 |
4055 | Author: Oliver Kurth <okurth@vmware.com> |
4056 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
4057 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4058 | |
4059 | - lib/file: Style clean up in the public file.h |
4060 | + Update seamless window's copyright year as 1998-2019 |
4061 | + |
4062 | + 1. Changing the COPYRIGHT_YEARS in vm_legal.h to 1998-2019 |
4063 | + 2. COPYRIGHT_YEARS is used by UTF8_COPYRIGHT_STRING_BASE and |
4064 | + UTF16_COPYRIGHT_STRING for win32 UTF-16 version. |
4065 | |
4066 | -commit 3a7dc2f92e6cb61c9ca8e57c367c972683355278 |
4067 | +commit 5260d3b532c436d2b3be825876359f9c6682578d |
4068 | Author: Oliver Kurth <okurth@vmware.com> |
4069 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
4070 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4071 | |
4072 | - Common header file changes not applicable to open-vm-tools. |
4073 | + Common header file change not applicable to open-vm-tools. |
4074 | |
4075 | -commit c52bb302a181d4bdd0b2b61d6e901339b61d2dab |
4076 | +commit bf62073f69e496a83529e6acf3b33300a50ad991 |
4077 | Author: Oliver Kurth <okurth@vmware.com> |
4078 | -Date: Tue Feb 6 16:32:40 2018 -0800 |
4079 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4080 | |
4081 | - Common header file change not applicable to open-vm-tools. |
4082 | + Common header file change not directly applicable to open-vm-tools. |
4083 | |
4084 | -commit 035765d487f8ab9b2222ad239b278e4725aa5a22 |
4085 | +commit 8c2911145026ddc7bd1fdfab97e1af3fefab5dae |
4086 | Author: Oliver Kurth <okurth@vmware.com> |
4087 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4088 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4089 | |
4090 | - Changes to common header files; not applicable to open-vm-tools. |
4091 | + Common header file change not directly applicable to open-vm-tools. |
4092 | |
4093 | -commit 3011466e0f59471292a58ba5124238898d18945a |
4094 | +commit 070ef6fd44b6a0095ec51faebf2e0c5c0151efb7 |
4095 | Author: Oliver Kurth <okurth@vmware.com> |
4096 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4097 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4098 | |
4099 | - open-vm-tools: use ENV{DEVTYPE}=="disk" in udev scsi rule |
4100 | + [Part 1] GuestLib support for 64bit memory shares. |
4101 | |
4102 | - Fix udev scsi rule to not print warnings on boot. |
4103 | - The rule now checks for the device type. The previous fix by |
4104 | - trying to check for a valid timeout field did not work as expected. |
4105 | - This change uses the rule from Mike Latimer at |
4106 | - https://github.com/vmware/open-vm-tools/pull/216 |
4107 | + MEMSCHED_SHARES_MAX is currently set to MAX_PPN and will not fit in 32-bit soon. |
4108 | + |
4109 | + Changed the datatype of 'memshares' property to uint64 for the future support. |
4110 | + |
4111 | + 'memshares' is exposed in GuestLib as unsigned 32-bit value. |
4112 | + Modified the ESX code to set this property only if the vaulue can be fit in |
4113 | + a uint32 type. Else, the value is not set and 'valid' bit set is set to FALSE. |
4114 | + |
4115 | + Added a new property "memShares64" (as uint64) in GuestLib for the new |
4116 | + 64-bit memory shares. |
4117 | + |
4118 | + This CLN implements only the necessary changes on ESX side. |
4119 | |
4120 | -commit 9da6562e0c04fa79fad726513508a628f29f4812 |
4121 | +commit f14ba86d12e158c2ad1bac2d41082054d2154127 |
4122 | Author: Oliver Kurth <okurth@vmware.com> |
4123 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4124 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4125 | |
4126 | - Common header file change not applicable to open-vm-tools. |
4127 | + Changes to common header files not applicable to open-vm-tools. |
4128 | |
4129 | -commit 6ccc073a58e1822dc4eb8c20e10dc89791643e9c |
4130 | +commit c9cf0614fdb1dd9bbea572f37c1543d8852c7f37 |
4131 | Author: Oliver Kurth <okurth@vmware.com> |
4132 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4133 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4134 | |
4135 | - Fix memory corruption bug in StdIO_ReadNextLine |
4136 | + Common header file change not applicable to open-vm-tools. |
4137 | |
4138 | -commit 4f729b61b908c82318b8dcfc16264c15b58817c8 |
4139 | +commit ba975b71a38b96f19f06ed2dc6dd37acd421e99e |
4140 | Author: Oliver Kurth <okurth@vmware.com> |
4141 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4142 | +Date: Tue Feb 19 12:51:30 2019 -0800 |
4143 | |
4144 | - Common header file changes not applicable to open-vm-tools. |
4145 | + [Asyncsocket] Avoid ASSERT failure when removing recv callback if fd has POLL_FLAG_ACCEPT_INVALID_FDS flag set. |
4146 | |
4147 | -commit 9fa726051f7efe1b7e0bab745b7bad85d1fb3efb |
4148 | +commit ec4e32afe179db8cf514177b08d9ab69696a2450 |
4149 | Author: Oliver Kurth <okurth@vmware.com> |
4150 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4151 | +Date: Tue Feb 19 12:51:29 2019 -0800 |
4152 | |
4153 | - Common header file changes not applicable to open-vm-tools. |
4154 | + Security issue with the intermediate staging directory used for DnD and CnP |
4155 | + |
4156 | + Problem: |
4157 | + /tmp/VMwareDnD is a staging directory used for DnD and CnP. It should be |
4158 | + a regular directory, but malicious code or user may create the /tmp/VMwareDnD |
4159 | + as a symbolic link which points to the home directory of the current desktop |
4160 | + user before the staging directory is created. Later when the desktop user |
4161 | + initiates a DnD or CnP operation, the permission of that user's home directory |
4162 | + will be changed allowing the malicious user full access to the desktop user's |
4163 | + home directory. |
4164 | + |
4165 | + Solution: |
4166 | + Do not set the permission of the staging directory if that directory already |
4167 | + exists and has the wrong permission. The permission of the directory will |
4168 | + be 1777 if it is created by VMTools. If that is not the case, the directory |
4169 | + has been created or modified by malicious code or user; just cancel the host |
4170 | + to guest DnD or CnP operation. |
4171 | |
4172 | -commit 378c193d4a57cfed14045ffed6ea641957ed18c7 |
4173 | +commit 1a39495618c1573c0fb16dd15368d0f2e606372c |
4174 | Author: Oliver Kurth <okurth@vmware.com> |
4175 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4176 | +Date: Wed Jan 16 14:53:06 2019 -0800 |
4177 | |
4178 | Common header file change not applicable to open-vm-tools. |
4179 | |
4180 | -commit ba83dcff6214190f8ed545401f2bfa27650bbf07 |
4181 | +commit 4b9d0560bbeb50a395ffcfa7f1114d0c0246f207 |
4182 | Author: Oliver Kurth <okurth@vmware.com> |
4183 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4184 | +Date: Wed Jan 16 14:53:06 2019 -0800 |
4185 | |
4186 | - Common header file change not directly applicable to open-vm-tools. |
4187 | + Add WarningToHost() and WarningToGuest() functions |
4188 | + |
4189 | + This change is needed to address the privacy and security changes that |
4190 | + are required so that vmware library warnings can be forwarded to the |
4191 | + host side selectively. |
4192 | + |
4193 | + For instance, if a warning message is sent to VMX, the user name must be |
4194 | + stripped from the message. |
4195 | |
4196 | -commit fc922804318de417578fd08fab2e07c1d58e8de8 |
4197 | +commit f16f911678e8075ba8422de3f2b70de9a7859974 |
4198 | Author: Oliver Kurth <okurth@vmware.com> |
4199 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4200 | +Date: Wed Jan 16 14:53:05 2019 -0800 |
4201 | |
4202 | - Update copyright year to 2018. |
4203 | + Fix CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate(). |
4204 | + |
4205 | + Red Hat ran coverity scan on open-vm-tools and found an occurrence |
4206 | + of CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate(). |
4207 | |
4208 | -commit ca39511ceb8e88254cad71e98cba5cbfff08a99d |
4209 | +commit 96da61e5aba3f97907477734b0a830a1338cd48b |
4210 | Author: Oliver Kurth <okurth@vmware.com> |
4211 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4212 | +Date: Wed Jan 16 14:53:05 2019 -0800 |
4213 | |
4214 | - UUID: Clean up UUID_PackText |
4215 | + [10.3.10] Update copyright year to 2019. |
4216 | |
4217 | - Use size_t, not int. |
4218 | + Update the copyright year to 2019 for ALL open-vm-tools destined files |
4219 | + modified since the release of 10.3.5. |
4220 | |
4221 | -commit c358e5e181b95d872da9ffcc943cc147ae0584f8 |
4222 | +commit 3f5711d996598a625252cdcc77404fbb09cbb3d0 |
4223 | Author: Oliver Kurth <okurth@vmware.com> |
4224 | -Date: Tue Feb 6 16:32:39 2018 -0800 |
4225 | +Date: Wed Jan 16 14:53:05 2019 -0800 |
4226 | |
4227 | - Changes to common header files; not applicable to open-vm-tools. |
4228 | + Bail out of vmtoolsd early when there are RPC errors. |
4229 | + |
4230 | + VMX state machine could give up quiescing operation for various |
4231 | + reasons when vmtoolsd is busy performing necessary state transitions. |
4232 | + Once VMX gives up quiescing operation, there is no point in |
4233 | + vmtoolsd continuing with it. vmtoolsd should also give up the |
4234 | + operation asap. The vmtoolsd process can detect VMX state machine |
4235 | + change when it gets errors sending VMBACKUP_PROTOCOL_EVENT_SET RPC. |
4236 | + |
4237 | + RPC errors are only used as a trigger to abort the operation. |
4238 | + We ignore the RPC errors that might occur after aborting the |
4239 | + operation. |
4240 | |
4241 | -commit 0ccc8b1a79bf76b9826c37b2133e5dbd4b9904dc |
4242 | +commit f2d053bb4b7fca870ed3e4aacc26fdd92907d008 |
4243 | Author: Oliver Kurth <okurth@vmware.com> |
4244 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4245 | +Date: Wed Jan 16 14:53:05 2019 -0800 |
4246 | |
4247 | - Common header file change not applicable to open-vm-tools. |
4248 | + Don't send a backup manifest when aborting a Linux quiesced snapshot. |
4249 | + |
4250 | + When taking a Linux quiesced snapshot, communication failures between |
4251 | + VMX and VMTools may result in VMTools sending a genericManifest event |
4252 | + message after the quiesced snapshot operation has been aborted. If |
4253 | + this happens, VMX will send an error back to VMTools, which in turn |
4254 | + causes VMTools not to send genericManifest messages on subsequent |
4255 | + quiesced snapshots even if the host supports such messages. |
4256 | + |
4257 | + One aspect of the implementation that gives rise to this behavior is |
4258 | + the use of the sync provider's snapshotDone function to undo a |
4259 | + quiescing operation. Specifically, if VMTools aborts a quiesced |
4260 | + snapshot when the file system is quiesced, the quiescing must be |
4261 | + undone. Currently, this is handled by calling the sync provider's |
4262 | + snapshotDone function. This is the same function that is called to |
4263 | + complete the quiescing snapshot protocol when it is successful. In |
4264 | + some respects this makes sense, since in either case snapshotDone |
4265 | + unquiesces the file system. However, architecturally and conceptually, |
4266 | + it seems useful to distinguish between the action to be taken in the |
4267 | + successful case versus the aborting case. It's also useful to do so |
4268 | + in practice, because the successful case sends the genericManifest |
4269 | + event to notify the host there is a backup manifest file, while the |
4270 | + aborting case should not do that. |
4271 | + |
4272 | + To address the issue, add an "undo" function for the Linux sync |
4273 | + provider. The undo function is called instead of snapshotDone as |
4274 | + part of aborting a quiesced snapshot in which the file system is |
4275 | + quiesced at the time of the abort. |
4276 | |
4277 | -commit 5c6f7b09d6865496036653360301092b8672675f |
4278 | +commit d2386efc9b8d66e44b87d21db71fb1fc39cf00f1 |
4279 | Author: Oliver Kurth <okurth@vmware.com> |
4280 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4281 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4282 | |
4283 | - guestOS identification: Tweak handling the LSB |
4284 | - |
4285 | - The multi-standard handing code dealt with the LSB strictly. This |
4286 | - causes some issues with older distros that are not LSB compliant but |
4287 | - happened to work due to a specific behavior. |
4288 | - |
4289 | - Return the LSB to "LSB and old way" and provide some specific coverage |
4290 | - of detaults to ensure coverage. |
4291 | + Common header file change not applicable to open-vm-tools. |
4292 | |
4293 | -commit 2516f528e47722faa38868d99939c825f13c2bdb |
4294 | +commit 7c7371304783928cbd8fafeae682de46a1e64b4f |
4295 | Author: Oliver Kurth <okurth@vmware.com> |
4296 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4297 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4298 | |
4299 | - Restore "ufs" to the list of known filesystems |
4300 | - |
4301 | - Removing extraneous #ifdef VMX86_TOOLS - #endif |
4302 | + Common source file change not applilcable to open-vm-tools. |
4303 | |
4304 | -commit 3c453912325ead3f19b84fced65217608069ddfa |
4305 | +commit 0ab701192d0f5cdbb38525b1cd507bc56962651d |
4306 | Author: Oliver Kurth <okurth@vmware.com> |
4307 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4308 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4309 | |
4310 | - Restore "ufs" to the list of known filesystems |
4311 | - |
4312 | - A previous change, 5074636, to remove "ufs" from the kernel also removed |
4313 | - "ufs" from the known list of Linux filesystems. As a result, the "ufs" |
4314 | - filesystems on FreeBSD and Solaris VMs cannot be seen and therefore |
4315 | - no disk information is available in vmsvc/get.guest output. |
4316 | + Common source file change not directly applicable to open-vm-tools. |
4317 | |
4318 | -commit aa6502a057aec571a72b971cb13cf0e9d713cddc |
4319 | +commit 5e957b0af978d7ba5106c1ae6a4e98e39cedd01c |
4320 | Author: Oliver Kurth <okurth@vmware.com> |
4321 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4322 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4323 | |
4324 | - Update tools copyright to 2018 |
4325 | + Common header file change not applicable to open-vm-tools. |
4326 | |
4327 | -commit 5af33281a66ebf0c30ad15074f931f33bda0bc9d |
4328 | +commit 6af2b0bb4ba3d77d94cf61643803282198c7c68e |
4329 | Author: Oliver Kurth <okurth@vmware.com> |
4330 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4331 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4332 | |
4333 | Common header file change not applicable to open-vm-tools. |
4334 | |
4335 | -commit dc028e7bbb63865e1ae1c6262872e74c47c80d61 |
4336 | +commit eed75f0ab178cceeabb761661cecaf636b595bdb |
4337 | Author: Oliver Kurth <okurth@vmware.com> |
4338 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4339 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4340 | |
4341 | - Common header file change that is not applicable to open-vm-tools. |
4342 | + Common header file change not applicable to open-vm-tools |
4343 | |
4344 | -commit d55cc529267b0b385fc9d4453075d023c789e46f |
4345 | +commit 87d1ca65dc4f0d0fa53a2fb5e1411c104aaa84d3 |
4346 | Author: Oliver Kurth <okurth@vmware.com> |
4347 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4348 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4349 | |
4350 | - Hgfs Server: replace duplicate function usage with a common function. |
4351 | - |
4352 | - This change simply replaces a duplicate function usage with a common |
4353 | - function and removes the duplicate one. |
4354 | + Common header file change not applicable to open-vm-tools. |
4355 | |
4356 | -commit ccdef7096a4782dd00b6f55695aff9c3f01cf4b5 |
4357 | +commit 51dd95f05655e6d6c84aa0622cb48aeaf2880180 |
4358 | Author: Oliver Kurth <okurth@vmware.com> |
4359 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4360 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4361 | |
4362 | - hostinfoPosix.c: Change a warning to a log message. |
4363 | + Record VMware Tools version 10.3.7 used for a patch. |
4364 | |
4365 | -commit 2321ff31fa671658ad0af3af22eef27e5d9af050 |
4366 | +commit 01d4d19cc0f638ef119fb0b23801c66acd634920 |
4367 | Author: Oliver Kurth <okurth@vmware.com> |
4368 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4369 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4370 | |
4371 | - Switch IMC to use RpcChannel_SendOne instead of deprecated RpcOut_sendOne |
4372 | - |
4373 | - Modify ./libDeployPkg/Makefile.am to build deploypkg module for |
4374 | - open-vm-tools correctlly. |
4375 | + Common header file change not applicable to open-vm-tools. |
4376 | |
4377 | -commit d9f7c825cfbe075c3b643632419ff26a72628e41 |
4378 | +commit e57c49e1a8504620acc87d5d64304d76c5cab804 |
4379 | Author: Oliver Kurth <okurth@vmware.com> |
4380 | -Date: Tue Feb 6 16:32:38 2018 -0800 |
4381 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4382 | |
4383 | - lib/file: Clean up a few things. |
4384 | + Modernize diskInfo RPC |
4385 | + |
4386 | + Rewrite diskInfo RPC to allow it to be backwards and forwards compatible. |
4387 | + step 1 -- re-org existing code. |
4388 | |
4389 | -commit b4ee6678c9dd8cdf4e144056545dd41ba0636085 |
4390 | +commit 94ba58e23bda8f2cc74041c3c9cd2e8365a1b431 |
4391 | Author: Oliver Kurth <okurth@vmware.com> |
4392 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4393 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4394 | |
4395 | - hostinfoPosix.c: Pick up some review comments |
4396 | + Common header file change not applicable to open-vm-tools. |
4397 | |
4398 | -commit ce060ca498defdf08da4fac899dc623328d47a5d |
4399 | +commit c2a852b98c01b61b0a73be2aaa77ca334e44e902 |
4400 | Author: Oliver Kurth <okurth@vmware.com> |
4401 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4402 | +Date: Wed Jan 16 14:53:04 2019 -0800 |
4403 | |
4404 | - GuestOS: Support the os-release standard |
4405 | - |
4406 | - While bringing up Amazon Linux as a guest, it was discovered that |
4407 | - Amazon Linux was not LSB compilant. The LSB standard defines a way |
4408 | - to uniquely determine which distro one is running on. Since our code |
4409 | - was based on the LSB standard, we made some changes to explicitly |
4410 | - detect Amazon Linux and handle it as a special case. |
4411 | - |
4412 | - Amazon let us know that there is a "new" standard - os-release - which |
4413 | - they are compliant with. One must explicitly install Amazon Linux in a |
4414 | - special way to obtain the LSB compliance. |
4415 | - |
4416 | - Researching the "new" standard, it turned out to not be that different |
4417 | - than the LSB standard. Further research showed that some distros (e.g. |
4418 | - Ubuntu) are releasing with both standards. |
4419 | + Special-case profile loading for StartProgram |
4420 | |
4421 | - This change refactors the existing code, removes the explicit Amazon |
4422 | - Linux checking, and accepts the os-release standard. Amazon Linux then |
4423 | - "just falls out". |
4424 | + Keep the user's profile loaded for the life of the |
4425 | + program, to avoid races where its unloaded too quickly. |
4426 | |
4427 | -commit 6bd88d82e943d691c4312e3f2e7cef1038af7a9c |
4428 | +commit 68e81d11ead52350a6be0ab383a65d2b11884345 |
4429 | Author: Oliver Kurth <okurth@vmware.com> |
4430 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4431 | +Date: Wed Jan 16 14:53:03 2019 -0800 |
4432 | |
4433 | - Reduce Vigor transport socket draining overhead |
4434 | - |
4435 | - A previous change in VigorPollImpl and asyncsocket to fix a memory |
4436 | - leak that causes a performance regression for parallel reconfiguration of |
4437 | - running VMs (the kind requiring FSR). During an FSR, the connection |
4438 | - between hostd and the source vmx would drop and hostd would then |
4439 | - reconnect to the destination vmx. One source of regression is that |
4440 | - the buffer has to be drained when a disconnect happens and the draining |
4441 | - logic may potentially unregister and re-register the recv callback |
4442 | - multiple times. This change adds an asyncsocket function specifically |
4443 | - for draining recv that reduces the manipulation of callback. It |
4444 | - reduces the regression by up to ~50% (the effect is more pronounced with |
4445 | - more VMs). |
4446 | + Switch some stringxx headers to use angle brackets instead of double quotes |
4447 | |
4448 | -commit de9b602664d91c54288b91a81f6a01d7cb927fce |
4449 | +commit ff766a3e0dae726cf1d171a150633d9e995f2c08 |
4450 | Author: Oliver Kurth <okurth@vmware.com> |
4451 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4452 | +Date: Wed Jan 16 14:53:03 2019 -0800 |
4453 | |
4454 | - atomic: add TestSetBitVector and TestClearBitVector functions |
4455 | + Code clean-up - bora-vmsoft/lib/procMgr/procMgrPosix.c |
4456 | |
4457 | - Implement atomic set/clear bit from a byte array. |
4458 | + Recent discussions about setting "errno" to ENOENT when either |
4459 | + getpwuid_r() or getpwnam_r() return 0 (success) if there is no passwd |
4460 | + entry for the user have vacillated. |
4461 | |
4462 | - Also add missing "memory" constraint to non-atomic ClearBitVector() |
4463 | - and ComplementBitVector(). |
4464 | + Since none of the current callers of the routines in procMgrPosix.c |
4465 | + query the contents of "errno", the current consensus is to simply log |
4466 | + a warning message along with reason for the failure. |
4467 | |
4468 | -commit 17e9209aeb4f6d3a3535b7064916f3a25b985395 |
4469 | +commit b2e0ca7c6a8a9fd7ad33cbc950f63c14ab205718 |
4470 | Author: Oliver Kurth <okurth@vmware.com> |
4471 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4472 | +Date: Wed Jan 16 14:53:03 2019 -0800 |
4473 | |
4474 | - Tools Hgfs Server Plugin: fix logging of client redirector handling functions |
4475 | - |
4476 | - Modify logging of client redirector handling functions for starting the client |
4477 | - redirector kernel component and reconnecting mapped drives at services start |
4478 | - up. This changes the level from warning to info as these messages are purely |
4479 | - informational and not warnings of unexpected events or conditions. |
4480 | + Common header file change not applicable to open-vm-tools. |
4481 | |
4482 | -commit 076b7201b61af9f3dcb36050ff37a8145a05d404 |
4483 | +commit 9aef5870bc7dc439bfa422662403369dfdd7f1d3 |
4484 | Author: Oliver Kurth <okurth@vmware.com> |
4485 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4486 | +Date: Wed Jan 16 14:53:03 2019 -0800 |
4487 | |
4488 | - Fix error reported by clang 6.0.0 - comparison 'int' <= 4294967295 is always true |
4489 | - |
4490 | - Fix the logical constant compare warning/error in vixTools.c of the |
4491 | - vix plugin. Rewrite the continuous for loop to simply iterate from |
4492 | - zero to MAX_INT32. |
4493 | + Common header file change not applicable to open-vm-tools. |
4494 | |
4495 | -commit 7a58576e98e5bdb47fbe101c43b106ba77f2e811 |
4496 | +commit e74e440279d402c5d81a1b6f75e0760d91c4eb88 |
4497 | Author: Oliver Kurth <okurth@vmware.com> |
4498 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4499 | +Date: Wed Jan 16 14:53:03 2019 -0800 |
4500 | |
4501 | - Add VMware Tools 10.2.5 to vm_tools_version.h |
4502 | - |
4503 | - - Add tools version 10.2.5 as the first scheduled tools 10.2.x |
4504 | - update - TOOLS_VERSION_CHAINSAW_UPDATE1 |
4505 | - - Corrected a typo in a macro name in an earlier tools version |
4506 | - definition. |
4507 | + Changes to common header files not directly appilcable to open-vm-tools. |
4508 | |
4509 | -commit 13c49b85cebacea847d30c4e5a0b92fa7ea9dba8 |
4510 | +commit f8817830c0c41c6e5f7acf77555f9b1be2677b08 |
4511 | Author: Oliver Kurth <okurth@vmware.com> |
4512 | -Date: Tue Feb 6 16:32:37 2018 -0800 |
4513 | +Date: Wed Jan 16 14:53:03 2019 -0800 |
4514 | |
4515 | - hostinfo: Identify Amazon Linux |
4516 | - |
4517 | - Amazon Linux is not LSB compliant. Add a small amount of code such that |
4518 | - Amazon Linux can differentiated from all of other Linuxen and correctly |
4519 | - report its identifying data. |
4520 | + Style: Fix parameter alignment. |
4521 | |
4522 | -commit c5bc784da611ee929e0da7c20a410e03e6540613 |
4523 | +commit 4b3f4bc4878aa9eec15d29e8a5a177186a07292c |
4524 | Author: Oliver Kurth <okurth@vmware.com> |
4525 | -Date: Fri Jan 26 15:04:36 2018 -0800 |
4526 | +Date: Wed Jan 16 14:53:02 2019 -0800 |
4527 | |
4528 | - Set X11 as the backend for gtk3 of open-vm-tools |
4529 | - |
4530 | - Open-vm-tools defaults to gtk3. For distros like Fedora 27, Wayland is |
4531 | - the default display server. With no restriction on the backend, plugins |
4532 | - will try to use Wayland as the backend of Gtk+3. As a result, |
4533 | - gdk_display_get_default() returns a Wayland display; |
4534 | - gdk_display_get_default_group() also returns a Wayland window. Applying |
4535 | - GDK_WINDOW_XID() on the Wayland window will result in the crash reported |
4536 | - on recent Linux releases that default to a Wayland display server. |
4537 | - |
4538 | - As X11-specific code is widely used in tools plugins, a migratation to |
4539 | - Wayland in the short term is not possible. So, as a compromised solution, |
4540 | - plugins can be forced to run on XWayland, which is the compatible mode |
4541 | - of Wayland for legacy X11 clients. |
4542 | - |
4543 | - gdk_set_allowed_backends() only applies when flag GTK3 is defined, and Gtk |
4544 | - version cwgreater than 3.10. |
4545 | + Changes to common header files not applicable to open-vm-tools. |
4546 | |
4547 | -commit 98e0ab52c86b3a1d4fd38cec6913b1f5ba0f336c |
4548 | +commit e5f79d1591677fd83173203e552e5a495109137f |
4549 | Author: Oliver Kurth <okurth@vmware.com> |
4550 | -Date: Fri Jan 26 15:04:36 2018 -0800 |
4551 | +Date: Tue Dec 18 14:12:19 2018 -0800 |
4552 | |
4553 | - hostinfo: More cleanup |
4554 | - |
4555 | - Continue the prep for Amazon Linux. |
4556 | + Updates to the DeployPkg guest customization source code. |
4557 | |
4558 | -commit ce769ae4aa3a14810b418c044629f2d9dcb72a37 |
4559 | +commit 401cf6d23667a66cd8f5ed5b5d6644305cb9180c |
4560 | Author: Oliver Kurth <okurth@vmware.com> |
4561 | -Date: Fri Jan 26 15:04:36 2018 -0800 |
4562 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4563 | |
4564 | - hostinfo: More prep work for Amazon Linux support |
4565 | - |
4566 | - Amazon Linux is not LSB compliant but it does have a file that is |
4567 | - much like an LSB compliant release (name=value pairs). Make the names |
4568 | - of the structures generic... the logic can be reused for Amazon Linux |
4569 | - in a follow up change. |
4570 | - |
4571 | - Fix up some function headers. |
4572 | + Changes to common header files; not applicable to open-vm-tools. |
4573 | |
4574 | -commit 7fce1b8f9ec60c27865717f536a4e440587500ad |
4575 | +commit 78c8c4c2e83a6d24e0302e55f21912d7ebee9a2e |
4576 | Author: Oliver Kurth <okurth@vmware.com> |
4577 | -Date: Fri Jan 26 15:04:36 2018 -0800 |
4578 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4579 | |
4580 | - Refactor HostinfoOSData... |
4581 | + Changes to common header files not applicable to open-vm-tools. |
4582 | + |
4583 | +commit 6c3d03d6ef32edffa882ce1816f344f4e1db4d8a |
4584 | +Author: Oliver Kurth <okurth@vmware.com> |
4585 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4586 | + |
4587 | + Header file guestcust-events.h moved to a new location. |
4588 | + |
4589 | +commit dafeb935f81a7c10946f359b0753de2ea74befda |
4590 | +Author: Oliver Kurth <okurth@vmware.com> |
4591 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4592 | + |
4593 | + Common header file change not applicable to open-vm-tools. |
4594 | + |
4595 | +commit 6009a6c1d3c7e72880541b0e4ca2a39e09e6d4e3 |
4596 | +Author: Oliver Kurth <okurth@vmware.com> |
4597 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4598 | + |
4599 | + General code clean-up. |
4600 | |
4601 | - Refactor the HostinfoOsData in several smaller and simpler routines. |
4602 | - This will make it easier to maintain in the future (it was pretty |
4603 | - unwieldy already) and easier to add the logic for a non-LSB Linux. |
4604 | + bora/lib/misc/posixPosix.c: |
4605 | + Treat local variables "len" consistently as "size_t" type in |
4606 | + Posix_Getmntent_r() |
4607 | |
4608 | - More refactoring and actually adding the Amazon recognition code will |
4609 | - follow. |
4610 | + bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c: |
4611 | + Improve readability of error handling logic in ShrinkDoWipeAndShrink() |
4612 | + and remove another line of dead code. |
4613 | |
4614 | -commit b2b71c7995f4389cd7a9899dca8aa29bd9fa9c6a |
4615 | +commit a2ecb98683ee8edabddd47cfdd4bf37eb043cc17 |
4616 | Author: Oliver Kurth <okurth@vmware.com> |
4617 | -Date: Fri Jan 26 15:04:36 2018 -0800 |
4618 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4619 | |
4620 | Common header file change not applicable to open-vm-tools. |
4621 | |
4622 | -commit 40bcee40c892cc7de92825cce1226576d6eab66c |
4623 | +commit 767aaab78492854f178ebc7b16f0bf34b71c832b |
4624 | Author: Oliver Kurth <okurth@vmware.com> |
4625 | -Date: Fri Jan 26 15:04:35 2018 -0800 |
4626 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4627 | |
4628 | - Changes to common source files: |
4629 | - |
4630 | - lib/asyncsocket/asyncsocket.c: Use ASSERT instead of VERIFY when removings |
4631 | - poll callback in AsyncSocketCancelRecv. |
4632 | - lib/include/vm_product_versions.h: Change not applicable to open-vm-tools. |
4633 | + Record VMware Tools version 10.3.10 as TOOLS_VERSION_JACKHAMMER_UPDATE2 |
4634 | |
4635 | -commit 757833d601541e9bde24571fa22e669900e98a7e |
4636 | +commit 3b40e2629e84abf2c3176264142fae54ac4431f0 |
4637 | Author: Oliver Kurth <okurth@vmware.com> |
4638 | -Date: Fri Jan 26 15:04:35 2018 -0800 |
4639 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4640 | |
4641 | - Change the glibc constraint to 2.11 from 2.12. |
4642 | + Back out previous change to plugins/vix/vixTools.c. |
4643 | |
4644 | - Earlier, we made a change to stop building open-vm-tools |
4645 | - for LINUX systems with glibc < 2.12 But SLES 11 SP4 which is |
4646 | - supported comes with glibc 2.11.3 The check will |
4647 | - block SLES 11 SP4 from moving to OVT 10.2.x To fix it, this change |
4648 | - relaxes the glibc constraint to 2.11. |
4649 | + Too many subtle issues to trust this one without more testing. |
4650 | |
4651 | -commit 75825dcc7548d779f23c4c93429736d690d86a45 |
4652 | +commit 601b399538796cc1692c65f30686140c20b0ba33 |
4653 | Author: Oliver Kurth <okurth@vmware.com> |
4654 | -Date: Fri Jan 26 15:04:35 2018 -0800 |
4655 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4656 | |
4657 | - Hgfs: remove Hgfs VMCI transport header from linux open-vm-tools |
4658 | + Cleanup -Wno-incompatible-pointer-types-discards-qualifiers |
4659 | |
4660 | - Linux Hgfs clients do not use the VMCI module for a transport and have |
4661 | - since migrated to a FUSE implementation. Therefore we do not need to |
4662 | - include the Hgfs VMCI transport header file. |
4663 | - |
4664 | -commit 09b6621863ece170e4fc6b617f0bc1e3d17867f2 |
4665 | -Author: Oliver Kurth <okurth@vmware.com> |
4666 | -Date: Fri Jan 26 15:04:35 2018 -0800 |
4667 | - |
4668 | - Hgfs Server: fix error result for new dir creation in the virtual folder |
4669 | + Details |
4670 | |
4671 | - The Hgfs server code detects when a client tries to create a new folder in the |
4672 | - virtual folder containing the VMware Shares. This is not allowed as only the |
4673 | - host can add new Shares which appears in this folder. The current error code |
4674 | - returned to the client in these cases is access denied. This is only correct |
4675 | - when the new folder does not collide with an existing share. This stops clients |
4676 | - treating the virtual folder as a regular read/write physical folder. However, |
4677 | - for the case where the name collides, the access denied error is not correct, |
4678 | - as it does not tell the client the folder already exists. This causes some |
4679 | - applications to fail as they expect to see this error if the path component |
4680 | - exists as that is okay and expected. At this point the application will continue |
4681 | - to traverse the path and ensure the next component exists or if not create that. |
4682 | + Both gcc and clang (on Mac) warn for pointer-incompatible |
4683 | + assignments. It appears that gcc's -Wwarn-strings isn't working |
4684 | + properly, because it produces no warnings for the following |
4685 | + assignment: |
4686 | |
4687 | - To ensure that applications don't prematurely fail and can test that the share |
4688 | - still exists in the path the Hgfs server should return HGFS_ERROR_FILE_EXIST |
4689 | - and leave HGFS_ERROR_ACCESS_DENIED for all other cases. |
4690 | - |
4691 | -commit fb3630fb0d7846b9f06f0c506c38eadf0cfbfa81 |
4692 | -Author: Oliver Kurth <okurth@vmware.com> |
4693 | -Date: Fri Jan 26 15:04:35 2018 -0800 |
4694 | - |
4695 | - Hgfs: get rid of vmware_pack_begin and vmware_pack_end header files |
4696 | + char *potentialSegV = ".rodata-based string"; |
4697 | |
4698 | - Get rid of vmware_pack_begin and vmware_pack_end header files and |
4699 | - replace with the pragma pack and pop. This code currently only |
4700 | - affects Windows clients and the VMX HGFS VMCI transport. |
4701 | - |
4702 | -commit f7c551253400e7f153cc696b5b121cd6e0d4ebd8 |
4703 | -Author: Oliver Kurth <okurth@vmware.com> |
4704 | -Date: Fri Jan 26 15:04:35 2018 -0800 |
4705 | - |
4706 | - GOSTable: Amazon Linux 2 |
4707 | + However, clang does. |
4708 | |
4709 | - Add the basic support for Amazon Linux 2. The distro identification |
4710 | - code will follow in a separate change. |
4711 | + This change addresses three problems in bora/lib that produce build |
4712 | + failures when -Wincompatible-pointer-types-discards-qualifiers is |
4713 | + enabled when using clang (one wonders how many other such potential |
4714 | + problems exist?) |
4715 | + |
4716 | + o bsd_vsnprintf.c |
4717 | + |
4718 | + The 'cp' pointer is assigned the address of a constant string. |
4719 | + Since there are writes through 'cp', the quickest solution is to |
4720 | + declare a local, non-const, array variable that holds the string |
4721 | + "(null)". |
4722 | + |
4723 | + o unicodeSimpleTypes.c |
4724 | + |
4725 | + This change, the easiest of the three, marks the 'char *' field as |
4726 | + 'const'. |
4727 | |
4728 | -commit c8f7c09d106884c19100077fdffe8f11b80d6bdb |
4729 | +commit 07877933b3b2890f1111d07c92cff54e839ff8c6 |
4730 | Author: Oliver Kurth <okurth@vmware.com> |
4731 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4732 | +Date: Tue Dec 18 13:19:48 2018 -0800 |
4733 | |
4734 | - Changes to common header files not applicable to open-vm-tools |
4735 | + Common header file change not applicable to open-vm-tools. |
4736 | |
4737 | -commit 5939eaefbad529e811c64b46d93ddcce56615db8 |
4738 | +commit 8b5f6fa802d60aa8bb1855843b395c3851363cce |
4739 | Author: Oliver Kurth <okurth@vmware.com> |
4740 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4741 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4742 | |
4743 | - Common header file change not applicable to open-vm-tools |
4744 | + Backout previous change to vm_basic_asm.h; not applicable to open-vm-tools. |
4745 | |
4746 | -commit 55f323265bb7aee605a40f289f9c1a8ba7be56c6 |
4747 | +commit d8e831e22912d7f2a285c16af1824dafc072cd3a |
4748 | Author: Oliver Kurth <okurth@vmware.com> |
4749 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4750 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4751 | |
4752 | - Common header file change not applicable to open-vm-tools |
4753 | + Common header file change not applicable to open-vm-tools. |
4754 | |
4755 | -commit d42e5bf76689c820dfb84d681c007c96197f6182 |
4756 | +commit 05209f64dcc5eb253b18b3969582749039a835c5 |
4757 | Author: Oliver Kurth <okurth@vmware.com> |
4758 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4759 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4760 | |
4761 | Common header file change not applicable to open-vm-tools. |
4762 | |
4763 | -commit 90819beef53238ba108be35cba93329b9d160de7 |
4764 | +commit 3fef292a16fd27c83e3dd690e3a2a3bc5e74f2b1 |
4765 | Author: Oliver Kurth <okurth@vmware.com> |
4766 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4767 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4768 | |
4769 | - Get rid of convertutf and bsd_printf for all non-Win VMware Tools |
4770 | - |
4771 | - The MsgFmt_* functions are referenced in a few utilities |
4772 | - related to VMware Tools. This change replaces the MsgFmt_* |
4773 | - with a stub. This also affects the Windows version. |
4774 | + Revert previous change to vmci_sockets.h. |
4775 | |
4776 | -commit e5e478d46f047aa8f22b427b9d4505581af9915a |
4777 | +commit f91f7355619ad0ed7afcbe0b7161be3680b88688 |
4778 | Author: Oliver Kurth <okurth@vmware.com> |
4779 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4780 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4781 | |
4782 | - Fix the SSL/AsyncSocket "SSL_shutdown:shutdown while in init" problem |
4783 | + Fix NULL pointer dereference and remove three lines of dead code. |
4784 | |
4785 | - QE regression tests have caught a bug in the bora SSL/AsyncSocket |
4786 | - layer. A normal SSL connection could be abnormally terminated by some |
4787 | - other random connections. |
4788 | + QbitLogic has run [Code]Ai on the open-vm-tools source code and |
4789 | + and notified VMware of a potential NULL pointer reference and four |
4790 | + pieces of dead code. |
4791 | |
4792 | - Seems a common bug of the SSL usage according to the link below. |
4793 | - VMware is not the first one to hit it. :-) |
4794 | - https://marc.info/?l=openssl-users&w=4&r=1&s=shutdown+while+in+init&q=b |
4795 | + See https://github.com/vmware/open-vm-tools/pull/247 |
4796 | |
4797 | - The cause is that the SSL error queue was not cleared before |
4798 | - calling the SSL IO functions like SSL_write,read,connect,accept. |
4799 | - Refer to the man page of SSL_get_error, Paragraph 2 of the Description. |
4800 | - Fixed the problem by adding addtional call to clear the error queue. |
4801 | + bora-vmsoft/services/vmtoolsd/pluginMgr.c |
4802 | + The proposed fix conditionally emitted a log message. That fix has |
4803 | + been reworked to consistently emit a log message with conditional |
4804 | + content. |
4805 | |
4806 | - Found another problem that the system error is not preserved between |
4807 | - where it is set after the SSL IO call and the use of it to determine |
4808 | - whether to retry the SSL IO. This is probably due to tools has its |
4809 | - own logging which does not preserve the system error number. |
4810 | - Fixed the logging. |
4811 | + bora/lib/misc/posixPosix.c |
4812 | + bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c |
4813 | + Remove one line of dead code from each source file. |
4814 | + |
4815 | + bora-vmsoft/lib/procMgr/procMgrPosix.c: |
4816 | + Suggested dead code fix actually pointed to a bug where errno |
4817 | + was not getting updated as intended. |
4818 | + |
4819 | + bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c: |
4820 | + Suggested dead code is no longer dead; change not applicable. |
4821 | |
4822 | -commit 8a9c43698ebcc858314ec1c041d24b8e8d1372cf |
4823 | +commit bbcb8a46876352e120d22ee07bae26be29ec27c3 |
4824 | Author: Oliver Kurth <okurth@vmware.com> |
4825 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4826 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4827 | |
4828 | - vm_basic_types.h: use stdint.h a little more. |
4829 | - |
4830 | - Now that enough of the builds are C++11, let's make the common case |
4831 | - use the <stdint.h> header to define the intNN types directly |
4832 | - from language-standard intNN_t types, and treat pre-C99/C++98 |
4833 | - code as the special case. |
4834 | - |
4835 | - This also provides some clarity about the last __STRICT_ANSI__ |
4836 | - macros in this file. One was related to usage of 'long long' in |
4837 | - strict c90 mode and has been replaced with a comment indicating that |
4838 | - 64-bit-variable compiler extensions are mandatory (strict c90 mode is |
4839 | - not allowed via the headers). The other related to X11 headers; those |
4840 | - headers have been examined to understand the workarounds needed and |
4841 | - the exact scenario(s) that are problematic have been commented (turns |
4842 | - out FreeBSD had nothing to do with the problem). |
4843 | - |
4844 | - Finally, all the Bool-related definitions have been moved and merged |
4845 | - to a single location NOT at the top of the file. |
4846 | - |
4847 | - Net effects of this change: |
4848 | - - non-linux C++11 (so Windows+Mac) now uses stdint.h |
4849 | - - exact set of macros involved in declaring Bool is reduced |
4850 | - - compiling with c90 mode really will break now (use gnu90 instead). |
4851 | + Remove erroneous defines of __FreeBSD__ & __VMKTCPIP__ from vmci_sockets.h |
4852 | |
4853 | -commit 2674b02449875b04889be00400f52351105ab25f |
4854 | +commit 56d568396910f2af7408517b75b0a6e387bf69ef |
4855 | Author: Oliver Kurth <okurth@vmware.com> |
4856 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4857 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4858 | |
4859 | - Consume vmx headear files in bora tree instead of gosc's own copy |
4860 | - |
4861 | - 1. Consuming header files from bora/vmx instead of gosc/vmx |
4862 | - 2. Deprecated "gosc/vmx/public/toolsdDeployPkg.h", |
4863 | - use "bora/guestABI/include/vmware/guestrpc/deploypkg.h" instead. |
4864 | - Combined macro definition to the new header file and modified |
4865 | - reference accordingly. |
4866 | - 3. Modified makefile for open-vm-tools to consume new header file, |
4867 | - removed old header file staging in open-vm-tools.stage |
4868 | + Add VMware Tools version 10.3.6 to vm_tools_version.h |
4869 | |
4870 | -commit bd018012a08579e89209e23b69963937210e5182 |
4871 | +commit e843a034b7ea9e32959512d39ca1d046968c575e |
4872 | Author: Oliver Kurth <okurth@vmware.com> |
4873 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4874 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4875 | |
4876 | - Common header file change not applicable to open-vm-tools |
4877 | + Common header file change not applicable to open-vm-tools. |
4878 | |
4879 | -commit 36929119b9e28df8e267c49b5661354253439215 |
4880 | +commit f32fde16f226a67b42fe095aea33bf7b5e8040c0 |
4881 | Author: Oliver Kurth <okurth@vmware.com> |
4882 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4883 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4884 | |
4885 | - Remove some __STRICT_ANSI__ guards in vm_basic_types.h |
4886 | + special case profile loading for StartProgram |
4887 | |
4888 | - Some time in the distant past, these guards were needed to |
4889 | - work around... something. (Probably, it was that 'long long' |
4890 | - is not a valid type in strict c90 mode). Note that we don't |
4891 | - use c90 mode, we only use gnu90 or c99. |
4892 | - |
4893 | - This ends up being relevant because for C++ we are indeed |
4894 | - using -std=c++11 (which implies __STRICT_ANSI__). The Linux/C++ |
4895 | - section of this file thus had duplicate definitions (which I am |
4896 | - now removing) to work around the gap. |
4897 | + For StartProgram, we need to be sure there's no race in the profile |
4898 | + unloading. So keep it open through the life of the started program. |
4899 | |
4900 | - Quick cheat sheet for -std= values: |
4901 | - - c90 := __STRICT_ANSI__, no long long type |
4902 | - - gnu90 := c90 + gcc extensions, has long long type |
4903 | - - c99 := __STRICT_ANSI__, has long long type (defined in c99) |
4904 | - - c++11 := __STRICT_ANSI__, has long long type (defined in C++11) |
4905 | + See related vgauth change. |
4906 | |
4907 | -commit 6b1ef0ef99f34011da3f5383414eeedf81c59d3b |
4908 | +commit 150483202fdd5b3c447e4547bee00d18b918bb31 |
4909 | Author: Oliver Kurth <okurth@vmware.com> |
4910 | -Date: Fri Jan 5 14:47:15 2018 -0800 |
4911 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4912 | |
4913 | - open-vm-tools: fix finding C++ compiler for cross-compiling |
4914 | - |
4915 | - Patch contributed by Andrew Stormont (andy-js) on github: |
4916 | - https://github.com/vmware/open-vm-tools/pull/206 and |
4917 | - https://github.com/vmware/open-vm-tools/issues/92. |
4918 | + Common header file change not applicable to open-vm-tools |
4919 | |
4920 | -commit df18c2c2c3e7dde4478ee68a5f4a96600a3d07a2 |
4921 | +commit 1997a49deaed475d44ef4eece6c592e51115a8b0 |
4922 | Author: Oliver Kurth <okurth@vmware.com> |
4923 | -Date: Fri Jan 5 14:47:14 2018 -0800 |
4924 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4925 | |
4926 | - Allow copying of object policy within the same container |
4927 | - |
4928 | - ObjLib_CloneExtParams is currently not allowing copying of policy from |
4929 | - parent to child/clone object on VSAN. This is because the copy policy |
4930 | - check is based on unique filesystem ID, which will be different for |
4931 | - parent and child on VSAN because they will mostly be created on same |
4932 | - container but different namespace. This change uses VCFS root instead |
4933 | - of namespace UUID to make the comparison on VSAN. |
4934 | + Fix the issue that Deploypkg log files of linux should not be world readable. |
4935 | + |
4936 | +commit f16590d1b721112f7841283ed03912c3837f120d |
4937 | +Author: Oliver Kurth <okurth@vmware.com> |
4938 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4939 | + |
4940 | + lib/file: Memory leak in File_ListDirectory when directory is empty |
4941 | |
4942 | - Bonus fix: File_FullPath is now fixed to work for any combination of |
4943 | - ancestor path being present. Currently it only works if either the |
4944 | - given path exists, or when only the last component of the path does |
4945 | - not exist. And since this fix relies on finding the VCFS root of both |
4946 | - parent and child (parent is present but child is not), |
4947 | - ObjLibPathToVCFSRoot has been modified to rely on File_FullPath in |
4948 | - addition to Util_GetCanonicalPath if the path does not exist. |
4949 | + If the directory is empty, calloc of zero still succeeds and a memory |
4950 | + leak results. |
4951 | |
4952 | -commit a678f3ea9f6de366b3b3de2f99956d93d2216b08 |
4953 | +commit 1a685809609906464f90f2a2a2e2c5299bb8cb4e |
4954 | Author: Oliver Kurth <okurth@vmware.com> |
4955 | -Date: Fri Jan 5 14:47:14 2018 -0800 |
4956 | +Date: Tue Dec 18 13:19:47 2018 -0800 |
4957 | |
4958 | - Correction to previous change for Solaris11_64 GOS. |
4959 | + Common header file change not applicable to open-vm-tools. |
4960 | |
4961 | -commit 74eb0c942f78f775c9de2bfd0e4f9970a8cded51 |
4962 | +commit e03c5b88c6e42a3bf395ad647544ae113e83779c |
4963 | Author: Oliver Kurth <okurth@vmware.com> |
4964 | -Date: Fri Jan 5 14:47:14 2018 -0800 |
4965 | +Date: Tue Dec 18 13:19:46 2018 -0800 |
4966 | |
4967 | - Properly classify Solaris 11-64 as 64-bit |
4968 | + Changes to common source files not applicable to open-vm-tools. |
4969 | |
4970 | -commit 47e604c2dba131c13300fe15bf4ad69d5b996674 |
4971 | +commit 74561dc19faf9a44fffc0676c27c16176b35d3af |
4972 | Author: Oliver Kurth <okurth@vmware.com> |
4973 | -Date: Mon Dec 4 16:27:21 2017 -0800 |
4974 | +Date: Tue Dec 18 13:19:46 2018 -0800 |
4975 | |
4976 | - Common header file change; not applicable to open-vm-tools. |
4977 | + lib/file: Improve File_ListDirectory and File_WalkDirectory* |
4978 | + |
4979 | + The File_WalkDirectory implementation has an initial latency (before |
4980 | + file names are available) that is unnecessary. Using the unicode |
4981 | + library, when not necessary, adds a huge amount of memory usage and |
4982 | + wastes CPU time. |
4983 | + |
4984 | + These routines duplicate quite a bit of code. |
4985 | + |
4986 | + Rewrite File_ListDirectory to use File_WalkDirectory*. |
4987 | + |
4988 | + Rewrite File_WalkDirectory*: |
4989 | + - Return files as they are discovered, not after the entire directory |
4990 | + contents are parsed. If one decides to stop early, they don't have |
4991 | + to pay the price for the entire directory contents. |
4992 | + - Preserve the protection from duplicate file names. While Windows |
4993 | + locks a directory during a content tranverse, POSIXen does nott. Code |
4994 | + is here in the lib/file for quite some time so that the numerous |
4995 | + callers do not have to handle dealing with dups. |
4996 | + - Avoid using the unicode library on platforms where we can, this avoid |
4997 | + most of the eggregious memory usage. |
4998 | + - Don't use Dynbuf... Handling things directly is more efficient. |
4999 | |
5000 | -commit 584aa9f307c85b07fa8adaf113e87cc3c200cca9 |
The diff has been truncated for viewing.
PPA: https:/ /launchpad. net/~paelzer/ +archive/ ubuntu/ bug-1844834- open-vm- tools-11- sru