Merge ~paelzer/ubuntu/+source/open-vm-tools:merge-10.3.5-1-disco into ubuntu/+source/open-vm-tools:debian/sid

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: 1352d4fbda8d79f2c58c010002f2d50fd4dde580
Proposed branch: ~paelzer/ubuntu/+source/open-vm-tools:merge-10.3.5-1-disco
Merge into: ubuntu/+source/open-vm-tools:debian/sid
Diff against target: 146 lines (+90/-1)
4 files modified
debian/changelog (+85/-0)
debian/control (+2/-1)
debian/open-vm-tools.service (+1/-0)
debian/open-vm-tools.vgauth.service (+2/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+359184@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Tags for easier review pushed:
To ssh://git.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools
 * [new tag] lp1804625/deconstruct/2%10.3.0-0ubuntu4 -> lp1804625/deconstruct/2%10.3.0-0ubuntu4
 * [new tag] lp1804625/logical/2%10.3.0-0ubuntu4 -> lp1804625/logical/2%10.3.0-0ubuntu4
 * [new tag] lp1804625/new/debian -> lp1804625/new/debian
 * [new tag] lp1804625/old/debian -> lp1804625/old/debian
 * [new tag] lp1804625/old/ubuntu -> lp1804625/old/ubuntu
 * [new tag] lp1804625/reconstruct/2%10.3.0-0ubuntu4 -> lp1804625/reconstruct/2%10.3.0-0ubuntu4

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Test builds completed

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

If one can please review the merge as-is, but consider the grain of salt that the fix for bug 1804287 is not yet final (see bug).

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The services still work on a vsphere guest after upgrades.
I'll ask vmware for verification AFTER we have sorted our bug 1804287 to avoid having to do it twice after we dropped/changed that preliminary fix.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

- reconstruct ok
- logical ok
- logical applied on top of new/debian (everything dropped) ok
- new changes: awaiting upstream comments on #1804287

+1 pending testing of the added changes and discussion with cloud-init

review: Approve
Revision history for this message
Scott Moser (smoser) :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

We uncoupled 1804287 from the merge for now, that makes it a sync.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This one can be considered "merged" and the follow on fix will be a new MP soon.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f878e2e..4ceea77 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,26 @@
6+open-vm-tools (2:10.3.5-1ubuntu1) disco; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1804625). No Remaining changes.
9+ * Dropped Changes (upstream now):
10+ - d/p/lp-1793219-fix-stats-overflow.patch: fix potential overflow of 32
11+ bit /proc values (LP: 1793219)
12+ - d/p/ubuntu/lp-1791220-Disable-hgfsServer-not-VMware.patch: avoid
13+ crashing with segfaults when force starting the service in non VMWare
14+ environments. (LP: 1791220)
15+ * Dropped Changes (in Debian now):
16+ - Disable PrivateTmp for the open-vm-tools.service as it triggers issues
17+ when triggering processes that need tmp through VMOMI API (LP: 1758428)
18+ - d/p/debian/enable_vmhgfs-fuse_by_default: update to match changes in 10.3
19+ * Added Changes:
20+ - ensure VGAuthService is in time for cases like Site Recovery Manager
21+ failover (LP: #1804287)
22+ + d/open-vm-tools.service: be After=vgauth.service
23+ + d/open-vm-tools.vgauth.service: since this is before
24+ open-vm-tools.service now it also needs to drop DefaultDependencies=No
25+ to have cloud init configure data early enough.
26+
27+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 22 Nov 2018 11:04:26 +0100
28+
29 open-vm-tools (2:10.3.5-1) unstable; urgency=medium
30
31 * [7061cb7] Update upstream source from tag 'upstream/10.3.5'
32@@ -20,6 +43,46 @@ open-vm-tools (2:10.3.0-1) unstable; urgency=medium
33
34 -- Bernd Zeimetz <bzed@debian.org> Tue, 07 Aug 2018 23:41:00 +0200
35
36+open-vm-tools (2:10.3.0-0ubuntu4) disco; urgency=medium
37+
38+ * No-change rebuild for icu soname changes.
39+
40+ -- Matthias Klose <doko@ubuntu.com> Tue, 13 Nov 2018 08:16:01 +0000
41+
42+open-vm-tools (2:10.3.0-0ubuntu3) cosmic; urgency=medium
43+
44+ * d/p/lp-1793219-fix-stats-overflow.patch: fix potential overflow of 32 bit
45+ /proc values (LP: #1793219)
46+
47+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Mon, 24 Sep 2018 11:21:11 +0200
48+
49+open-vm-tools (2:10.3.0-0ubuntu2) cosmic; urgency=medium
50+
51+ * d/p/ubuntu/lp-1791220-Disable-hgfsServer-not-VMware.patch: avoid crashing
52+ with segfaults when force starting the service in non VMWare environments.
53+ (LP: #1791220)
54+ * d/p/debian/scsi-udev-rule: fix applying of the scsi timeout (LP: #1790145)
55+ - revert "update to match changes in 10.3 (DEVTYPE checkadded upstream)"
56+ - refresh patch context to match upstream version 10.3
57+
58+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Mon, 10 Sep 2018 09:33:13 +0200
59+
60+open-vm-tools (2:10.3.0-0ubuntu1) cosmic; urgency=medium
61+
62+ * Merge with Upstream Tag stable-10.3.0 (LP: #1784638) from
63+ https://github.com/vmware/open-vm-tools/releases/tag/stable-10.3.0
64+ Remaining changes:
65+ - Disable PrivateTmp for the open-vm-tools.service as it triggers issues
66+ when triggering processes that need tmp through VMOMI API (LP: 1758428)
67+ * Added changes:
68+ - d/p/debian/enable_vmhgfs-fuse_by_default: update to match changes in 10.3
69+ (Upstream changed the entry level from 4.0 to 3.10 - could be dropped,
70+ but stay close to what Debian has for now)
71+ - d/p/debian/scsi-udev-rule: update to match changes in 10.3 (DEVTYPE check
72+ added upstream)
73+
74+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 01 Aug 2018 08:16:10 +0200
75+
76 open-vm-tools (2:10.2.5-1) unstable; urgency=medium
77
78 * [ea03a58] Update upstream source from tag 'upstream/10.2.5'
79@@ -29,6 +92,28 @@ open-vm-tools (2:10.2.5-1) unstable; urgency=medium
80
81 -- Bernd Zeimetz <bzed@debian.org> Fri, 06 Apr 2018 11:18:50 +0200
82
83+open-vm-tools (2:10.2.0-3ubuntu3) bionic; urgency=medium
84+
85+ * Disable PrivateTmp for the open-vm-tools.service as it triggers issues
86+ when triggering processes that need tmp through VMOMI API (LP: #1758428)
87+
88+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 19 Apr 2018 11:23:58 +0200
89+
90+open-vm-tools (2:10.2.0-3ubuntu2) bionic; urgency=medium
91+
92+ * Revert change in d/open-vm-tools.service that added After=local-fs.target.
93+ It turned out that the systemd in bionic already implicitly fixes
94+ this issue (the change is still needed for backports) (LP: 1750780)
95+
96+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 27 Feb 2018 08:03:13 +0100
97+
98+open-vm-tools (2:10.2.0-3ubuntu1) bionic; urgency=medium
99+
100+ * d/open-vm-tools.service: Add After=local-fs.target dependency ensuring
101+ filesystems are ready to fix a race on startup (LP: #1750780)
102+
103+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 22 Feb 2018 08:39:26 +0100
104+
105 open-vm-tools (2:10.2.0-3) unstable; urgency=medium
106
107 * [47e50a1] Fix debhelper dep for backports
108diff --git a/debian/control b/debian/control
109index 2a5b977..15b060b 100644
110--- a/debian/control
111+++ b/debian/control
112@@ -1,7 +1,8 @@
113 Source: open-vm-tools
114 Section: admin
115 Priority: extra
116-Maintainer: Bernd Zeimetz <bzed@debian.org>
117+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
118+XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org>
119 Build-Depends:
120 debhelper (>= 11~), autotools-dev, doxygen, libcunit1-dev,
121 libdumbnet-dev, libfuse-dev, libgtkmm-3.0-dev, libgtk-3-dev,
122diff --git a/debian/open-vm-tools.service b/debian/open-vm-tools.service
123index a50db06..e9630db 100644
124--- a/debian/open-vm-tools.service
125+++ b/debian/open-vm-tools.service
126@@ -4,6 +4,7 @@ Documentation=http://open-vm-tools.sourceforge.net/about.php
127 ConditionVirtualization=vmware
128 DefaultDependencies=no
129 Before=cloud-init-local.service
130+After=vgauth.service
131 RequiresMountsFor=/tmp
132
133 [Service]
134diff --git a/debian/open-vm-tools.vgauth.service b/debian/open-vm-tools.vgauth.service
135index 94f7c89..2d843e9 100644
136--- a/debian/open-vm-tools.vgauth.service
137+++ b/debian/open-vm-tools.vgauth.service
138@@ -3,6 +3,8 @@ Description=Authentication service for virtual machines hosted on VMware
139 Documentation=http://github.com/vmware/open-vm-tools
140 ConditionVirtualization=vmware
141 PartOf=open-vm-tools.service
142+DefaultDependencies=no
143+RequiresMountsFor=/tmp
144
145 [Service]
146 ExecStart=/usr/bin/VGAuthService

Subscribers

People subscribed via source and target branches