Merge ~paelzer/ubuntu/+source/nova:fix-libvirt-dependency into ~ubuntu-server-dev/ubuntu/+source/nova:master

[Christian Ehrhardt ]

Hi,
this is about bug 1694159.
TL;DR: get rid of old libvirt-bin dependencies.

There are also some service references to libvirt-bin in nova which are intentional (bug 1567811) for backports and such. Yet that is covered by the newer releases of libvirt having an alias of their libvirtd service to "libvirt-bin".
That said we don't want to touch these references yet (in 18.10 then where you'll no more backport to the old world it is time to remove them as we intend to drop the alias there).

But we want to replace the package dependency itself from the transitional package to the new ones - so that we can drop the transitional package at some point.

The packages were split from libvirt-bin into:
- libvirt-daemon (daemons)
- libvirt-daemon-system (run daemon as service)
- libvirt-clients (cli tools).

Currently nova-compute-libvirt depends on:
- "python-libvirt" to connect to libvirt
- libvirt-bin to have the service it can rely on

That said the correct new dependency should be libvirt-daemon-system.

There is no code reference to virsh or other cli outside some docs.
So "libvirt-clients" should not be needed as direct dependency.

[Christian Ehrhardt  (paelzer)]

I wanted to test build but the current in flight 2:16.0.0~b1-0ubuntu5 fails as-is (e.g. build depends on python-pypowervm).
I assume you are resolving those anyway as time permits - so I'll have to wait for your to review and hopefully shove this change into 2:16.0.0~b1-0ubuntu5 as well.

[Christian Ehrhardt  (paelzer)]

This surely does no more apply, but the change is so trivial that carry forward on your own as needed.
I wanted to ask if there is any update on this?

[Christian Ehrhardt  (paelzer)]

Well since you backport to Xenial you might want to keep it, but we should remember to drop on 18.04 if that is your issue accepting this.

[James Page (james-page)]

Agreed - rejecting this merge proposal for now; we'll need to fix this for queens@18.04

[Christian Ehrhardt  (paelzer)]

For backportability this can easily be as well:

libvirt-daemon-system | libvirt-bin

diff --git a/debian/changelog b/debian/changelog
index 1b81960..c65c8c1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,6 @@
 nova (2:16.0.0~b1-0ubuntu5) UNRELEASED; urgency=medium
 
+  [ James Page ]
   * d/p/drop-iscsi-test.patch: Drop, included upstream.
   * d/control: Add python-pypowervm to (Build-)Depends.
   * d/*: wrap-and-sort.
@@ -8,6 +9,10 @@ nova (2:16.0.0~b1-0ubuntu5) UNRELEASED; urgency=medium
   * d/nova-cert.*,control: Drop nova-cert package, removed post
     deprecation upstream.
 
+  [ Christian Ehrhardt ]
+  * d/control: move libvirt dependency from transitional libvirt-bin to
+    new package libvirt-daemon-system (LP: #1694159).
+
  -- James Page <[e-mail]>  Wed, 24 May 2017 09:42:04 +0100
 
 nova (2:16.0.0~b1-0ubuntu4) artful; urgency=medium
diff --git a/debian/control b/debian/control
index 83aedd4..5e2d554 100644
--- a/debian/control
+++ b/debian/control
@@ -252,7 +252,7 @@ Depends: adduser,
          genisoimage,
          iptables,
          kpartx,
-         libvirt-bin,
+         libvirt-daemon-system,
          nova-compute (= ${binary:Version}),
          open-iscsi,
          parted,