Merge ~paelzer/ubuntu/+source/netcat-openbsd:bionic-lp-1767283 into ubuntu/+source/netcat-openbsd:ubuntu/bionic-devel

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: c818f5931e9e1f32a7ae60df4bac551ff3759e69
Proposed branch: ~paelzer/ubuntu/+source/netcat-openbsd:bionic-lp-1767283
Merge into: ubuntu/+source/netcat-openbsd:ubuntu/bionic-devel
Diff against target: 30 lines (+10/-1)
2 files modified
debian/changelog (+9/-0)
debian/patches/misc-failures-and-features.patch (+1/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server packageset reviewers Pending
git-ubuntu developers Pending
Review via email: mp+345518@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Considering https://salsa.debian.org/debian/netcat-openbsd.git commit by commit this can be done mcuh simpler ...

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Yeah that looks much better.
Works from ppa https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3260/+packages
to fix bug 1767283 in Bionic and I'd be happy about a review.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

Just missing the sru template in the bug.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks Andreas, I added the SRU Template in the meantime.
Uploading now ...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 9ba728a..9f63e2b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+netcat-openbsd (1.187-1ubuntu0.1) bionic; urgency=medium
7+
8+ * Re-enable usage of '-s' (local source address) and '-p' (local source
9+ port) in client mode (when '-l' is unset). Regression introduced in
10+ a Debian-specific patch added in 1.187-1. (LP: #1767283).
11+ Backport of https://salsa.debian.org/debian/netcat-openbsd/commit/338b1fa7
12+
13+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Mon, 14 May 2018 14:24:33 +0200
14+
15 netcat-openbsd (1.187-1) unstable; urgency=low
16
17 * New upstream release (from OpenBSD 6.2)
18diff --git a/debian/patches/misc-failures-and-features.patch b/debian/patches/misc-failures-and-features.patch
19index e907711..468791d 100644
20--- a/debian/patches/misc-failures-and-features.patch
21+++ b/debian/patches/misc-failures-and-features.patch
22@@ -295,7 +295,7 @@ Subject: misc failures and features
23 host = argv[0];
24 - uport = argv[1];
25 + uport = &argv[1];
26-+ if (pflag || sflag)
27++ if (lflag && (pflag || sflag))
28 + usage(1);
29 } else
30 usage(1);

Subscribers

People subscribed via source and target branches