Merge ~paelzer/ubuntu/+source/libvirt:lp-1921880-1921754-amd-epyc-1922907-stepping-parsing-GROOVY into ubuntu/+source/libvirt:ubuntu/groovy-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 251a44900667d1cf12b60fb28436cc324f410d54
Merge reported by: Christian Ehrhardt 
Merged at revision: 251a44900667d1cf12b60fb28436cc324f410d54
Proposed branch: ~paelzer/ubuntu/+source/libvirt:lp-1921880-1921754-amd-epyc-1922907-stepping-parsing-GROOVY
Merge into: ubuntu/+source/libvirt:ubuntu/groovy-devel
Diff against target: 452 lines (+400/-0)
8 files modified
debian/changelog (+10/-0)
debian/patches/series (+6/-0)
debian/patches/ubuntu/lp-1921754-cpumap-Add-support-for-ibrs-CPU-feature.patch (+59/-0)
debian/patches/ubuntu/lp-1921880-cpu_map-Add-EPYC-Milan-x86-CPU-model.patch (+129/-0)
debian/patches/ubuntu/lp-1921880-cpu_map-Add-support-for-fsrm-CPU-feature.patch (+73/-0)
debian/patches/ubuntu/lp-1921880-cpu_map-Fix-spelling-of-svme-addr-chk-feature.patch (+51/-0)
debian/patches/ubuntu/lp-1921880-cpu_map-Install-x86_EPYC-Milan.xml.patch (+39/-0)
debian/patches/ubuntu/lp-1921880-cpumap-Add-support-for-svme-addr-check-CPU-feature.patch (+33/-0)
Reviewer Review Type Date Requested Status
Robie Basak sru Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+401374@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Robie Basak (racb) :
review: Approve (sru)
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for the Review Robie!

FYI tests also completed (again in a more complete fashion) and LGTM:

prep (x86_64) : Pass 25 F/S/N 0/0/0 - RC 0 (15 min 44428 lin)
migrate (x86_64) : Pass 720 F/S/N 36/0/0 - RC 36 (496 min 820003 lin)
cross (x86_64) : Pass 58 F/S/N 0/1/2 - RC 0 (82 min 100241 lin)
misc (x86_64) : Pass 219 F/S/N 0/0/0 - RC 0 (84 min 120581 lin)

prep (s390x) : Pass 25 F/S/N 0/0/0 - RC 0 (14 min 31196 lin)
migrate (s390x) : Pass 804 F/S/N 0/15/0 - RC 0 (311 min 517498 lin)
cross (s390x) : Pass 62 F/S/N 0/1/1 - RC 0 (94 min 93721 lin)
misc (s390x) : Pass 199 F/S/N 2/0/0 - RC 2 (78 min 94668 lin)

The 36 fails in x86 are an issue with postcopy-after-precopy that isn't due to this new version.
The 2 fails on s390x are a real issue in Hirsute guests, but not due to these updates.
The tests above included F/G/H releases.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hirsute is completed, uploading this one

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/libvirt
 * [new tag] upload/6.6.0-1ubuntu3.5 -> upload/6.6.0-1ubuntu3.5

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libvirt_6.6.0-1ubuntu3.5.dsc: done.
  Uploading libvirt_6.6.0-1ubuntu3.5.debian.tar.xz: done.
  Uploading libvirt_6.6.0-1ubuntu3.5_source.buildinfo: done.
  Uploading libvirt_6.6.0-1ubuntu3.5_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is in F/G-proposed, setting the MP to merged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 95eef86..a93ad0d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+libvirt (6.6.0-1ubuntu3.5) groovy; urgency=medium
7+
8+ * d/p/u/lp-1921754*: add EPYC-Rome-v2 as v1 missed IBRS and thereby fails
9+ on some HW/Guest combinations e.g. Windows 10 on Threadripper
10+ (LP: #1921754)
11+ * d/p/u/lp-1921880*: add EPYC-Milan features and named cpu type support
12+ (LP: #1921880)
13+
14+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 07 Apr 2021 13:33:46 +0200
15+
16 libvirt (6.6.0-1ubuntu3.4) groovy; urgency=medium
17
18 * d/p/lp1915811-*: Fix NUMA topology population for machines with high number
19diff --git a/debian/patches/series b/debian/patches/series
20index 9841757..02c394a 100644
21--- a/debian/patches/series
22+++ b/debian/patches/series
23@@ -50,3 +50,9 @@ ubuntu/lp-1901242-util-Fix-logic-in-virFileSetCOW.patch
24 ubuntu/lp-1913266-qemu-Add-virtio-related-options-to-vsock.patch
25 ubuntu/lp1915811-01-virnuma-Don-t-work-around-numa_node_to_cpus.patch
26 ubuntu/lp1915811-02-virnuma-Use-numa_nodes_ptr-when-checking-av.patch
27+ubuntu/lp-1921754-cpumap-Add-support-for-ibrs-CPU-feature.patch
28+ubuntu/lp-1921880-cpu_map-Add-support-for-fsrm-CPU-feature.patch
29+ubuntu/lp-1921880-cpumap-Add-support-for-svme-addr-check-CPU-feature.patch
30+ubuntu/lp-1921880-cpu_map-Add-EPYC-Milan-x86-CPU-model.patch
31+ubuntu/lp-1921880-cpu_map-Install-x86_EPYC-Milan.xml.patch
32+ubuntu/lp-1921880-cpu_map-Fix-spelling-of-svme-addr-chk-feature.patch
33diff --git a/debian/patches/ubuntu/lp-1921754-cpumap-Add-support-for-ibrs-CPU-feature.patch b/debian/patches/ubuntu/lp-1921754-cpumap-Add-support-for-ibrs-CPU-feature.patch
34new file mode 100644
35index 0000000..5cd251d
36--- /dev/null
37+++ b/debian/patches/ubuntu/lp-1921754-cpumap-Add-support-for-ibrs-CPU-feature.patch
38@@ -0,0 +1,59 @@
39+From 5c17a7ba41670f3182186c06e621995b5d03fc95 Mon Sep 17 00:00:00 2001
40+From: Tim Wiederhake <twiederh@redhat.com>
41+Date: Mon, 22 Feb 2021 13:20:09 +0100
42+Subject: [PATCH] cpumap: Add support for ibrs CPU feature
43+
44+Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
45+Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
46+
47+Origin: upstream, https://libvirt.org/git/?p=libvirt.git;a=commit;h=5c17a7ba
48+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1921754
49+Last-Update: 2021-04-07
50+
51+---
52+ src/cpu_map/x86_features.xml | 3 +++
53+ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +
54+ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml | 1 +
55+ 3 files changed, 5 insertions(+)
56+
57+diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
58+index 5cfa07502a..b03a6b065d 100644
59+--- a/src/cpu_map/x86_features.xml
60++++ b/src/cpu_map/x86_features.xml
61+@@ -507,6 +507,9 @@
62+ <feature name='ibpb'>
63+ <cpuid eax_in='0x80000008' ebx='0x00001000'/>
64+ </feature>
65++ <feature name='ibrs'>
66++ <cpuid eax_in='0x80000008' ebx='0x00004000'/>
67++ </feature>
68+ <feature name='amd-stibp'>
69+ <cpuid eax_in='0x80000008' ebx='0x00008000'/>
70+ </feature>
71+diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
72+index 6d95b508b2..40e7912398 100644
73+--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
74++++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml
75+@@ -17,6 +17,7 @@
76+ <feature policy='require' name='topoext'/>
77+ <feature policy='require' name='perfctr_nb'/>
78+ <feature policy='require' name='invtsc'/>
79++ <feature policy='require' name='ibrs'/>
80+ <feature policy='require' name='amd-ssbd'/>
81+ <feature policy='require' name='lbrv'/>
82+ <feature policy='require' name='svm-lock'/>
83+diff --git a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
84+index 65eaeabdd0..9f8108cdaa 100644
85+--- a/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
86++++ b/tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml
87+@@ -18,6 +18,7 @@
88+ <feature name='topoext'/>
89+ <feature name='perfctr_nb'/>
90+ <feature name='invtsc'/>
91++ <feature name='ibrs'/>
92+ <feature name='amd-ssbd'/>
93+ <feature name='lbrv'/>
94+ <feature name='svm-lock'/>
95+--
96+2.31.1
97+
98diff --git a/debian/patches/ubuntu/lp-1921880-cpu_map-Add-EPYC-Milan-x86-CPU-model.patch b/debian/patches/ubuntu/lp-1921880-cpu_map-Add-EPYC-Milan-x86-CPU-model.patch
99new file mode 100644
100index 0000000..50710d5
101--- /dev/null
102+++ b/debian/patches/ubuntu/lp-1921880-cpu_map-Add-EPYC-Milan-x86-CPU-model.patch
103@@ -0,0 +1,129 @@
104+From f321a4822e9fa6542e48a78611989ecd9acaa83a Mon Sep 17 00:00:00 2001
105+From: Jiri Denemark <jdenemar@redhat.com>
106+Date: Mon, 1 Mar 2021 19:20:51 +0100
107+Subject: [PATCH] cpu_map: Add EPYC-Milan x86 CPU model
108+MIME-Version: 1.0
109+Content-Type: text/plain; charset=UTF-8
110+Content-Transfer-Encoding: 8bit
111+
112+Introduced in QEMU 6.0.0 by 623972ceae091b31331ae4a1dc94fe5cbb891937
113+
114+Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
115+Reviewed-by: Ján Tomko <jtomko@redhat.com>
116+
117+Backport-Note: only whitespace damage
118+Origin: backport, https://libvirt.org/git/?p=libvirt.git;a=commit;h=f321a482
119+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1921880
120+Last-Update: 2021-04-07
121+
122+---
123+ src/cpu_map/index.xml | 1 +
124+ src/cpu_map/x86_EPYC-Milan.xml | 92 ++++++++++++++++++++++++++++++++++
125+ 2 files changed, 93 insertions(+)
126+ create mode 100644 src/cpu_map/x86_EPYC-Milan.xml
127+
128+--- /dev/null
129++++ b/src/cpu_map/x86_EPYC-Milan.xml
130+@@ -0,0 +1,92 @@
131++<cpus>
132++ <model name='EPYC-Milan'>
133++ <decode host='on' guest='on'/>
134++ <signature family='25' model='1'/>
135++ <vendor name='AMD'/>
136++ <feature name='3dnowprefetch'/>
137++ <feature name='abm'/>
138++ <feature name='adx'/>
139++ <feature name='aes'/>
140++ <feature name='amd-ssbd'/>
141++ <feature name='amd-stibp'/>
142++ <feature name='apic'/>
143++ <feature name='arat'/>
144++ <feature name='avx'/>
145++ <feature name='avx2'/>
146++ <feature name='bmi1'/>
147++ <feature name='bmi2'/>
148++ <feature name='clflush'/>
149++ <feature name='clflushopt'/>
150++ <feature name='clwb'/>
151++ <feature name='clzero'/>
152++ <feature name='cmov'/>
153++ <feature name='cr8legacy'/>
154++ <feature name='cx16'/>
155++ <feature name='cx8'/>
156++ <feature name='de'/>
157++ <feature name='erms'/>
158++ <feature name='f16c'/>
159++ <feature name='fma'/>
160++ <feature name='fpu'/>
161++ <feature name='fsgsbase'/>
162++ <feature name='fsrm'/>
163++ <feature name='fxsr'/>
164++ <feature name='fxsr_opt'/>
165++ <feature name='ibpb'/>
166++ <feature name='ibrs'/>
167++ <feature name='invpcid'/>
168++ <feature name='lahf_lm'/>
169++ <feature name='lm'/>
170++ <feature name='mca'/>
171++ <feature name='mce'/>
172++ <feature name='misalignsse'/>
173++ <feature name='mmx'/>
174++ <feature name='mmxext'/>
175++ <feature name='movbe'/>
176++ <feature name='msr'/>
177++ <feature name='mtrr'/>
178++ <feature name='npt'/>
179++ <feature name='nrip-save'/>
180++ <feature name='nx'/>
181++ <feature name='osvw'/>
182++ <feature name='pae'/>
183++ <feature name='pat'/>
184++ <feature name='pcid'/>
185++ <feature name='pclmuldq'/>
186++ <feature name='pdpe1gb'/>
187++ <feature name='perfctr_core'/>
188++ <feature name='pge'/>
189++ <feature name='pku'/>
190++ <feature name='pni'/>
191++ <feature name='popcnt'/>
192++ <feature name='pse'/>
193++ <feature name='pse36'/>
194++ <feature name='rdpid'/>
195++ <feature name='rdrand'/>
196++ <feature name='rdseed'/>
197++ <feature name='rdtscp'/>
198++ <feature name='sep'/>
199++ <feature name='sha-ni'/>
200++ <feature name='smap'/>
201++ <feature name='smep'/>
202++ <feature name='sse'/>
203++ <feature name='sse2'/>
204++ <feature name='sse4.1'/>
205++ <feature name='sse4.2'/>
206++ <feature name='sse4a'/>
207++ <feature name='ssse3'/>
208++ <feature name='svm'/>
209++ <feature name='svme-addr-check'/>
210++ <feature name='syscall'/>
211++ <feature name='tsc'/>
212++ <feature name='umip'/>
213++ <feature name='vme'/>
214++ <feature name='wbnoinvd'/>
215++ <feature name='xgetbv1'/>
216++ <feature name='xsave'/>
217++ <feature name='xsavec'/>
218++ <feature name='xsaveerptr'/>
219++ <feature name='xsaveopt'/>
220++ <feature name='xsaves'/>
221++ </model>
222++</cpus>
223+--- a/src/cpu_map/index.xml
224++++ b/src/cpu_map/index.xml
225+@@ -66,6 +66,7 @@
226+ <include filename="x86_EPYC.xml"/>
227+ <include filename="x86_EPYC-IBPB.xml"/>
228+ <include filename="x86_EPYC-Rome.xml"/>
229++ <include filename='x86_EPYC-Milan.xml'/>
230+
231+ <!-- Hygon CPU models -->
232+ <include filename="x86_Dhyana.xml"/>
233diff --git a/debian/patches/ubuntu/lp-1921880-cpu_map-Add-support-for-fsrm-CPU-feature.patch b/debian/patches/ubuntu/lp-1921880-cpu_map-Add-support-for-fsrm-CPU-feature.patch
234new file mode 100644
235index 0000000..72a6c0f
236--- /dev/null
237+++ b/debian/patches/ubuntu/lp-1921880-cpu_map-Add-support-for-fsrm-CPU-feature.patch
238@@ -0,0 +1,73 @@
239+From 8c5c660b99101544d8cfcb8edbe48688c04bee25 Mon Sep 17 00:00:00 2001
240+From: Tim Wiederhake <twiederh@redhat.com>
241+Date: Wed, 6 Jan 2021 11:05:06 +0100
242+Subject: [PATCH] cpu_map: Add support for fsrm CPU feature
243+
244+Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
245+Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
246+
247+Origin: upstream, https://libvirt.org/git/?p=libvirt.git;a=commit;h=8c5c660b
248+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1921880
249+Last-Update: 2021-04-07
250+
251+---
252+ src/cpu_map/x86_features.xml | 3 +++
253+ tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-disabled.xml | 2 +-
254+ tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 +
255+ tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml | 1 +
256+ 4 files changed, 6 insertions(+), 1 deletion(-)
257+
258+diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
259+index a55f52b16c..b0bf22d916 100644
260+--- a/src/cpu_map/x86_features.xml
261++++ b/src/cpu_map/x86_features.xml
262+@@ -339,6 +339,9 @@
263+ <feature name='avx512-4fmaps'>
264+ <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000008'/>
265+ </feature>
266++ <feature name='fsrm'>
267++ <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000010'/>
268++ </feature>
269+ <feature name='md-clear'> <!-- md_clear -->
270+ <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000400'/>
271+ </feature>
272+diff --git a/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-disabled.xml b/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-disabled.xml
273+index ce65579bcc..33bd1013f0 100644
274+--- a/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-disabled.xml
275++++ b/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-disabled.xml
276+@@ -1,7 +1,7 @@
277+ <!-- Features disabled by QEMU -->
278+ <cpudata arch='x86'>
279+ <cpuid eax_in='0x00000001' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x0804c1fc' edx='0xb0600000'/>
280+- <cpuid eax_in='0x00000007' ecx_in='0x00' eax='0x00000000' ebx='0x02001000' ecx='0x00400010' edx='0x00000000'/>
281++ <cpuid eax_in='0x00000007' ecx_in='0x00' eax='0x00000000' ebx='0x02001000' ecx='0x00400010' edx='0x00000010'/>
282+ <cpuid eax_in='0x0000000f' ecx_in='0x01' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000006'/>
283+ <cpuid eax_in='0x80000007' ecx_in='0x00' eax='0x00000000' ebx='0x00000000' ecx='0x00000000' edx='0x00000100'/>
284+ </cpudata>
285+diff --git a/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml b/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml
286+index 9b75ace710..3a71b28cfb 100644
287+--- a/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml
288++++ b/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml
289+@@ -24,6 +24,7 @@
290+ <feature policy='require' name='sha-ni'/>
291+ <feature policy='require' name='ospke'/>
292+ <feature policy='require' name='rdpid'/>
293++ <feature policy='require' name='fsrm'/>
294+ <feature policy='require' name='stibp'/>
295+ <feature policy='require' name='arch-capabilities'/>
296+ <feature policy='require' name='xsaves'/>
297+diff --git a/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml b/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml
298+index efbf9d363b..1582de0422 100644
299+--- a/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml
300++++ b/tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml
301+@@ -25,6 +25,7 @@
302+ <feature name='sha-ni'/>
303+ <feature name='ospke'/>
304+ <feature name='rdpid'/>
305++ <feature name='fsrm'/>
306+ <feature name='stibp'/>
307+ <feature name='arch-capabilities'/>
308+ <feature name='xsaves'/>
309+--
310+2.31.1
311+
312diff --git a/debian/patches/ubuntu/lp-1921880-cpu_map-Fix-spelling-of-svme-addr-chk-feature.patch b/debian/patches/ubuntu/lp-1921880-cpu_map-Fix-spelling-of-svme-addr-chk-feature.patch
313new file mode 100644
314index 0000000..8d23051
315--- /dev/null
316+++ b/debian/patches/ubuntu/lp-1921880-cpu_map-Fix-spelling-of-svme-addr-chk-feature.patch
317@@ -0,0 +1,51 @@
318+From b5abf9a192248b1005f63a7102d2627375d70fe5 Mon Sep 17 00:00:00 2001
319+From: Jiri Denemark <jdenemar@redhat.com>
320+Date: Thu, 4 Mar 2021 08:43:09 +0100
321+Subject: [PATCH] cpu_map: Fix spelling of svme-addr-chk feature
322+
323+Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this feature
324+with an incorrect "svme-addr-check" spelling.
325+
326+Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
327+Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
328+
329+Backport-Note: sync_qemu_cpu_i386 didn't exist before v6.10
330+Origin: backport, https://libvirt.org/git/?p=libvirt.git;a=commit;h=b5abf9a1
331+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1921880
332+Last-Update: 2021-04-07
333+
334+---
335+ src/cpu_map/sync_qemu_i386.py | 2 +-
336+ src/cpu_map/x86_EPYC-Milan.xml | 2 +-
337+ src/cpu_map/x86_features.xml | 2 +-
338+ 3 files changed, 3 insertions(+), 3 deletions(-)
339+
340+diff --git a/src/cpu_map/x86_EPYC-Milan.xml b/src/cpu_map/x86_EPYC-Milan.xml
341+index 53f0cd6aac..3055e175fa 100644
342+--- a/src/cpu_map/x86_EPYC-Milan.xml
343++++ b/src/cpu_map/x86_EPYC-Milan.xml
344+@@ -76,7 +76,7 @@
345+ <feature name='sse4a'/>
346+ <feature name='ssse3'/>
347+ <feature name='svm'/>
348+- <feature name='svme-addr-check'/>
349++ <feature name='svme-addr-chk'/>
350+ <feature name='syscall'/>
351+ <feature name='tsc'/>
352+ <feature name='umip'/>
353+diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
354+index c43520d08f..e98b84f3ef 100644
355+--- a/src/cpu_map/x86_features.xml
356++++ b/src/cpu_map/x86_features.xml
357+@@ -554,7 +554,7 @@
358+ <feature name='pfthreshold'>
359+ <cpuid eax_in='0x8000000a' edx='0x00001000'/>
360+ </feature>
361+- <feature name='svme-addr-check'>
362++ <feature name='svme-addr-chk'>
363+ <cpuid eax_in='0x8000000a' edx='0x10000000'/>
364+ </feature>
365+
366+--
367+2.31.1
368+
369diff --git a/debian/patches/ubuntu/lp-1921880-cpu_map-Install-x86_EPYC-Milan.xml.patch b/debian/patches/ubuntu/lp-1921880-cpu_map-Install-x86_EPYC-Milan.xml.patch
370new file mode 100644
371index 0000000..263e151
372--- /dev/null
373+++ b/debian/patches/ubuntu/lp-1921880-cpu_map-Install-x86_EPYC-Milan.xml.patch
374@@ -0,0 +1,39 @@
375+From d3de79dbfc20dc4dfc19154b16079861c542b71e Mon Sep 17 00:00:00 2001
376+From: Jiri Denemark <jdenemar@redhat.com>
377+Date: Tue, 2 Mar 2021 10:32:42 +0100
378+Subject: [PATCH] cpu_map: Install x86_EPYC-Milan.xml
379+
380+Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
381+Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
382+
383+Backport-Note: Groovy is pre-meson so the patch needed to be adapted to
384+ fit the Make based build, the same that we've done in patch
385+ ubuntu/lp-1887490-cpu_map-Defined-and-enable-EPYC-Rome-model.patch
386+Origin: backport, https://libvirt.org/git/?p=libvirt.git;a=commit;h=d3de79db
387+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1921880
388+Last-Update: 2021-04-07
389+
390+---
391+ src/cpu_map/meson.build | 1 +
392+ 1 file changed, 1 insertion(+)
393+
394+--- a/src/Makefile.in
395++++ b/src/Makefile.in
396+@@ -5561,6 +5561,7 @@ cpumap_DATA = \
397+ cpu_map/x86_Dhyana.xml \
398+ cpu_map/x86_EPYC.xml \
399+ cpu_map/x86_EPYC-IBPB.xml \
400++ cpu_map/x86_EPYC-Milan.xml \
401+ cpu_map/x86_EPYC-Rome.xml \
402+ cpu_map/x86_Haswell.xml \
403+ cpu_map/x86_Haswell-IBRS.xml \
404+--- a/src/cpu_map/Makefile.inc.am
405++++ b/src/cpu_map/Makefile.inc.am
406+@@ -29,6 +29,7 @@ cpumap_DATA = \
407+ cpu_map/x86_Dhyana.xml \
408+ cpu_map/x86_EPYC.xml \
409+ cpu_map/x86_EPYC-IBPB.xml \
410++ cpu_map/x86_EPYC-Milan.xml \
411+ cpu_map/x86_EPYC-Rome.xml \
412+ cpu_map/x86_Haswell.xml \
413+ cpu_map/x86_Haswell-IBRS.xml \
414diff --git a/debian/patches/ubuntu/lp-1921880-cpumap-Add-support-for-svme-addr-check-CPU-feature.patch b/debian/patches/ubuntu/lp-1921880-cpumap-Add-support-for-svme-addr-check-CPU-feature.patch
415new file mode 100644
416index 0000000..5e5420e
417--- /dev/null
418+++ b/debian/patches/ubuntu/lp-1921880-cpumap-Add-support-for-svme-addr-check-CPU-feature.patch
419@@ -0,0 +1,33 @@
420+From 5ac6ab2fde63881d3c5cc7372a0d0e59618feb55 Mon Sep 17 00:00:00 2001
421+From: Tim Wiederhake <twiederh@redhat.com>
422+Date: Mon, 22 Feb 2021 13:20:10 +0100
423+Subject: [PATCH] cpumap: Add support for svme-addr-check CPU feature
424+
425+Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
426+Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
427+
428+Origin: upstream, https://libvirt.org/git/?p=libvirt.git;a=commit;h=5ac6ab2f
429+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1921880
430+Last-Update: 2021-04-07
431+
432+---
433+ src/cpu_map/x86_features.xml | 3 +++
434+ 1 file changed, 3 insertions(+)
435+
436+diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
437+index b03a6b065d..c43520d08f 100644
438+--- a/src/cpu_map/x86_features.xml
439++++ b/src/cpu_map/x86_features.xml
440+@@ -554,6 +554,9 @@
441+ <feature name='pfthreshold'>
442+ <cpuid eax_in='0x8000000a' edx='0x00001000'/>
443+ </feature>
444++ <feature name='svme-addr-check'>
445++ <cpuid eax_in='0x8000000a' edx='0x10000000'/>
446++ </feature>
447+
448+ <!-- IA32_ARCH_CAPABILITIES features -->
449+ <feature name='rdctl-no'>
450+--
451+2.31.1
452+

Subscribers

People subscribed via source and target branches