Code review comment for ~paelzer/ubuntu/+source/libseccomp:lp-1755250-add-statx

Seth Arnold (seth-arnold) wrote :

Tyler and I took a look at this patch and thought it looked good.

We also thought that a similar patch should be included at the same time:

https://github.com/seccomp/libseccomp/commit/c842c2f6c203ad9da37ca60219172aa0be68d26a

If we're going to go through the work of validating a new version, now would be a good time to bring these in as well.

(I don't know if that means the review result should be Approve, because there's nothing wrong here, or Needs Fixing, because we'd also like a bit more work to be done. Sorry.)

Thanks

review: Approve

« Back to merge proposal