Merge ~paelzer/ubuntu/+source/libpam-mount:lp-1804408-LUKS2-support-cosmic into ubuntu/+source/libpam-mount:ubuntu/cosmic-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andreas Hasenack on 2019-02-07 | ||||
Approved revision: | 066ee38328c05cc65754c10632297ebba5d4feee | ||||
Merge reported by: | Christian Ehrhardt | ||||
Merged at revision: | 056f42054d076a11eded92b5e358af388ae6ad2f | ||||
Proposed branch: | ~paelzer/ubuntu/+source/libpam-mount:lp-1804408-LUKS2-support-cosmic | ||||
Merge into: | ubuntu/+source/libpam-mount:ubuntu/cosmic-devel | ||||
Diff against target: |
157 lines (+123/-0) 5 files modified
debian/changelog (+9/-0) debian/patches/0015-Use-crypt_get_type-to-get-type-and-support-CRYPT_LUK.patch (+49/-0) debian/patches/series (+1/-0) debian/tests/control (+3/-0) debian/tests/local-luks (+61/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Hasenack | 2019-02-06 | Approve on 2019-02-07 | |
Canonical Server Team | 2019-02-06 | Pending | |
Ubuntu Server Dev import team | 2019-02-06 | Pending | |
Review via email:
|
Christian Ehrhardt (paelzer) wrote : | # |
Christian Ehrhardt (paelzer) wrote : | # |
I added an dep8 test for some extra confidence
Result example:
Cosmic with fix: http://
Cosmic without: http://
Bionic with fix: http://
Christian Ehrhardt (paelzer) wrote : | # |
For Disco I submitted the test to Debian https:/
Christian Ehrhardt (paelzer) wrote : | # |
There is no Debian bug (and there won't be as it is fixed in latest).
I'll remove the line.
- be1116b... by Christian Ehrhardt on 2019-02-07
Andreas Hasenack (ahasenack) wrote : | # |
+1, just some suggestions inside.
I was also going to suggest that the script be made idempotent, that helps a lot when iterating over it with enhancements or changes without having to clean up manually before each new run, but that makes it a bit more complicated than needed at this time (check user before adding, or remove user at the end, add traps, etc).
- fed41c5... by Christian Ehrhardt on 2019-02-07
- 056f420... by Christian Ehrhardt on 2019-02-07
PPA available at: https:/ /launchpad. net/~ci- train-ppa- service/ +archive/ ubuntu/ 3635
I added autopkgtests as I realized what I wrote for the bug would almost already make a good test.
For Disco I'd not upload the tests as Delta, but instead open them as MP/Bug to Debian to be included there. Only if there is no activity I'd consider adding a Delta.
But lets get a review here first :-)
The PPA worked on my box as outlined in the SRU template.
Tests will run soon (the PPA just rebuilds) and will be available in Bileto then.