Merge ~paelzer/ubuntu/+source/libaio:merge-0.3.112-11-JAMMY into ubuntu/+source/libaio:debian/sid

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: c44ea7c760d8f69907c5c12aa093cf0148315e6b
Proposed branch: ~paelzer/ubuntu/+source/libaio:merge-0.3.112-11-JAMMY
Merge into: ubuntu/+source/libaio:debian/sid
Diff against target: 65 lines (+28/-2)
3 files modified
debian/changelog (+25/-0)
debian/control (+2/-1)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Pending
git-ubuntu import Pending
Review via email: mp+410996@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4696/+packages

Rather trivial merge (only delta is LTO, which nothing changed about from upstream or Debian)

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I'll review this one.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote (last edit ):

Thanks for the MP, Christian.

It built fine locally. Debian added autopkgtests to the package (great!). At least locally, I see one pass and one flaky test here, which also happens on Debian:

https://ci.debian.net/data/autopkgtest/testing/amd64/liba/libaio/16063796/log.gz

So I'm not concerned.

You haven't pushed the other branches related to the merge (old/debian, old/ubuntu, etc), nor the tags (split, logical, etc). I understand this is a simple and trivial merge, but I'd still have liked to be able to inspect these other artifacts.

Either way, I'm approving the MP because I'm satisfied with the resulting package.

LGTM, +1.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for the hint Sergio, they are here and look as you'd expect.
But that was a good reminder for the coming potentially more complex merges.

To ssh://git.launchpad.net/~paelzer/ubuntu/+source/libaio
 * [new tag] lp1946864/logical/0.3.112-9ubuntu1 -> lp1946864/logical/0.3.112-9ubuntu1
 * [new tag] lp1946864/new/debian -> lp1946864/new/debian
 * [new tag] lp1946864/old/debian -> lp1946864/old/debian
 * [new tag] lp1946864/old/ubuntu -> lp1946864/old/ubuntu
 * [new tag] lp1946864/reconstruct/0.3.112-9ubuntu2 -> lp1946864/reconstruct/0.3.112-9ubuntu2
 * [new tag] lp1946864/split/0.3.112-9ubuntu1 -> lp1946864/split/0.3.112-9ubuntu1

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Uploaded

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libaio_0.3.112-11ubuntu1.dsc: done.
  Uploading libaio_0.3.112-11ubuntu1.debian.tar.xz: done.
  Uploading libaio_0.3.112-11ubuntu1_source.buildinfo: done.
  Uploading libaio_0.3.112-11ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI full LTO builds with
https://git.hadrons.org/cgit/debian/pkgs/libaio.git/diff/?id=b17f8e5

in 0.3.112-12, since this was the only Delta left -> sync it now.

And another evidence that these non-LTO changes should be upstreamed to Debian and Projects.

Thanks to Guillem Jover for the quick and great response!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is in proposed, even though we immediately sync it over now => merged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 0e5a8ab..461240d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+libaio (0.3.112-11ubuntu1) jammy; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1946864). Remaining changes:
9+ - d/rules: Disable building with lto.
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Fri, 29 Oct 2021 09:23:58 +0200
12+
13 libaio (0.3.112-11) unstable; urgency=medium
14
15 * Use CC as a shell variable instead of a make one in autopkgtests.
16@@ -19,6 +26,24 @@ libaio (0.3.112-10) unstable; urgency=medium
17
18 -- Guillem Jover <guillem@debian.org> Sat, 09 Oct 2021 17:31:09 +0200
19
20+libaio (0.3.112-9ubuntu2) impish; urgency=medium
21+
22+ * No-change rebuild to build packages with zstd compression.
23+
24+ -- Matthias Klose <doko@ubuntu.com> Thu, 07 Oct 2021 12:13:56 +0200
25+
26+libaio (0.3.112-9ubuntu1) hirsute; urgency=medium
27+
28+ * Disable building with lto.
29+
30+ -- Matthias Klose <doko@ubuntu.com> Mon, 22 Mar 2021 22:13:01 +0100
31+
32+libaio (0.3.112-9build1) hirsute; urgency=medium
33+
34+ * No-change rebuild to drop the udeb package.
35+
36+ -- Matthias Klose <doko@ubuntu.com> Mon, 22 Feb 2021 10:34:21 +0100
37+
38 libaio (0.3.112-9) unstable; urgency=medium
39
40 * Remove Build-Depends on dpkg-dev, satisfied in stable.
41diff --git a/debian/control b/debian/control
42index 868be44..798fefe 100644
43--- a/debian/control
44+++ b/debian/control
45@@ -1,5 +1,6 @@
46 Source: libaio
47-Maintainer: Guillem Jover <guillem@debian.org>
48+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
49+XSBC-Original-Maintainer: Guillem Jover <guillem@debian.org>
50 Priority: optional
51 Section: libs
52 Vcs-Browser: https://git.hadrons.org/cgit/debian/pkgs/libaio.git
53diff --git a/debian/rules b/debian/rules
54index 9010218..d2d7db8 100755
55--- a/debian/rules
56+++ b/debian/rules
57@@ -3,7 +3,7 @@
58 # Uncomment this to turn on verbose mode.
59 #export DH_VERBOSE=1
60
61-DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
62+DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow optimize=-lto
63 DEB_CFLAGS_MAINT_PREPEND = -Wall
64
65 include /usr/share/dpkg/default.mk

Subscribers

People subscribed via source and target branches