Code review comment for ~paelzer/ubuntu/+source/dovecot:fix-FTFBS-HIRSUTE

> > + * d/p/test-backtrace.patch: update to fix FTFBS with glibc 2.33 and later
>
> Ah, I'd seen a s/backtrace_append/test_backtrace/ (or maybe vice versa) in my googling. Was that due to a symbol change, or just a mistake? If it was due to a symbol change that might be worth mention here, in case it randomly crops up again.

Not really a symbol change, upstreams original code looks for "main"
but on some architectures that isn't present so debian changed it.
Debian had picked a function that was in the backtrace back then, but
the combination of the new glibc and compiler optimizations have
removed that function :-)
Picking the function name that has to be externally called ensures it
will not be optimized away (as it needs to stay to be callable)

> > + * d/p/avoid-json-parse-misoptimization.patch: new toolchains mis-optimized
> > + json parsing to fail at negative values, avoid by not-optimizing the
> > + function
>
> "at negative values; avoid by not-optimizing the function."

Yeah a ";" might indeed be better - adapting

...

> > +Description: avoid failures due to over-optimization
> > + New gcc reorders clear/set and thereby breaks json parsing.
> > + For now add avoidance to not run unto unexpected issues.
> > +Forwarded: yes - https://dovecot.org/pipermail/dovecot/2021-March/121770.html
>
> Wow, awesome debugging work there. Hopefully that gives upstream a solid path to look down for a solution.

Thanks, they are responsive already - we will see where it leads us.