Code review comment for ~paelzer/ubuntu/+source/collectd:lp1971093-bring-collectd-back-to-JAMMY-v2

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Since nut is being disabled again in 14e10db2ce218eb58e2e4e85800c949943aceb08, isn't the minimal fix just these two:

      * [343f857] Don't use local variables in global pointers
        Closes: #1016187

and

      * [15098cc] Also fix local variables issue in write_prometheus

What were your considerations when pondering the above? That it's simpler and less error-prone to grab the -10 debian package and disable nut, like is done in -11?

From an SRU perspective, I would prefer the minimal fixes, but then again, this package does not exist in jammy, so there is technically no regression case, other then new rebuilds of other packages down the line which link to libcollectdclient1.

review: Needs Information

« Back to merge proposal