Code review comment for ~paelzer/ubuntu/+source/chrony:merge-disco-3.4

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sorry about the confusing review.

I guess my only comment is about that d/chronyd-starter.sh wrapper commit which forgot to mention chrony.service. I see that in under paelzer/lp1802886/logical/3.3-2ubuntu2 too:

commit bb17fdf9967601d436a73bf93f9b3e72fa67696a
Author: Christian Ehrhardt <email address hidden>
Date: Thu Mar 15 09:31:48 2018 +0100

    - debian/chronyd-starter.sh: wrapper to handle special cases in containers

    Signed-off-by: Christian Ehrhardt <email address hidden>

No big deal, though.

Logical, drops, and added change are good. delta carried forward as expected. Would be cool to see a new dep8 run after bileto was fixed today to work with disco (hopefully).

review: Approve

« Back to merge proposal