Code review comment for ~paelzer/ubuntu/+source/chrony:merge-cosmic-3.3-1

Revision history for this message
Robie Basak (racb) wrote :

On Fri, May 18, 2018 at 05:59:20AM -0000,  Christian Ehrhardt  wrote:
> > Looks good!
> >
> > One question from an upload perspective:
> >
> > 2d3ebbe: is a policy-rc.d interaction required? I'm not sure so I'll defer to
> > you or someone like xnox.
>
> Interesting - This is no new change, I can kick a discussion with xnox separate to this but would not block the upload here for now. If it turns out we need a modification later on that can be done individually.
>
> To kick that off properly could you elaborate a few sentences on the policy-rc.d interaction you'd have in mind outside of this MP e.g. in a mail to me?

Agreed that it isn't introduced in this merge so shouldn't block the
merge. I've filed a bug so it doesn't get forgotten - and you can
prioritise (or deprioritise) it appropriately.

[...]

> I'm not going to rewrite all my old patches I've done last year, but from now on I make a difference between backport from upstream git and backport from upstream discussion (which was how the forwarded came in - to carry a link or such).

Agreed. Not worth going over old stuff.

« Back to merge proposal