Merge ~paelzer/ubuntu/+source/bind9:bug-1833400-race-on-shutdown into ubuntu/+source/bind9:ubuntu/xenial-devel
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Christian Ehrhardt on 2019-08-09 | ||||||||
Approved revision: | 3e06372c267368be1b9d74add302d2925367c62c | ||||||||
Merged at revision: | 3e06372c267368be1b9d74add302d2925367c62c | ||||||||
Proposed branch: | ~paelzer/ubuntu/+source/bind9:bug-1833400-race-on-shutdown | ||||||||
Merge into: | ubuntu/+source/bind9:ubuntu/xenial-devel | ||||||||
Diff against target: |
166 lines (+132/-0) 5 files modified
debian/changelog (+8/-0) debian/patches/fix-shutdown-race.diff (+41/-0) debian/patches/series (+3/-0) debian/patches/ubuntu/lp-1833400-master-Remove-REQUIRE-preventing-change-4592-from-wo.patch (+33/-0) debian/patches/ubuntu/lp-1833400-master-fix-dispatch.c-shutdown-race.patch (+47/-0) |
||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Hasenack | 2019-08-05 | Approve on 2019-08-07 | |
Canonical Server Team | 2019-08-05 | Pending | |
Ubuntu Server Dev import team | 2019-08-05 | Pending | |
Review via email:
|
Christian Ehrhardt (paelzer) wrote : | # |
Christian Ehrhardt (paelzer) wrote : | # |
Never the less it can be reviewed for silly errors on my side, so why not opening it up for review ...
Andreas Hasenack (ahasenack) wrote : | # |
I pinged upstream in the commits asking for the report to be made public
Andreas Hasenack (ahasenack) wrote : | # |
+1
I found their own backports of these patches in their v9_10 branch, if you rather have those:
https:/
and
https:/
I assume you didn't want to point at the upstream bug in the DEP3 headers because it's not public?
Christian Ehrhardt (paelzer) wrote : | # |
Thank you Andreas,
as you know they made the bug public now (thanks to your ping) so I can reference it now.
I changed the references to the 9_10 backport commits and added the upstream bug references.
Code-wise things stay the same on these compared to what I had (the backport I needed was for the "Changes" File not matching).
Christian Ehrhardt (paelzer) wrote : | # |
I'll upload this to unapproved after I added a SRU template
Christian Ehrhardt (paelzer) wrote : | # |
Actually I'm holding back until we talked about adding a potential backport for bug 1797926 as well.
Andreas Hasenack (ahasenack) wrote : | # |
+1 for including the fix for bug 1797926
Christian Ehrhardt (paelzer) wrote : | # |
Added the fix for bug 1797926 here.
Also pushed the version with it to the PPA.
I'll open a new MP for the same towards Bionic.
Andreas Hasenack (ahasenack) wrote : | # |
The Origin url's hash doesn't match the From one in the DEP3 headers anymore in d/p/ubuntu/*, if that's a concern.
Christian Ehrhardt (paelzer) wrote : | # |
No concern on the hash mismatch, but yes to marking as backport
Christian Ehrhardt (paelzer) wrote : | # |
tagged and uploaded
PPA: https:/ /launchpad. net/~paelzer/ +archive/ ubuntu/ bug-1833400- bind-crash
We still miss the repro steps since the upstream bug is inaccessible and the reporters didn't mention yet. So far this is therefore a low prio review, mostly meant that the changes are readily available if anyone wants to continue on this.