Merge ~paelzer/ubuntu/+source/autofs:lp-1818121-nfs4.x-disco into ubuntu/+source/autofs:ubuntu/disco-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Andreas Hasenack
Approved revision: 0d4605c0e44f7b6eee1dd2a97f9ca64b38b6685f
Merge reported by: Christian Ehrhardt 
Merged at revision: 0d4605c0e44f7b6eee1dd2a97f9ca64b38b6685f
Proposed branch: ~paelzer/ubuntu/+source/autofs:lp-1818121-nfs4.x-disco
Merge into: ubuntu/+source/autofs:ubuntu/disco-devel
Diff against target: 72 lines (+50/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch (+42/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+364082@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

taking a look

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I don't think this is worth a backport note, since you just removed an obvious hunk that is not relevant and did not change any of the bits that are being applied. I think the backport note you added in the description explains well enough what was done and why, and it's even below the signed off part the author added.

+1, up to you.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I thought the note can't hurt, so i'll keep it.
Thanks for checking this!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Tagged and uploaded to Disco

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 789fbce..65d2234 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+autofs (5.1.2-4ubuntu2) disco; urgency=medium
7+
8+ * d/p/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch:
9+ fix usage of NFS 4.x subversions (LP: #1818121)
10+
11+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 07 Mar 2019 13:03:35 +0100
12+
13 autofs (5.1.2-4ubuntu1) cosmic; urgency=medium
14
15 * Merge with Debian unstable. Remaining changes:
16diff --git a/debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch b/debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch
17new file mode 100644
18index 0000000..fdb0cd0
19--- /dev/null
20+++ b/debian/patches/autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch
21@@ -0,0 +1,42 @@
22+From aa1f432180f3878c303088def8d647f1bd50b10b Mon Sep 17 00:00:00 2001
23+From: Ian Kent <raven@themaw.net>
24+Date: Thu, 19 Oct 2017 08:48:44 +0800
25+Subject: [PATCH] autofs-5.1.3 - handle additional nfs versions in mount_nfs.c
26+
27+Since NFSv4 can now have a subversion it needs to be allowed for.
28+
29+It's enough to check for an options string starting with "vers=4" or
30+"nfsvers=4" because it's used only to set a flag used for special
31+casing the availibility probe for any NFS version 4 version.
32+
33+Signed-off-by: Ian Kent <raven@themaw.net>
34+
35+Backport Note: skip the hunk on CHANGELOG as it is not needed and lacks
36+ the 5.1.3 context it needs
37+Author: Christian Ehrhardt <christian.ehrhardt@canonical.com>
38+Original-Author: Ian Kent <raven@themaw.net>
39+Origin: backport, https://git.kernel.org/pub/scm/linux/storage/autofs/autofs.git/commit/?id=aa1f432180f3878c303088def8d647f1bd50b10b
40+
41+Bug-Ubuntu: https://bugs.launchpad.net/bugs/<todo-bug>
42+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=<todo-bug>
43+Last-Update: 2019-03-07
44+
45+---
46+ CHANGELOG | 1 +
47+ modules/mount_nfs.c | 5 +++--
48+ 2 files changed, 4 insertions(+), 2 deletions(-)
49+
50+--- a/modules/mount_nfs.c
51++++ b/modules/mount_nfs.c
52+@@ -148,8 +148,9 @@ int mount_mount(struct autofs_point *ap,
53+ } else if (_strncmp("use-weight-only", cp, o_len) == 0) {
54+ flags |= MOUNT_FLAG_USE_WEIGHT_ONLY;
55+ } else {
56+- if (_strncmp("vers=4", cp, o_len) == 0 ||
57+- _strncmp("nfsvers=4", cp, o_len) == 0)
58++ /* Is any version of NFSv4 in the options */
59++ if (_strncmp("vers=4", cp, 6) == 0 ||
60++ _strncmp("nfsvers=4", cp, 9) == 0)
61+ vers = NFS4_VERS_MASK | TCP_SUPPORTED;
62+ else if (_strncmp("vers=3", cp, o_len) == 0 ||
63+ _strncmp("nfsvers=3", cp, o_len) == 0) {
64diff --git a/debian/patches/series b/debian/patches/series
65index 6e57a85..209e009 100644
66--- a/debian/patches/series
67+++ b/debian/patches/series
68@@ -13,3 +13,4 @@ fix-autofs-manpage-whatis.patch
69 16group_buffer_size.patch
70 fix-lookup-ldap-crash.patch
71 autofs-5.1.4-dont-allow-trailing-slash-in-master-map-mount-points.patch
72+autofs-5.1.3-handle-additional-nfs-versions-in-mount.patch

Subscribers

People subscribed via source and target branches