Merge ~paelzer/ubuntu/+source/apparmor:lp-1895967-apparmor-in-containers into ubuntu/+source/apparmor:ubuntu/groovy-devel

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: 2f41b7b9bd9beeed09531624fa723415b346dd56
Proposed branch: ~paelzer/ubuntu/+source/apparmor:lp-1895967-apparmor-in-containers
Merge into: ubuntu/+source/apparmor:ubuntu/groovy-devel
Diff against target: 52 lines (+9/-21)
3 files modified
debian/changelog (+9/-0)
debian/patches/series (+0/-1)
dev/null (+0/-20)
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Approve
John Johansen Pending
Canonical Server packageset reviewers Pending
Canonical Server Pending
git-ubuntu developers Pending
Review via email: mp+391134@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4276/+packages
Bug: https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/1895967

FYI
This is not for the server Team to review/upload but for the security Team to take over from here for an upload the way they prefer to maintain changes and uploads.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Got merged \o/

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Sorry I didn't see the MP and I uploaded with a different changelog. Thank you so much for the analysis and this MP! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 45c49aa..10a6987 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+apparmor (3.0.0~beta1-0ubuntu6) groovy; urgency=medium
7+
8+ * Drop old patch lp1824812.patch which is superseded and even conflicting
9+ with 61c27d88 "Fix and simplify setting SFS_MOUNTPOINT" that is in
10+ apparmor 3.0.0 (LP: #1895967). This will fix apparmor in containers
11+ that support stacking.
12+
13+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 22 Sep 2020 16:03:15 +0200
14+
15 apparmor (3.0.0~beta1-0ubuntu5) groovy; urgency=medium
16
17 [ John Johansen ]
18diff --git a/debian/patches/lp1824812.patch b/debian/patches/lp1824812.patch
19deleted file mode 100644
20index 847db01..0000000
21--- a/debian/patches/lp1824812.patch
22+++ /dev/null
23@@ -1,20 +0,0 @@
24-Author: Jamie Strandboge <jamie@canonical.com>
25-Description: set SFS_MOUNTPOINT in is_container_with_internal_policy() since it
26- is sometimes called before is_apparmor_loaded()
27-Bug: https://launchpad.net/bugs/1824812
28-Forwarded: yes
29-
30----
31- parser/rc.apparmor.functions | 1 +
32- 1 file changed, 1 insertion(+)
33-
34---- apparmor-3.0.0-beta1.orig/parser/rc.apparmor.functions
35-+++ apparmor-3.0.0-beta1/parser/rc.apparmor.functions
36-@@ -82,6 +82,7 @@
37- is_container_with_internal_policy() {
38- # this function is sometimes called independently of
39- # is_apparmor_loaded(), so also define this here.
40-+ SFS_MOUNTPOINT="${SECURITYFS}/${MODULE}"
41- local ns_stacked_path="${SFS_MOUNTPOINT}/.ns_stacked"
42- local ns_name_path="${SFS_MOUNTPOINT}/.ns_name"
43- local ns_stacked
44diff --git a/debian/patches/series b/debian/patches/series
45index b95bf3b..1247a7a 100644
46--- a/debian/patches/series
47+++ b/debian/patches/series
48@@ -1,4 +1,3 @@
49-lp1824812.patch
50 parser-fix_cap_match.patch
51 policy-provide-example-and-base-abi-to-pin-pre-3.0-p.patch
52 parser-add-abi-warning-flags.patch

Subscribers

People subscribed via source and target branches