Merge ~paelzer/ubuntu-seeds/+git/platform:demote-nicstat into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:kinetic

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Robie Basak
Merged at revision: 61c3ab890756674927f36fd515e9bcf13cdf2362
Proposed branch: ~paelzer/ubuntu-seeds/+git/platform:demote-nicstat
Merge into: ~ubuntu-core-dev/ubuntu-seeds/+git/platform:kinetic
Diff against target: 12 lines (+0/-1)
1 file modified
supported-misc-servers (+0/-1)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Canonical Server Pending
Review via email: mp+424052@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Per the analysis at https://bugs.launchpad.net/ubuntu/+source/nicstat/+bug/1487190/comments/6, +1 to the demotion of this.

Regarding the followup work, I think I'd actually be a -1 on tasking anyone with the fix, since the patch has been there 7 years (and forwarded to Debian) with no additional comments by anyone outside our team. But just IMHO about if it's worth the effort; I don't see any actual harm in landing the patch.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks, landed

On the fix itself I agree that it has to compete with other low-prio things and without anyone voting for it, it might be stalled for quite a while.
But it also is a great bitesize easy new-starter case :-)

Revision history for this message
Robie Basak (racb) wrote :

This is merged, but didn't get automatically marked as merged because the final commit isn't the same (ie. it was rewritten - presumably rebased).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/supported-misc-servers b/supported-misc-servers
2index 35599d7..efab766 100644
3--- a/supported-misc-servers
4+++ b/supported-misc-servers
5@@ -81,7 +81,6 @@ Utilities:
6 * iotop
7 * john
8 * libmemcached-tools #ClintByrum - server-maverick-uds-web20-workloads
9- * nicstat
10 * nut # UPS management
11 * nut-cgi
12 * nut-snmp

Subscribers

People subscribed via source and target branches