Merge ~paelzer/ubuntu-archive-tools:split-teams into ubuntu-archive-tools:main

Proposed by Christian Ehrhardt
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 67c845136a2c8b13fcb814a533ecd98b0b5a5024
Merged at revision: 67c845136a2c8b13fcb814a533ecd98b0b5a5024
Proposed branch: ~paelzer/ubuntu-archive-tools:split-teams
Merge into: ubuntu-archive-tools:main
Diff against target: 55 lines (+10/-5)
2 files modified
change-override (+1/-1)
lputils.py (+9/-4)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+486406@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt (paelzer) wrote :

The initial set of teams is based on a quick check if I know a Canonical team behind them.
But with the split in place we can in future PRs update it further.

For example seb128 and I discussed if nowadays ubuntu-printing should move to debcrafters anyway - and then be dropped from owners (but not from team_names i guess)

Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks good and makes sense, thanks!

review: Approve
Revision history for this message
Christian Ehrhardt (paelzer) wrote :

I tested this with change-override e.g. akonadi (kubuntu-bugs and in universe) would now be flagged as lacking an owning canonical team, while formerly it was not.

Revision history for this message
Christian Ehrhardt (paelzer) wrote :

Thanks for having a look, merging ...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/change-override b/change-override
2index b4308aa..2c75db6 100755
3--- a/change-override
4+++ b/change-override
5@@ -115,7 +115,7 @@ def change_overrides(options, packages):
6 source_package = lpubuntu.getSourcePackage(name=source)
7 for subscription in source_package.getSubscriptions():
8 subscriber = subscription.subscriber
9- if subscriber.name in lputils.team_names:
10+ if subscriber.name in lputils.owner_names:
11 known_team_subscribed = True
12 break
13 if not known_team_subscribed:
14diff --git a/lputils.py b/lputils.py
15index 01fdb71..13d4172 100644
16--- a/lputils.py
17+++ b/lputils.py
18@@ -43,7 +43,8 @@ ARCHIVE_REFERENCE_DESCRIPTION = (
19 '"ubuntu/partner" for a partner or copy archive.')
20
21
22-team_names = [
23+# Used for tooling that checks if a Canonical team is subscribed for ownership
24+owner_names = [
25 'canonical-hw-cert',
26 'canonical-mainstream',
27 'canonical-support',
28@@ -53,13 +54,10 @@ team_names = [
29 'documentation-packages',
30 'foundations-bugs',
31 'kernel-packages',
32- 'kubuntu-bugs',
33 'landscape-bugs',
34 'maas-maintainers',
35 'mir-team',
36- 'pkg-ime',
37 'snappy-dev',
38- 'translators-packages',
39 'ubuntu-lxc',
40 'ubuntu-openstack',
41 'ubuntu-printing',
42@@ -69,6 +67,13 @@ team_names = [
43 'ubuntu-tegra',
44 ]
45
46+# Used for tooling that displays per-team
47+team_names = [
48+ 'kubuntu-bugs',
49+ 'pkg-ime',
50+ 'translators-packages',
51+ ] + owner_names
52+
53 def setup_location(args, default_pocket="Release"):
54 archive = None
55 if getattr(args, "archive", False):

Subscribers

People subscribed via source and target branches