Merge ~paelzer/germinate:report-arch-a-dependency-was-not-found into germinate:master

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

I added the fix that I've found for bug 1895106 to this MP as well

[Christian Ehrhardt  (paelzer)]

ping?

[Christian Ehrhardt  (paelzer)]

Any chance to get this reviewed / merged?

[Colin Watson (cjwatson)]

LGTM. I don't see the fix you mentioned for bug 1895106, though, and I wonder if perhaps you forgot to push it. Perhaps open a new MP for that commit once you find it?

review: Approve

[Christian Ehrhardt  (paelzer)]

Thanks for review and merge Colin.

I was checking the local branch that I had - you are right and thanks for the hint.
I have not yet pushed that - opening new MP https://code.launchpad.net/~paelzer/germinate/+git/germinate/+merge/396826 for it.

diff --git a/germinate/germinator.py b/germinate/germinator.py
index be808b9..11ad556 100644
--- a/germinate/germinator.py
+++ b/germinate/germinator.py
@@ -962,7 +962,8 @@ class Germinator(object):
 
             else:
                 # No idea
-                _logger.error("Unknown %s package: %s", seed, pkg)
+                _logger.error("Unknown package %s for seed %s on arch %s",
+                              pkg, seed, self._arch)
 
         for pkg in seedsnaps:
             seed._snaps.add(pkg)
@@ -1452,9 +1453,9 @@ class Germinator(object):
                 desc = "recommendation"
             else:
                 desc = "dependency"
-            _logger.error("Unknown %s %s by %s", desc,
+            _logger.error("Unknown %s %s by %s on arch %s", desc,
                           self._unparse_dependency(depname, depver, deptype),
-                          pkg)
+                          pkg, self._arch)
             return False
 
         if dependlist: