Merge lp:~paelzer/gdebi/gdebi-fix-glib-2.68 into lp:gdebi

[Christian Ehrhardt ]

[Christian Ehrhardt  (paelzer)]

Filed as Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989647
and Ubuntu bug: https://bugs.launchpad.net/debian/+source/gdebi/+bug/1931394

[Michael Vogt (mvo)]

Thanks for the patch. Unfortunately this patch does not look quite correct.

The function gio_copy_in_place() is a small helper that is meant to downlaod the file to the local system for non "file:/" urls. For remote urls the "os.path.exists(file)" will always be false so this will break gdebi operations on urls (I might read this code wrong though, it has been some years since I actively worked on gdebi :)

I assume this is patch was created to fix an autopkgtest issue? Do you have more details, like a failed run or anything like this?

review: Needs Fixing

[Christian Ehrhardt  (paelzer)]

Hi Michael,
thanks for clarifying.

In that case we can still make it work well, let me rewrite it.
I'm ok that we don't use file-exist - I've had it verify to work if we only use '!=""'.
So if called (e.g. from tests) without a path then don't enter that.

I'll push it in a bit once I have bzr convinced to do what I want.

[lp:~paelzer/gdebi/gdebi-fix-glib-2.68]

494. By Christian Ehrhardt  on 2021-06-09

gio_copy_in_place can be used for remote urls

Due to that let us now check on os.path.exists, but still if no path/uri
was passed at all skip the call.

[Christian Ehrhardt  (paelzer)]

The linked bug reports in comment #1 here hold more details and test logs.
Also I've now properly linked the LP bug to the MP.

I re-pushed the branch with another commit on top removing the os.path.exists

[Michael Vogt (mvo)]

Thank you, this looks fine.

review: Approve

Unmerged revisions

494. By Christian Ehrhardt  on 2021-06-09

gio_copy_in_place can be used for remote urls

Due to that let us now check on os.path.exists, but still if no path/uri
was passed at all skip the call.

493. By Christian Ehrhardt  on 2021-06-09

Avoid hangs with glib2-0 2.68 and later

The behavior of gio.File changes and got more restrictive.
gdebi used to call gio_copy_in_place to check the file, but that
now either fails badly:
    g-io-error-quark: Operation not supported (15)
and/or gets stuck in tests when printing error messages (triggered by
the above root cause)

The problem is that without an argument passed to "file" it tries to
copy a non-existing file in place which fails.

In this case (no filename passed) just don't check on the files.

=== modified file 'GDebi/GDebiGtk.py'
--- GDebi/GDebiGtk.py	2015-07-08 13:31:21 +0000
+++ GDebi/GDebiGtk.py	2021-06-09 12:56:23 +0000
@@ -119,7 +119,8 @@
                                  self.on_window_main_drag_data_received)
 
         # Check file with gio
-        file = self.gio_copy_in_place(file)
+        if file != "":
+            file = self.gio_copy_in_place(file)
 
         #self.vte_terminal.set_font_from_string("monospace 10")
         self.cprogress = self.CacheProgressAdapter(self.progressbar_cache)