> so, some comments inline . that might seem like a lot, and that i'm nit
> picking. Sorry if it seems like that.
You are not, I'm happy about a good review and that it is!
If the file would be free of warnings in general it would be easier to see the new ones :-)
I usually found a lot of missing docstrings and invalid constant/variable name issues of pylint littering my view of checker warnings probably too much.
Anyway - most of the (not nit) picks are stuff I copied or moved and now you just look at it again - so I don't feel offended but assisted to make the code better.
I found even more minor things on my own in the meantime that I can merge in given that changes of a respin.
> so, some comments inline . that might seem like a lot, and that i'm nit
> picking. Sorry if it seems like that.
You are not, I'm happy about a good review and that it is!
If the file would be free of warnings in general it would be easier to see the new ones :-)
I usually found a lot of missing docstrings and invalid constant/variable name issues of pylint littering my view of checker warnings probably too much.
Anyway - most of the (not nit) picks are stuff I copied or moved and now you just look at it again - so I don't feel offended but assisted to make the code better.
I found even more minor things on my own in the meantime that I can merge in given that changes of a respin.