britney

Merge lp:~paelzer/britney/hints-ubuntu-mask-livecd-rootfs-disco into lp:~ubuntu-release/britney/hints-ubuntu

  1. hints-ubuntu-mask-livecd-rootfs-disco
  2. Merge into hints-ubuntu
Proposed by Christian Ehrhardt 
Status: Merged
Merged at revision: 3507
Proposed branch: lp:~paelzer/britney/hints-ubuntu-mask-livecd-rootfs-disco
Merge into: lp:~ubuntu-release/britney/hints-ubuntu
Diff against target: 10 lines (+3/-0)
1 file modified
ubuntu-release (+3/-0)
To merge this branch: bzr merge lp:~paelzer/britney/hints-ubuntu-mask-livecd-rootfs-disco
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Balint Reczey Pending
Review via email: mp+362475@code.launchpad.net

This proposal supersedes a proposal from 2019-01-30.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote : Posted in a previous version of this proposal

Hmm, that lacks my actual commit - dear bzr what are you doing?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote : Posted in a previous version of this proposal

Ah, here it is.

@rbalint - please let me know if you'd agree to this temporary stop-gap of more and more packages being gated on livecd-rootfs.

Revision history for this message
Balint Reczey (rbalint) wrote : Posted in a previous version of this proposal

Hi, I support the hint but the diff is off.

review: Needs Fixing
Revision history for this message
Christian Ehrhardt  (paelzer) wrote : Posted in a previous version of this proposal

wow that diff is odd, that must be the merge target that is off
I'll sort it out and find someone to push it.

Thanks for your general +1 on this Balint!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

As soon as the merge target was correct the diff looks ok.

Given that I fixed the only concern (bad merge target) I'd hope that one of the release Team could merge that to unblock a few migrations.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-release'
2--- ubuntu-release 2019-01-29 21:43:26 +0000
3+++ ubuntu-release 2019-01-30 16:48:29 +0000
4@@ -203,3 +203,6 @@
5
6 # autopkgtests regress but this package is needed as a build-dep https://bugs.debian.org/878337
7 force-badtest node-grunt-contrib-concat/1.0.1-2
8+
9+# autopkgtests regressed and it is a false-positive for now (LP: #1813730)
10+force-badtest livecd-rootfs/2.558