Merge lp:~paelzer/britney/hints-ubuntu-focal-strongswan-no-i386 into lp:~ubuntu-release/britney/hints-ubuntu

Proposed by Christian Ehrhardt 
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp:~paelzer/britney/hints-ubuntu-focal-strongswan-no-i386
Merge into: lp:~ubuntu-release/britney/hints-ubuntu
Diff against target: 11 lines (+1/-0)
1 file modified
ubuntu-release (+1/-0)
To merge this branch: bzr merge lp:~paelzer/britney/hints-ubuntu-focal-strongswan-no-i386
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Review via email: mp+378708@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

See the (long) commit message for reasoning, ah well you know I'll copy and paste it here - might be easier.

The issue reproduces in autopkgtest:
$ sudo ~/work/autopkgtest/autopkgtest/runner/autopkgtest --no-built-binaries --apt-upgrade --apt-pocket=proposed=src:re2c --setup-commands="dpkg --add-architecture i386; apt-get update" --shell-fail -a i386 strongswan_5.8.2-1ubuntu1.dsc -- qemu --qemu-options='-cpu host' --ram-size=2048 --cpus 2 ~/work/autopkgtest-focal-amd64.img

But it makes no sense, if you check in there:

ubuntu@autopkgtest:~$ dpkg --print-foreign-architectures
i386
ubuntu@autopkgtest:~$ dpkg --print-architecture
amd64

And listed by
ubuntu@autopkgtest:~$ apt-cache policy strongswan
strongswan:
  Installed: (none)
  Candidate: 5.8.1-1ubuntu1
  Version table:
     5.8.2-1ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main i386 Packages
     5.8.1-1ubuntu1 990
        990 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages
        990 http://archive.ubuntu.com/ubuntu focal/main i386 Packages

But still it can't find/install it:
ubuntu@autopkgtest:~$ sudo apt-get install strongswan:i386
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package strongswan:i386

So far so good, but why does it then trigger and fail on the i386 test?
http://autopkgtest.ubuntu.com/packages/s/strongswan/focal/i386

Because from d/control:
Package: strongswan
Architecture: all

But it is not just all being Arch:all it also happens to
Package: strongswan-pki
Architecture: any

And per https://lists.ubuntu.com/archives/ubuntu-devel/2019-December/040859.html it isn't part of the whitelist.
So I'd expect the test to just "not run".

I'm a bit uncertain, if the resolution is a different one than merging this MP please let me know what it is.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

In a similar fashion IMHO "kronosnet" which also shows up in excused shouldn't run i386 tests at all. I'm waiting how this MP resolves to know how to handle those.

But if you want feel free to add it right away along strongswan.

Revision history for this message
Steve Langasek (vorlon) wrote :

Because strongswan is not in the i386 whitelist, we shouldn't be adding a versioned hint. I already added a hint for strongswan/all/i386 before reviewing this MP, so rejecting now.

review: Disapprove
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Ok, so no-whitelist = unversioned hint - thanks!

Unmerged revisions

4493. By Christian Ehrhardt 

Strongswan is not in the i386 whitelist but triggers tests

The issue reproduces in autopkgtest:
$ sudo ~/work/autopkgtest/autopkgtest/runner/autopkgtest --no-built-binaries
--apt-upgrade --apt-pocket=proposed=src:re2c --setup-commands="dpkg
--add-architecture i386; apt-get update" --shell-fail -a i386
strongswan_5.8.2-1ubuntu1.dsc -- qemu --qemu-options='-cpu host'
--ram-size=2048 --cpus 2 ~/work/autopkgtest-focal-amd64.img

But it makes no sense, if you check in there:

ubuntu@autopkgtest:~$ dpkg --print-foreign-architectures
i386
ubuntu@autopkgtest:~$ dpkg --print-architecture
amd64

And listed by
ubuntu@autopkgtest:~$ apt-cache policy strongswan
strongswan:
  Installed: (none)
  Candidate: 5.8.1-1ubuntu1
  Version table:
     5.8.2-1ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main i386 Packages
     5.8.1-1ubuntu1 990
        990 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages
        990 http://archive.ubuntu.com/ubuntu focal/main i386 Packages

But still it can't find/install it:
ubuntu@autopkgtest:~$ sudo apt-get install strongswan:i386
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package strongswan:i386

So far so good, but why does it then trigger and fail on the i386 test?
http://autopkgtest.ubuntu.com/packages/s/strongswan/focal/i386

Because from d/control:
Package: strongswan
Architecture: all

But it is not just all being Arch:all it also happens to
Package: strongswan-pki
Architecture: any

And per https://lists.ubuntu.com/archives/ubuntu-devel/2019-December/040859.html
it isn't part of the whitelist.
So I'd expect the test to just "not run".

For now ignore it at least on the current version.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-release'
2--- ubuntu-release 2020-02-07 08:10:00 +0000
3+++ ubuntu-release 2020-02-07 11:43:20 +0000
4@@ -8501,6 +8501,7 @@
5
6 # requires more investigation
7 ##
8+force-badtest strongswan/5.8.2-1ubuntu1/i386
9 force-badtest libnotify/0.7.8-1ubuntu4/i386
10 force-badtest nvidia-graphics-drivers-390/390.132-0ubuntu2/i386
11 force-badtest openjdk-lts/11.0.6+10-1ubuntu1/i386