apt-clone

Merge lp:~paelzer/apt-clone/apt-clone-fix-fails-early-cycle into lp:apt-clone

  1. apt-clone-fix-fails-early-cycle
  2. Merge into trunk
Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Michael Vogt
Approved revision: 165
Merge reported by: Christian Ehrhardt 
Merged at revision: not available
Proposed branch: lp:~paelzer/apt-clone/apt-clone-fix-fails-early-cycle
Merge into: lp:apt-clone
Diff against target: 12 lines (+1/-1)
1 file modified
tests/test_clone_upgrade.py (+1/-1)
To merge this branch: bzr merge lp:~paelzer/apt-clone/apt-clone-fix-fails-early-cycle
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Julian Andres Klode Approve
Review via email: mp+393310@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Added mvo directly since (at least for historical reasons) he is the apt-cache owner.
@mvo - are you still merging and uploading this package if needed?

Revision history for this message
Julian Andres Klode (juliank) wrote :

This makes sense to me.

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

Makes sense

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

Merged on https://github.com/mvo5/apt-clone/commit/a5d21715ed4407b9ebd326b8932d0201c7f0802b and uploaded 0.4.2 with the fixes to debian. This can be a straight "sync" again.

Revision history for this message
Michael Vogt (mvo) wrote :

I synced the debian upload into hirsute this morning.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test_clone_upgrade.py'
2--- tests/test_clone_upgrade.py 2014-02-24 18:58:05 +0000
3+++ tests/test_clone_upgrade.py 2020-11-04 10:57:12 +0000
4@@ -37,7 +37,7 @@
5 for meta in ["ubuntu-standard", "ubuntu-desktop", "kubuntu-desktop",
6 "xubuntu-desktop"]:
7 logging.info("testing %s" % meta)
8- old = self._create_fake_upgradable_root(supported[-2], meta=meta)
9+ old = self._create_fake_upgradable_root(supported[0], meta=meta)
10 self.addCleanup(shutil.rmtree, old)
11 # create statefile based on the old data
12 with tarfile.open("lala.tar.gz", "w:gz") as state:

Subscribers

People subscribed via source and target branches