Merge lp:~pablocm/account-payment/7.0-account-payment-extension-groups-fix into lp:~account-payment-team/account-payment/7.0

Proposed by PabloCM on 2014-01-29
Status: Merged
Merged at revision: 110
Proposed branch: lp:~pablocm/account-payment/7.0-account-payment-extension-groups-fix
Merge into: lp:~account-payment-team/account-payment/7.0
Diff against target: 15 lines (+2/-2)
1 file modified
account_payment_extension/account_payment_view.xml (+2/-2)
To merge this branch: bzr merge lp:~pablocm/account-payment/7.0-account-payment-extension-groups-fix
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review Approve on 2014-03-17
Pedro Manuel Baeza code review 2014-01-29 Approve on 2014-01-29
Review via email: mp+203677@code.launchpad.net

Description of the change

Removed the groups attribute on the field reconcile_partial_id and changed it to multi currency on currency_id on the account.move.line tree view. They were referencing the no longer existant base.group_extended.

To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
review: Approve (code review)
Pedro Manuel Baeza (pedro.baeza) wrote :

I'll proceed to do the merge due to the two approvals and to have passed enough time from the proposal.

Regards.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_payment_extension/account_payment_view.xml'
2--- account_payment_extension/account_payment_view.xml 2013-08-18 21:18:02 +0000
3+++ account_payment_extension/account_payment_view.xml 2014-01-29 08:38:15 +0000
4@@ -29,9 +29,9 @@
5 <field name="amount_to_pay"/>
6 </field>
7 <field name="currency_id" position="replace">
8- <field name="currency_id" groups="base.group_extended"/>
9+ <field name="currency_id" groups="base.group_multi_currency"/>
10 <field name="reconcile_id"/>
11- <field name="reconcile_partial_id" groups="base.group_extended"/>
12+ <field name="reconcile_partial_id"/>
13 <field name="state"/>
14 <field name="payment_type"/>
15 </field>