Code review comment for lp:~pablocm/account-payment/7.0-account-payment-extension-fix-invoice-field

Revision history for this message
PabloCM (pablocm) wrote :

> I know it is really bad to overwrite the field, shadowing future changes, but
> I had to. If I don't, the new methods won't get called. Maybe it's only
> happening
> in the instance I've tested it (openerp-7.0-20130806-231058) but are you sure
> it
> works as you say?

By the way, this is the reason the problem with the variable names had
passed unnoticed: because since the field wasn't overwritten, the new _invoice
was never being called. It should have thrown an error as soon as you opened the
"Journal Items" menu.

« Back to merge proposal