Allow compositor-thread specific data to be uninitialized in OutputSurface when using surfaces
When using surfaces, cc::OutputSurface::DetachFromClient isn't called on the compositor thread,
but we currently do some work that depends on this in Oxide. As we can't use DetachFromClient here
(it releases the cc::ContextProvider, which is needed by the cc::Display destructor on the main
thread), we introduce a new method - cc::OutputSurface::DetachFromDisplayClient.
This is a temporary hack - we should refactor Oxide to not rely on this
Change UnixEventEmitter to use a generic FIFOInterface instead of
FIFOChar specifically. Add bytewise Read() and Write() methods to
the former interface so that subclasses can handle both stream and
datagram based communication. For SOCK_DGRAM, use the FIFOPacket
class as the backend instead of FIFOChar.
[Android] Use fallback icon if there is no large favicon on the history page
This CL makes the history page use a rounded rectangle with the first letter of
the URL for history entries for which there is no large enough favicon.
Previously, the history page did a really bad resize for entries for which there
is no large enough favicon.
This CL:
- Introduces an Android version of FallbackIconService:
FallbackIconServiceImplAndroid which uses RoundedIconGenerator
- Encodes the SkBitmap produced by FallbackIconService to PNG on a worker
thread. Encoding to PNG takes on average 5ms on a Nexus 5.
0cb6b42...
by
"rdevlin.cronin" <email address hidden>
[UI Views] Handle accelerators being pressed for buttons inside a menu
CustomButton::AcceleratorPressed checks that the button's widget is active,
but this won't be true for a button hosted inside a menu. Add support for
in-menu buttons being triggered by the keyboard, and add a test.
- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").
Unfortunately this means the UI/presentational concept of cancel/accept is inverted from the model's definition.
