Merge lp:~ovnicraft/account-financial-tools/account-financial-tools-inv-voucher-constraints into lp:~account-core-editors/account-financial-tools/7.0

[Cristian Salamea]

Added constraint module for account.
First constaint added in vouchers
Voucher module pass silent difference to payable|receivable account if amount_diff is > 0.

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

LGTM from code point of view, accountant opinion might be useful before merging.

review: Approve (code review, no tests)

[Nhomar - Vauxoo (nhomar)]

Hello.

In the description:

62 + 'description': """This module implement constraints required in account documents:
63 + Voucher: check open balance with amount
64 + Invoice: due_date must be in period

And in the code there are only one contraint.

I don't understand why validate the amount here, if you please can enlight us to understand why this amount from a functional PoV must be lower than another it should be great.

From My PoV i can pay more or less than what I mark in the invoice, we just need to be sure the reconciliation stay as partial (as it is now) to use the difference in other payment process, but may be I am wrong.

Thanks for your contribution.

review: Needs Information

[Cristian Salamea (ovnicraft)]

Hi,

in fact i consider a bug in openerp and constraint solve this problem:
Make and invoice, click on pay all default values are loaded, user can chance amount value, error happens when you pay more, system silent resolve problem and send the difference to payable|receivable account, from account PoV this cannot happen.

Constraint make this explicit, if you will let open balance most be less or the same value, if more change balance option to send to specific account.

This make more clear the process to account users.

I work this with accountants customers and all are a little bit happy .-).

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

Please update the module description according to the constraint provided, or implement the second constraint.

Thanks.

review: Needs Fixing (code review)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

No changes since 2013-11-03 after Need Fixing request -> I set this in WIP

@Cristian Salamea (Gnuthink) (ovnicraft)

Please do the required changes then set it in Needs Review again

(And please do a merge of lp:account-financial-tools in this branche to resolve conflicts)

Cheers,
Yannick

Unmerged revisions

96. By Cristian Salamea on 2013-07-16

[FIX] typo message error

95. By Cristian Salamea on 2013-01-02

[IMP] simplest method validation, dont allow users cause entry with extra line error

94. By Cristian Salamea on 2013-01-02

[IMP] constraint in voucher amount

=== added directory 'account_constraints'
=== renamed directory 'account_constraints' => 'account_constraints.moved'
=== added file 'account_constraints/__init__.py'
--- account_constraints/__init__.py	1970-01-01 00:00:00 +0000
+++ account_constraints/__init__.py	2013-07-17 22:25:56 +0000
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Account Constraints module for OpenERP
+#    Copyright (C) 2013 Gnuthink (http://www.gnuthink.com). All Rights Reserved
+#    @author Cristian Salamea <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import voucher

=== added file 'account_constraints/__openerp__.py'
--- account_constraints/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_constraints/__openerp__.py	2013-07-17 22:25:56 +0000
@@ -0,0 +1,41 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Account Constraints module for OpenERP
+#    Copyright (C) 2013 Gnuthink (http://www.gnuthink.com). All Rights Reserved
+#    @author Cristian Salamea <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Account Constraints',
+    'version': '0.1',
+    'category': 'Generic Modules/Accounting',
+    'license': 'AGPL-3',
+    'description': """This module implement constraints required in account documents:
+    Voucher: check open balance with amount
+    Invoice: due_date must be in period
+    """,
+    'author': 'Gnuthink Co. Ltd.',
+    'website': 'http://www.gnuthink.com/',
+    'depends': ['account_voucher'],
+    'init_xml': [],
+    'update_xml': [],
+    'demo_xml': [],
+    'installable': True,
+    'active': False,
+}
+

=== added file 'account_constraints/voucher.py'
--- account_constraints/voucher.py	1970-01-01 00:00:00 +0000
+++ account_constraints/voucher.py	2013-07-17 22:25:56 +0000
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Account Constraints module for OpenERP
+#    Copyright (C) 2013 Gnuthink (http://www.gnuthink.com). All Rights Reserved
+#    @author Cristian Salamea <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from osv import osv
+
+class AccountVoucher(osv.Model):
+
+    _inherit = 'account.voucher'
+
+    def _check_amount_payment(self, cr, uid, ids):
+        """
+        Method to check writeoff option set `with` when
+        writeoff amount > 0.
+        
+        CHECK: possible with sql_constraint ?
+        """
+        for obj in self.browse(cr, uid, ids):
+            if obj.writeoff_amount > 0 and obj.payment_option == 'without_writeoff':
+                return False
+        return True
+
+    _constraints = [(_check_amount_payment, "Amount can't be great than unreconciled total.", ['Amount to Pay'])]
+
+