Merge lp:~ourdelta-core/maria/maria-5.1-ourdelta into lp:~maria-captains/maria/5.1-converting

Proposed by Cafuego
Status: Merged
Merge reported by: Kristian Nielsen
Merged at revision: not available
Proposed branch: lp:~ourdelta-core/maria/maria-5.1-ourdelta
Merge into: lp:~maria-captains/maria/5.1-converting
Diff against target: 151 lines
8 files modified
Docs/myisam.txt (+1/-1)
configure.in (+1/-1)
mysql-test/mysql-stress-test.pl (+2/-2)
mysys/safemalloc.c (+1/-1)
sql/mysqld.cc (+2/-2)
sql/sql_select.cc (+1/-1)
sql/udf_example.c (+1/-1)
support-files/mysql.server.sh (+29/-2)
To merge this branch: bzr merge lp:~ourdelta-core/maria/maria-5.1-ourdelta
Reviewer Review Type Date Requested Status
Kristian Nielsen Approve
Review via email: mp+13815@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kristian Nielsen (knielsen) wrote :

Thanks, Peter!
I have merged and pushed this into lp:~maria-captains/maria/maria-5.1-merge, so
it will be included in the upcoming release.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Docs/myisam.txt'
2--- Docs/myisam.txt 2000-07-31 19:29:14 +0000
3+++ Docs/myisam.txt 2009-10-23 03:10:31 +0000
4@@ -868,7 +868,7 @@
5 Prefix compression helps if there are many strings with an identical prefix.
6
7 In memory table characteristics
8-HEAP tables only exists in memory so they are lost if `mysqld' is taken down or crashes. But since they are *very* fast they are usefull as anyway.
9+HEAP tables only exists in memory so they are lost if `mysqld' is taken down or crashes. But since they are *very* fast they are useful as anyway.
10
11 The *MySQL* internal HEAP tables uses 100% dynamic hashing without overflow areas and don't have problems with delete.
12
13
14=== modified file 'configure.in'
15--- configure.in 2009-10-08 09:43:31 +0000
16+++ configure.in 2009-10-23 03:10:31 +0000
17@@ -2847,7 +2847,7 @@
18 done
19 AC_SUBST(sql_union_dirs)
20
21-# Some usefull subst
22+# Some useful subst
23 AC_SUBST(CC)
24 AC_SUBST(GXX)
25
26
27=== modified file 'mysql-test/mysql-stress-test.pl'
28--- mysql-test/mysql-stress-test.pl 2006-03-03 18:15:01 +0000
29+++ mysql-test/mysql-stress-test.pl 2009-10-23 03:10:31 +0000
30@@ -1100,7 +1100,7 @@
31 they specified in the list file.
32
33 --sleep-time=<time in seconds>
34- Delay between test execution. Could be usefull in continued testsing
35+ Delay between test execution. Could be useful in continued testsing
36 when one of instance of stress script perform periodical cleanup or
37 recreating of some database objects
38
39@@ -1109,7 +1109,7 @@
40
41 --check-tests-file
42 Check file with list of tests. If file was modified it will force to
43- reread list of tests. Could be usefull in continued testing for
44+ reread list of tests. Could be useful in continued testing for
45 adding/removing tests without script interruption
46
47 --mysqltest=/path/to/mysqltest binary
48
49=== modified file 'mysys/safemalloc.c'
50--- mysys/safemalloc.c 2009-09-07 20:50:10 +0000
51+++ mysys/safemalloc.c 2009-10-23 03:10:31 +0000
52@@ -436,7 +436,7 @@
53 /*
54 Report where a piece of memory was allocated
55
56- This is usefull to call from withing a debugger
57+ This is useful to call from withing a debugger
58 */
59
60 void sf_malloc_report_allocated(void *memory)
61
62=== modified file 'sql/mysqld.cc'
63--- sql/mysqld.cc 2009-10-07 13:07:10 +0000
64+++ sql/mysqld.cc 2009-10-23 03:10:31 +0000
65@@ -4712,7 +4712,7 @@
66 if (opt_delim= strchr(extra_opt, '='))
67 {
68 size_t length= ++opt_delim - extra_opt;
69- strnmov(pos, extra_opt, length);
70+ pos= strnmov(pos, extra_opt, length);
71 }
72 else
73 opt_delim= extra_opt;
74@@ -6630,7 +6630,7 @@
75 0, 0, 0, 0, 0},
76
77 {"test-ignore-wrong-options", OPT_TEST_IGNORE_WRONG_OPTIONS,
78- "Ignore wrong enums values in command line arguments. Usefull only for test scripts",
79+ "Ignore wrong enums values in command line arguments. Useful only for test scripts",
80 (uchar**) &opt_ignore_wrong_options, (uchar**) &opt_ignore_wrong_options,
81 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
82 {"timed_mutexes", OPT_TIMED_MUTEXES,
83
84=== modified file 'sql/sql_select.cc'
85--- sql/sql_select.cc 2009-09-15 10:46:35 +0000
86+++ sql/sql_select.cc 2009-10-23 03:10:31 +0000
87@@ -11812,7 +11812,7 @@
88 {
89 #if !defined(DBUG_OFF) && defined(NOT_USING_ITEM_EQUAL)
90 /*
91- This test could be very usefull to find bugs in the optimizer
92+ This test could be very useful to find bugs in the optimizer
93 where we would call this function with an expression that can't be
94 evaluated yet. We can't have this enabled by default as long as
95 have items like Item_equal, that doesn't report they are const but
96
97=== modified file 'sql/udf_example.c'
98--- sql/udf_example.c 2009-04-25 10:05:32 +0000
99+++ sql/udf_example.c 2009-10-23 03:10:31 +0000
100@@ -205,7 +205,7 @@
101 ** try to keep the error message less than 80 bytes long!
102 **
103 ** This function should return 1 if something goes wrong. In this case
104-** message should contain something usefull!
105+** message should contain something useful!
106 **************************************************************************/
107
108 #define MAXMETAPH 8
109
110=== modified file 'support-files/mysql.server.sh'
111--- support-files/mysql.server.sh 2009-07-02 13:18:12 +0000
112+++ support-files/mysql.server.sh 2009-10-23 03:10:31 +0000
113@@ -434,9 +434,36 @@
114 fi
115 fi
116 ;;
117- *)
118+ 'configtest')
119+ # Safeguard (relative paths, core dumps..)
120+ cd $basedir
121+ echo $echo_n "Testing MySQL configuration syntax"
122+ daemon=$bindir/mysqld
123+ if test -x $libexecdir/mysqld
124+ then
125+ daemon=$libexecdir/mysqld
126+ elif test -x $sbindir/mysqld
127+ then
128+ daemon=$sbindir/mysqld
129+ elif test -x `which mysqld`
130+ then
131+ daemon=`which mysqld`
132+ else
133+ log_failure_msg "Unable to locate the mysqld binary!"
134+ exit 1
135+ fi
136+ help_out=`$daemon --help 2>&1`; r=$?
137+ if test "$r" != 0 ; then
138+ log_failure_msg "$help_out"
139+ log_failure_msg "There are syntax errors in the server configuration. Please fix them!"
140+ else
141+ log_success_msg "Syntax OK"
142+ fi
143+ exit $r
144+ ;;
145+ *)
146 # usage
147- echo "Usage: $0 {start|stop|restart|reload|force-reload|status} [ MySQL server options ]"
148+ echo "Usage: $0 {start|stop|restart|reload|force-reload|status|configtest} [ MySQL server options ]"
149 exit 1
150 ;;
151 esac

Subscribers

People subscribed via source and target branches