~otubo/cloud-init:nm-support

Last commit made on 2019-01-15
Get this branch:
git clone -b nm-support https://git.launchpad.net/~otubo/cloud-init
Only Eduardo Otubo can upload to this branch. If you are Eduardo Otubo please log in for upload directions.

Branch merges

Branch information

Name:
nm-support
Repository:
lp:~otubo/cloud-init

Recent commits

dc1300a... by Eduardo Otubo

Reword comment to avoid pycodestyle E501 error

b132e73... by Eduardo Otubo

Multiple changes from Chad Smith's comments

aad2cc3... by Eduardo Otubo

multiple fixes from Ryan Harper on my unit test

4f19760... by Eduardo Otubo

multiple fixes per comments on launchpad

7f68926... by Eduardo Otubo

Split sysconfig available method into two

Splitting available method into two separate methods
available_sysconfig() and available_nm() so we can remove the global
variable nm_present = True, and have a better handling of tests with no
side effects.

Signed-off-by: Eduardo Otubo <email address hidden>

f5e3dee... by Eduardo Otubo

Fxing typo in plugin in unit-test

9b56486... by Eduardo Otubo

Multiple changes per review

* Method enable_ifcfg_rh() now accpets a path as argument.
* Typo in word `plugin'
* Now ifcfg-rh is being verified inside config['main']['plugin'] in the
unit test

Signed-off-by: Eduardo Otubo <email address hidden>

946463f... by Eduardo Otubo

Small fixes based on maintainers feedback

Addressed all small fixes based on maintainers comments:

1) variable nm_present is now global in the cloudinit/net/sysconfig.py
file scope, since it needs to be checked and modified in both
available() method and __init__() method inside Renderer class

2) check_and_enable_ifcfg_rh() shouldn't chanage system configuration
inside available() method. So renamed to enable_ifcfg_rh() and moved to
__init__() method inside Renderer class,

3) Small logic fixes on other parts of available() method

Signed-off-by: Eduardo Otubo <email address hidden>

bbcc725... by Eduardo Otubo

Move nm-sysconfig unit test to tests/unittests/test_net.py

Since it's not entirely necessary to have a test of its own, this patch
moves the Network-Manager plugin detection unit test to
tests/unittests/test_net.py

Signed-off-by: Eduardo Otubo <email address hidden>

10dd3b1... by Eduardo Otubo

Wrong If when searching for sysconfig files

This 'if' condition was erroneous set to 'not' when searching for
sysconfig configuration files resulting in the renderer malfunction and
not configuring NetworkManager correctly.

Signed-off-by: Eduardo Otubo <email address hidden>