Merge lp:~osomon/webbrowser-app/youtube-ua-override into lp:webbrowser-app

[Olivier Tilloy]

Add a UA override rule for m.youtube.com to allow playing videos.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:556
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/857/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/603
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-touch/152/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/535
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/742
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/742/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1259
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1259/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6791/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8069

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/857/rebuild

review: Needs Fixing (continuous-integration)

[David Barth (dbarth)]

Works well

review: Approve

[Bill Filler (bfiller)]

works, should we consider adding the trailing semi colon to the default UA string?

[Olivier Tilloy (osomon)]

I wouldn’t do that, as other sites/apps parsing the UA string might consider it malformed.
I think it makes sense to use a specific override for this case.

Note that the way the default UA is built, it allows for a device ID token (which, if not empty, will be inserted before the closing parenthesis, with a leading semi-colon).

=== modified file 'src/Ubuntu/Components/Extras/Browser/ua-overrides-mobile.js'
--- src/Ubuntu/Components/Extras/Browser/ua-overrides-mobile.js	2014-04-14 08:12:30 +0000
+++ src/Ubuntu/Components/Extras/Browser/ua-overrides-mobile.js	2014-06-04 11:30:06 +0000
@@ -20,4 +20,5 @@
 
 var overrides = [
     [/^https?:\/\/mail\.google\.com\//, "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4) AppleWebKit/537.36 Chromium/35.0.1870.2 Mobile Safari"],
+    [/^https?:\/\/m\.youtube\.com\//, "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chromium/35.0.1870.2 Mobile Safari/537.36"], // http://pad.lv/1228415
 ];