Merge lp:~osomon/webbrowser-app/work-around-1316057 into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 509
Proposed branch: lp:~osomon/webbrowser-app/work-around-1316057
Merge into: lp:webbrowser-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/app/webbrowser/Browser.qml (+1/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/work-around-1316057
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+218273@code.launchpad.net

Commit message

Work around a recent regression by forcing the OSK to show up when the address bar is being focused.

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

manual test shows the fix works for opening a new tab with image utopic11 on mako.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:509
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/801/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/5236/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/4311
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/303
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/303
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/303/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/303
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/4503/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/5477
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/5477/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4911
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4911/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6539
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/6779

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/801/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/Browser.qml'
2--- src/app/webbrowser/Browser.qml 2014-04-16 22:53:07 +0000
3+++ src/app/webbrowser/Browser.qml 2014-05-05 12:10:28 +0000
4@@ -264,6 +264,7 @@
5 if (!chromeless) {
6 if (focusAddressBar) {
7 panel.chrome.addressBar.forceActiveFocus()
8+ Qt.inputMethod.show() // work around http://pad.lv/1316057
9 panel.open()
10 }
11 }

Subscribers

People subscribed via source and target branches

to status/vote changes: