Merge lp:~osomon/webbrowser-app/webkitdpr-patch-not-mandatory into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Ugo Riboni
Approved revision: 101
Merged at revision: 101
Proposed branch: lp:~osomon/webbrowser-app/webkitdpr-patch-not-mandatory
Merge into: lp:webbrowser-app
Diff against target: 24 lines (+7/-1)
1 file modified
src/Ubuntu/Browser/Browser.qml (+7/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/webkitdpr-patch-not-mandatory
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ugo Riboni (community) Approve
Review via email: mp+155706@code.launchpad.net

Commit message

Allow running with stock QtWebKit as found in Ubuntu,
by not trying to set the 'WebView.experimental.devicePixelRatio' property if it doesn’t exist.

Description of the change

We don’t have the patched webkit (that adds the 'WebView.experimental.devicePixelRatio' property) built in the phablet-team PPA for raring at the moment, so the browser won’t run on a raring desktop at the moment.

This branch relaxes the hard dependency on said patch, thus slightly degrading the functionality, but allowing to run anyway.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

The code is fairly straightforward and looks good to me.
Works on desktop (quantal).

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Browser/Browser.qml'
2--- src/Ubuntu/Browser/Browser.qml 2013-03-25 17:43:06 +0000
3+++ src/Ubuntu/Browser/Browser.qml 2013-03-27 11:25:46 +0000
4@@ -128,7 +128,6 @@
5 }
6 }
7
8- experimental.devicePixelRatio: browser.qtwebkitdpr
9 experimental.preferences.developerExtrasEnabled: browser.developerExtrasEnabled
10 experimental.preferences.navigatorQtObjectEnabled: true
11 experimental.userScripts: [Qt.resolvedUrl("hyperlinks.js"),
12@@ -184,6 +183,13 @@
13 }
14 }
15
16+ onQtwebkitdprChanged: {
17+ // Do not make this patch to QtWebKit a hard requirement.
18+ if (webview.experimental.hasOwnProperty('devicePixelRatio')) {
19+ webview.experimental.devicePixelRatio = qtwebkitdpr
20+ }
21+ }
22+
23 Selection {
24 id: selection
25

Subscribers

People subscribed via source and target branches

to status/vote changes: