Merge lp:~osomon/webbrowser-app/webapp-confinement into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 311
Merged at revision: 313
Proposed branch: lp:~osomon/webbrowser-app/webapp-confinement
Merge into: lp:webbrowser-app
Diff against target: 13 lines (+3/-0)
1 file modified
src/app/webbrowser-app.cpp (+3/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/webapp-confinement
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Alexandre Abreu (community) Approve
Review via email: mp+185862@code.launchpad.net

Commit message

Use the value of APP_ID to set the application name.

This ensures that webapps (which run with a unique app ID) will write their data where they ought to, and that they won’t have access to other apps’ cache and cookies.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

the application name will be used to alter the path for the cache, storage etc caches? no need to manually set the qtwebkit settings ?

review: Needs Information
Revision history for this message
Olivier Tilloy (osomon) wrote :

> the application name will be used to alter the path for the cache, storage etc
> caches? no need to manually set the qtwebkit settings ?

No need indeed, because QtWebKit already uses QStandardPaths internally. See http://code.woboq.org/qt5/qtwebkit/Source/WebKit2/Shared/qt/QtDefaultDataLocation.cpp.html.

Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

THe mako device used in this test appears to have failed, re-approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Build failded due to bzr/launchpad issued, re-approve.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser-app.cpp'
2--- src/app/webbrowser-app.cpp 2013-09-16 12:06:54 +0000
3+++ src/app/webbrowser-app.cpp 2013-09-16 16:47:22 +0000
4@@ -75,6 +75,9 @@
5 QString appId = m_arguments->appId().isEmpty() ? QString(APP_ID) : m_arguments->appId();
6 qputenv("APP_ID", appId.toUtf8());
7 }
8+ // Ensure that application-specific data is written where it ought to.
9+ QString appPkgName = qgetenv("APP_ID").split('_').first();
10+ QCoreApplication::setApplicationName(appPkgName);
11
12 if (m_arguments->remoteInspector()) {
13 QString host;

Subscribers

People subscribed via source and target branches

to status/vote changes: