Merge lp:~osomon/webbrowser-app/ua-override-facebook.com into lp:webbrowser-app
Proposed by
Olivier Tilloy
Status: | Merged |
---|---|
Approved by: | Bill Filler |
Approved revision: | 288 |
Merged at revision: | 316 |
Proposed branch: | lp:~osomon/webbrowser-app/ua-override-facebook.com |
Merge into: | lp:webbrowser-app |
Diff against target: |
9 lines (+1/-0) 1 file modified
src/Ubuntu/Components/Extras/Browser/ua-overrides.js (+1/-0) |
To merge this branch: | bzr merge lp:~osomon/webbrowser-app/ua-override-facebook.com |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bill Filler (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+182862@code.launchpad.net |
Commit message
Override the UA string for facebook.com to ensure we’re getting touch-enabled content.
Without this override, we were getting unstyled mobile content from the 90s.
Impersonating an iphone or android would offer to install the respective applications when logging in.
The 'Firefox' token gets us the right content (and pretending to be AppleWebKit seems to be necessary too, otherwise the layout is busted).
To post a comment you must log in.
FAILED: Continuous integration, rev:288 jenkins. qa.ubuntu. com/job/ webbrowser- app-ci/ 284/ jenkins. qa.ubuntu. com/job/ generic- mediumtests- saucy/2784 jenkins. qa.ubuntu. com/job/ generic- mediumtests- touch/388 jenkins. qa.ubuntu. com/job/ webbrowser- app-saucy- amd64-ci/ 167 jenkins. qa.ubuntu. com/job/ webbrowser- app-saucy- armhf-ci/ 167 jenkins. qa.ubuntu. com/job/ webbrowser- app-saucy- armhf-ci/ 167/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ webbrowser- app-saucy- i386-ci/ 167 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-i386/ 2790 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-i386/ 2790/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- saucy/2361 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 390 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 390/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- maguro/ 351 jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- mako/358
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ webbrowser- app-ci/ 284/rebuild
http://