Merge lp:~osomon/webbrowser-app/ua-override-facebook.com into lp:webbrowser-app

[Olivier Tilloy]

Override the UA string for facebook.com to ensure we’re getting touch-enabled content.

Without this override, we were getting unstyled mobile content from the 90s.
Impersonating an iphone or android would offer to install the respective applications when logging in.
The 'Firefox' token gets us the right content (and pretending to be AppleWebKit seems to be necessary too, otherwise the layout is busted).

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:288
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/284/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2784
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/388
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/167
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/167
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/167/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/167
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2790
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2790/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2361
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/390
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/390/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/351
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/358

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/284/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

Looks like the images served with this override are low resolution. Wild guess: B2G users are assumed to have expensive data plans, so images are served low-res to save on bandwidth.

Switching back to the iphone UA string ("Mozilla/5.0 (iPhone; CPU iPhone OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3"), the same images are served in high resolution.

[Olivier Tilloy (osomon)]

However, when using the iphone UA string, the login page suggests using the iphone app, and right after logging in, the user is presented with a full screen suggesting to download the iphone app instead of browsing the site.

[Olivier Tilloy (osomon)]

Adding an "Android" token to the UA string also gets us high-res images (but of course it offers to install the android app).

Interestingly, I have noticed that only the iphone version offers a proper contextual OSK when entering the e-mail address to use as login (i.e. I’m getting the "@" and ".com" keys by default when this field has focus, whereas I’m getting the default keyboard layout when pretending to be android or firefox).

So it looks like the iphone version is better, if we except the popup that wants to install the iphone app after logging in.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:288
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/289/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2816
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/414
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/172
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/172
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/172/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/172
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2822
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/2822/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2391
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/416
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/416/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/376
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/383

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/289/rebuild

review: Approve (continuous-integration)

[Bill Filler (bfiller)]

approved

review: Approve

=== modified file 'src/Ubuntu/Components/Extras/Browser/ua-overrides.js'
--- src/Ubuntu/Components/Extras/Browser/ua-overrides.js	2013-08-16 14:48:28 +0000
+++ src/Ubuntu/Components/Extras/Browser/ua-overrides.js	2013-08-29 10:51:47 +0000
@@ -93,4 +93,5 @@
     "dailymotion.com": ["Mobile", "Android; Mobile Safari"],
     "amazon.co.uk": ["Mobile", "Android; Mobile"],
     "ebay.co.uk": ["Mobile", "Android; Mobile"],
+    "facebook.com": [/WebKit\/[.0-9]*/, "Apple$& Firefox/18"],
 };