Merge lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1472
Proposed branch: lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide
Merge into: lp:webbrowser-app
Diff against target: 43 lines (+4/-7)
2 files modified
debian/control (+1/-1)
src/Ubuntu/Web/UserAgent02.qml (+3/-6)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+291906@code.launchpad.net

Commit message

Use the chromium version exposed by oxide in the default UA string.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-04-08 17:06:09 +0000
3+++ debian/control 2016-04-14 15:11:09 +0000
4@@ -115,7 +115,7 @@
5 Pre-Depends: ${misc:Pre-Depends}
6 Depends: ${misc:Depends},
7 ${shlibs:Depends},
8- liboxideqt-qmlplugin (>= 1.12),
9+ liboxideqt-qmlplugin (>= 1.15),
10 qml-module-qtquick2 (>= 5.4),
11 qml-module-qtquick-window2 (>= 5.3),
12 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3),
13
14=== modified file 'src/Ubuntu/Web/UserAgent02.qml'
15--- src/Ubuntu/Web/UserAgent02.qml 2015-12-10 10:43:04 +0000
16+++ src/Ubuntu/Web/UserAgent02.qml 2016-04-14 15:11:09 +0000
17@@ -1,5 +1,5 @@
18 /*
19- * Copyright 2013-2015 Canonical Ltd.
20+ * Copyright 2013-2016 Canonical Ltd.
21 *
22 * This file is part of webbrowser-app.
23 *
24@@ -17,6 +17,7 @@
25 */
26
27 import QtQml 2.0
28+import com.canonical.Oxide 1.15
29
30 /*
31 * Useful documentation:
32@@ -57,11 +58,7 @@
33 // See chromium/src/content/webkit_version.h.in in oxide’s source tree.
34 readonly property string _webkitVersion: "537.36"
35
36- // See chromium/src/chrome/VERSION in oxide’s source tree.
37- // Note: the actual version number probably doesn’t matter that much,
38- // however its format does, so we probably don’t need to bump it
39- // every time we rebase on a newer chromium.
40- readonly property string _chromiumVersion: "35.0.1870.2"
41+ readonly property string _chromiumVersion: Oxide.chromiumVersion
42
43 readonly property string _formFactor: smallScreen ? "Mobile" : ""
44

Subscribers

People subscribed via source and target branches

to status/vote changes: