Merge lp:~osomon/webbrowser-app/toolbar-spacing into lp:webbrowser-app

Proposed by Olivier Tilloy
Status: Merged
Approved by: Günter Schwann
Approved revision: 334
Merged at revision: 338
Proposed branch: lp:~osomon/webbrowser-app/toolbar-spacing
Merge into: lp:webbrowser-app
Diff against target: 30 lines (+3/-3)
1 file modified
src/app/Chrome.qml (+3/-3)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/toolbar-spacing
Reviewer Review Type Date Requested Status
Günter Schwann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+187205@code.launchpad.net

Commit message

Adjust margins in the chrome to be consistent with the default toolbar.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Günter Schwann (schwann) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/Chrome.qml'
2--- src/app/Chrome.qml 2013-09-03 20:28:36 +0000
3+++ src/app/Chrome.qml 2013-09-24 11:07:38 +0000
4@@ -57,7 +57,7 @@
5 objectName: "backButton"
6 anchors {
7 left: parent.left
8- leftMargin: units.gu(1)
9+ leftMargin: units.gu(2)
10 verticalCenter: parent.verticalCenter
11 }
12 // On narrow screens, hide the button to maximize the
13@@ -79,7 +79,7 @@
14 objectName: "forwardButton"
15 anchors {
16 left: backButton.right
17- leftMargin: units.gu(1)
18+ leftMargin: visible ? units.gu(1) : 0
19 verticalCenter: parent.verticalCenter
20 }
21 // On narrow screen, hide the button to maximize
22@@ -118,7 +118,7 @@
23 anchors {
24 verticalCenter: parent.verticalCenter
25 right: parent.right
26- margins: units.gu(1)
27+ rightMargin: units.gu(2)
28 }
29 width: units.gu(5)
30 height: width

Subscribers

People subscribed via source and target branches

to status/vote changes: