webbrowser-app

Merge lp:~osomon/webbrowser-app/textfield-left-integer into lp:webbrowser-app

  1. textfield-left-integer
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1357
Merged at revision: 1363
Proposed branch: lp:~osomon/webbrowser-app/textfield-left-integer
Merge into: lp:webbrowser-app
Diff against target: 16 lines (+4/-2)
1 file modified
src/app/webbrowser/NavigationBar.qml (+4/-2)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/textfield-left-integer
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+286469@code.launchpad.net

Commit message

Work around a bug in the UITK that prevents touch scrolling to the left of the address bar by ensuring that the x coordinate of the text field is an integer.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1357
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2624/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6548
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1377
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1377
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1377/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1377
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4994
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6559
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6559/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27735

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2624/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/NavigationBar.qml'
2--- src/app/webbrowser/NavigationBar.qml 2016-01-26 17:44:49 +0000
3+++ src/app/webbrowser/NavigationBar.qml 2016-02-18 09:31:13 +0000
4@@ -109,8 +109,10 @@
5 findController: internal.webview ? internal.webview.findController : null
6
7 anchors {
8- left: forwardButton.right
9- leftMargin: units.gu(1)
10+ left: parent.left
11+ // Work around https://launchpad.net/bugs/1546346 by ensuring
12+ // that the x coordinate of the text field is an integer.
13+ leftMargin: Math.round(backButton.width + forwardButton.width + units.gu(1))
14 right: rightButtonsBar.left
15 rightMargin: units.gu(1)
16 verticalCenter: parent.verticalCenter

Subscribers

People subscribed via source and target branches

to status/vote changes: