Merge lp:~osomon/webbrowser-app/tablist-hidden-tabchrome into lp:webbrowser-app

[Olivier Tilloy]

Fix the tab preview sometimes covering the tab chrome, in the tabs view.
Offset tab previews by 1px to cover the semi-transparent horizontal line at the bottom of the tab chrome asset.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1303
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2524/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5700
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1278
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1278
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1278/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1278
    None: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4426/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5713
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5713/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25940

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2524/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1304
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2525/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1279
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1279
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1279/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1279
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4429
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5716
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5716/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25943

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2525/rebuild

review: Approve (continuous-integration)

[Ugo Riboni (uriboni)]

Even though I can't repro the original issue, the code looks sane and the explanations given make sense.

review: Approve

=== modified file 'src/app/webbrowser/TabPreview.qml'
--- src/app/webbrowser/TabPreview.qml	2015-11-17 14:50:31 +0000
+++ src/app/webbrowser/TabPreview.qml	2015-12-10 15:19:36 +0000
@@ -19,7 +19,7 @@
 import QtQuick 2.4
 import Ubuntu.Components 1.3
 
-Column {
+Item {
     id: tabPreview
 
     property alias title: chrome.title
@@ -36,11 +36,11 @@
     signal selected()
     signal closed()
 
-
     TabChrome {
         id: chrome
 
         anchors {
+            top: parent.top
             left: parent.left
             right: parent.right
         }
@@ -51,8 +51,14 @@
     }
 
     Item {
-        width: parent.width
+        anchors {
+            top: chrome.bottom
+            topMargin: units.dp(-1)
+            left: parent.left
+            right: parent.right
+        }
         height: parent.height
+        clip: true
 
         Rectangle {
             anchors.fill: parent