webbrowser-app

Merge lp:~osomon/webbrowser-app/staging-fix-webapp-container-progress-bar into lp:webbrowser-app/staging

  1. staging-fix-webapp-container-progress-bar
  2. Merge into staging
Proposed by Olivier Tilloy
Status: Merged
Merged at revision: 1564
Proposed branch: lp:~osomon/webbrowser-app/staging-fix-webapp-container-progress-bar
Merge into: lp:webbrowser-app/staging
Diff against target: 12 lines (+3/-0)
1 file modified
src/app/webcontainer/Chrome.qml (+3/-0)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/staging-fix-webapp-container-progress-bar
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Alexandre Abreu (community) Approve
Review via email: mp+308564@code.launchpad.net

Commit message

Fix progress bar when the webapp container has some chrome.

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM, it works, thanks for that!

review: Approve
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

FWIW, this fixes the issue for me as well :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webcontainer/Chrome.qml'
2--- src/app/webcontainer/Chrome.qml 2016-10-07 09:48:59 +0000
3+++ src/app/webcontainer/Chrome.qml 2016-10-14 21:31:53 +0000
4@@ -27,6 +27,9 @@
5 property bool navigationButtonsVisible: false
6 property bool accountSwitcher: false
7
8+ loading: webview && webview.loading
9+ loadProgress: loading ? webview.loadProgress : 0
10+
11 function updateChromeElementsColor(color) {
12 chromeTextLabel.color = color
13

Subscribers

People subscribed via source and target branches